Re: [PATCH] staging: comedi: fix potentially uninitialised variable

2013-11-10 Thread Dan Carpenter
On Sun, Nov 10, 2013 at 07:37:49PM +0100, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > If none of the if conditions take a true path, the ret variable will > never be assigned a value. Don't use a From: unless you are sending it on behalf of another sender. You need a Signed-off-by li

Re: [PATCH 1/7] staging: go7007: fix use of uninitialised pointer

2013-11-10 Thread Dan Carpenter
There are 3 other uses before "go" gets initialized. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/7] staging: go7007: fix use of uninitialised pointer

2013-11-10 Thread Michal Nazarewicz
Signed-off-by: Michal Nazarewicz --- drivers/staging/media/go7007/go7007-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) On Sun, Nov 10 2013, Greg Kroah-Hartman wrote: > Please either delete this entirely, or use the struct device in the > usb_interface pointer. > > A driver should

Re: [PATCH] staging: go7007: fix use of uninitialised pointer

2013-11-10 Thread Greg Kroah-Hartman
On Sun, Nov 10, 2013 at 07:37:57PM +0100, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > The go variable is declade without initialisation and invocation of > dev_dbg immediatelly tries to dereference it. > --- > drivers/staging/media/go7007/go7007-usb.c | 2 +- > 1 file changed, 1 inser

[PATCH] staging: ced401: ced_ioc: fix a blank/tab codingstyle issue.

2013-11-10 Thread Joachim Adolf Schuetz
From: Joachim Adi Schuetz Fixed a coding style issue - removed a blank before a tab. Signed-off-by: Joachim Adolf Schuetz --- drivers/staging/ced1401/ced_ioc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401

[PATCH 2/2] staging: cxt1e1: comet: fixed some brace coding style issues.

2013-11-10 Thread Joachim Adolf Schuetz
Fixed some coding style issues - a few braces and indentions. Signed-off-by: Joachim Adolf Schuetz --- drivers/staging/cxt1e1/comet.c | 31 +-- 1 files changed, 13 insertions(+), 18 deletions(-) diff --git a/drivers/staging/cxt1e1/comet.c b/drivers/staging/cxt1e1/c

[PATCH] Staging: ft1000: fixed coding style issues

2013-11-10 Thread Aldo Iljazi
Fixed the following coding style issues: Lines 84-91,99-106,275,514: Replaced spaces at the start of the lines with tabs. Lines 205,271: Inserted spaces after the commas. Lines 275,1060,1065: Indented the code with tabs instead of spaces. Line 275: Inserted spaces around '=' and '<', also moved