On Thu, Nov 21, 2013 at 09:19:21PM +, Mark Einon wrote:
On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote:
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote:
Otherwise this patch seems nice but it needs to be split up and resent.
By the way, this mailing list is surely an open list, but I can't find
how to subscribe it - the website at driverdev.osuosl.org said it has
no
On 11/22/13, Mark Einon mark.ei...@gmail.com wrote:
On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote:
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly
On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote:
Otherwise this patch seems nice but it needs to be split up and resent.
By the way, this mailing list is surely an open list, but I can't find
how to
On Fri, Nov 22, 2013 at 5:17 PM, Denis Kirjanov kirja...@gmail.com wrote:
On 11/22/13, Mark Einon mark.ei...@gmail.com wrote:
On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote:
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls
If you have no free TX descriptors that means that something went
wrong and it's a BUG. You have to tell the stack to stop sending
packets using netif_stop_queue() and reenable transmissions once tx
descriptors will be available. There are a lot of live examples in the
source tree.
On 11/22/13,
On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote:
On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote:
Otherwise this patch seems nice but it needs to be split up and resent.
By the way,
On Fri, Nov 22, 2013 at 7:56 PM, Denis Kirjanov kirja...@gmail.com wrote:
If you have no free TX descriptors that means that something went
wrong and it's a BUG. You have to tell the stack to stop sending
packets using netif_stop_queue() and reenable transmissions once tx
descriptors will be
On Fri, Nov 22, 2013 at 8:13 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote:
On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Fri, Nov 22, 2013 at 04:44:48PM +0800, ZHAO Gang wrote:
Otherwise
On Fri, Nov 22, 2013 at 08:35:39PM +0800, ZHAO Gang wrote:
On Fri, Nov 22, 2013 at 8:13 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Fri, Nov 22, 2013 at 07:37:58PM +0800, ZHAO Gang wrote:
On Fri, Nov 22, 2013 at 5:00 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Fri,
1. As TODO list suggested, do this sort of things to reduce split lines:
struct fbr_lookup *fbr;
fbr = rx_local-fbr[id];
Then replace all the instances of rx_local-fbr[id] with fbr.
2. Some code style changes
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
v4 - v5: split
Variable u32 numrfd is not necessary in this function.
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 0a6cc62..6df7145
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
adapter-lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev-addr_list_lock hold, to protect from
concurrent access. So adapter-lock is redundant.
Signed-off-by: ZHAO Gang
The private data does not contain 'das6402_irqcount' or 'das6402_wordsread'
members so the printk noise produces build errors when DEBUG is defined.
The other printk is just added noise.
Remove the printk's to fix the build errors and remove the noise.
Signed-off-by: H Hartley Sweeten
This macro is only used to output some function tracing debug messages.
These messages are just added noise so remove the DEBUG macro as well
as the noise.
Also, remove pcl816_cmdtest_out() which was only called as part of the
DEBUG() in pcl816_ai_cmdtest().
Signed-off-by: H Hartley Sweeten
The comedi core defines a DPRINTK macro in comedidev.h. Use that macro
instead of defining a private version in this driver.
Also, remove the DEBUG define since it was only used to enable the
DPRINTK macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This define is only used to enable some debug messages during the
board attach. These are just added noise, remove them as well as
the DEBUG define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove this module parameter and use the CONFIG_COMEDI_DEBUG option to
enable normal kernel debugging with -DDEBUG flag.
Remove the #undef DEBUG from all the comedi source files so they will
honour the -DDEBUG flag.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This define unables some debug code that prints the status flags
during the interrupt handler. These messages are just added noise
and it's probably not a good idea to spew them during the interrupt
anyway.
Remove the DEBUG define as well as the debug code.
Signed-off-by: H Hartley Sweeten
Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.
The dev_dbg() will prefix the messages appropriately so remove the
comedi%d: DRIVER_NAME portion and use __func__ to show the actual
function name for debugging.
Signed-off-by: H Hartley Sweeten
Remove the DPRINTK messages that are just function trace noise.
Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
This macro is used by the comedi drivers that usee the mite module to
output development function trace messages. These are just added noise.
Remove the messages as well as the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
These debug messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 22 --
1 file changed, 22
Convert a printk(KERN_DEBUG ... message to dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 3 +--
1 file changed, 1 insertion(+), 2
Convert a printk(KERN_DEBUG ... message to dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 6 +++---
1 file changed, 3 insertions(+), 3
Defining DEBUG_INTERRUPT enables some function trace messages during the
interrupt. These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The pwm subdevice in this driver sets the subdev_flags to SDF_WRITEABLE
so the s-insn_read callback is not needed. Since this callback simply
outputs a printk(KERN_DEBUG ... message jsut remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
This define is not used by the driver. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/fl512.c | 2 --
1 file changed, 2 deletions(-)
diff --git
The DEBUG_FLAGS define enables some development code that outputs
interrupt flags and status information in the interrupt handler.
This information is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as
well as a DPRINTK() macro. To actually get debug messages to display the
kernel
still needs to be built with the -DDEBUG flag.
Cleanup all the custom uses of DEBUG in comedi and use the COMEDI_DEBUG option
to enable
Defining DEBUG_STATUS_A enables dumping of a status register during the
interrupt. These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
dwc2_process_non_isoc_desc() can potentially free the qtd, so null
out the qtd pointer if the call fails so we don't try to access it
later
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/staging/dwc2/hcd_ddma.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
DWC2_PARAM_TEST is not a very good name for this macro, so rename
it to DWC2_OUT_OF_BOUNDS
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/staging/dwc2/core.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
We were not checking the return value from any of these functions,
so make them void functions
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/staging/dwc2/core.c | 193
drivers/staging/dwc2/core.h | 60 +++---
Remove useless cast in dwc2_get_otg_version()
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/staging/dwc2/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
index 6149fbc..5b490a4 100644
---
Rename dwc2_check_core_status() to dwc2_is_controller_alive(), and
make it a boolean function. Also change the message when the
controller is dead to say dead instead of disconnected.
Signed-off-by: Paul Zimmerman pa...@synopsys.com
---
drivers/staging/dwc2/core.c | 6 +++---
37 matches
Mail list logo
