Re: hello

2013-11-26 Thread Zhang Xiaoguang
I have an important message for you which is of mutual benefit to us . Let me know if you get this email. Regards, Zhang Xiaoguang ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Andre Heider
On Mon, Nov 25, 2013 at 10:02:30PM -0700, Stephen Warren wrote: The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non- default parameters. Select these based on the compatible value from the DT node. For all other HW, fall back to the default parameters currently in use. The

Re: [PATCH 0/2] staging: as102: Cleanups for the as102 driver

2013-11-26 Thread Mauro Dreissig
On 11/25/2013 10:06 PM, Greg Kroah-Hartman wrote: On Mon, Nov 25, 2013 at 05:10:51PM -0500, Mauro Dreissig wrote: The first patch cleans sparse warnings and the second one removes useless code. Mauro Dreissig (2): staging: as102: Declare local variables as static staging: as102: Remove

[PATCH 0/2] staging: as102: Cleanups for the as102 driver

2013-11-26 Thread Mauro Dreissig
The first patch cleans sparse warnings and the second one removes useless code. Mauro Dreissig (2): staging: as102: Declare local variables as static staging: as102: Remove ENTER/LEAVE debugging macros drivers/staging/media/as102/as102_drv.c| 10 --

[PATCH 2/2] staging: as102: Remove ENTER/LEAVE debugging macros

2013-11-26 Thread Mauro Dreissig
Too much noise, also does not cover every possible code paths. Signed-off-by: Mauro Dreissig muk...@gmail.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/media/as102/as102_drv.c| 10 -- drivers/staging/media/as102/as102_drv.h| 8

[PATCH 1/2] staging: as102: Declare local variables as static

2013-11-26 Thread Mauro Dreissig
As pointed out by sparse: drivers/staging/media/as102/as102_fw.c:29:6: warning: symbol 'as102_st_fw1' was not declared. Should it be static? drivers/staging/media/as102/as102_fw.c:30:6: warning: symbol 'as102_st_fw2' was not declared. Should it be static?

[PATCH v2 03/26] staging: comedi: ni_pcidio: remove debug_int()

2013-11-26 Thread H Hartley Sweeten
This function is not used by the driver. Just remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_pcidio.c | 31 -- 1

[PATCH v2 12/26] staging: comedi: ni_pcimio: remove PCI_DEBUG

2013-11-26 Thread H Hartley Sweeten
This define is not used in the driver. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_pcimio.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH v2 04/26] staging: comedi: ni_pcidio: remove use of DPRINTK

2013-11-26 Thread H Hartley Sweeten
Remove the DPRINTK messages that are just function trace noise. Use dev_dbg() instead of the DPRINTK macro to output the comedi debugging information. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH v2 07/26] staging: comedi: mite: remove DEBUG_MITE code

2013-11-26 Thread H Hartley Sweeten
The code protected by the DEBUG_MITE define outputs some development debug information. This information is just added noise in the final driver. Remove the code. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH v2 14/26] staging: comedi: pcmmio: remove commented out debug code

2013-11-26 Thread H Hartley Sweeten
Remove the commented out code in init_asics() that enables the rising edge interrupts on port0 of both asics. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 19/26] staging: comedi: pcl818: remove an unnecessary printk(KERN_DEBUG ...

2013-11-26 Thread H Hartley Sweeten
This debug message is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH v2 10/26] staging: comedi: ni_at_a2150: remove A2150_DEBUG

2013-11-26 Thread H Hartley Sweeten
The A2150_DEBUG define enables some development messages, specifically the ni_dum_regs() function. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH v2 21/26] staging: comedi: ni_mio_common: remove unused NI_CS5529_DEBUG code

2013-11-26 Thread H Hartley Sweeten
The code blocked by #ifdef NI_CS5529_DEBUG is not used by the driver. Just remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 30

[PATCH v2 17/26] staging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read()

2013-11-26 Thread H Hartley Sweeten
The pwm subdevice in this driver sets the subdev_flags to SDF_WRITEABLE so the s-insn_read callback is not needed. Since this callback simply outputs a printk(KERN_DEBUG ... message jsut remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott

[PATCH v2 09/26] staging: comedi: gsc_hpdi: remove DEBUG_PRINT

2013-11-26 Thread H Hartley Sweeten
The DEBUG_PRINT macro in this driver is used to output development debug tracing messages. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH v2 01/26] staging: comedi: comedi_fops: remove use of DPRINTK

2013-11-26 Thread H Hartley Sweeten
Use dev_dbg(), or pr_debug() when dev is not valid, instead of the DPRINTK macro to output the comedi debugging information. Remove the debug messages for allocation failures. The failure will have already generated a message. Reword the messages that include the dev-minor number. This number

[PATCH v2 20/26] staging: comedi: dmm32at: remove some unnecessary printk(KERN_DEBUG ...

2013-11-26 Thread H Hartley Sweeten
These debug messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dmm32at.c | 6 -- 1 file changed, 6

[PATCH v2 06/26] staging: comedi: mite: remove MDPRINTK macro

2013-11-26 Thread H Hartley Sweeten
This macro is used by the comedi drivers that usee the mite module to output development function trace messages. These are just added noise. Remove the messages as well as the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH v2 00/26] cleanup debugging support

2013-11-26 Thread H Hartley Sweeten
Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as well as a DPRINTK() macro. To actually get debug messages to display the kernel still needs to be built with the -DDEBUG flag. Cleanup all the custom uses of DEBUG in comedi and use the COMEDI_DEBUG option to enable

[PATCH v2 25/26] staging: comedi: ni_mio_common: remove DEBUG_INTERRUPT messages

2013-11-26 Thread H Hartley Sweeten
Defining DEBUG_INTERRUPT enables some function trace messages during the interrupt. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 16/26] staging: comedi: pcmmio: convert a KERN_DEBUG message to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert a printk(KERN_DEBUG ... message to dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcmmio.c | 6 +++--- 1 file changed, 3 insertions(+),

[PATCH v2 22/26] staging: comedi: ni_mio_common: remove DEBUG_DIO messages

2013-11-26 Thread H Hartley Sweeten
Defining DEBUG_DIO simply enables some function trace messages. These are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 23/26] staging: comedi: ni_mio_common: remove DEBUG_STATUS_B messages

2013-11-26 Thread H Hartley Sweeten
Defining DEBUG_STATUS_B enables dumping of a status register during the interrupt. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 26/26] staging: comedi: unionxx5: tidy up some dev_{level} messages

2013-11-26 Thread H Hartley Sweeten
Remove the comedi%d: prefix from the dev_{level} messages. This previx will already be displayed. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/unioxx5.c | 32

[PATCH v2 08/26] staging: comedi: cb_pcidas64: remove DEBUG_PRINT

2013-11-26 Thread H Hartley Sweeten
The DEBUG_PRINT macro in this driver is used to output development debug tracing messages. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH v2 24/26] staging: comedi: ni_mio_common: remove DEBUG_STATUS_A messages

2013-11-26 Thread H Hartley Sweeten
Defining DEBUG_STATUS_A enables dumping of a status register during the interrupt. These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 13/26] staging: comedi: pcmmio: remove DAMMIT_ITS_BROKEN debug

2013-11-26 Thread H Hartley Sweeten
These debug messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcmmio.c | 22 -- 1 file

RE: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Paul Zimmerman
From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Monday, November 25, 2013 9:03 PM The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non- default parameters. Select these based on the compatible value from the DT node. For all other HW, fall back to the default

RE: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Paul Zimmerman
From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Tuesday, November 26, 2013 11:43 AM On 11/26/2013 12:27 PM, Paul Zimmerman wrote: From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Monday, November 25, 2013 9:03 PM The DWC2 USB controller in the BCM2835 (Raspberry Pi)

[PATCH 10/60] staging: comedi: cb_pcimdas: remove commented out irq init code

2013-11-26 Thread H Hartley Sweeten
This driver does not have interrupt support. Remove the commented out code that requests the irq. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdas.c | 9

[PATCH 03/60] staging: comedi: dmm32at: remove final attach noise and fix return value

2013-11-26 Thread H Hartley Sweeten
The success message after an attach is just added noise. Remove it. The normal return value for success is 0. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 17/60] staging: comedi: dt2801: remove disabled code in dt2801_writedata

2013-11-26 Thread H Hartley Sweeten
The code that checks the DT_S_READY status is disabled. Just remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt2801.c | 7 --- 1 file changed, 7

[PATCH 09/60] staging: comedi: c6xdigio: remove commented out function trace messages

2013-11-26 Thread H Hartley Sweeten
These commented out messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/c6xdigio.c | 14 -- 1 file changed, 14

[PATCH 11/60] staging: comedi: cb_pcimdas: remove unnecessary printk noise

2013-11-26 Thread H Hartley Sweeten
The ai read timeout will return -ETIMEDOUT. The printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdas.c | 5 ++--- 1

[PATCH 29/60] staging: comedi: dt282x: remove attach noise in dt282x_grab_dma()

2013-11-26 Thread H Hartley Sweeten
These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 10 ++ 1 file changed, 2 insertions(+), 8

[PATCH 01/60] staging: comedi: pcmmio.c: remove kcalloc() failure message

2013-11-26 Thread H Hartley Sweeten
An allocation failure will have already displayed a message. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcmmio.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 28/60] staging: comedi: dt282x: tidy up the irq support in dt282x_attach()

2013-11-26 Thread H Hartley Sweeten
An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if the request_irq() fails the attach does not fail. Remove the printk noise about the irq. Only hookup the async command support if the request_irq() was successful. Also,

[PATCH 13/60] staging: comedi: dmm32at: remove unnecessary printk noise

2013-11-26 Thread H Hartley Sweeten
A timeout will return -ETIMEDOUT. The printks are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dmm32at.c | 17 + 1

[PATCH 25/60] staging: comedi: dt2814: tidy up the irq support in dt2814_attach()

2013-11-26 Thread H Hartley Sweeten
An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if the request_irq() fails the attach does not fail. Remove the printk noise about the irq. Only hookup the async command support if the request_irq() was successful.

[PATCH 20/60] staging: comedi: dt2811: remove disabled dt2811_adtrig() function

2013-11-26 Thread H Hartley Sweeten
This function is not used by the driver. It's also suffering from bitrot since COMEDI_MDEMAND and COMEDI_MCONTS are not defined anywhere. Just remove the code. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 00/60] staging: comedi: more printk debug cleanup

2013-11-26 Thread H Hartley Sweeten
There are a lot of debugging messages in the comedi drivers that are just added noise. Some of them messages are worth keeping but they should be converted to the appropriate dev_{level} format. This series is a first pass at cleaning this up. H Hartley Sweeten (60): staging: comedi: pcmmio.c:

[PATCH 16/60] staging: comedi: dmm32at: convert a printk(KERN_ERR to a dev-err()

2013-11-26 Thread H Hartley Sweeten
Convert this printk message to a dev_err() message. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 18/60] staging: comedi: dt2801: remove commented out printk()

2013-11-26 Thread H Hartley Sweeten
This printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt2801.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 02/60] staging: comedi: adv_pci1710: convert some printk's to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert these debug messages to dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1710.c | 27 --- 1 file changed, 12

[PATCH 15/60] staging: comedi: dmm32at: tidy up the irq support in dmm32at_attach()

2013-11-26 Thread H Hartley Sweeten
An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if the request_irq() fails the attach does not fail. Remove the printk noise about the irq. Only hookup the async command support if the request_irq() was successful.

[PATCH 60/60] staging: comedi: ni_atmio16d: remove an unnecessary printk

2013-11-26 Thread H Hartley Sweeten
This blank line printk is not necessary. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_atmio16d.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 46/60] staging: comedi: pcl818: remove board attach noise

2013-11-26 Thread H Hartley Sweeten
These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 10 -- 1 file changed, 10 deletions(-) diff

[PATCH 47/60] staging: comedi: pcl818: tidy up the irq support in pcl818_attach()

2013-11-26 Thread H Hartley Sweeten
Tidy up the code that does the request_irq(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 28 +++- 1 file changed, 7

[PATCH 27/60] staging: comedi: dt2815: convert printk's in dt2815_attach()

2013-11-26 Thread H Hartley Sweeten
These messages don't appear to be important enough to warrent KERN_INFO and KERN_WARNING levels. Convert them dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 48/60] staging: comedi: pcl818: convert printk() messages to dev_{level}

2013-11-26 Thread H Hartley Sweeten
Convert the remaining printk messsages in this driver to dev_{level}. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 29 +++-- 1

[PATCH 19/60] staging: comedi: dt2801: convert printk() messages to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert all the printk() messages in this driver to dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt2801.c | 20 ++-- 1 file changed,

[PATCH 45/60] staging: comedi: pcl818: remove printk function trace messages

2013-11-26 Thread H Hartley Sweeten
These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 26/60] staging: comedi: dt2815: convert printk's in dt2815_ao_insn()

2013-11-26 Thread H Hartley Sweeten
Convert the printk(KERN_WARNING messages in this function to dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt2815.c | 10 ++ 1 file changed, 6

[PATCH 35/60] staging: comedi: dt282x: convert dt282x_ao_inttrig() messages

2013-11-26 Thread H Hartley Sweeten
Convert the messages in this function to dev_err(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 43/60] staging: comedi: pcm3724: remove commented out printk debug

2013-11-26 Thread H Hartley Sweeten
These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcm3724.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 36/60] staging: comedi: dt282x: remove commented out printk

2013-11-26 Thread H Hartley Sweeten
This printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 51/60] staging: comedi: pcl816: tidy up the irq support in pcl816_attach()

2013-11-26 Thread H Hartley Sweeten
Tidy up the code that does the request_irq(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 33 ++--- 1 file changed, 6

[PATCH 42/60] staging: comedi: plx9080.h: remove unnecessary printk noise

2013-11-26 Thread H Hartley Sweeten
The timeouts will return -ETIMEDOUT. The printks are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/plx9080.h | 13 +++-- 1

[PATCH 24/60] staging: comedi: dt2814: convert a printk(KERN_ERR into a dev_err()

2013-11-26 Thread H Hartley Sweeten
Convert this printk message into a dev_dev(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt2814.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 41/60] staging: comedi: rtd520: remove commented out printk debug

2013-11-26 Thread H Hartley Sweeten
These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/rtd520.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 22/60] staging: comedi: dt2814: remove unnecessary printk noise

2013-11-26 Thread H Hartley Sweeten
The ai read timeout will return -ETIMEDOUT. The printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt2814.c | 4 +--- 1 file

[PATCH 58/60] staging: comedi: ni_atmio16d: remove printk() noise in atmio16d_ai_insn_read()

2013-11-26 Thread H Hartley Sweeten
These printk messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_atmio16d.c | 7 +-- 1 file changed, 1 insertion(+),

[PATCH 53/60] staging: comedi: pcl816: convert printk messages in pcl816_attach()

2013-11-26 Thread H Hartley Sweeten
Convert the printk messages in this function to dev_{level} mesages. Remove the ones that are just added noise. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 57/60] staging: comedi: ni_pcimio: convert printk() to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert this printk messages to a dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_pcimio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 44/60] staging: comedi: pcl818: remove commented out printk debug

2013-11-26 Thread H Hartley Sweeten
These messages are just added noise. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 10 -- 1 file changed, 10 deletions(-) diff

[PATCH 37/60] staging: comedi: mpc624: remove commented out printk

2013-11-26 Thread H Hartley Sweeten
This printk is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/mpc624.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 40/60] staging: comedi: mpc624: convert printk messages in mpc624_ai_rinsn()

2013-11-26 Thread H Hartley Sweeten
There's no reason for these messages to be KERN_INFO. Convert them to dev_dbg(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/mpc624.c | 8 1 file

[PATCH 49/60] staging: comedi: pcl816: remove commented out outb() macro

2013-11-26 Thread H Hartley Sweeten
This macro is commented out, thankfully... Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 05/60] staging: comedi: pcl816: convert some printk's to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert these warning messages to dev_dbg() to minimize the noise. Also, tidy them up a bit. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 28

[PATCH 04/60] staging: comedi: pcl812: convert some printk's to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert these debug messages to dev_dbg() and tidy them up a bit. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl812.c | 13 +++-- 1 file changed, 3

[PATCH 12/60] staging: comedi: das16m1: tidy up the irq support in das16m1_attach()

2013-11-26 Thread H Hartley Sweeten
An irq is only needed by this driver in order to support async commands. Since it is optional, modify the attach so that if an invalid irq is selected by the user, or the request_irq() fails, the attach does not fail. Remove all the printk noise about the irq. Only hookup the async command

[PATCH 30/60] staging: comedi: dt282x: convert printk() in dt282x_attach to a dev_err()

2013-11-26 Thread H Hartley Sweeten
Convert this printk message into a dev_err(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 06/60] staging: comedi: pcl818: convert some printk's to dev_dbg()

2013-11-26 Thread H Hartley Sweeten
Convert these messages to dev_dbg() and tidy them up a bit. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 24 1 file changed,

[PATCH 34/60] staging: comedi: dt282x: convert dt282x_ai_dma_interrupt() messages

2013-11-26 Thread H Hartley Sweeten
Convert the messages in this function to dev_{level}(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 32/60] staging: comedi: dt282x: remove disable code that disables the irq

2013-11-26 Thread H Hartley Sweeten
The code that would disable the irq after getting a number of D/A errors is disabled. Just remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 7

[PATCH 56/60] staging: comedi: ni_tio: remove commented out printk message

2013-11-26 Thread H Hartley Sweeten
This printk message is just added noise. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_tio.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 33/60] staging: comedi: dt282x: convert dt282x_ao_dma_interrupt() messages

2013-11-26 Thread H Hartley Sweeten
Convert the messages in this function to dev_err(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/dt282x.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Stephen Warren
(trimming out the devicetree list and maintainers for this discussion) On 11/26/2013 12:52 PM, Paul Zimmerman wrote: From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Tuesday, November 26, 2013 11:43 AM On 11/26/2013 12:27 PM, Paul Zimmerman wrote: From: Stephen Warren

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Joe Perches
On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. [] diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c [] @@ -1057,7 +1057,7 @@ static int

[PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe':

[PATCH] drivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user() in ft1000_ioctl()

2013-11-26 Thread Chen Gang
get_user() may fail and cause 'msgsz' uninitialized, so need give a check. The related warning (with allmodconfig under hexagon): CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_debug.o drivers/staging/ft1000/ft1000-usb/ft1000_debug.c: In function 'ft1000_ioctl':

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
On 11/27/2013 11:21 AM, Joe Perches wrote: On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. [] diff --git a/drivers/staging/media/go7007/go7007-usb.c

[PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe':

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Greg KH
On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
On 11/27/2013 12:03 PM, Greg KH wrote: On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M]

Re: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Gordon Hollingworth
This looks like it is the same problem we saw in the dwc_otg driver with incorrect scheduling of split USB transactions to downstream ports behind single TT hubs (this just makes the problem worse rather than be the cause of anything) In general it should be possible to schedule multiple split

[PATCH 0/3] staging: et131x: patches for et131x

2013-11-26 Thread ZHAO Gang
This patch set is based on previous sent v5 of 7 patches for et131x. ZHAO Gang (3): staging: et131x: simplify rx dma code staging: et131x: simplify tx dma code staging: et131x: fix build warning drivers/staging/et131x/et131x.c | 298 +--- 1 file

[PATCH 2/3] staging: et131x: simplify tx dma code

2013-11-26 Thread ZHAO Gang
combine two dma_alloc_coherent to one Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 72 - 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c

[PATCH 3/3] staging: et131x: fix build warning

2013-11-26 Thread ZHAO Gang
fix make -W1 warning: drivers/staging/et131x//et131x.c: In function ‘et1310_setup_device_for_multicast’: drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not used [-Wunused-but-set-variable] u32 pm_csr; ^ drivers/staging/et131x//et131x.c: In function