I have an important message for you which is of mutual benefit to us . Let me
know if you get this email.
Regards,
Zhang Xiaoguang
___
devel mailing list
de...@linuxdriverproject.org
On Mon, Nov 25, 2013 at 10:02:30PM -0700, Stephen Warren wrote:
The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non-
default parameters. Select these based on the compatible value from the
DT node. For all other HW, fall back to the default parameters currently
in use.
The
On 11/25/2013 10:06 PM, Greg Kroah-Hartman wrote:
On Mon, Nov 25, 2013 at 05:10:51PM -0500, Mauro Dreissig wrote:
The first patch cleans sparse warnings and the second one removes
useless code.
Mauro Dreissig (2):
staging: as102: Declare local variables as static
staging: as102: Remove
The first patch cleans sparse warnings and the second one removes
useless code.
Mauro Dreissig (2):
staging: as102: Declare local variables as static
staging: as102: Remove ENTER/LEAVE debugging macros
drivers/staging/media/as102/as102_drv.c| 10 --
Too much noise, also does not cover every possible code paths.
Signed-off-by: Mauro Dreissig muk...@gmail.com
Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/media/as102/as102_drv.c| 10 --
drivers/staging/media/as102/as102_drv.h| 8
As pointed out by sparse:
drivers/staging/media/as102/as102_fw.c:29:6: warning: symbol 'as102_st_fw1' was
not declared. Should it be static?
drivers/staging/media/as102/as102_fw.c:30:6: warning: symbol 'as102_st_fw2' was
not declared. Should it be static?
This function is not used by the driver. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_pcidio.c | 31 --
1
This define is not used in the driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_pcimio.c | 2 --
1 file changed, 2 deletions(-)
diff
Remove the DPRINTK messages that are just function trace noise.
Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The code protected by the DEBUG_MITE define outputs some development
debug information. This information is just added noise in the final
driver. Remove the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Remove the commented out code in init_asics() that enables the rising
edge interrupts on port0 of both asics.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This debug message is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 2 --
1 file changed, 2 deletions(-)
diff
The A2150_DEBUG define enables some development messages, specifically
the ni_dum_regs() function. These messages are just added noise. Remove
them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The code blocked by #ifdef NI_CS5529_DEBUG is not used by the driver.
Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 30
The pwm subdevice in this driver sets the subdev_flags to SDF_WRITEABLE
so the s-insn_read callback is not needed. Since this callback simply
outputs a printk(KERN_DEBUG ... message jsut remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott
The DEBUG_PRINT macro in this driver is used to output development
debug tracing messages. These messages are just added noise. Remove
them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
DPRINTK macro to output the comedi debugging information.
Remove the debug messages for allocation failures. The failure will
have already generated a message.
Reword the messages that include the dev-minor number. This number
These debug messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dmm32at.c | 6 --
1 file changed, 6
This macro is used by the comedi drivers that usee the mite module to
output development function trace messages. These are just added noise.
Remove the messages as well as the macro.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as
well as a DPRINTK() macro. To actually get debug messages to display the
kernel
still needs to be built with the -DDEBUG flag.
Cleanup all the custom uses of DEBUG in comedi and use the COMEDI_DEBUG option
to enable
Defining DEBUG_INTERRUPT enables some function trace messages during the
interrupt. These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Convert a printk(KERN_DEBUG ... message to dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 6 +++---
1 file changed, 3 insertions(+),
Defining DEBUG_DIO simply enables some function trace messages. These are
just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Defining DEBUG_STATUS_B enables dumping of a status register during the
interrupt. These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the comedi%d: prefix from the dev_{level} messages. This previx
will already be displayed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/unioxx5.c | 32
The DEBUG_PRINT macro in this driver is used to output development
debug tracing messages. These messages are just added noise. Remove
them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Defining DEBUG_STATUS_A enables dumping of a status register during the
interrupt. These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
These debug messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 22 --
1 file
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Monday, November 25, 2013 9:03 PM
The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non-
default parameters. Select these based on the compatible value from the
DT node. For all other HW, fall back to the default
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Tuesday, November 26, 2013 11:43 AM
On 11/26/2013 12:27 PM, Paul Zimmerman wrote:
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Monday, November 25, 2013 9:03 PM
The DWC2 USB controller in the BCM2835 (Raspberry Pi)
This driver does not have interrupt support. Remove the commented out
code that requests the irq.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcimdas.c | 9
The success message after an attach is just added noise. Remove it.
The normal return value for success is 0.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The code that checks the DT_S_READY status is disabled. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2801.c | 7 ---
1 file changed, 7
These commented out messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 14 --
1 file changed, 14
The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcimdas.c | 5 ++---
1
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 10 ++
1 file changed, 2 insertions(+), 8
An allocation failure will have already displayed a message.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 5 +
1 file changed, 1 insertion(+), 4
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.
Remove the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
Also,
A timeout will return -ETIMEDOUT. The printks are just added noise.
Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dmm32at.c | 17 +
1
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.
Remove the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
This function is not used by the driver. It's also suffering from bitrot
since COMEDI_MDEMAND and COMEDI_MCONTS are not defined anywhere. Just
remove the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
There are a lot of debugging messages in the comedi drivers that are
just added noise. Some of them messages are worth keeping but they
should be converted to the appropriate dev_{level} format.
This series is a first pass at cleaning this up.
H Hartley Sweeten (60):
staging: comedi: pcmmio.c:
Convert this printk message to a dev_err() message.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dmm32at.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This printk is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2801.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Convert these debug messages to dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 27 ---
1 file changed, 12
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if the request_irq() fails
the attach does not fail.
Remove the printk noise about the irq.
Only hookup the async command support if the request_irq() was successful.
This blank line printk is not necessary. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 1 -
1 file changed, 1 deletion(-)
diff --git
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 10 --
1 file changed, 10 deletions(-)
diff
Tidy up the code that does the request_irq().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 28 +++-
1 file changed, 7
These messages don't appear to be important enough to warrent KERN_INFO
and KERN_WARNING levels. Convert them dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Convert the remaining printk messsages in this driver to dev_{level}.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 29 +++--
1
Convert all the printk() messages in this driver to dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2801.c | 20 ++--
1 file changed,
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
Convert the printk(KERN_WARNING messages in this function to dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2815.c | 10 ++
1 file changed, 6
Convert the messages in this function to dev_err().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 4 ++--
1 file changed, 2 insertions(+), 2
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcm3724.c | 6 --
1 file changed, 6 deletions(-)
diff --git
This printk is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Tidy up the code that does the request_irq().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 33 ++---
1 file changed, 6
The timeouts will return -ETIMEDOUT. The printks are just added noise.
Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/plx9080.h | 13 +++--
1
Convert this printk message into a dev_dev().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2814.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/rtd520.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
The ai read timeout will return -ETIMEDOUT. The printk is just added
noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2814.c | 4 +---
1 file
These printk messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 7 +--
1 file changed, 1 insertion(+),
Convert the printk messages in this function to dev_{level} mesages.
Remove the ones that are just added noise.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Convert this printk messages to a dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_pcimio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
These messages are just added noise. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 10 --
1 file changed, 10 deletions(-)
diff
This printk is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mpc624.c | 1 -
1 file changed, 1 deletion(-)
diff --git
There's no reason for these messages to be KERN_INFO. Convert them to
dev_dbg().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mpc624.c | 8
1 file
This macro is commented out, thankfully... Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 2 --
1 file changed, 2 deletions(-)
diff --git
Convert these warning messages to dev_dbg() to minimize the noise.
Also, tidy them up a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 28
Convert these debug messages to dev_dbg() and tidy them up a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 13 +++--
1 file changed, 3
An irq is only needed by this driver in order to support async commands.
Since it is optional, modify the attach so that if an invalid irq is
selected by the user, or the request_irq() fails, the attach does not
fail.
Remove all the printk noise about the irq.
Only hookup the async command
Convert this printk message into a dev_err().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Convert these messages to dev_dbg() and tidy them up a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 24
1 file changed,
Convert the messages in this function to dev_{level}().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 4 ++--
1 file changed, 2 insertions(+), 2
The code that would disable the irq after getting a number of D/A errors
is disabled. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 7
This printk message is just added noise. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c | 1 -
1 file changed, 1 deletion(-)
diff --git
Convert the messages in this function to dev_err().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 4 ++--
1 file changed, 2 insertions(+), 2
(trimming out the devicetree list and maintainers for this discussion)
On 11/26/2013 12:52 PM, Paul Zimmerman wrote:
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Tuesday, November 26, 2013 11:43 AM
On 11/26/2013 12:27 PM, Paul Zimmerman wrote:
From: Stephen Warren
On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote:
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized.
[]
diff --git a/drivers/staging/media/go7007/go7007-usb.c
b/drivers/staging/media/go7007/go7007-usb.c
[]
@@ -1057,7 +1057,7 @@ static int
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized. Related warning (with allmodconfig under
hexagon):
CC [M] drivers/staging/media/go7007/go7007-usb.o
drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe':
get_user() may fail and cause 'msgsz' uninitialized, so need give a
check. The related warning (with allmodconfig under hexagon):
CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_debug.o
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c: In function 'ft1000_ioctl':
On 11/27/2013 11:21 AM, Joe Perches wrote:
On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote:
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized.
[]
diff --git a/drivers/staging/media/go7007/go7007-usb.c
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized. Related warning (with allmodconfig under
hexagon):
CC [M] drivers/staging/media/go7007/go7007-usb.o
drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe':
On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote:
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized. Related warning (with allmodconfig under
hexagon):
CC [M] drivers/staging/media/go7007/go7007-usb.o
On 11/27/2013 12:03 PM, Greg KH wrote:
On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote:
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized. Related warning (with allmodconfig under
hexagon):
CC [M]
This looks like it is the same problem we saw in the dwc_otg driver
with incorrect scheduling of split USB transactions to downstream
ports behind single TT hubs (this just makes the problem worse rather
than be the cause of anything)
In general it should be possible to schedule multiple split
This patch set is based on previous sent v5 of 7 patches for et131x.
ZHAO Gang (3):
staging: et131x: simplify rx dma code
staging: et131x: simplify tx dma code
staging: et131x: fix build warning
drivers/staging/et131x/et131x.c | 298 +---
1 file
combine two dma_alloc_coherent to one
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 72 -
1 file changed, 20 insertions(+), 52 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
fix make -W1 warning:
drivers/staging/et131x//et131x.c: In function
‘et1310_setup_device_for_multicast’:
drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not
used [-Wunused-but-set-variable]
u32 pm_csr;
^
drivers/staging/et131x//et131x.c: In function
90 matches
Mail list logo
