Hi
On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 19 Dec 2013, David Herrmann wrote:
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 253fe23..81eacd3 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1334,7 +1334,7 @@
Hi
On Thu, Dec 19, 2013 at 11:08 AM, David Herrmann dh.herrm...@gmail.com wrote:
Hi
On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina jkos...@suse.cz wrote:
On Thu, 19 Dec 2013, David Herrmann wrote:
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 253fe23..81eacd3 100644
On Thu, 19 Dec 2013, David Herrmann wrote:
As this thread doesn't really contain any oops message nor the exact
driver name (except mentioning hyperv and magicmouse),
FWIW I recall the oopses being present somewhere in the ubuntu bug
tracker, referenced in this thread.
Thanks,
--
Jiri
On Thu, Dec 19, 2013 at 12:13:14PM +0100, Ralph Mueck wrote:
This patch contains several whitespace cleanups for the beeceem driver that
have been reported by checkpatch.
Too ambigous.
Subsequent patches will fix other issues that checkpatch complains about and
which still remain after
From: Simon Schuster li...@rationality.eu
This patch reduces the level of indentation in bssdb.c of the vt6656
driver by transforming nested conditions to a series of logical
conjunctions. E.g.
if (cond1) {
if (cond2) {
block();
}
}
is transformed to
if (cond1
This patch series reformats the bssdb.c file of the vt6656 driver in
staging. It resolves all errors and some warnings which checkpatch.pl
discovered.
However some occurrences of the following warnings are not patched:
- Lines over 80 characters
- Too many indentation levels
- printk should
This patch fixed trailing whitespace found by
checkpatch.pl within dgap_trace.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/dgap/dgap_trace.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap_trace.c
On Thu, Dec 19, 2013 at 04:27:05PM +0100, Sebastian Rachuj wrote:
From: Simon Schuster li...@rationality.eu
This patch reformats bssdb.c of the vt6656 driver (in staging) to
conform to the linux coding guidelines.
The indentation is adjusted to use tabs, the argument lists and
conditions
-Original Message-
From: Daniel Borkmann [mailto:dbork...@redhat.com]
Sent: Thursday, December 19, 2013 1:45 PM
To: Haiyang Zhang
Cc: Ben Hutchings; da...@davemloft.net; net...@vger.kernel.org; KY
Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-
ker...@vger.kernel.org;
-Original Message-
From: Ben Hutchings [mailto:bhutchi...@solarflare.com]
Sent: Thursday, December 19, 2013 12:46 PM
To: Haiyang Zhang
Cc: da...@davemloft.net; net...@vger.kernel.org; KY Srinivasan;
o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org;
From: Tom Herbert therb...@google.com
Date: Thu, 19 Dec 2013 13:43:06 -0800
+ u32 v, r;
+ int off, rem;
+
+ off = idx / 8;
+ rem = idx % 8;
+
+ v = (((unsigned int)key[off]) 24) +
+ (((unsigned int)key[off + 1]) 16) +
+ (((unsigned
The shared Status registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The Mode registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The ni_tio module is used by the ni_atmio, ni_660x, ni_pcimio and ni_mio_cs
drivers to provide support functions for the NI General Purpose Counters.
The ni_tiocmd module is used by the ni_660x and ni_pcimio to support async
commands with the counters.
These boards that have different register
The DMA Status registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Change the parameters to ni_tio_insn_config() to make it a proper comedi
(*insn_config) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
The LoadA registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetics, move all the MODULE_* information to the end of the file.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c | 32
The Interrupt Enable registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The LoadB registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The Input Select registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The SW Save registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The Status registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Rename the define for the shared status register.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Change the parameters to ni_tio_cmd() to make it a proper comedi
(*do_cmd) function.
The wrappers in the ni_660x and ni_mio_common modules are still needed
to request the mite channel and setup the device before actually doing
the command.
Signed-off-by: H Hartley Sweeten
The HW Save registers are the only ones missing an access macro.
Add one for completness.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 1 +
1
The 'extern' is not required, remove it.
Tidy up the function prototypes a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.h | 57
This inline helper function simply returns the s-private void *.
Remove the helper and just get the s-private void * directly where
needed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
As prefered by the CodingStyle, rename all the CamelCase labels of the
enum ni_gpct_register.
Cleanup all the helper functions in ni_tio_internal.h that used the enum.
The 'counter_index' parameter to all the functions is the ni_gpct_device
'counter_index' which is initialized when the
Change the parameters to ni_tio_winsn() to make it a proper comedi
(*insn_write) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
For aesthetics, rename the function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
The DMA Config registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use a local variable for the 'counter-chip_index' to help shorten the
long lines and clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_660x.c |
Use a local variable for the 'counter-counter_index' to help shorten the
long lines and ugly line breaks.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c |
The shared Reset registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The Counting Mode registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The counter-chip_index will always be counters_per_chip due to the
initialization of the subdevices during the attach of the board.
The dma_selection_counter() helper just does a BUG_ON() check before
returning the original value. Just use the original value directly
in the caller and remove the
As prefered by the CodingStyle, rename this CamelCase enum and its labels.
Also, cleanup the ni_gpct_to_660x_register() helper function. Just return the
ni_660x_register for each ni_gpct_register and remove the unnecessary break
statements after the return statements.
Signed-off-by: H Hartley
Change the parameters to ni_tio_rinsn() to make is a proper comedi
(*insn_read) function. This allows using it directly and removing the
wrapper functions in the ni_660x and ni_mio_common modules.
For aesthetics, rename the function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
-Original Message-
From: Tom Herbert [mailto:therb...@google.com]
Sent: Thursday, December 19, 2013 4:43 PM
To: Haiyang Zhang
Cc: Daniel Borkmann; Ben Hutchings; da...@davemloft.net;
net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
jasow...@redhat.com;
-Original Message-
From: Tom Herbert [mailto:therb...@google.com]
Sent: Thursday, December 19, 2013 2:59 PM
To: Haiyang Zhang
Cc: Daniel Borkmann; Ben Hutchings; da...@davemloft.net;
net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de;
jasow...@redhat.com;
Originally, this driver created it's own allocating
function. This patch removes that function and calls
kzalloc directly.
This patch affects:
- driver.c
- driver.h
- fep5.c
- tty.c
Signed-off-by: Lidza Louina lidza.lou...@gmail.com
---
drivers/staging/dgap/dgap_driver.c | 18
The AutoIncrement registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Clean up the multi-line comment and tidy the function a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_660x.c | 21 -
1 file changed,
The shared Status2 registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The shared Status1 registers are sequential in the enum ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use a local variable for the 'counter-counter_index' to help shorten the
long lines and ugly line breaks.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The Interrupt Acknowledge registers are sequential in the enum
ni_gpct_register.
Replace this inline CamelCase function with a simple define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
From: Wei Yongjun yongjun_...@trendmicro.com.cn
In case of error, the function crypto_alloc_hash() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
Because the original driver was designed to build for Windows, FreeBSD, and
Linux,
there are wrappers for many of the OS primitives. These patches remove a number
of them.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
Larry Finger (11):
staging: r8188eu: Remove pointless thread_exit
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 38
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 16 +++
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
This wrapper does nothing on Linux. When calls to it were removed, a number of
routines became empty and could also be removed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 -
drivers/staging/rtl8188eu/core/rtw_cmd.c |
Each instance may bre replaced by udelay
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/hal/HalPwrSeqCmd.c | 6 +++---
drivers/staging/rtl8188eu/hal/odm.c| 10 -
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 16
drivers/staging/rtl8188eu/core/rtw_mp.c
The checking condition in 'validateFlash2xReadWrite()' is not sufficient.
A large number invalid would cause an integer overflow and pass
the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
Signed-off-by: Wenliang Fan fanwle...@gmail.com
---
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
@@ -1509,10 +1509,6 @@ _func_enter_;
rtw_p2p_set_state(pwdinfo, P2P_STATE_FIND_PHASE_SEARCH);
-
55 matches
Mail list logo
