Re: [PATCH 1/2] staging: comedi: fix auto-unconfig kernel error

On 27/12/13 23:49, Bernd Porr wrote: Signed-off-by: Bernd Porr m...@berndporr.me.uk Signed-off-by should be after the description. :) Merging un-registering of both the subdevices and the main comedi device into one function and the module which actually associated with it. The kernel oops

Re: [PATCH 2/2] staging: comedi: report success/failure of autoconfig

On 27/12/13 23:49, Bernd Porr wrote: Added success message to the driver autoconfig and error message in case it fails. A success message is required so that the user can find out which comedi driver has been associated with which udev device. This also makes troubleshooting much easier when

[PATCH] Staging: comedi: replace printk() calls with dev_dbg() in pcmmio.c

From: Chase Southwood chase.southw...@yahoo.com This is a patch for pcmmio.c that changes several printk() calls to dev_dbg() or dev_err() to fix checkpatch.pl warnings. Patched from 3.13-rc5. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- drivers/staging/comedi/drivers/pcmmio.c

Re: [PATCH 1/2] staging: comedi: fix auto-unconfig kernel error

Signed-off-by should be after the description. :) How did I manage that? ;) Merging un-registering of both the subdevices and the main comedi device into one function and the module which actually associated with it. The kernel oops observed before was because the main device was

[PATCH] Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c

This is a patch to the alarm_dev.c file that fixes up a return is not a function warning found by the checkpatch.pl tool Signed-off-by: Arthur Schwalbenberg arthurs...@gmail.com --- drivers/staging/android/alarm-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] Staging: Android: Fixed coding issue return parenthesis in alarm_dev.c

On Sat, Dec 28, 2013 at 11:03:28AM -0500, Arthur Schwalbenberg wrote: This is a patch to the alarm_dev.c file that fixes up a return is not a function warning found by the checkpatch.pl tool Signed-off-by: Arthur Schwalbenberg arthurs...@gmail.com Why the odd indentation?

Re: [PATCH 1/2] staging: comedi: fix auto-unconfig kernel error

Hi Ian, I've just tested it with a couple of legacy minors and it works fine. You have already taken care of it. comedi_free_board_dev(dev) is only called for autoconfigured devices. If they are legacy devices comedi_free_board_dev won't be called:

[PATCH 2/3] staging: comedi: report success/failure of autoconfig

Added success message to the driver autoconfig and error message in case it fails. A success message is required so that the user can find out which comedi driver has been associated with which udev device. This also makes troubleshooting much easier when more than one card is in the computer or a

[PATCH 3/3] staging: comedi: drivers: streamlined auto attach with main comedi

Removed the word attached from the ADC_zero output which is now reported by comedi itself at the end of the auto attach. A negative value of the offset is an error and should be reported to comedi auto config as an error. Output only the offset if no error has been reported. Signed-off-by: Bernd

[PATCH 1/3] staging: comedi: fix auto-unconfig kernel error

Merging the un-registering of both the subdevices and the main comedi device into one function and the module which actually associated with it. The kernel oops observed before was because the main device was un-registered first and then the subdevices which were then no longer valid. This has

[PATCH] Staging: bcm: DDRInit: fix up some bracing issues.

I fixed some brace coding style issues. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 107 -- 1 file changed, 30 insertions(+), 77 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c