[PATCH 1/1] staging: imx-drm: Fix build error

2014-01-27 Thread Sachin Kamat
Instead of redefining the enums, use the standard ones already available to avoid the following build errors: drivers/staging/imx-drm/imx-hdmi.c:56:13: error: nested redefinition of ‘enum hdmi_colorimetry’ drivers/staging/imx-drm/imx-hdmi.c:56:13: error: redeclaration of ‘enum hdmi_colorimetry’

Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread David Miller
From: Haiyang Zhang Date: Mon, 27 Jan 2014 15:03:42 -0800 > This will allow us to use bigger receive buffer, and prevent allocation > failure > due to fragmented memory. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Dan Carpenter
On Mon, Jan 27, 2014 at 03:27:36PM -0800, Greg KH wrote: > On Tue, Jan 28, 2014 at 02:02:12AM +0300, Dan Carpenter wrote: > > On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote: > > > On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: > > > > From: Heinrich Schuchardt > > > >

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Greg KH
On Tue, Jan 28, 2014 at 02:02:12AM +0300, Dan Carpenter wrote: > On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote: > > On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: > > > From: Heinrich Schuchardt > > > > > > p is freed if NULL. > > > > Not a real problem, right? > >

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Dan Carpenter
On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote: > On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: > > From: Heinrich Schuchardt > > > > p is freed if NULL. > > Not a real problem, right? > > > p is leaked if second calloc fails. > > You just created a new bug in yo

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Sergei Shtylyov
Hello. On 01/28/2014 01:29 AM, xypron.g...@gmx.de wrote: From: Heinrich Schuchardt p is freed if NULL. This is not an issue. p is leaked if second calloc fails. Signed-off-by: Heinrich Schuchardt --- drivers/staging/usbip/userspace/libsrc/names.c |2 +- 1 file changed, 1 ins

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Dan Carpenter
On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: > From: Heinrich Schuchardt Fix your email account so we can get this automatically from your email. Currently the From header on your email is just: From: xypron.g...@gmx.de without your name. > > p is freed if NULL. > p is

Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread Greg KH
On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.g...@gmx.de wrote: > From: Heinrich Schuchardt > > p is freed if NULL. Not a real problem, right? > p is leaked if second calloc fails. You just created a new bug in your "fix" :( Please run your patches through scripts/checkpatch.pl, odds are,

[PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

2014-01-27 Thread xypron . glpk
From: Heinrich Schuchardt p is freed if NULL. p is leaked if second calloc fails. Signed-off-by: Heinrich Schuchardt --- drivers/staging/usbip/userspace/libsrc/names.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/libsrc/names.c b/drive

[PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread Haiyang Zhang
This will allow us to use bigger receive buffer, and prevent allocation failure due to fragmented memory. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/hv/channel.c| 14 -- drivers/net/hyperv/hyperv_net.h |2 +- drivers/net/hyperv/netvsc.c

RE: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread Haiyang Zhang
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, January 27, 2014 4:51 PM > To: Haiyang Zhang > Cc: KY Srinivasan; net...@vger.kernel.org; o...@aepfle.de; > jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org >

RE: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread Haiyang Zhang
> -Original Message- > From: KY Srinivasan > Sent: Monday, January 20, 2014 5:11 PM > To: Haiyang Zhang; David Miller > Cc: net...@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com; linux- > ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org > Subject: RE: [PATCH net-next]

Re: [PATCH net-next] hyperv: Add support for physically discontinuous receive buffer

2014-01-27 Thread David Miller
From: Haiyang Zhang Date: Mon, 27 Jan 2014 21:47:43 + > So, could this patch be taken first? You always need to resend patches that I've originally rejected and you've made arguments for. ___ devel mailing list de...@linuxdriverproject.org http://d

RE: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Haiyang Zhang
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, January 27, 2014 2:31 AM > To: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org; > net...@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Jason Wang > Subject: [PATCH net] net: hyperv: initi

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Jason Wang
On 01/27/2014 06:30 PM, Ben Hutchings wrote: > On Mon, 2014-01-27 at 18:28 +0800, Jason Wang wrote: >> On 01/27/2014 06:22 PM, Ben Hutchings wrote: >>> On Mon, 2014-01-27 at 17:40 +0800, Jason Wang wrote: On 01/27/2014 04:35 PM, David Miller wrote: > From: Jason Wang > Date: Mon, 27 J

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Ben Hutchings
On Mon, 2014-01-27 at 18:28 +0800, Jason Wang wrote: > On 01/27/2014 06:22 PM, Ben Hutchings wrote: > > On Mon, 2014-01-27 at 17:40 +0800, Jason Wang wrote: > >> On 01/27/2014 04:35 PM, David Miller wrote: > >>> From: Jason Wang > >>> Date: Mon, 27 Jan 2014 15:30:54 +0800 > >>> > Call netif_c

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Jason Wang
On 01/27/2014 06:22 PM, Ben Hutchings wrote: > On Mon, 2014-01-27 at 17:40 +0800, Jason Wang wrote: >> On 01/27/2014 04:35 PM, David Miller wrote: >>> From: Jason Wang >>> Date: Mon, 27 Jan 2014 15:30:54 +0800 >>> Call netif_carrier_on() after register_device(). Otherwise it won't work

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Ben Hutchings
On Mon, 2014-01-27 at 17:40 +0800, Jason Wang wrote: > On 01/27/2014 04:35 PM, David Miller wrote: > > From: Jason Wang > > Date: Mon, 27 Jan 2014 15:30:54 +0800 > > > >> Call netif_carrier_on() after register_device(). Otherwise it won't work > >> since > >> the device was still in NETREG_UNINIT

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread Jason Wang
On 01/27/2014 04:35 PM, David Miller wrote: > From: Jason Wang > Date: Mon, 27 Jan 2014 15:30:54 +0800 > >> Call netif_carrier_on() after register_device(). Otherwise it won't work >> since >> the device was still in NETREG_UNINITIALIZED state. >> >> Fixes a68f9614614749727286f675d15f1e09d13cb54a

Re: [PATCH net] net: hyperv: initialize link status correctly

2014-01-27 Thread David Miller
From: Jason Wang Date: Mon, 27 Jan 2014 15:30:54 +0800 > Call netif_carrier_on() after register_device(). Otherwise it won't work since > the device was still in NETREG_UNINITIALIZED state. > > Fixes a68f9614614749727286f675d15f1e09d13cb54a > (hyperv: Fix race between probe and open calls) > >