From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to
flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
From: Micky Ching micky_ch...@realsil.com.cn
If the host driver removed while card in the slot, the host will not
power off card power correctly. This bug is produced because host
eject flag set before the last mmc_set_ios callback, we should set the
eject flag after power off.
Signed-off-by:
From: Micky Ching micky_ch...@realsil.com.cn
The new phase searching method is more concise and easier to
understand.
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
---
drivers/mmc/host/rtsx_pci_sdmmc.c | 112 +++--
include/linux/mfd/rtsx_pci.h |
From: Micky Ching micky_ch...@realsil.com.cn
First we fix the card poweroff bug: the card power is not shutdown when sd/mmc
card removed, this will make UHS-card failed to running in high speed mode if we
insert the card again.
We offer a concise tuning searching method, it is much easier to
From: Micky Ching micky_ch...@realsil.com.cn
Add support for non-blocking request, pre_req() runs dma_map_sg() and
post_req() runs dma_unmap_sg(). This patch can increase card read/write
speed, especially for high speed card and slow CPU(for some embedded
platform).
Users can get a great benefit
On 02/17/2014 04:22 PM, Lee Jones wrote:
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to
flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
On 02/17/2014 06:02 PM, Lee Jones wrote:
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to flash
memory cards. This driver exports host instances for mmc and memstick subsystems
and handles basic works.
Signed-off-by: Roger Tseng
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/efuse.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/efuse.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/ps.c | 28 +---
1 file changed, 1 insertion(+), 27 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/pci.c | 122 +--
1 file changed, 1 insertion(+), 121 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/compat.h | 56
1 file changed, 56 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/core.c | 158 +-
1 file changed, 3 insertions(+), 155 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Series is compile tested against latest linux-next (20140217).
---
drivers/staging/rtl8821ae/base.c | 45 --
1
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/rc.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rc.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/rtl8821ae/trx.c | 45 -
1 file changed, 45 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/debug.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8821ae/debug.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/rtl8821ae/sw.c | 21 -
1 file changed, 21 deletions(-)
diff --git
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data
to flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/pci.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.h
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/regd.h |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8821ae/regd.h
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/rtl8821ae/trx.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.h
On 2014-02-15 03:59, Chase Southwood wrote:
Since simple_strtoul() has been deprecated, replace it with kstrtouint().
Also, since return code checking for this new function is enforced, add a
check to ensure that the conversion has succeeded.
Signed-off-by: Chase Southwood
On 2014-02-16 08:40, Chase Southwood wrote:
This patch for hwdrv_apci035 removes some unneeded braces, and moves some
improperly placed braces to the correct position, as found by checkpatch.
It also removes a commented out if-statement that I found whilst cleaning
braces that is identical to
On 2014-02-16 08:41, Chase Southwood wrote:
This patch for hwdrv_apci035.c aligns comment blocks and makes indentation
of comments consistent. Removed all spaces before tabs in comment
indentation as well.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
On 2014-02-16 08:41, Chase Southwood wrote:
This patch for hwdrv_apci035.c changes a printk() call to a dev_err call
since this is generally preferred.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c | 2 +-
1 file
On 2014-02-16 08:41, Chase Southwood wrote:
This patch for hwdrv_apci035.c removes a zero initialization from two
static variables. Static variables are initialized to zero by default,
so doing so explicitly is not necessary.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
I
On 17 February 2014 18:04, Dan Carpenter dan.carpen...@oracle.com wrote:
On Mon, Feb 17, 2014 at 05:21:56PM +0530, Sachin Kamat wrote:
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
We're going to
On 02/16/2014 04:00 PM, Tomas Winkler wrote:
Looks like phys_addr_t's are fully plumbed in the kernel.
This needs a better commit description.
Also you should include Colin and the rest of the Android kernel folks
(cc'ed in this mail) so they can review and hopefully provide acks.
thanks
-john
On 02/14/2014 01:18 PM, Greg Kroah-Hartman wrote:
On Fri, Feb 14, 2014 at 12:45:30PM -0500, Mark Hounschell wrote:
On 02/14/2014 12:38 PM, Greg Kroah-Hartman wrote:
On Wed, Feb 12, 2014 at 03:32:10PM -0500, Mark Hounschell wrote:
There is a lot of cleanup work to do on these digi drivers and
There are a couple paths where we don't check how much data we copy back
to the user.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index fdebc3bba0b5..6f1997dc44c8 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++
We do:
if (NOB DEFAULT_BUFF_SIZE)
BuffSize = DEFAULT_BUFF_SIZE;
else
BuffSize = NOB;
Since NOB can be negative it results in a larger than intended BuffSize
and makes kzalloc() fail.
The code is still a bit crap because it lets the users read as
On Mon, Feb 17, 2014 at 10:56:06PM +0300, Dan Carpenter wrote:
There are a couple paths where we don't check how much data we copy back
to the user.
I'm curious, is this something smatch is only picking up now that
I chopped up that mega function into lots of little functions ?
Dave
On Mon, Feb 17, 2014 at 02:59:19PM -0500, Dave Jones wrote:
On Mon, Feb 17, 2014 at 10:56:06PM +0300, Dan Carpenter wrote:
There are a couple paths where we don't check how much data we copy back
to the user.
I'm curious, is this something smatch is only picking up now that
I chopped up
On Monday, February 17, 2014 7:16 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-02-16 08:40, Chase Southwood wrote:
This patch for hwdrv_apci035 removes some unneeded braces, and moves some
improperly placed braces to the correct position, as found by checkpatch.
It also removes a commented
On Monday, February 17, 2014 7:18 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-02-16 08:41, Chase Southwood wrote:
This patch for hwdrv_apci035.c changes a printk() call to a dev_err call
since this is generally preferred.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
The 'i8254_osc_base' is the same for all board types. Remove this data
from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 7 ++-
1
Some of the boards supported by this driver can do differential analog
input when configureg with jumpers on the board. When diff. ai is used
the number of input channels is half the single-ended number of channels.
The user specifies the analog input mode for these boards when attaching
to the
For the board types that have digital inputs and outputs there are always
16 input channels and 16 output channels.
Remove the 'n_dichan' and 'n_dochan' members in the boardinfo and replace
them with a bit-field flag 'has_dio'. Refactor pcl812_attach() to use the
new boardinfo.
Signed-off-by: H
All the board types have 12-bit analog outputs. Remove this data from
the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 10 +-
1
This member in the boardinfo is not used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 8
1 file changed, 8 deletions(-)
diff
Change this flag in the boardinfo into a bit-field.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The 'io_range' is the same for all board types. Remove this data from
the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 9 +
1 file
All the board types have 16 digital inputs and 16 digital outputs.
Remove the 'n_dichan' and 'n_dochan' members in the boardinfo.
The subdevice support code is currently incomplete in this driver. For
now just tidy up the incomplete subdevice code in pcl816_attach().
Signed-off-by: H Hartley
The 'io_range' is the same for all board types. Remove this data from
the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 23
The analog input subdevice range is setup in this driver based on a config
option passed by the user. Factor the code that sets the range_table out
of pcl818_attach() to clarify the (*attach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The unlisted members in the boardinfo declaration will default to 0/NULL.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 7 ---
1 file changed, 7
This member of the boardinfo is the same for all board types. Remove this
data from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 5
All the board types that can do DMA can use DMA channels 3 or 1. Remove
the 'DMAbits', which is a mask of the valid channels, from the boardinfo
and replace it with a bit-field flag 'has_dma'.
Refactor pcl818_attach() to use the new flag and remove the need for the
goto.
Signed-off-by: H Hartley
To reduce editing errors and make the data more maintainable, convert
the boardinfo declaration to C99 format.
For aesthetics, move the declaration closer to the definition and remove
the unnecessary comments in the definition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc:
The 'rangelist_ao' is the same for all board types. Remove this data
from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 5 +
1 file
These comedi drivers are all very similar so it made sense to clean them
up together.
This series removes a bunch of the cruft in the drivers and reduces the
boardinfo and private data.
H Hartley Sweeten (87):
staging: comedi: pcl812: convert boardinfo declaration to C99 format
staging:
All the board types have 16 digital inputs and 16 digital outputs.
Remove the 'n_dichan' and 'n_dochan' members in the boardinfo. Refactor
pcl818_attach() to always setup these subdevices.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
To reduce editing errors and make the data more maintainable, convert
the boardinfo declaration to C99 format.
For aesthetics, move the declaration closer to the definition and remove
the unnecessary comments in the definition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc:
This member in the boardinfo is the same for all board types. Remove
it.
The comedi core will initalize the subdevice len_chanlist to 1 if it
is not set by the driver so remove the unnecessary initialization.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
The unlisted members in the boardinfo declaration will default to 0/NULL.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 61
All the boards supported by this driver have 16 analog input channels.
Remove the 'n_aichan' member from the boardinfo and refactor pcl816_attach().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
The 'rangelist_ao' is the same for all board types. Remove this data
from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 16
The timer divisors are calculated in the (*do_cmdtest) before the (*do_cmd)
is called by the comedi core. Save the values in the private data so they
don't need to be recalced.
Refactor pcl812_start_pacer() to use the values from the private data.
Signed-off-by: H Hartley Sweeten
This member of the private data is just a copy of the cmd-chanlist_len.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 16 +++-
1 file
The analog input subdevice range is setup in this driver based on a config
option passed by the user. Factor the code that sets the range_table out
of pcl812_attach() to clarify the (*attach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Introduce a helper function to read the 14/16-bit analog input data
sample.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 26 +++---
THis member of the private data is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 2 --
1 file changed, 2 deletions(-)
This (*insn_read) function was used to read 16-bit analog input data
from the boardACL8216 boardtypes. The 12/16-bit differences are now
handled by the pcl812_ai_eoc() and pcl812_ai_get_sample() helpers.
Remove this function and use pcl812_ai_insn_read() for all boardtypes.
Signed-off-by: H
The hardware does not have any analog output interrupt support. Remove the
stubbed in code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 15
All the boards supported by this driver have 16 single-ended analog input
channels. The boards can also be configued to give 8 differential inputs.
Remove the 'n_aichan_se' and 'n_aichan_diff' members from the boardinfo and
refactor pcl818_attach().
Signed-off-by: H Hartley Sweeten
The 'rangelist_ao' is the same for all board types. Remove this data
from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 10 +-
1
Convert the flags in the private data to bit-fields to save a bit of
space.
Rename the CamelCase 'use_MPC' member.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
All the board types can use IRQ 2-7 for async command support. Remove
the 'IRQbits', which is a mask of the valid IRQs, from the boardinfo
and refactor pcl816_attach().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
THis member of the private data is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 2 --
1 file changed, 2 deletions(-)
Convert the flags in the private data to bit-fields to save a bit of
space.
The 'irq_was_now_closed' member is actually a flag, devpriv-int816_mode
will always be 0 when it's used to set irq_was_now_closed in the cancel
function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc:
The timer divisors are calculated in the (*do_cmdtest) before the (*do_cmd)
is called by the comedi core. The extra sanity checks in the (*do_cmd) are
not necessary, the values returned from i8253_cascade_ns_to_timer() will be
greater than 1. Save the values in the private data so they don't need
All the board types can do DMA using DMA channels 3 or 1. Remove the 'DMAbits',
which is a mask of the valid channels, from the boardinfo.
Refactor pcl816_attach() to remove the need for the goto.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
This driver uses 2 buffers for DMA. Refactor the buffer allocation to
use a for loop to remove code duplication. Remove the dev_err() messages
when __get_dma_pages() fails and change the errno returned from -EBUSY
to -ENOMEM.
Both buffers are the same size so replace the 'dmapages' and
This member of the private data is just a copy of the cmd-stop_arg.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 15 ++-
1 file changed, 6
This member of the private data is just a copy of the cmd-stop_arg.
Refactor the code to follow the style of pcl812 and pcl816 drivers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data is not used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 2 --
1 file changed, 2 deletions(-)
diff --git
Use the subdevice (*cancel) operation to remove the need for a forward
declaration.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 8 +++-
1 file
This member of the private data is just a copy of the cmd-flags.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 4 +---
1 file changed, 1 insertion(+),
The maximum chanlist that this hardware can handle is 16 (the number of
input channels).
Remove this incorrect data from the boardinfo and just initialize the
subdevice 'len_chanlist' to subdevice 'n_chan'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
All the board types have 12-bit analog inputs. Remove this data from
the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 10 +-
1 file
This member of the private data is just a copy of the cmd-stop_arg.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 16 +++-
1 file changed,
This member of the boardinfo is the same for all board types. Remove this
data from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 16
This member of the private data is just a pointer to the cmd-chanlist.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 8 ++--
1
Introduce a helper function to read the 12-bit analog input data
sample and optionally return the channel that the sample was for.
The channel is only used in the interrupt routine to check for
dropped samples.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This member of the private data is just a copy of the cmd-chanlist_len.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 6 ++
1 file changed, 2
All the board types use the same analog input range_table. Remove this
data from the boardinfo.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 5 +
Introduce a helper function to read the 12/16-bit analog input data
sample.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 27
The timer divisors are calculated in the (*do_cmdtest) before the (*do_cmd)
is called by the comedi core. The extra sanity checks in the (*do_cmd) are
not necessary, the values returned from i8253_cascade_ns_to_timer() will be
greater than 1. Save the values in the private data so they don't need
This member in the private data is a flag that indicates that an analog
input async command is currently running. Rename it to make this clear.
The private data is kzalloc'ed in the attach so remove the unnecessary
clearing of this flag.
Signed-off-by: H Hartley Sweeten
This member in the boardinfo is not used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
The private data is kzalloc'ed in the (*attach). There is no need to
initialize and the members to 0.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 2
This driver uses 2 buffers for DMA. Refactor the buffer allocation to
use a for loop to remove code duplication. Remove the dev_err() messages
when __get_dma_pages() fails and change the errno returned from -EBUSY
to -ENOMEM.
Both buffers are the same size so replace the 'dmapages' and
These forward declarations are not needed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 5 -
1 file changed, 5 deletions(-)
diff --git
Use the helper functions in 8253.h to clarify the timer programming.
Move start_pacer() to remove the need for the forward declarations.
Rename the function so it has namespace associated with the driver.
Change the 'mode' parameter. This parameter is really a flag to the
function indicating if
Use the subdevice (*cancel) operation to remove the need for a forward
declaration.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 24
All the board types that can do DMA can use DMA channels 3 or 1. Remove
the 'DMAbits', which is a mask of the valid channels, from the boardinfo
and replace it with a bit-field flag 'has_dma'.
Refactor pcl812_attach() to use the new flag and remove the need for the
goto.
Signed-off-by: H Hartley
These members of the private data don't do anything usefull. Just remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 13 -
1 file
These comments are just added cruft. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 40 -
1 file changed,
Use the helper functions in 8253.h to clarify the timer programming.
Move start_pacer() to remove the need for the forward declarations.
Rename the function so it has namespace associated with the driver.
Change the 'mode' parameter. This parameter is really a flag to the
function indicating if
1 - 100 of 115 matches
Mail list logo
