Please fix the following static checker complaints before moving out of
staging:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
poten
On Tue, Feb 25, 2014 at 02:35:39PM -0500, Mark Hounschell wrote:
> On 02/25/2014 01:40 PM, Mark Hounschell wrote:
>
> >
> >>>+struct dgap_port {
> >>>+struct tty_port port;
> >>>+};
> >>
> >>Do you really need a wrapping structure here?
> >>
> >
> >I may be incorrect, but I think so. I will in
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++--
1 file changed, 47 insertions(+), 47 de
On Wed, Feb 26, 2014 at 06:17:59PM +0900, Daeseok Youn wrote:
>
> These functions are only referenced in this file scope
> so it can be marked static.
> And remove space between function name and open parenthesis.
If it's on the same line as a "static" change then it's fine, otherwise
it should g
Hi,
> > diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index
> > b7b3dd0..1b11886 100644
> > --- a/drivers/video/hyperv_fb.c
> > +++ b/drivers/video/hyperv_fb.c
> > @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info)
> > info->apertures->ranges[0].bas
On Wed, Feb 26, 2014 at 11:39:03AM +0300, Dan Carpenter wrote:
>
> Please fix the following static checker complaints before moving out of
> staging:
>
> drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
> variable dereferenced before check 'dmfc' (see line 157)
Note
Hi,
This patch series adds support for uefi-based gen2 virtual machines
to the hyperv-fb driver. It depends on a few vmbus changes which are
staged in Greg's char-misc tree (and linux-next).
Patch #1 implements gen2 vm support for hyperv-fb.
Patch #2 unregisters efifb early to make sure the f
UEFI-based generation 2 virtual machines support vmbus devices only.
There is no pci bus. Thus they use a different mechanism for the
graphics framebuffer: Instead of using the vga pci bar a chunk of
memory muct be allocated from the hyperv mmio region declared using
APCI. This patch implements
Remove firmware framebuffer before initializing hyperv-fb. Needed
on gen2 virtual machines. Letting register_framebuffer handle the
switchover results in efifb still being active while hyperv graphics
are initialized, which in turn can make the linux kernel hang.
Signed-off-by: Gerd Hoffmann
-
Actually , I saw some code like this file which is seperate line
between return value and function name.
So I didn't make one line of them.
Ok, I will make another patch after merge this one.
Thanks.
Daeseok Youn.
2014-02-26 18:20 GMT+09:00, Dan Carpenter :
> On Wed, Feb 26, 2014 at 06:17:59PM +0
On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote:
> Actually , I saw some code like this file which is seperate line
> between return value and function name.
> So I didn't make one line of them.
>
> Ok, I will make another patch after merge this one.
No, you are misunderstanding what
Oh.. sorry.
Ok, I will seperate this patch as you said.
Thanks.
Daeseok Youn.
2014-02-26 20:31 GMT+09:00, Dan Carpenter :
> On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote:
>> Actually , I saw some code like this file which is seperate line
>> between return value and function name.
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty->port. This will crash the kernel later. Fix the
driver
It also renames the main function this patch addresses because
its name is misleading.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Ha
On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote:
> -static void dgap_sysfs_create(struct board_t *brd)
> +static int dgap_tty_register_ports(struct board_t *brd)
> {
> struct channel_t *ch;
> - int j = 0;
> + int i;
> +
> + brd->SerialPorts = kcalloc(brd->nasync,
On 02/26/2014 09:01 AM, Dan Carpenter wrote:
On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote:
-static void dgap_sysfs_create(struct board_t *brd)
+static int dgap_tty_register_ports(struct board_t *brd)
{
struct channel_t *ch;
- int j = 0;
+ int i;
+
+
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty->port. This will crash the kernel later. Fix the
driver
It also renames the main function this patch addresses because
its name is misleading.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Ha
On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote:
> This patch addresses the follow error message followed
> by a kernel oops:
>
> dgap: driver does not set tty->port. This will crash the kernel later. Fix
> the driver
>
> It also renames the main function this patch addresses bec
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Wednesday, February 26, 2014 5:51 AM
> To: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY Srinivasan;
> Abhishek Gupta (LIS); Haiyang Zhang; jasow...@redhat.com;
>
> -Original Message-
> From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev-
> ow...@vger.kernel.org] On Behalf Of Gerd Hoffmann
> Sent: Wednesday, February 26, 2014 5:51 AM
> To: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY Sriniva
Cc: Eric Bénard
Cc: Greg Kroah-Hartman
Cc: Shawn Guo
Cc: de...@driverdev.osuosl.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis Carikli
---
ChangeLog v7->v8:
- Shrinked even more the Cc list.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove peop
If de-active and/or pixelclk-active properties were set in the
display-timings DT node, they were not used.
Instead the data-enable and the pixel data clock polarity
were hardcoded.
This change is needed for making the eukrea-cpuimx51
QVGA display work.
Cc: Eric Bénard
Cc: Greg Kroah-Hartman
Cc: Alexander Shiyan
Cc: Eric Bénard
Cc: Greg Kroah-Hartman
Cc: driverdev-devel@linuxdriverproject.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis Carikli
---
ChangeLog v7->v8:
- Shrinked even more the Cc list.
- Rebased.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
-
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Cc: Eric Bénard
Cc: Greg Kroah-Hartman
Cc: Shawn Guo
Cc: de...@driverdev.osuosl.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Denis Carikli
---
Change
Hi Russell
(I suspect this my email will be rejected by ALKML too like other my
recent emails, but at least other MLs will pick it up and individual CCs
too, so, if replying, maybe it would be good to keep my entire reply, all
the more that it's going to be very short)
On Thu, 2 Jan 2014, Russ
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes()
error:
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/ipu-v3/ipu-
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/imx
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/imx-drm-core.c | 2 +-
1
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan Carpenter
S
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
Reported-by: Dan Carpenter
Signed-off-by: Fa
On Wed, Feb 26, 2014 at 06:44:34PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
> variable dereferenced before check 'dmfc' (see line 157)
>
> Reported-by: Dan Ca
On Wed, Feb 26, 2014 at 06:44:37PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warnings:
>
> drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
> error: potential null dereference 'mode'. (drm_mode_create returns null)
> driver
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Check 'dmfc' pri
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
d
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes()
error:
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan Carpenter
S
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
drivers/staging/imx-dr
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
Reported-by: Dan Carpenter
Signed-off-by: Fa
On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote:
> Hi Russell
>
> (I suspect this my email will be rejected by ALKML too like other my
> recent emails, but at least other MLs will pick it up and individual CCs
> too, so, if replying, maybe it would be good to keep my entire
On Wed, Feb 26, 2014 at 06:44:36PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
> overflow. buf_size: 16 length: 18
> probably 18 is theory and not real li
URGENT CLAIM IS MANDATORY.
M T N global Net-work Online raffle-draw Promotions.
Head Office: Cotonou Benin,
6701 eminent Road apapa Cotonou,
Benin republic,
(dr.david...@netglo.net ( office contact )
I am Dr.David Gak the International online cor-donator.
We wish you success in our M T N globa
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v2:
- None
Changes sin
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v2:
- None
Cha
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes()
error:
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
Reported-by: Dan Carpenter
Signed-off-by: Fa
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v2:
- None
Changes since v1:
- None
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan Carpenter
Signed-off-by: Fa
On Wed, Feb 26, 2014 at 7:44 PM, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
> overflow. buf_size: 16 length: 18
> probably 18 is theory and not real life, but 16 is base
On Wed, Feb 26, 2014 at 07:44:33PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Fix the following static checker warning:
>
> drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
> overflow. buf_size: 16 length: 18
> probably 18 is theory and not real life, but
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 70 ++--
1 file changed, 35 insertions(+), 35 de
From: Fabio Estevam
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes()
error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes()
error:
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn:
variable dereferenced before check 'dmfc' (see line 157)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v3:
- None
Changes sin
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:
potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v3:
- None
Cha
From: Fabio Estevam
Use snprintf() in order to fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string
overflow. buf_size: 16 length: 18
probably 18 is theory and not real life, but 16 is based on
theory as well.
Reported-by: Dan C
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol
'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter
Signed-off-by: Fabio Estevam
---
Changes since v3:
- None
Changes since v2:
- None
From: Fabio Estevam
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects
argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
Reported-by: Dan Carpenter
Signed-off-by: Fa
56 matches
Mail list logo
