On Sat, 2014-03-01 at 22:22 -0700, Axel Rasmussen wrote:
> The definition of the driver's ChannelPlan array produced a large number
> of checkpatch.pl errors. This patch fixes all of them by adding spaces
> and wrapping the resulting overly-long lines.
I think the current code is better.
> diff -
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 65 ++
1 file changed, 42 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index cd22ba3..a0ca4f2 100644
--- a/dr
The function rtl8180_wmm_param_update contained two blocks of code which
were nearly identical. This patch combines those two blocks into a
single function, to reduce code duplication, and do fix some
checkpatch.pl warnings about excessively long lines due to the large
number of indents that were n
A section of code in the function rtl8180_tx was indented for no reason,
causing numerous checkpatch.pl warnings.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 133 +
1 file changed, 70 insertions(+), 63 deletions(-)
diff --git a/driv
The definition of the driver's ChannelPlan array produced a large number
of checkpatch.pl errors. This patch fixes all of them by adding spaces
and wrapping the resulting overly-long lines.
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 49 ++--
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 73 --
1 file changed, 44 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index b6c8c00..cd22ba3 100644
--- a/dr
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 40 ++
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 67c2583..b6c8c00 100644
--- a/dr
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180_core.c | 125 ++---
1 file changed, 83 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
b/drivers/staging/rtl8187se/r8180_core.c
index 9e1642f..b6fdb6f 100644
--- a/dr
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/r8180.h | 2 +-
drivers/staging/rtl8187se/r8180_core.c | 29 ++---
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180.h
b/drivers/staging/rtl8187se/r8180.h
inde
This set of patches fixes a substantial number of checkpatch.pl errors and
warnings, and additionally it refactors some sections of code where lines were
far too long due to organizational problems.
Axel Rasmussen (9):
drivers: staging: rtl8187se: use netdev_* instead of prink
drivers: stagi
Signed-off-by: Axel Rasmussen
---
drivers/staging/rtl8187se/Module.symvers | 0
drivers/staging/rtl8187se/r8180_core.c | 8
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 drivers/staging/rtl8187se/Module.symvers
diff --git a/drivers/staging/rtl8187se/Module.symve
>On Friday, February 28, 2014 11:49 PM, Chase Southwood
> wrote:
>>On Friday, February 28, 2014 11:26 AM, Ian Abbott wrote:
>>>On 2014-02-28 07:35, Chase Southwood wrote:
[snip]
>>In the case of s626_send_dac(), it doesn't seem to be used in any
>>critical sections, so it could make use of Ha
Replaced all the spin lock/unlock wrappers from oz_polling_lock_bh()
and oz_polllin_unlock_bh() with spin_lock_bh(&g_polling_lock) and
spin_unlock_bh(&g_polling_lock).Completely erased the wrappers defination
and declaration.
Module builded successfully with sparse without warnings.
Signed-off-by:
>On Saturday, March 1, 2014 6:18 PM, Chase Southwood
> wrote:
>Hi Dan,
>
[snip]
>
>I like this idea. Just to clarify though, basically all of the macros would
>change to something like
>
>#define APCI1564_DIGITAL_IP 0x4 #define APCI1564_DIGITAL_IP_INTERRUPT_MODE1
>(0x4 + 0x4) >#define APCI1564
Hi Dan,
>On Saturday, March 1, 2014 6:46 AM, Dan Carpenter
>wrote:
>>On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote:
>> This patch introduces a handful of outl and inl helper functions with the
>> ultimate goal of improving code readability and allowing several lines
>> which v
We don't have such Kconfig option, so the current code is dead and
the documentation is wrong. Users can adjust this setting by using
module parameter or kernel command line, so we can delete this code.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 4
drivers/
Make cvm_oct_free_tx_skbs static to eliminate a sparse warning.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet-tx.c
b/drivers/staging/octeon/ethernet-tx.c
index 47541e1..8c
Make num_packet_buffers static to eliminate a sparse warning.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet.c
b/drivers/staging/octeon/ethernet.c
index 9dbc58f..ff7214a 10064
Make global_register_lock static to eliminate a sparse warning.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet-rgmii.c
b/drivers/staging/octeon/ethernet-rgmii.c
index ea
ethernet-mem was missing its own include file, causing sparse to complain
about undeclared global functions.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-mem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon/ethernet-mem.c
b/drivers/staging/octeon/
This patch applies following code style changes to the whole driver.
- Removing braces from single statements following a 'if' statement.
- Removing unnessasary spaces and braces from files.
- Re-order statements crossing 80 columns limitation.
- Fixed one quoted string split across lines.
Signed
On Sat, Mar 01, 2014 at 03:44:18PM +0300, Dan Carpenter wrote:
> On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote:
> > This patch introduces a handful of outl and inl helper functions with the
> > ultimate goal of improving code readability and allowing several lines
> > which violat
On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote:
> This patch introduces a handful of outl and inl helper functions with the
> ultimate goal of improving code readability and allowing several lines
> which violate the character limit to be shortened in a sane way.
>
> Cc: Dan Carpe
On Sat, Mar 01, 2014 at 05:11:57AM -0500, Mark Hounschell wrote:
> On 02/28/2014 05:36 PM, Dan Carpenter wrote:
> >Please redo this one.
> >
> >On Fri, Feb 28, 2014 at 03:49:09PM -0500, Mark Hounschell wrote:
> >>This patch fixes various small checkpatch errors
> >>I missed in patches 01-10.
> >>
>
On Sat, Mar 01, 2014 at 04:54:41AM -0500, Mark Hounschell wrote:
> On 02/28/2014 05:06 PM, Dan Carpenter wrote:
> >Reviewed-by: Dan Carpenter
> >
> >Btw, for later work, this driver returns -EFAULT a lot when some times
> >it should be returning -EINVAL or something. Also the
> >DGAP_VERIFY_BOARD
On Sat, Mar 01, 2014 at 03:37:17PM +0530, Monam Agarwal wrote:
> Hello all,
>
> I have a confusion regarding functions in aes_ccmp.c. It seems none of
> these functions are currently being used. So Is fine if we can remove
> this file or should we keep it.
Are you sure? The first function I look
We can use these inl and outl helper functions to improve code
readability and shorten several lines to under the character limit.
Cc: Dan Carpenter
Signed-off-by: Chase Southwood
---
I checked over this all several times so I hope it is correct. I welcome
feedback on anything here
Thanks,
Cha
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability and allowing several lines
which violate the character limit to be shortened in a sane way.
Cc: Dan Carpenter
Signed-off-by: Chase Southwood
---
This patchset serves as a replace
On 02/28/2014 05:36 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:49:09PM -0500, Mark Hounschell wrote:
This patch fixes various small checkpatch errors
I missed in patches 01-10.
Signed-off-by: Mark Hounschell
Cc: Greg Kroah-Hartman
---
drivers/staging/dgap/dga
Hello all,
I have a confusion regarding functions in aes_ccmp.c. It seems none of
these functions are currently being used. So Is fine if we can remove
this file or should we keep it.
Regards,
Monam Agarwal
___
devel mailing list
de...@linuxdriverprojec
On 02/28/2014 05:27 PM, Dan Carpenter wrote:
Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
This patch fixes some printk related errors report by checkpatch.
It also removes more Digi debug/trace code left behind from patch #1.
These are two separate p
On 02/28/2014 05:59 PM, Greg KH wrote:
On Fri, Feb 28, 2014 at 12:42:14PM -0500, Mark Hounschell wrote:
This patch fixes "externs should be avoided in .c files"
in dgap.c as reported by checkpatch
Signed-off-by: Mark Hounschell
---
drivers/staging/dgap/dgap.c | 8
1 file changed, 4
On 02/28/2014 05:06 PM, Dan Carpenter wrote:
Reviewed-by: Dan Carpenter
Btw, for later work, this driver returns -EFAULT a lot when some times
it should be returning -EINVAL or something. Also the
DGAP_VERIFY_BOARD() macro is disgusting.
regards,
dan carpenter
Yes, the DGAP_VERIFY_BOARD() i
On 02/28/2014 04:53 PM, Dan Carpenter wrote:
I have some comments on this patch. It's all minor stuff you can fix in
a later patch. Don't redo this one. Staging has more relaxed standards
on whitespace than mm/. We don't want to slow you down by making you
redo stuff and I don't want to revie
On Sat, Mar 01, 2014 at 12:41:55AM -0800, Masood Mehmood wrote:
> - Adjusted pointer's '*' declaration to the data_type.
> - Added space after 'if' keyword
>
> Signed-off-by: Masood Mehmood
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
This patch introduces bugs.
On Fri, Feb 28, 2014 at 06:15:52PM -0800, Masood Mehmood wrote:
>
>
> Fixing some basic coding style issues.
>
Changelog sucks. Doesn't say what the changes are.
> Signed-off-by: Masood Mehmood
> ---
> drivers/staging/tidspbridge/rmgr/node.c | 23 +++---
- Adjusted pointer's '*' declaration to the data_type.
- Added space after 'if' keyword
Signed-off-by: Masood Mehmood
---
drivers/staging/tidspbridge/dynload/tramp.c | 2 +-
drivers/staging/tidspbridge/rmgr/dbdcd.c| 4 ++--
drivers/staging/tidspbridge/rmgr/drv.c | 2 +-
drivers/staging/
37 matches
Mail list logo
