[PATCH 3/5 v4] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git

[PATCH v2 1/2] Staging: comedi: convert while loops to timeouts in s626.c

This patch changes a handful of while loops to timeouts to prevent infinite looping on hardware failure. A couple such loops are in a function (s626_debi_transfer()) which is called from critical sections, so comedi_timeout() is unusable for them, and an iterative timeout is used instead. For

[PATCH v2 2/2] Staging: comedi: propagate timeout errors in s626.c

This patch for s626.c propagates the errors from the newly introduced calls to comedi_timeout() as far as possible. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- Compile tested only. drivers/staging/comedi/drivers/s626.c | 63 +-- 1 file changed,

Re: [PATCH 3/7] staging: cxt1e1: Fix line length over 80 characters in linux.c

On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote: clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/linux.c | 48 +-- 1 files changed,

Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) ci = (ci_t *)(netdev_priv(hi-ndev)); for (j = 0; j ci-max_port; j++) for (k = 0; k MUSYCC_NCHANS; k++) -

Re: [PATCH 00/66] staging: comedi: cleanup pcl812/816/818 drivers part 2

On 03/03/14 21:19, Hartley Sweeten wrote: On Monday, March 03, 2014 11:17 AM, Ian Abbott wrote: On 2014-02-28 23:23, H Hartley Sweeten wrote: This series continues the cleanup of the pcl812/816/818 drivers. H Hartley Sweeten (66): I've looked through them all now. I have noted likely

Re: [PATCH v2 0/9] drivers: staging: rtl8187se: various code cleanups

Seems ok. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/7] staging: cxt1e1: Fix line length over 80 characters in linux.c

Thanks for review. Ok. I Will fix later. Daeseok Youn 2014-03-04 17:45 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Tue, Mar 04, 2014 at 11:08:46AM +0900, Daeseok Youn wrote: clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn

Re: [PATCH 4/7] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

Yes, it need to add brace in inner loop. I will send again. Thanks for review. Daeseok Youn 2014-03-04 18:04 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Tue, Mar 04, 2014 at 11:09:39AM +0900, Daeseok Youn wrote: @@ -1174,7 +1179,8 @@ cleanup_hdlc(void) ci =

Re: [patch 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

On 03/03/2014 04:20 PM, Greg KH wrote: On Mon, Mar 03, 2014 at 02:05:07PM -0600, Romer, Benjamin M wrote: Hi Greg, The copyright text is old boilerplate that we'd been carrying. Be careful about old boilerplate, that can get you in trouble :) We'll change it so that it's correctly GPL 2

[patch V2 0/8] staging: Drivers to support Unisys Secure Partitioning

This series includes a base set of drivers for the Unisys s-Par system. This set of drivers is enough to get a virtual guest up and running on s-Par hardware. The remaining drivers needed to have a fully functional system will be submitted after review of this initial set. s-Par is firmware

[patch V2 4/8] staging: visorchannelstub driver to provide channel support routines

The visorchannelstub module provides support routines for storing and retrieving data from a channel. Signed-off-by: Ken Cox j...@redhat.com Cc: Ben Romer sparmaintai...@unisys.com Index: upstream-staging/drivers/staging/unisys/Kconfig

[patch V2 8/8] staging: s-Par driver documentation

Documentation for the set of s-Par drivers Signed-off-by: Ken Cox j...@redhat.com Cc: Ben Romer sparmaintai...@unisys.com Index: upstream-staging/drivers/staging/unisys/Documentation/proc-entries.txt === --- /dev/null +++

[PATCH 02/04 v2] staging: dgap: get rid of nasty DGAP_VERIFY_BOARD macro

This patch replaces the DGAP_VERIFY_BOARD macro with the dgap_verify_board function because of checkpatch error. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/dgap/dgap.c | 62 +++-- 1

Re: [PATCH] drivers:staging:ozwpan Replaced wrapper functions with actual spin lock function

On 04/03/14 07:57, Surendra Patil wrote: * Replaced all the spin lock/unlock wrappers from oz_polling_lock_bh() and oz_polllin_unlock_bh() with spin_lock_bh(g_polling_lock) and spin_unlock_bh(g_polling_lock).Completely erased the wrappers defination and declaration. * declared g_polling_lock as

RE: [PATCH net-next] hyperv: Move state setting for link query

-Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, March 3, 2014 10:10 PM To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org Cc: KY Srinivasan; o...@aepfle.de; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org Subject:

RE: [PATCH 00/66] staging: comedi: cleanup pcl812/816/818 drivers part 2

On Tuesday, March 04, 2014 2:44 AM, Ian Abbott wrote: On 03/03/14 21:19, Hartley Sweeten wrote: On Monday, March 03, 2014 11:17 AM, Ian Abbott wrote: On 2014-02-28 23:23, H Hartley Sweeten wrote: This series continues the cleanup of the pcl812/816/818 drivers. H Hartley Sweeten (66): I've

[PATCH 33/67 v2] staging: comedi: pcl818: consolidate the common interrupt code

The DMA, FIFO, and EOC interrupt handler functions, that are called by the _real_ interrupt function, always return IRQ_HANDLED. Change the return type for these functions to void and move the final return to the real interrupt function. Change the parameters to the handler functions to the

[PATCH 01/67 v2] staging: comedi: pcl816: remove pcl816_check()

This function is a _very_ simplified probe that tried to verify that the driver is being attached to a PCL-816 compatible board. The function simply writes some values to specific registers then reads back the values to see if they are the same. It's possible that the user could try to attach

[PATCH 05/67 v2] staging: comedi: pcl816: remove 'ai_neverending' from private data

This member of the private data is not needed. We can check the stop_src to determine this information: ai_neverending - cmd-stop_src == TRIG_NONE !ai_neverending - cmd-stop_src == TRIG_COUNT Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc:

[PATCH 36/67 v2] staging: comedi: pcl818: tidy up the digital subdevices

For aesthetics, tidy up the digtial subdevice code. Rename the register map defines for the digital input and output ports. Move the two digital subdevice (*insn_bits) functions out of the analog support functions. Tidy them up a bit during the move. Signed-off-by: H Hartley Sweeten

[PATCH 21/67 v2] staging: comedi: pcl818: factor out the common dropout detect code

The DMA, FIFO, and EOC interrupt handlers all have common code that checks for channel dropout when running an async command. Factor this common code into a helper function. Only return the sample if the channel is valid. The EOC handler was previously returning the value then checking for

[PATCH 22/67 v2] staging: comedi: pcl816: reduce indent level in pcl816_ai_cancel()

If an async command is not running the (*cancel) function doesn't do anything. Exit the function early if this is the case. This allows reducing the indent level in the rest of the function. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 20/67 v2] staging: comedi: pcl818: introduce pcl818_ai_get_fifo_sample()

To clarify the code, introduce a helper function to read the analog input data sample from the FIFO and optionally return the channel that the sample was for. The channel is used to check for dropped samples. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 30/67 v2] staging: comedi: pcl818: remove 'ai_mode' from private data

This member of the private data is not needed. We can determine the interrupt mode based on the 'dma' and 'usefifo' members. Refactor the interrupt handler and the (*cancel) function to not use the 'ai_mode' and remove the setting of this member in the (*do_cmd) heler functions. Signed-off-by: H

[PATCH 13/67 v2] staging: comedi: pcl818: interrupt handlers should not busywait

The interrupt is only generated by the hardware at the completion of an A/D conversion. Because of this the sanity check to make sure that the A/D conversion is complete and data is available is probably unnecessary but it doesn't hurt anything. The busywait loop is a different issue. Interrupt

[PATCH 12/67 v2] staging: comedi: pcl812: interrupt handlers should not busywait

The interrupt is only generated by the hardware at the completion of an A/D conversion. Because of this the sanity check to make sure that the A/D conversion is complete and data is available is probably unnecessary but it doesn't hurt anything. The busywait loop is a different issue. Interrupt

[PATCH 32/67 v2] staging: comedi: pcl816: consolidate the interrupt code

This driver only supports interrupt driven DMA transfers for async command support. Absorb the interrupt_pcl816_ai_mode13_dma() helper into the interrupt handler to clarify the code. At some point during the interrupt, comedi_event() is called to pass any events to the comedi subsystem. Move this

[PATCH 14/67 v2] staging: comedi: pcl816: remove unreachable interrupt handler code

According to the users manual, when using interrupt (non-DMA) transfers this hardware generates an interrupt at the start of a conversion. This requires the interrupt routine to busywait until the end-of-conversion. It appears this was unreliable and interrupt only async command support was

[PATCH 03/67 v2] staging: comedi: pcl818: fix board resource region request

Some of the PCL-818 compatible boards have a FIFO that can be used when running analog input async commands. This FIFO increased the resource range used by the driver. Request the correct resources used by the board even if the FIFO is not used. This prevents another driver from trying to use the

[PATCH 40/67 v2] staging: comedi: pcl818: tidy up the analog input (*insn_read)

For aesthetics, move this function out of the async command support code. For safety, the INT request (end-of-conversion flag) should be cleared before doing each conversion and after the final data sample is read. This driver already clears the flag before starting a conversion but it does not

[PATCH 02/67 v2] staging: comedi: pcl818: remove pcl818_check()

This function is a _very_ simplified probe that tried to verify that the driver is being attached to a PCL-818 compatible board. The function simply writes some values to specific registers then reads back the values to see if they are the same. It's possible that the user could try to attach

[PATCH 11/67 v2] staging: comedi: pcl816: remove 'dmasamplesize' from private data

This member of the private data is not used. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 24/67 v2] staging: comedi: pcl816: clarify 'irq_was_now_closed' flag in private data

This flag in the private data is set when an async command is canceled with the ai (*cancel) operation. Rename the flag to 'ai_cmd_canceled' to clarify its use. Move the check for the flag in the interrupt handler. If the async command was canceled there is no reason to handle the interrupt. Just

[PATCH 04/67 v2] staging: comedi: pcl812: remove 'ai_neverending' from private data

This member of the private data is not needed. We can check the stop_src to determine this information: ai_neverending - cmd-stop_src == TRIG_NONE !ai_neverending - cmd-stop_src == TRIG_COUNT Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc:

[PATCH 09/67 v2] staging: comedi: pcl818: factor out dma setup to helper functions

To assist in cleaning up the the rest of the driver, factor the initial dma setup and the next dma buffer setup into helper functions. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 17/67 v2] staging: comedi: pcl816: factor out the next ai chan code

Factor out the code that bumps the counters in the private data that keep track of what channel is being samples next and when all the data has been sampled. Don't clear the events in the driver. The comedi core will clear the events at the end of the comedi_event(). Make sure the

[PATCH 27/67 v2] staging: comedi: pcl816: exit interrupt quick when there is nothing to do

If an async ai command is not running or the int816_mode is 0 the interrupt routine doesn't do anything other than spew some noise and clear the interrupt request in the hardware. Because this driver is manually attached, the premature interrupt check in the interrupt handler should never happen.

[PATCH 43/67 v2] staging: comedi: pcl812: introduce pcl812_ai_clear_eoc()

Introduce a helper function to clear the end-of-conversion flag. This flag is set when an analog input conversion is finished and the hardware generates an interrupt request. Writing any value to the register resets the flag and re-enables the interrupt. Remove a redundant call in

[PATCH 00/67 v2] staging: comedi: clenaup pcl812/816/818 drivers part 2

This series continues the cleanup of the pcl812/816/818 drivers. v2: address some issues pointed out by Ian Abbott * remove interrupt only command support from the pcl816 driver * reorder FIFO read in the pcl816 driver H Hartley Sweeten (67): staging: comedi: pcl816: remove

[PATCH 44/67 v2] staging: comedi: pcl816: introduce pcl816_ai_clear_eoc()

Introduce a helper function to clear the end-of-conversion flag. This flag is set when an analog input conversion is finished and the hardware generates an interrupt request. Writing any value to the register resets the flag and re-enables the interrupt. Move the call in pcl816_ai_cancel() so

[PATCH 57/67 v2] staging: comedi: pcl818: cleanup setup_channel_list()

Move this function to remove the need for the forward declaration. Rename it so it has namespace associated with the driver. Remove the unnecessary comedi_subdevice parameter from the function. The hardware has per-channel programmable gain. This function first sets the range for each channel

[PATCH 29/67 v2] staging: comedi: pcl816: remove 'int816_mode' from private data

This member of the private data is not needed. Refactor the interrupt handler and the (*cancel) function to not use the 'int816_mode' and remove the setting of this member in the (*do_cmd) heler function. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 46/67 v2] staging: comedi: pcl818: introduce pcl818_ai_soft_trig()

Introduce a helper function to start a software triggered analog input conversion. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 10 +++--- 1 file

[PATCH 66/67 v2] staging: comedi: pcl812: clarify pcl812_reset()

Instead of using the 'board_type' and the switch, use the boardinfo to determine what should be reset. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl812.c | 42

[PATCH 63/67 v2] staging: comedi: pcl812: tidy up the remaining register defines

The PCL812_CNTENABLE define is not used in this driver. Remove it. For aesthetics, rename the software trigger register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 25/67 v2] staging: comedi: pcl818: fix (*cancel) when cmd-stop_src == TRIG_NONE

When using DMA, the async command (*cancel) operation is delayed until the current DMA transfer is complete. When the DMA transfer finishes the interrupt routine detects this and calls the (*cancel) again which should then cancel the async command. The current logic does not work when

[PATCH 45/67 v2] staging: comedi: pcl818: introduce pcl818_ai_clear_eoc()

Introduce a helper function to clear the end-of-conversion flag. This flag is set when an analog input conversion is finished and the hardware generates an interrupt request. Writing any value to the register resets the flag and re-enables the interrupt. Remove the clearing of the flag in

[PATCH 39/67 v2] staging: comedi: pcl818: tidy up the analog output subdevice

For aesthetics, tidy up the analog output subdevice code. Change the regsiter map defines to simplify the code. Move the analog subdevice support functions out of the analog input support functions. Tidy them up a bit during the move. Reverse the logic of the subdevice init and add some

[PATCH 49/67 v2] staging: comedi: pcl812: tidy up analog input registers

For aesthetics, rename the analog input register defines and convert the offsets to hex. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl812.c | 15

[PATCH 35/67 v2] staging: comedi: pcl816: add support for digital subdevices

The PCL-816 boards have 16 digital inputs and 16 digtial outputs. Add the subdevice support for these channels. Allocate additional subdevice space to the analog outputs. This code is not currently in the driver so mark the subdevice as COMEDI_SUBD_UNUSED. Signed-off-by: H Hartley Sweeten

[PATCH 62/67 v2] staging: comedi: pcl818: cleanup ai_cmd()

Rename this function so it has namespace associated with the driver. The cmd-scan_begin_src is always TRIG_FOLLOW and the only valid cmd-convert_src is TRIG_TIMER or TRIG_EXT so pcl818_ai_cmd_mode() is always called with a 'mode' of 1 or 3. The 'mode' actually indicates the trigger source.

[PATCH 50/67 v2] staging: comedi: pcl816: tidy up analog input registers

For aesthetics, rename the analog input register defines and convert the offsets to hex. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 13 +

[PATCH 48/67 v2] staging: comedi: pcl812: introduce pcl812_ai_soft_trig()

Introduce a helper function to start a software triggered analog input conversion. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl812.c | 9 +++-- 1 file

[PATCH 31/67 v2] staging: comedi: pcl812: consolidate the common interrupt code

The DMA and EOC interrupt handler functions, that are called by the _real_ interrupt function, always return IRQ_HANDLED. Change the return type for these functions to void and move the final return to the real interrupt function. Change the parameters to the handler functions to the

[PATCH 53/67 v2] staging: comedi: pcl816: define the status register bits

Define the bits in the status register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 20 +--- 1 file changed, 13 insertions(+), 7

[PATCH 58/67 v2] staging: comedi: pcl812: define the mode register bits

For aesthetics, rename this register. Define the bits in the register to remove the magic values. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl812.c | 30

[PATCH 34/67 v2] staging: comedi: pcl812: tidy up the digital subdevices

For aesthetics, tidy up the digtial subdevice code. rename the register map defines for the digital input and output ports. Move the two digital subdevice (*insn_bits) functions out of the analog support functions. Tidy them up a bit during the move. Add some whitespace to the subdevice init.

[PATCH 59/67 v2] staging: comedi: pcl816: define the mode register bits

Define the bits in the register to remove the magic values. Fix pcl816_ai_cancel(). The 0x73 mask of the value read from the control register will not stop the A/D as indicated by the comment. This would just clear the DS1, POE, and EXT bits which would only disable the external trigger. Setting

[PATCH 47/67 v2] staging: comedi: pcl816: introduce pcl816_ai_soft_trig()

Introduce a helper function to start a software triggered analog input conversion. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 11 --- 1 file

[PATCH 52/67 v2] staging: comedi: pcl818: define the status register bits

Define the bits in the status register and remove the magic values. Writing any value to the status register clears any pending interrupt. For aesthetics, rename the status register and remove the clrint register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 56/67 v2] staging: comedi: pcl816: cleanup setup_channel_list()

Move this function to remove the need for the forward declaration. Rename it so it has namespace associated with the driver. Remove the unnecessary comedi_subdevice parameter from the function. The hardware has per-channel programmable gain. This function first sets the range for each channel

[PATCH 60/67 v2] staging: comedi: pcl818: define the mode register bits

Define the bits in the register to remove the magic values. Tidy up pcl818_ai_cancel(). The 0x73 mask of the value read from the control register will disable dma and interrupts but it does not change the trigger mode. So the software trigger following it might not work. Just disable the trigger

[PATCH 51/67 v2] staging: comedi: pcl818: tidy up analog input registers

For aesthetics, rename the analog input register defines and convert the offsets to hex. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 13 +

[PATCH 67/67 v2] staging: comedi: pcl818: clarify pcl818_reset()

Like done in the pcl812 driver, use the boardinfo to determine what should be reset. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 31

[PATCH 55/67 v2] staging: comedi: pcl812: cleanup setup_range_channel()

Move this function to remove the need for the forward declaration. Rename it so it has namespace associated with the driver. Remove the unnecessary comedi_subdevice parameter from the function. The hardware does not support analog input channel scanning so the mux and range need to be set before

[PATCH 42/67 v2] staging: comedi: pcl812: tidy up the analog input (*insn_read)

For aesthetics, move this function out of the async command support code. For safety, the INT request (end-of-conversion flag) should be cleared before doing each conversion and after the final data sample is read. The driver currently does not do this. Refactor the function a bit so it's more

[PATCH 18/67 v2] staging: comedi: pcl818: factor out the common next ai chan code

The DMA, FIFO, and EOC interrupt handlers all have common code that bumps the counters in the private data that keep track of what channel is being sampled next and when all the data has been sampled. Factor this common code into a helper function. Make sure the COMEDI_CB_BLOCK event is set when

[PATCH 41/67 v2] staging: comedi: pcl816: tidy up the analog input (*insn_read)

For aesthetics, move this function out of the async command support code. For safety, the INT request (end-of-conversion flag) should be cleared before doing each conversion and after the final data sample is read. This driver does that but it's a bit awkward with the initial clear being outside

[PATCH 16/67 v2] staging: comedi: pcl812: factor out the common next ai chan code

The DMA and EOC interrupt handlers all have common code that bumps the counters in the private data that keep track of what channel is being sampled next and when all the data has been sampled. Factor this common code into a helper function. Don't clear the events in the driver. The comedi core

[PATCH 64/67 v2] staging: comedi: pcl816: tidy up the remaining register defines

For aesthetics, rename the clear INT request register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl816.c | 9 + 1 file changed, 5 insertions(+), 4

[PATCH 54/67 v2] staging: comedi: pcl812: define the status register bits

Define the bits in the status register. Writing any value to the status register clears any pending interrupt. For aesthetics, rename the status register and remove the clrint register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 28/67 v2] staging: comedi: pcl818: exit interrupt quick when there is nothing to do

If an async ai command is not running or the ai_mode is 0 the interrupt routine doesn't do anything other than spew some noise and clear the interrupt request in the hardware. Because this driver is manually attached, the premature interrupt check in the interrupt handler should never happen. The

[PATCH 23/67 v2] staging: comedi: pcl818: reduce indent level in pcl818_ai_cancel()

If an async command is not running the (*cancel) function doesn't do anything. Exit the function early if this is the case. This allows reducing the indent level in the rest of the function. Also, move the setting of the 'irq_was_now_closed' to the only place wher it actually gets left set to 1

[PATCH 15/67 v2] staging: comedi: pcl816: only hook up async command support if DMA is available

This driver only supports async commands if a DMA channel is available. Modify the subdevice init so that the command support only gets hooked up if we can do DMA. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 37/67 v2] staging: comedi: pcl816: move pcl816_reset()

For aesthetics, move this function to follow the pcl812 and pcl818 drivers better. Remove the commented out cut-and-paste code from the pcl818 driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 65/67 v2] staging: comedi: pcl818: tidy up the remaining register defines

For aesthetics, rename the timer/counter enable request register and define its bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 15 ++-

[PATCH 19/67 v2] staging: comedi: pcl818: fix PCL818_FI_DATAHI

The A/D FIFO uses two registers to get each analog data sample. PCL818_FI_DATALO is the LSB of the data and PCL818_FI_DATAHI is the MSB of the data. The current define for PCL818_FI_DATAHI is incorrect and results in the LSB getting read twice. Signed-off-by: H Hartley Sweeten

[PATCH 00/12] Migrate usbip-utils to libudev

This patch series modifies the USB/IP userspace side (usbip-utils) to use libudev instead of libsysfs. This change was necessary as libsysfs is no longer maintained and we have discovered a bug that affected USB/IP. On the other hand, libudev is actively maintained and recommended for interacting

[PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

This patch adds autoconf check for libudev and migrates usbip_bind to the new library. libsysfs will still be used until all userspace is modified. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 6 +

[PATCH 02/12] staging: usbip: userspace: remove useless libsysfs includes

This patch removes useless libsysfs.h includes in various userspace files. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_attach.c | 1 - drivers/staging/usbip/userspace/src/usbip_detach.c | 2 --

[PATCH 04/12] staging: usbip: userspace: migrate usbip_list to libudev

This patch modifies usbip_list to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 137 +-- 1 file changed, 51 insertions(+), 86 deletions(-) diff --git

[PATCH 05/12] staging: usbip: userspace: re-add interface information listing

This was deleted in the driver conversion patch. It didn't need to be deleted; showing more information is ok. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++- drivers/staging/usbip/userspace/src/usbipd.c

[PATCH 11/12] staging: usbip: userspace: remove libsysfs flag and autoconf check

libsysfs is now completely removed from USB/IP. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/usbip/userspace/configure.ac

[PATCH 12/12] staging: usbip: userspace: update dependencies in README

Add libudev as dependency and remove libsysfs. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/README

[PATCH 07/12] staging: usbip: userspace: move sysfs_utils to libsrc

Since it offers a API to both usbip tools and libusbip, it is more appropriate to be place in the library. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- .../staging/usbip/userspace/libsrc/sysfs_utils.c | 36

[PATCH 08/12] staging: usbip: userspace: migrate usbip_host_driver to libudev

This patch modifies usbip_host_driver to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/usbip_common.c | 74 ++ .../staging/usbip/userspace/libsrc/usbip_common.h | 5 +- .../usbip/userspace/libsrc/usbip_host_driver.c |

[PATCH 03/12] staging: usbip: userspace: migrate usbip_unbind to libudev

This patch modifies usbip_unbind to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_unbind.c | 92 +++--- 1 file changed, 29 insertions(+), 63 deletions(-) diff --git

[PATCH 10/12] staging: usbip: userspace: migrate vhci_driver to libudev

This patch migrates vhci_driver to libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/usbip_common.h | 1 - .../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++--- .../staging/usbip/userspace/libsrc/vhci_driver.h

[PATCH 06/12] staging: usbip: userspace: add new list API

Add a new list API from CCAN. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- .../staging/usbip/userspace/libsrc/build_assert.h | 40 ++ .../staging/usbip/userspace/libsrc/check_type.h| 64 +++

[PATCH] staging: usbip: userspace: increase version to 2.0

Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac b/drivers/staging/usbip/userspace/configure.ac index 25bf160..607d05c

Re: [PATCH] staging: usbip: userspace: increase version to 2.0

On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote: Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac

[PATCH] staging: usbip: let client choose device configuration

Since usbip-host is now a device driver and the client has full access to the shared device, it makes sense to let the client choose device configuration. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 10 +-

[PATCH] staging: usbip: trigger driver probing after unbinding from usbip-host

A sysfs attribute is used to announce kernel space that a new driver probing session should be triggered for the just unbinded device. In order to have the address of struct device associated to this USB device, a new member has been added to struct bus_id_priv. Signed-off-by: Valentina Manea

[PATCH] staging: usbip: claim ports used by shared devices

Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 22 ++ drivers/usb/core/devio.c | 17 - drivers/usb/core/hub.c | 2 ++ drivers/usb/core/usb.h | 6 +- include/linux/usb.h

[PATCH] staging: usbip: userspace: don't throw error when trying to read configuration specific attributes

When a device has just been bound to usbip-host but the client hasn't set a configuration on it, certain attributes will not exist. Don't treat this as an error. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17

[PATCH] staging: usbip: userspace: add hwdata as optional dependency in README

This is an optional dependency since USB/IP can fully work without it. However, it is needed to display device information such as vendor. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 1 file changed, 4 insertions(+) diff --git

RE: [PATCH net-next] hyperv: Move state setting for link query

-Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, March 3, 2014 10:10 PM To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org Cc: KY Srinivasan; o...@aepfle.de; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org Subject:

Re: [PATCH] staging: usbip: claim ports used by shared devices

On Tue, 4 Mar 2014, Valentina Manea wrote: diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 90e18f6..a91dc1f 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -62,23 +62,6 @@ /* Mutual exclusion for removal, open, and release */

[PATCH] staging: cxt1e1: Add extern keyword for sparse 'static' warning

Resolve sparse warning: symbol '...' was not declared. Should it be static? messages. Includes comet_tables.h, which contains extern declarations for the variables defined in comet_tables.c. Signed-off-by: Shaun Laing sh...@xresource.ca --- drivers/staging/cxt1e1/comet_tables.c |1 + 1

  1   2   >