Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 Thread DaeSeok Youn
Ok. I will use sizeof(name) for snprintf() call. Thanks. Daeseok Youn. 2014-03-06 16:33 GMT+09:00 Tobias Klauser : > On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn wrote: >> 2014-03-05 19:13 GMT+09:00 Tobias Klauser : >> > On 2014-03-05 at 02:24:22 +0100, Daeseok Youn >> > wrote: >> >> >> >> It

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 Thread Tobias Klauser
On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn wrote: > 2014-03-05 19:13 GMT+09:00 Tobias Klauser : > > On 2014-03-05 at 02:24:22 +0100, Daeseok Youn > > wrote: > >> > >> It doesn't need to assign name array address to np pointer. > >> > >> Signed-off-by: Daeseok Youn > >> --- > >> drivers/stag

Re: [PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-05 Thread Andrew Grover
On Wed, Mar 5, 2014 at 10:14 PM, Valentina Manea wrote: > On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote: >> On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote: >>> -AC_INIT([usbip-utils], [1.1.1], [linux-...@vger.kernel.org]) >>> +AC_INIT([usbip-utils], [2.0], [linux-...@vger.kernel.

[PATCH 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

2014-03-05 Thread Chase Southwood
This patch for hwdrv_apci1564.c fixes the register map defines for the digital input registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood --- .../comedi/drivers/addi-data/hwdrv_apci1564.c

[PATCH 4/5] Staging: comedi: addi-data: tidy up timer register map defines in hwdrv_apci1564.c

2014-03-05 Thread Chase Southwood
This patch for hwdrv_apci1564.c fixes the register map defines for the timer registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Additionally, the defines have been renamed to assist with shortening some lines in excess

[PATCH 2/5] Staging: comedi: addi-data: tidy up digital output register map defines in hwdrv_apci1564.c

2014-03-05 Thread Chase Southwood
This patch for hwdrv_apci1564.c fixes the register map defines for the digital output registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Additionally, the defines have been renamed to assist with shortening some lines i

[PATCH 3/5] Staging: comedi: addi-data: tidy up watchdog register map defines in hwdrv_apci1564.c

2014-03-05 Thread Chase Southwood
This patch for hwdrv_apci1564.c fixes the register map defines for the watchdog registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Additionally, the defines have been renamed to assist with shortening some lines in exce

[PATCH 1/5] Staging: comedi: addi-data: tidy up digital input register map defines in hwdrv_apci1564.c

2014-03-05 Thread Chase Southwood
This patch for hwdrv_apci1564.c fixes the register map defines for the digital input registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Additionally, the defines have been renamed to assist with shortening some lines in

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 Thread DaeSeok Youn
2014-03-05 19:13 GMT+09:00 Tobias Klauser : > On 2014-03-05 at 02:24:22 +0100, Daeseok Youn wrote: >> >> It doesn't need to assign name array address to np pointer. >> >> Signed-off-by: Daeseok Youn >> --- >> drivers/staging/cxt1e1/linux.c |5 ++--- >> 1 files changed, 2 insertions(+), 3 del

Re: [PATCH] staging: cxt1e1: use kzalloc instead of kmalloc/memset 0

2014-03-05 Thread DaeSeok Youn
Thanks for review. OK. I will try to change all of OS_kmalloc to kmalloc/kzalloc. And I also check GFP_DMA flag in kmalloc/kzalloc. Regards, Daeseok Youn 2014-03-05 19:04 GMT+09:00 Tobias Klauser : > On 2014-03-05 at 03:37:15 +0100, Daeseok Youn wrote: >> >> Signed-off-by: Daeseok Youn >> ---

Re: [PATCHv8][ 4/7] staging: imx-drm: Use de-active and pixelclk-active display-timings.

2014-03-05 Thread Lothar Waßmann
Hi, Denis Carikli wrote: > If de-active and/or pixelclk-active properties were set in the > display-timings DT node, they were not used. > > Instead the data-enable and the pixel data clock polarity > were hardcoded. > > This change is needed for making the eukrea-cpuimx51 > QVGA display work.

[PATCH v2 2/2] Staging: comedi: range: remove unnecessary sanity check

2014-03-05 Thread Fred Akers
This check is unnecessary because range_table will always be initialized to range_unknown by comedi_device_postconfig() for drivers that do not initialize range_table or range_table_list Signed-off-by: Fred Akers --- drivers/staging/comedi/range.c | 4 1 file changed, 4 deletions(-) diff -

[PATCH v2 1/2] Staging: comedi: range: tidy up comedi_check_chanlist()

2014-03-05 Thread Fred Akers
Refactor this function to remove an extra indent level Signed-off-by: Fred Akers --- drivers/staging/comedi/range.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c index

usb driver

2014-03-05 Thread Kalyan Kodamagula
Hi,   Iam new to this ML,I need info regarding Usb device drivers.I had learned Lnx device drivers and having  knowledge on USB Host driver(highlevel).   I had seen probe/read/write functions of a driver.As there is no need to write drivers from scratch,we can gain knowledge by fixing some bugs

Re: [PATCH] Staging: comedi: range: remove unnecessary sanity check

2014-03-05 Thread Greg KH
On Thu, Mar 06, 2014 at 01:07:03AM -0500, Fred Akers wrote: > This check is unnecessary because range_table will always be > initialized to range_unknown by comedi_device_postconfig() for > drivers that do not initialize range_table or range_table_list > > Signed-off-by: Fred Akers > --- > Apply

Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-05 Thread Valentina Manea
On Wed, Mar 5, 2014 at 12:15 PM, Dan Carpenter wrote: > On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote: >> On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: >> > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h >> > b/drivers/staging/usbip/userspace

[PATCH] staging: dgap: remove useless cast on kzalloc()

2014-03-05 Thread Daeseok Youn
coccinelle warning: drivers/staging/dgap/dgap.c:782:3-7: WARNING: casting value returned by k[cmz]alloc to (char *) is useless. drivers/staging/dgap/dgap.c:776:2-16: WARNING: casting value returned by k[cmz]alloc to (struct board_t *) is useless. Signed-off-by: Daeseok Youn --- drivers/stagin

Re: [PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-05 Thread Valentina Manea
On Tue, Mar 4, 2014 at 9:20 PM, Greg KH wrote: > On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote: >> Signed-off-by: Valentina Manea >> --- >> drivers/staging/usbip/userspace/configure.ac | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/u

[PATCH] Staging: comedi: range: remove unnecessary sanity check

2014-03-05 Thread Fred Akers
This check is unnecessary because range_table will always be initialized to range_unknown by comedi_device_postconfig() for drivers that do not initialize range_table or range_table_list Signed-off-by: Fred Akers --- Apply this after first patch drivers/staging/comedi/range.c | 4 1 file ch

[PATCH v2] staging: usbip: claim ports used by shared devices

2014-03-05 Thread Valentina Manea
A device should not be able to be used concurrently both by the server and the client. Claiming the port used by the shared device ensures no interface drivers bind to it and that it is not usable from the server. Signed-off-by: Valentina Manea --- Changes since v1: * add commit description * mov

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Joe Perches
On Thu, 2014-03-06 at 02:52 +0100, Laurent Pinchart wrote: Hi again Laurent > I've thought about that, but it would require iss.h to be included before all > other headers. I've also thought about creating an iss-debug.h header to be > included first just to #define DEBUG, but decided to go for

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Joe Perches
On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote: > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define > CONFIG_DEBUG'. 'DEBUG' needs to be defined for dev_dbg() to have any effect. Not quite. If CONFIG_DYNAMIC_DEBUG is set, these dev_dbg statements are compile

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Greg Kroah-Hartman
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote: > Hi Joe, > > On Wednesday 05 March 2014 16:28:03 Joe Perches wrote: > > On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote: > > > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define > > > CONFIG_DEBUG'

Re: [PATCH 3/3] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 02:52:26PM -0600, Ken Cox wrote: > Add the Unisys s-Par maintainer entry to the MAINTAINERS file. > Add Greg Kroah-Hartman to the list of patch recipients in the TODO file > > Signed-off-by: Ken Cox > --- > MAINTAINERS| 5 + > drivers/staging/u

linux-next: build failure after merge of the wireless-next tree

2014-03-05 Thread Stephen Rothwell
Hi John, [I started by reverting commit 161d78555435 "Revert "Staging: rtl8812ae: remove modules field of rate_control_ops""] After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Joe Perches
On Thu, 2014-03-06 at 02:27 +0100, Laurent Pinchart wrote: > On Wednesday 05 March 2014 17:00:37 Joe Perches wrote: > > On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote: > > > Would you recommend to drop driver-specific Kconfig options related to > > > debugging and use CONFIG_DYNAMIC_DEBU

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Laurent Pinchart
Hi Joe, On Wednesday 05 March 2014 17:35:42 Joe Perches wrote: > On Thu, 2014-03-06 at 02:27 +0100, Laurent Pinchart wrote: > > On Wednesday 05 March 2014 17:00:37 Joe Perches wrote: > > > On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote: > > > > Would you recommend to drop driver-specifi

Re: [PATCH net-next,v2] hyperv: Move state setting for link query

2014-03-05 Thread David Miller
From: Haiyang Zhang Date: Tue, 4 Mar 2014 14:11:06 -0800 > It moves the state setting for query into rndis_filter_receive_response(). > All callbacks including query-complete and status-callback are synchronized > by channel->inbound_lock. This prevents pentential race between them. > > Signed-

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Laurent Pinchart
Hi Joe, On Wednesday 05 March 2014 17:00:37 Joe Perches wrote: > On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote: > > Would you recommend to drop driver-specific Kconfig options related to > > debugging and use CONFIG_DYNAMIC_DEBUG instead ? > > For development, sure, if there's suffici

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Joe Perches
On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote: > Would you recommend to drop driver-specific Kconfig options related to > debugging and use CONFIG_DYNAMIC_DEBUG instead ? For development, sure, if there's sufficient memory. For embedded systems with limited memory, using dynamic_debu

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Laurent Pinchart
Hi Joe, On Wednesday 05 March 2014 16:28:03 Joe Perches wrote: > On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote: > > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define > > CONFIG_DEBUG'. 'DEBUG' needs to be defined for dev_dbg() to have any > > effect. > > Not qu

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Laurent Pinchart
Hi Mauro, Thank you for the review. On Wednesday 05 March 2014 17:10:06 Mauro Carvalho Chehab wrote: > Em Tue, 11 Feb 2014 13:38:51 +0100 Laurent Pinchart escreveu: > > On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote: > > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4

Re: [PATCH 02/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-05 Thread Dan Carpenter
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote: > @@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const > unsigned char *buf, int > if (down_interruptible(&dgap_TmpWriteSem)) > return -EINTR; > > - if (copy_

Re: [PATCH 01/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-05 Thread Dan Carpenter
Btw, if you don't get any messages from me that means I have given your patch the stamp of approval. So good job on your previous patchset. :) On Wed, Mar 05, 2014 at 03:54:49PM -0500, Mark Hounschell wrote: > @@ -1613,7 +1616,8 @@ static void dgap_tty_uninit(struct board_t *brd) > * dgap_snif

[PATCH 00/03] staging: dgap: Digi International dgap driver

2014-03-05 Thread Mark Hounschell
This patchset fixes more 80+ char lines as reported by checkpatch There are still many more. -- 1.8.1.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-05 Thread Mark Hounschell
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 55 + 1 file changed, 36 insertions(+), 19 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 03/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-05 Thread Mark Hounschell
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/d

[PATCH 02/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-05 Thread Mark Hounschell
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 100 +--- 1 file changed, 67 insertions(+), 33 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 1/3] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Ken Cox
A number of functions were used for debug at one time but that code has been removed. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmodutils.h| 99 +--- drivers/staging/unisys/visorutil/visorkmodutils.c | 565 -- 2 files changed, 1 insertion(+), 663 dele

[PATCH 3/3] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Ken Cox
Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox --- MAINTAINERS| 5 + drivers/staging/unisys/MAINTAINERS | 6 -- drivers/staging/unisys/TODO| 1 +

Re: [PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Ken Cox
Please disregard patches 9-11 sent previously. Corrected patches follow. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Mauro Carvalho Chehab
Em Tue, 11 Feb 2014 13:38:51 +0100 Laurent Pinchart escreveu: > Hi Paul, > > Thank you for the patch. > > On Tuesday 11 February 2014 12:17:01 Paul Bolle wrote: > > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 > > camera interface - Build system") added a Kconfig entry for

Re: [PATCH 10/11] staging: unisys: Give exported symbols unique names

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:49:34PM -0600, Ken Cox wrote: > From: Ken Cox Please fix. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 11/11] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:49:50PM -0600, Ken Cox wrote: > From: Ken Cox Please fix ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:48:59PM -0600, Ken Cox wrote: > From: Ken Cox I don't think that's the email address you really want us to use for your commit address... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.

Re: [PATCH 11/11] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:49:50PM -0600, Ken Cox wrote: > From: Ken Cox > > Add the Unisys s-Par maintainer entry to the MAINTAINERS file. > Add Greg Kroah-Hartman to the list of patch recipients in the TODO file > > Signed-off-by: Ken Cox > --- > MAINTAINERS| 7 ++

Re: [PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 01:48:59PM -0600, Ken Cox wrote: > From: Ken Cox Where are patches 1-8? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/11] staging: unisys: Fix MAINTAINERS and TODO

2014-03-05 Thread Ken Cox
From: Ken Cox Add the Unisys s-Par maintainer entry to the MAINTAINERS file. Add Greg Kroah-Hartman to the list of patch recipients in the TODO file Signed-off-by: Ken Cox --- MAINTAINERS| 7 +++ drivers/staging/unisys/MAINTAINERS | 6 -- drivers/staging/unisys/

[PATCH 09/11] staging: unisys: remove unreferenced utility functions.

2014-03-05 Thread Ken Cox
From: Ken Cox A number of functions were used for debug at one time but that code has been removed. Signed-off-by: Ken Cox --- drivers/staging/unisys/include/timskmodutils.h| 99 +--- drivers/staging/unisys/visorutil/visorkmodutils.c | 565 -- 2 files changed, 1 insert

Re: [PATCH] staging: cxt1e1: moved version string declaration

2014-03-05 Thread Greg KH
On Wed, Mar 05, 2014 at 12:29:31PM -0700, Shaun Laing wrote: > To resolve a sparse "should it be static" warning, the declaration for the > pmcc4_OSSI_release version string was moved from its own file to linux.c, and > the resulting empty file was deleted. > > Signed-off-by: Shaun Laing > --- >

[PATCH] staging: cxt1e1: moved version string declaration

2014-03-05 Thread Shaun Laing
To resolve a sparse "should it be static" warning, the declaration for the pmcc4_OSSI_release version string was moved from its own file to linux.c, and the resulting empty file was deleted. Signed-off-by: Shaun Laing --- drivers/staging/cxt1e1/Makefile |1 - drivers/staging/cxt1e1/linu

Re: [PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference

2014-03-05 Thread Dan Carpenter
On Wed, Mar 05, 2014 at 02:04:35PM +0100, Maxin B. John wrote: > From: "Maxin B. John" > > cppcheck reported possible null pointer dereference in mdc_lib.c > > [lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible null pointer dereference > : op_data - otherwise it is redundant to check if op_data

Re: [PATCH] Staging: comedi: range: tidy up comedi_check_chanlist()

2014-03-05 Thread Ian Abbott
On 2014-03-05 16:50, Hartley Sweeten wrote: But, it appears that this sanity check is really unnecessary: + if (!s->range_table && !s->range_table_list) { dev_err(dev->class_dev, "(bug) no range type list!\n"); return -EINVAL; } The comedi_check_c

10年前,互联网来了,有人因此成为商业巨头

2014-03-05 Thread 李佩��
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] Staging: comedi: range: tidy up comedi_check_chanlist()

2014-03-05 Thread Hartley Sweeten
On Wednesday, March 05, 2014 1:12 AM, Fred Akers wrote: > > Refactor this function to remove an extra indent level > > Signed-off-by: Fred Akers > --- > drivers/staging/comedi/range.c | 39 +++ > 1 file changed, 19 insertions(+), 20 deletions(-) FWIW, I'm ok w

[PATCH] staging: lustre: storage class should be before const qualifier

2014-03-05 Thread Tobias Klauser
The C99 specification states in section 6.11.5: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Signed-off-by: Tobias Klauser --- drivers/staging/lustre/lustre/lov/lov_object.c |2 +- 1 file cha

RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-05 Thread Haiyang Zhang
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, March 5, 2014 12:57 AM > To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org > Cc: KY Srinivasan; o...@aepfle.de; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org > Su

Re: [PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Philipp Zabel
Am Mittwoch, den 05.03.2014, 10:05 + schrieb Russell King - ARM Linux: > On Wed, Mar 05, 2014 at 10:20:52AM +0100, Philipp Zabel wrote: > > +struct imx_drm_component { > > + struct device_node *of_node; > > + struct list_head list; > > +}; > > + > > The only thing this structure appears to

Re: [patch V2 8/8] staging: s-Par driver documentation

2014-03-05 Thread Ken Cox
On 03/04/2014 06:57 PM, Greg KH wrote: On Tue, Mar 04, 2014 at 07:58:12AM -0600, Ken Cox wrote: Index: upstream-staging/drivers/staging/unisys/MAINTAINERS === Are you using cvs? Please start using git... I'm using quilt to genera

Re: [patch V2 1/8] staging: visorutil driver to provide common functionality to other s-Par drivers

2014-03-05 Thread Ken Cox
On 03/04/2014 06:54 PM, Greg KH wrote: On Tue, Mar 04, 2014 at 07:58:05AM -0600, Ken Cox wrote: +EXPORT_SYMBOL_GPL(proc_CreateType); You have some _very_ generic symbols that you are now exporting. Here's another funny one: +int hexDumpWordsToBuffer(char *dest, +int

[PATCH 2/2] lustre/lov_obd: fix possible null pointer dereference

2014-03-05 Thread Maxin B. John
From: "Maxin B. John" osc_obd can be NULL. cppcheck reported this: [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference: osc_obd - otherwise it is redundant to check if osc_obd is null at line 295 Signed-off-by: Maxin B. John --- drivers/staging/lustre/lustre/lov/lov_ob

[PATCH 1/2] lustre/mdc_lib: fix possible null pointer dereference

2014-03-05 Thread Maxin B. John
From: "Maxin B. John" cppcheck reported possible null pointer dereference in mdc_lib.c [lustre/lustre/mdc/mdc_lib.c:233]: (error) Possible null pointer dereference : op_data - otherwise it is redundant to check if op_data is null at line 226 Signed-off-by: Maxin B. John --- drivers/staging/lu

Re: [PATCH 00/67 v2] staging: comedi: clenaup pcl812/816/818 drivers part 2

2014-03-05 Thread Ian Abbott
On 2014-03-04 18:29, H Hartley Sweeten wrote: This series continues the cleanup of the pcl812/816/818 drivers. v2: address some issues pointed out by Ian Abbott * remove interrupt only command support from the pcl816 driver * reorder FIFO read in the pcl816 driver H Hartley Sweeten (6

Re: [PATCH] Staging: comedi: range: tidy up comedi_check_chanlist()

2014-03-05 Thread Ian Abbott
On 2014-03-05 08:11, Fred Akers wrote: Refactor this function to remove an extra indent level Signed-off-by: Fred Akers Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd.E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- ___

Re: [PATCH v2 2/2] Staging: comedi: propagate timeout errors in s626.c

2014-03-05 Thread Ian Abbott
On 2014-03-04 08:44, Chase Southwood wrote: This patch for s626.c propagates the errors from the newly introduced calls to comedi_timeout() as far as possible. Signed-off-by: Chase Southwood --- Compile tested only. Looks good, but if you change patch 1 this one will need rebasing to it. --

Re: [PATCH v2 1/2] Staging: comedi: convert while loops to timeouts in s626.c

2014-03-05 Thread Ian Abbott
On 2014-03-04 08:43, Chase Southwood wrote: This patch changes a handful of while loops to timeouts to prevent infinite looping on hardware failure. A couple such loops are in a function (s626_debi_transfer()) which is called from critical sections, so comedi_timeout() is unusable for them, and

[patch] staging: rtl8712: fix some confusing indenting

2014-03-05 Thread Dan Carpenter
These set off a static checker warning about "warn: add curly braces?", but actually the code it correct, it's just the indenting which is wrong. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index cc68d9748edb..57fef70ad984

Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-05 Thread Dan Carpenter
On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote: > On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: > > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h > > b/drivers/staging/usbip/userspace/libsrc/usbip_common.h > > index 2cb81b3..565ac78 100644 > >

Re: [PATCH 06/12] staging: usbip: userspace: add new list API

2014-03-05 Thread Dan Carpenter
On Tue, Mar 04, 2014 at 10:35:39PM -0800, Greg KH wrote: > On Tue, Mar 04, 2014 at 09:10:46PM +0200, Valentina Manea wrote: > > Add a new list API from CCAN. > > Why can't you just take the one from the kernel, as userspace is GPLv2 > code, right? > > And are you sure CC0 is a "valid" license tha

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 Thread Tobias Klauser
On 2014-03-05 at 02:24:22 +0100, Daeseok Youn wrote: > > It doesn't need to assign name array address to np pointer. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/cxt1e1/linux.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/cxt1e1/

Re: [PATCH] staging: cxt1e1: use kzalloc instead of kmalloc/memset 0

2014-03-05 Thread Tobias Klauser
On 2014-03-05 at 03:37:15 +0100, Daeseok Youn wrote: > > Signed-off-by: Daeseok Youn > --- > drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h > b/drivers/staging/cxt1e1/

Re: [PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 10:20:52AM +0100, Philipp Zabel wrote: > +struct imx_drm_component { > + struct device_node *of_node; > + struct list_head list; > +}; > + The only thing this structure appears to be doing is ensuring that a single component doesn't get added twice - is that correct

Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-05 Thread Dan Carpenter
On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: > +int write_sysfs_attribute(const char *attr_path, const char *new_value, > + size_t len) > +{ > + int fd; > + int length; > + > + if (attr_path == NULL || new_value == NULL || len == 0) { Can any

Re: [PATCH 4/7 v3] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-05 Thread DaeSeok Youn
Thank you for your kind explanation. I will do that when my patch is sent again. regards, Daeseok Youn. 2014-03-05 17:08 GMT+09:00 Dan Carpenter : > On Wed, Mar 05, 2014 at 04:58:36PM +0900, DaeSeok Youn wrote: >> Yes, it is not changed anything. >> >> But I had a request of greg. >> He want to r

Re: [PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-05 Thread Dan Carpenter
On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h > b/drivers/staging/usbip/userspace/libsrc/usbip_common.h > index 2cb81b3..565ac78 100644 > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h > +++ b/driv

[PATCH v2] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2014-03-05 Thread Philipp Zabel
The i.MX Image Processing Unit (IPU) contains a number of image processing blocks that sit right in the middle between DRM and V4L2. Some of the modules, such as Display Controller, Processor, and Interface (DC, DP, DI) or CMOS Sensor Interface (CSI) and their FIFOs could be assigned to either fram

[PATCH v5 06/11] imx-drm: imx-tve: Fix DDC I2C bus property

2014-03-05 Thread Philipp Zabel
This patch fixes the TV Encoder DDC I2C bus property to use the common 'ddc-i2c-bus' property name instead of 'ddc'. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-tve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers

[PATCH v5 02/11] staging: imx-drm-core: use of_graph_parse_endpoint

2014-03-05 Thread Philipp Zabel
Using of_graph_parse_endpoint recovers the port id from an endpoint device tree node. This just replaces an open coded read of the "reg" property. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/d

[PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Philipp Zabel
From: Philipp Zabel This patch adds support to find the involved components connected to the IPU display interface ports using the OF graph bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. It makes use of the of_graph (formerly v4l2_of) parsing helpers and thus

[PATCH v5 11/11] staging: imx-drm: Update TODO

2014-03-05 Thread Philipp Zabel
The device tree bindings are updated regardless of the common display framework and in the meantime the HDMI driver was included. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/imx-drm/TODO b/drivers/staging/i

[PATCH v5 07/11] ARM: dts: imx53-mba53: Fix TVE DDC I2C bus property

2014-03-05 Thread Philipp Zabel
This patch fixes the Television Encoder node's DDC I2C bus property to use the common property name of 'ddc-i2c-bus' instead of just 'ddc'. Signed-off-by: Philipp Zabel --- arch/arm/boot/dts/imx53-mba53.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx

[PATCH v5 03/11] staging: imx-drm: Document updated imx-drm device tree bindings

2014-03-05 Thread Philipp Zabel
This patch updates the device tree binding documentation for i.MX IPU/display nodes using the OF graph bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Philipp Zabel --- Changes since v4: - changed DT compatible string to 'fsl,imx-display-subsys

[PATCH v5 04/11] staging: imx-drm: Document imx-hdmi device tree bindings

2014-03-05 Thread Philipp Zabel
This patch adds device tree binding documentation for the HDMI transmitter on i.MX6. Signed-off-by: Philipp Zabel --- Changes since v4: - Fixed copy&paste documentation error - Added optional 'ddc-i2c-bus' property --- .../devicetree/bindings/staging/imx-drm/hdmi.txt | 58 +++

[PATCH v5 10/11] ARM: dts: imx6qdl: Add IPU DI ports and endpoints, move imx-drm node to dtsi

2014-03-05 Thread Philipp Zabel
This patch connects IPU and display encoder (HDMI, LVDS, MIPI) device tree nodes, as well as parallel displays on the DISP0 and DISP1 outputs, using the OF graph bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interface

[PATCH v5 08/11] ARM: dts: imx51: Add IPU ports and endpoints, move imx-drm node to dtsi

2014-03-05 Thread Philipp Zabel
This patch connects IPU and and parallel display device tree nodes using the OF graph bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interfaces. The order of endpoints in the ports is arbitrary. Since the imx-drm node

[PATCH v5 09/11] ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi

2014-03-05 Thread Philipp Zabel
This patch connects IPU and display encoder (VGA, LVDS) device tree nodes, as well as parallel displays on the DISP0 and DISP1 outputs, using the OF graph bindings described in Documentation/devicetree/bindings/media/video-interfaces.txt The IPU ports correspond to the two display interfaces. The

[PATCH v5 05/11] imx-drm: imx-hdmi: Fix DDC I2C bus property

2014-03-05 Thread Philipp Zabel
This patch fixes the DDC I2C bus property to use the common 'ddc-i2c-bus' property name instead of 'ddc'. This is already documented in Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-hdmi.c | 2 +- 1 file changed, 1 inserti

[PATCH v5 00/11] imx-drm dt bindings

2014-03-05 Thread Philipp Zabel
Hi, this latest version of the imx-drm DT binding patches applies on top of staging-next and also depends on the OF graph binding patchset that moves the v4l2_of helpers to drivers/of. Currently, the two patchsets are also available at: git://git.pengutronix.de/git/pza/linux.git topic/of-graph

[patch] Staging: rtl8712: fix an error test in start_drv_threads()

2014-03-05 Thread Dan Carpenter
Testing for "if (IS_ERR(padapter->cmdThread) < 0)" doesn't make sense. The kthread_run() function returns error pointers on error pointers on error so it should just be "if (IS_ERR(padapter->cmdThread))". Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/sta

[PATCH] Staging: comedi: range: tidy up comedi_check_chanlist()

2014-03-05 Thread Fred Akers
Refactor this function to remove an extra indent level Signed-off-by: Fred Akers --- drivers/staging/comedi/range.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c index

Re: [PATCH 4/7 v3] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-03-05 Thread Dan Carpenter
On Wed, Mar 05, 2014 at 04:58:36PM +0900, DaeSeok Youn wrote: > Yes, it is not changed anything. > > But I had a request of greg. > He want to resend my patches what he haven't applied to staging-next > branch because my patches had flushed from his own queue. > > And I didn't know how to set the