On 03/08/2014 04:59 AM, Mark Hounschell wrote:
On 03/07/2014 05:46 PM, Dan Carpenter wrote:
I still prefer my patch. Unless I'm missing something? Could you
review it and I will submit it as a patch tomorrow.
I've reviewed it and see no obvious problems. If you like it better, I'm
OK with
On Fri, 2014-03-07 at 01:30 -0800, Joe Perches wrote:
On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote:
(a question about a new message warning of a missing
blank line between variable declaration blocks and
code in a function)
How many warnings does this generate does this generate
On Mon, Mar 10, 2014 at 09:02:26AM -0700, Joe Perches wrote:
On Fri, 2014-03-07 at 01:30 -0800, Joe Perches wrote:
On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote:
(a question about a new message warning of a missing
blank line between variable declaration blocks and
code in a
sparse reported dgap_do_fep_load is redeclared with different type. while
fixing, I noticed __user attribute is used incorrectly in declaration.
There is no need to define __user for firware-data.
Replaced the __user with 'const uchar *' from function dgap_do_fep_load and
did the same for
This patch fixes a few 80+ char lines
as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 55 -
1 file changed, 30 insertions(+), 25 deletions(-)
On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote:
sparse reported dgap_do_fep_load is redeclared with different type. while
fixing, I noticed __user attribute is used incorrectly in declaration.
There is no need to define __user for firware-data.
Replaced the __user with 'const
On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote:
On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote:
1 file changed, 6 insertions(+), 7 deletions(-)
I don't see a patch 1/2 here, did you forget to send it to me?
Patch 1/2 has some unrelated changes. My bad, I forgot to
On Mon, 2014-03-10 at 09:50 -0700, Greg KH wrote:
On Mon, Mar 10, 2014 at 09:02:26AM -0700, Joe Perches wrote:
On Fri, 2014-03-07 at 01:30 -0800, Joe Perches wrote:
On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote:
(a question about a new message warning of a missing
blank line
On Mon, Mar 10, 2014 at 11:48:50AM -0700, Joe Perches wrote:
On Mon, 2014-03-10 at 09:50 -0700, Greg KH wrote:
On Mon, Mar 10, 2014 at 09:02:26AM -0700, Joe Perches wrote:
On Fri, 2014-03-07 at 01:30 -0800, Joe Perches wrote:
On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote:
(a
On Sun, Mar 09, 2014 at 12:33:32AM -0800, Masood Mehmood wrote:
On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote:
On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote:
1 file changed, 6 insertions(+), 7 deletions(-)
I don't see a patch 1/2 here, did you forget to send
On Mon, Mar 10, 2014 at 12:34:22PM -0700, Greg KH wrote:
On Sun, Mar 09, 2014 at 12:33:32AM -0800, Masood Mehmood wrote:
On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote:
On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote:
1 file changed, 6 insertions(+), 7
sparse reported dgap_do_fep_load is redeclared with different type. while
fixing, I noticed __user attribute is used incorrectly in declaration.
There is no need to define __user for firware-data.
Replaced the __user with 'const uchar *' from function dgap_do_fep_load and
did the same for
This patch fixes a few more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git
This patch fixes a few more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 162 ++--
1 file changed, 113 insertions(+), 49
From: K. Y. Srinivasan k...@microsoft.com
Date: Sat, 8 Mar 2014 19:22:42 -0800
This patch set enables both checksum as well as segmentation offload.
As part of this effort I have enabled scatter gather I/O a well.
In version 2 of these patches, I addressed comments from David Miller and
From: Haiyang Zhang haiya...@microsoft.com
Date: Sun, 9 Mar 2014 16:10:59 -0700
Due to a bug in the Hyper-V host verion 2008R2, we need to use a slightly
smaller
receive buffer size, otherwise the buffer will not be accepted by the legacy
hosts.
Signed-off-by: Haiyang Zhang
On Mon, 2014-03-10 at 12:33 -0700, Greg KH wrote:
On Mon, Mar 10, 2014 at 11:48:50AM -0700, Joe Perches wrote:
[]
I've no strong opinion of the need to write code
like:
{
u32 iterations = 0;
while (arch_spin_is_locked(lock))
This CamelCase function is just a wrapper around outb_p(). Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 53
This subdevice is a PWM output not and analog output, fix the 'type'.
Fix the subdevice 'range', range_bipolar does not make sense for a PWM
output. The range_unknown is a better choice.
Remove the commented out init of the 'trig'.
For aesthetics, add some whitespace to the init and rename the
Cleanup the driver.
H Hartley Sweeten (21):
staging: comedi: c6xdigio: remove ReadByteFromHwPort()
staging: comedi: c6xdigio: remove WriteByteToHwPort()
staging: comedi: c6xdigio: remove C6XDIGIO_SIZE
staging: comedi: c6xdigio: factor out status check busywait
staging: comedi: c6xdigio:
The 10-bit pwm value (2-498) is written by banging 2-bits in the data register.
Refactor this function to remove the need for the union pcmcmdtype and struct
pwmbitstype.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
All writes to the hardware involve writing the the data register then
checking the status register. Introduce a helper function to handle this.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
To clarify the code, define the bits in the data register and remove the
magic numbers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 45
From: H Hartley Sweeten hartl...@visionengravers.com
Change the generic MODULE_DESCRIPTION text to something more
specific for this driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Rename the CamelCase function.
For aesthetics, pass the comedi_device pointer instead of the dev-iobase
as the first parameter.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The register map was already defined but it was not being used. Rename
to defines and use them in the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetics, rename this function so it has namespace associated
with the driver.
Absorb the c6xdigio_pwm_init() and c6xdigio_encoder_reset() helpers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Remove the commented out init of the 'trig'.
For aesthetics, add some whitespace to the init and rename the 'insn_read'
function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetics, pass the comedi_device pointer instead of the dev-iobase
as the first parameter.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 52
Rename the CamelCase function.
For aesthetics, pass the comedi_device pointer instead of the dev-iobase
as the first parameter.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Reformat the multi-line comments at the beginning of the code to
follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 55
The value read from the encoders is in two's complement format. Use
the comedi_offset_munge() helper to convert the value to offset binary.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The 24-bit encoder value is read using 3-bits in the status register. The
data register is banged between each read of the status register to advance
the bits.
Introduce a helper function to handle this and remove the union encvaluetype
and struct encbitsbyte.
Signed-off-by: H Hartley Sweeten
Rename the CamelCase function.
For aesthetics, pass the comedi_device pointer instead of the dev-iobase.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c
Factor out the common code that busywaits for the status to change.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 187 --
This CamelCase function is just a wrapper around inb(). Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/c6xdigio.c | 102 ++
Good day,
We are Christian organization, we give out loan to those that have given
there lives to Christ, contact us via email marieloanlend...@gmail.com
Regard
Mrs Marie
___
devel mailing list
de...@linuxdriverproject.org
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Tuesday, March 11, 2014 1:26 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Subject: Re:
unsplit strings from two lines to one.
Signed-off-by: Gary Alan Rookard garyrook...@gmail.com
---
On branch staging-next
drivers/staging/lustre/lustre/fid/fid_request.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
unsplit string from two lines to one.
Signed-off-by: Gary Alan Rookard garyrook...@gmail.com
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c
fixed up a spacing issue.
Signed-off-by: Gary Alan Rookard garyrook...@gmail.com
---
On branch staging-next
drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c
It doesn't need to use while loop for getting newrate,
because it always breaks out the end of while loop with
break. So just replace while with if.
And the type of newrate is unsigned int, this type
is never less than zero. If it can be set to negative value by
user application with ioctl(), it
unsplit strings from two lines to one. Changes resulted
in line over 80 characters warning. Leaving the latter
of the two warnings for possible string grepping reasons.
Signed-off-by: Gary Alan Rookard garyrook...@gmail.com
---
On branch staging-next
On 03/03/2014 04:48 PM, Roger wrote:
On 02/24/2014 11:00 AM, Chris Ball wrote:
Hi,
On Mon, Feb 24 2014, Roger wrote:
Would you please help comment PATCH 2/3 and 3/3 (for mmc and memstick,
respectively) or give Acks? Thus we can proceed with applying or
revision if necessary.
For 2/3:
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote:
Hi,
this latest version of the imx-drm DT binding patches applies
on top of staging-next and also depends on the OF graph binding
patchset that moves the v4l2_of helpers to drivers/of.
Currently, the two patchsets are also
There is a macro RLINIT_TO_NICE in linux/sched/prio.h to convert priority in
rlimit
to nice value.
This patch replace the opened implementation with RLINIT_TO_NICE.
Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com
cc: de...@driverdev.osuosl.org
cc: Masanari Iida standby2...@gmail.com
46 matches
Mail list logo
