[PATCH] staging: unisys: remove incorrect error handling after queue_delayed_work

2014-03-11 Thread Daeseok Youn
The queue_delayed_work() return false if the work is already on the queue, true otherwise. So return value cannot be less than zero. Signed-off-by: Daeseok Youn --- .../unisys/visorchipset/visorchipset_main.c| 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff

[PATCH 13/16] driver/staging/android: Use rlimit_to_nice to replace opened code implementation.

2014-03-11 Thread Dongsheng Yang
There is a macro rlimit_to_nice in linux/sched/prio.h to convert priority in rlimit to nice value. This patch replace the opened implementation with rlimit_to_nice. Signed-off-by: Dongsheng Yang cc: de...@driverdev.osuosl.org cc: Masanari Iida cc: Bojan Prtvar cc: Serban Constantinescu Signe

[PATCH 14/16] driver/staging/lustre: Replace hardcoding of -20 with MIN_NICE.

2014-03-11 Thread Dongsheng Yang
Signed-off-by: Dongsheng Yang cc: de...@driverdev.osuosl.org cc: Xiong Zhou cc: Andreas Dilger cc: Cyril Roelandt cc: Kent Overstreet cc: Peng Tao --- drivers/staging/lustre/lustre/llite/lloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre

[PATCH 15/17] driver/staging/lustre: Replace hardcoding of -20 with MIN_NICE.

2014-03-11 Thread Dongsheng Yang
Signed-off-by: Dongsheng Yang cc: de...@driverdev.osuosl.org cc: Xiong Zhou cc: Andreas Dilger cc: Cyril Roelandt cc: Kent Overstreet cc: Peng Tao --- drivers/staging/lustre/lustre/llite/lloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre

[PATCH 14/17] driver/staging/android: Use rlimit_to_nice to replace opened code implementation.

2014-03-11 Thread Dongsheng Yang
There is a macro rlimit_to_nice in linux/sched/prio.h to convert priority in rlimit to nice value. This patch replace the opened implementation with rlimit_to_nice. Signed-off-by: Dongsheng Yang cc: de...@driverdev.osuosl.org cc: Masanari Iida cc: Bojan Prtvar cc: Serban Constantinescu Signe

Re: [PATCH 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-11 Thread Ian Abbott
On 2014-03-07 20:41, H Hartley Sweeten wrote: Create an enum for the boards supported by this driver and pass that enum in the pci_driver id_table as the driver_data. Introduce a boardinfo struct to hold the board specific data for the boards supported by this driver. Use the boardinfo when atta

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Philipp Zabel
Hi Shawn, Am Dienstag, den 11.03.2014, 11:46 +0800 schrieb Shawn Guo: > On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: > > Hi, > > > > this latest version of the imx-drm DT binding patches applies > > on top of staging-next and also depends on the OF graph binding > > patchset tha

Re: [PATCH 00/14] staging: comedi: jr3_pci: start cleaning up driver

2014-03-11 Thread Ian Abbott
On 2014-03-07 20:40, H Hartley Sweeten wrote: Cleanup the (*attach) of this driver and tidy up the existing code. H Hartley Sweeten (14): staging: comedi: jr3_pci: tidy up subdevice init staging: comedi: jr3_pci: use comedi_alloc_spriv() staging: comedi: jr3_pci: factor subdevice privat

[PATCH] Staging: comedi: ni_daq_dio24: fix a line over 80 characters

2014-03-11 Thread Matei Oprea
Fix a coding style issue. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Commmunity --- drivers/staging/comedi/drivers/ni_daq_dio24.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_d

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Shawn Guo
On Tue, Mar 11, 2014 at 12:42:08PM +0100, Philipp Zabel wrote: > Hi Shawn, > > Am Dienstag, den 11.03.2014, 11:46 +0800 schrieb Shawn Guo: > > On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: > > > Hi, > > > > > > this latest version of the imx-drm DT binding patches applies > > > o

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Lucas Stach
Am Dienstag, den 11.03.2014, 21:27 +0800 schrieb Shawn Guo: > On Tue, Mar 11, 2014 at 12:42:08PM +0100, Philipp Zabel wrote: > > Hi Shawn, > > > > Am Dienstag, den 11.03.2014, 11:46 +0800 schrieb Shawn Guo: > > > On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: > > > > Hi, > > > > >

[PATCH 00/04] staging: dgap: Digi International dgap driver

2014-03-11 Thread Mark Hounschell
Patch 1 - removes some unused defines in dgap.h Patch 2 - removes some unneeded code supporting the old firmware loading process. -- 1.8.1.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/

[PATCH 02/02] staging: dgap: Remove unneeded code from dgap.c

2014-03-11 Thread Mark Hounschell
This patch removes more unneeded code that was supporting the old firmware loading process Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 149 1 file changed, 149 deletions(-) diff

[PATCH 01/02] staging: dgap: remove some unused defines in dgap.h

2014-03-11 Thread Mark Hounschell
This patch removes some unused defines in dgap.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.h | 53 ++--- 1 file changed, 2 insertions(+), 51 deletions(-) diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging

Re: [PATCH 00/31] staging: comedi: comedi_fc: tidy up and use

2014-03-11 Thread Ian Abbott
On 2014-03-08 00:31, H Hartley Sweeten wrote: This module has a number of helper functions for common operations in comedi drivers. Tidy it up and then use the helpers in the drivers to remove some of the duplicate code. H Hartley Sweeten (31): Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV

[PATCH 03/04] staging: dgap: Remove unused DGAP_TRYLOCK macro

2014-03-11 Thread Mark Hounschell
This patch removes the unused DGAP_TRYLOCK macro Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h index 415d816..feeea7c 100644 --- a/drivers/stagin

[PATCH 04/04] staging: dgap: Replace/remove DGAP_SPINLOCK_INIT macro

2014-03-11 Thread Mark Hounschell
This patch gets rid of the DGAP_SPINLOCK_INIT macro Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 4 ++-- drivers/staging/dgap/dgap.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dga

Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

2014-03-11 Thread Ian Abbott
On 2014-03-09 02:42, Conrad Meyer wrote: Brought to you with the help of sed and manual clean-up after. $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \ addi-data/hwdrv_apci1500.c Since all of these printk()s were for invalid API inputs and most of them returned -EINVAL, I fixe

Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in s626.c

2014-03-11 Thread Ian Abbott
On 2014-03-09 04:00, Chase Southwood wrote: This patch changes a handful of while loops to timeouts to prevent infinite looping on hardware failure. A couple such loops are in a function (s626_debi_transfer()) which is called from critical sections, so comedi_timeout() is unusable for them, and a

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Shawn Guo
On Tue, Mar 11, 2014 at 02:34:38PM +0100, Lucas Stach wrote: > > Sorry, Philipp. The setup in my report is incorrect. The correct setup > > to see this issue consists of: > > > > 1) build a kernel without HDMI support, i.e. !CONFIG_DRM_IMX_HDMI > > > > 2) enable HDMI device in DT, i.e. adding t

Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names

2014-03-11 Thread Ian Abbott
On 2014-03-09 07:26, Fred Akers wrote: This patch fixes a few function names that are very long and are not in the correct naming style Signed-off-by: Fred Akers --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 62 ++ drivers/staging/comedi/drivers/addi_apci_1564.

Re: [PATCH v3 2/2] Staging: comedi: propagate timeout errors in s626.c

2014-03-11 Thread Ian Abbott
On 2014-03-08 01:43, Chase Southwood wrote: This patch for s626.c propagates the errors from the newly introduced calls to comedi_timeout() as far as possible. Signed-off-by: Chase Southwood --- Compile tested. 2: This patch was introduced in v2 of this set. 3: Rebased on top of PATCH 1/2 edi

Re: [PATCH 1/2] Staging: comedi: Fix if/else style in hwdrv_apci1500.c

2014-03-11 Thread Ian Abbott
On 2014-03-09 16:24, Conrad Meyer wrote: Also kill some useless comments while I was there, e.g.: if (foo) { ... } /* if (foo) */ With vim: :%s/}\t\t*\/\*\s\s*\(if\|else\|for\|while\|switch\).*$/}/ Signed-off-by: Conrad Meyer Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV L

Re: [PATCH 2/2] Staging: comedi: Validate early to flatten code

2014-03-11 Thread Ian Abbott
On 2014-03-09 16:24, Conrad Meyer wrote: Take advantage of -EINVAL returns to flatten code structure and hopefully reduce the number of 80+ character lines. Signed-off-by: Conrad Meyer Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd.E-mail: )=- -=( Tel: +44 (0)161 477 1898

Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names

2014-03-11 Thread Fred Akers
On Tuesday, March 11, 2014 02:31:07 PM Ian Abbott wrote: > On 2014-03-09 07:26, Fred Akers wrote: > > This patch fixes a few function names that are very long and are > > not in the correct naming style > > > > Signed-off-by: Fred Akers > > --- > > > > .../comedi/drivers/addi-data/hwdrv_apci15

Re: [PATCH 12/21] staging: comedi: c6xdigio: introduce c6xdigio_get_encoder_bits()

2014-03-11 Thread Ian Abbott
On 2014-03-10 21:07, H Hartley Sweeten wrote: The 24-bit encoder value is read using 3-bits in the status register. The data register is banged between each read of the status register to advance the bits. Introduce a helper function to handle this and remove the union encvaluetype and struct en

Re: [PATCH 00/21] staging: comedi: c6xdigio: cleanup driver

2014-03-11 Thread Ian Abbott
On 2014-03-10 21:07, H Hartley Sweeten wrote: Cleanup the driver. H Hartley Sweeten (21): staging: comedi: c6xdigio: remove ReadByteFromHwPort() staging: comedi: c6xdigio: remove WriteByteToHwPort() staging: comedi: c6xdigio: remove C6XDIGIO_SIZE staging: comedi: c6xdigio: factor out

Re: [PATCH] Staging: comedi: fixup: dev_warn() with correct dev

2014-03-11 Thread Ian Abbott
On 2014-03-11 14:58, Conrad Meyer wrote: Replace hw_dev with class_dev in new dev_warn()s. Sending this as a patch on top of the one already applied, since GregKH already took that one. If this is the wrong way to fix it, please let me know how I should proceed, I'm new. Thanks! Signed-off-by:

[PATCH] Staging: comedi: fixup: dev_warn() with correct dev

2014-03-11 Thread Conrad Meyer
Replace hw_dev with class_dev in new dev_warn()s. Sending this as a patch on top of the one already applied, since GregKH already took that one. If this is the wrong way to fix it, please let me know how I should proceed, I'm new. Thanks! Signed-off-by: Conrad Meyer --- .../comedi/drivers/addi

RE: [PATCH 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-11 Thread Hartley Sweeten
On Tuesday, March 11, 2014 4:18 AM, Ian Abbott wrote: > On 2014-03-07 20:41, H Hartley Sweeten wrote: >> Create an enum for the boards supported by this driver and pass that enum in >> the pci_driver id_table as the driver_data. >> >> Introduce a boardinfo struct to hold the board specific data for

[PATCH v2 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-11 Thread H Hartley Sweeten
Create an enum for the boards supported by this driver and pass that enum in the pci_driver id_table as the driver_data. Introduce a boardinfo struct to hold the board specific data for the boards supported by this driver. Use the boardinfo when attaching to the driver instead of using the pcidev-

RE: [PATCH v2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-11 Thread Hartley Sweeten
On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote: > This patch fixes a few function names that are very long and are > not in the correct naming style > > Signed-off-by: Fred Akers > --- > This is v2 of "[PATCH] Staging: comedi: apci_1564: Fix long CamelCase > function names" > Changed subje

RE: [PATCH v2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-11 Thread Hartley Sweeten
On Tuesday, March 11, 2014 10:49 AM, Joe Perches wrote: > On Tue, 2014-03-11 at 17:42 +, Hartley Sweeten wrote: >> On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote: >>> This patch fixes a few function names that are very long and are >>> not in the correct naming style > [] >>> diff --git

Re: [PATCH v2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-11 Thread Joe Perches
On Tue, 2014-03-11 at 17:42 +, Hartley Sweeten wrote: > On Tuesday, March 11, 2014 10:33 AM, Fred Akers wrote: > > This patch fixes a few function names that are very long and are > > not in the correct naming style [] > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci035.c >

[PATCH 1/2] staging: comedi: dac02: introduce comedi driver for DAC02 boards

2014-03-11 Thread H Hartley Sweeten
From: H Hartley Sweeten This board is currently supported by the poc driver. That driver used to support a number of simple boards but now only provides support for the DAC02 board. Introduce a new comedi driver specifically for the DAC02 board. This allows cleaning up all the cruft. Signed-off

[PATCH 2/2] staging: comedi: poc: remove obsolete driver

2014-03-11 Thread H Hartley Sweeten
From: H Hartley Sweeten The DAC02 board, which is the only board supported by this driver, now has its own comedi driver (dac02). Remove this obsolete driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/Kconfig | 9 -- drivers

[PATCH 0/2] staging: comedi: drivers: replace poc driver with new dac02 driver

2014-03-11 Thread H Hartley Sweeten
The poc driver was a catch-all for some very simple boards. Most of the boards that used to be supported by this driver have been migrated to other common drivers. The only board remaining in it was the DAC02, a two channel analog output board. Introduce a separate, simplified, driver for the DA

Re: [PATCH 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-11 Thread gre...@linuxfoundation.org
On Tue, Mar 11, 2014 at 04:48:42PM +, Hartley Sweeten wrote: > On Tuesday, March 11, 2014 4:18 AM, Ian Abbott wrote: > > On 2014-03-07 20:41, H Hartley Sweeten wrote: > >> Create an enum for the boards supported by this driver and pass that enum > >> in > >> the pci_driver id_table as the driv

RE: [PATCH 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-11 Thread Hartley Sweeten
On Tuesday, March 11, 2014 2:38 PM, gre...@linuxfoundation.org wrote: > On Tue, Mar 11, 2014 at 04:48:42PM +, Hartley Sweeten wrote: >> On Tuesday, March 11, 2014 4:18 AM, Ian Abbott wrote: >>> That's initializing the `class` member instead of the `driver_data` >>> member. You can use `PCI_VD

[RFC PATCH 09/22] staging: crypto: skein: use u8, u64 vice uint*_t

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18 +++

[RFC PATCH 21/22] staging: crypto: skein: remove unnecessary line continuation

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c +++

[RFC PATCH 04/22] staging: crypto: skein: remove brg_*.h includes

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions(-) dele

[RFC PATCH 18/22] staging: crypto: skein: wrap multi-line macros in do-while loops

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a/

[RFC PATCH 10/22] staging: crypto: skein: fixup pointer whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18 +

[RFC PATCH 22/22] staging: crypto: skein: add TODO file

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null ++

[RFC PATCH 19/22] staging: crypto: skein: remove externs from .c files

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a/dri

[RFC PATCH 05/22] staging: crypto: skein: remove skein_port.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644 d

Re: [PATCH v2 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-11 Thread Ian Abbott
On 11/03/14 17:03, H Hartley Sweeten wrote: Create an enum for the boards supported by this driver and pass that enum in the pci_driver id_table as the driver_data. Introduce a boardinfo struct to hold the board specific data for the boards supported by this driver. Use the boardinfo when attach

[RFC PATCH 16/22] staging: crypto: skein: fix do/while brace formatting

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein/skein_blo

[RFC PATCH 20/22] staging: crypto: skein: remove braces from single-statement block

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b/drivers

[RFC PATCH 01/22] scripts: objdiff: detect object code changes between two commits

2014-03-11 Thread Jason Cooper
objdiff is useful when doing large code cleanups. For example, when removing checkpatch warnings and errors from new drivers in the staging tree. objdiff can be used in conjunction with a git rebase to confirm that each commit made no changes to the resulting object code. It has the same return

[RFC PATCH 14/22] staging: crypto: skein: remove trailing whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c |

Re: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-11 Thread Fred Akers
On Wednesday, March 12, 2014 01:06:27 AM Hartley Sweeten wrote: > On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote: > > This patch fixes a few function names that are very long and are > > not in the correct naming style > > > > Signed-off-by: Fred Akers > > Fred, > > I pulled Greg's stagin

[RFC PATCH 06/22] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include/ske

[RFC PATCH 07/22] staging: crypto: skein: remove unneeded typedefs

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein/sk

[RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-11 Thread Jason Cooper
Greg, all, Attached is a series I've sat on for the past month and a half. I'm hoping that by posting it in it's incomplete state, it will either a) motivate me to finish hooking into the crypto API, or b) motivate someone else to pitch in. ;-) >From patch 3, all commits build successfully. In

[RFC PATCH 08/22] staging: crypto: skein: remove all typedef {struct, enum}

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42 +

RE: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-11 Thread Hartley Sweeten
On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote: > This patch fixes a few function names that are very long and are > not in the correct naming style > > Signed-off-by: Fred Akers > --- > .../comedi/drivers/addi-data/hwdrv_apci035.c | 58 +-- > .../comedi/drivers/addi-data/hwd

RE: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-11 Thread Hartley Sweeten
On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote: > This patch fixes a few function names that are very long and are > not in the correct naming style > > Signed-off-by: Fred Akers Fred, I pulled Greg's staging tree to see if your patches apply. Patch 1/2 is ok but patch 2/2 does not apply:

[RFC PATCH 17/22] staging: crypto: skein: fix brace placement errors

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff --

[RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-11 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- drivers/staging/Kconfig