Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-28 Thread Oliver Neukum
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote: On 03/26/2014 10:36 PM, Oliver Neukum wrote: On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com + if (ret) + goto out_init_fail; + + /* initialize USB SG transfer timer */

[patch] Staging: rtl8192e: array overflow in set_swcam()

2014-03-28 Thread Dan Carpenter
EntryNo comes from the user in rtl8192_ioctl(). We should limit it to 31 to prevent memory corruption. Also we may as well return on invalid data in setKey() as well. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Static analysis. I'm not certain this fix is enough to solve the

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-28 Thread Roger
On 03/28/2014 04:31 PM, Oliver Neukum wrote: On Fri, 2014-03-28 at 11:33 +0800, Roger wrote: On 03/26/2014 10:36 PM, Oliver Neukum wrote: On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com + if (ret) + goto

[PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Neil Armstrong
checkpatch script returns the following warning: WARNING: line over 80 characters 310: FILE: drivers/staging/netlogic/xlr_net.c:310: + void *accel_priv, select_queue_fallback_t fallback) This patch fixes the coding style issue. Signed-off-by: Neil Armstrong superna9...@gmail.com

Re: [PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 10:43:43AM +0100, Neil Armstrong wrote: checkpatch script returns the following warning: WARNING: line over 80 characters 310: FILE: drivers/staging/netlogic/xlr_net.c:310: + void *accel_priv, select_queue_fallback_t fallback) This patch fixes the

Re: [PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Dan Carpenter
The subject should be: [PATCH] Staging: netlogic: long lines in xlr_net.c You were missing the subsystem prefix: Staging: netlogic:. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

2014-03-28 Thread Dan Carpenter
On Fri, Mar 14, 2014 at 12:39:11AM +0900, Jérôme Pinot wrote: On 03/13/14 02:28, Greg Kroah-Hartman wrote: On Thu, Mar 13, 2014 at 10:21:44AM +0900, Jérôme Pinot wrote: [...] diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 5de5981..10c0a96 100644

Re: [PATCH 03/03] staging: dgap: remove more unneeded brd-state states

2014-03-28 Thread Dan Carpenter
These patches are fine and they were applied already. On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote: @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd, uchar __user *ubios, int len) /* * Checks to see if the BIOS completed running on the card.

Re: [PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-28 Thread Dan Carpenter
On Thu, Mar 13, 2014 at 12:30:48AM -0400, Gary Rookard wrote: I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL should be immediately below its function warning fix. Checkpatch.pl is wrong here and your patch breaks the build if LPROCFS is defined. (Probably it breaks the

Re: [PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

2014-03-28 Thread Dan Carpenter
On Thu, Mar 13, 2014 at 03:39:18PM -0500, Ken Cox wrote: Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. The missing calls to readl() are bug fixes, not cleanups. (Cleanups mean it doesn't change how the code works).

Re: [PATCH 4/6] Staging: unisys: visorchannel: Clean up sparse warnings in visorchannel code

2014-03-28 Thread Dan Carpenter
On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote: Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), and visorchannel_safesignalinsert() since they were not called from anywhere.

Re: [PATCH 03/03] staging: dgap: remove more unneeded brd-state states

2014-03-28 Thread Mark Hounschell
On 03/28/2014 07:34 AM, Dan Carpenter wrote: These patches are fine and they were applied already. On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote: @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd, uchar __user *ubios, int len) /* * Checks to

Re: [PATCH 03/03] staging: dgap: remove more unneeded brd-state states

2014-03-28 Thread Mark Hounschell
On 03/28/2014 09:08 AM, Mark Hounschell wrote: On 03/28/2014 07:34 AM, Dan Carpenter wrote: These patches are fine and they were applied already. On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote: @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd, uchar

Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

2014-03-28 Thread Joe Perches
(adding Andrew Morton, David Miller and LKML to cc's) On Fri, 2014-03-28 at 14:18 +0300, Dan Carpenter wrote: On Fri, Mar 14, 2014 at 12:39:11AM +0900, Jérôme Pinot wrote: On 03/13/14 02:28, Greg Kroah-Hartman wrote: On Thu, Mar 13, 2014 at 10:21:44AM +0900, Jérôme Pinot wrote: [...]

Re: [PATCH 4/6] Staging: unisys: visorchannel: Clean up sparse warnings in visorchannel code

2014-03-28 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 09:05:38AM -0500, Ken Cox wrote: On 03/28/2014 07:53 AM, Dan Carpenter wrote: On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote: Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(),

adoze

2014-03-28 Thread Ebesugawa Whiteley
cal matter, and is neare ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data

2014-03-28 Thread H Hartley Sweeten
In usbdux_ao_cmd(), the channels for the command are transfered from the cmd-chanlist and stored in the private data 'ao_chanlist'. The channel numbers are bit-shifted when stored so that they become the command that is transfered to the device. The channel to command conversion results in the

Re: [PATCH] Staging: netlogic: long lines in xlr_net.c

2014-03-28 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 02:43:01PM +0100, Neil Armstrong wrote: checkpatch script returns the following warning: WARNING: line over 80 characters 310: FILE: drivers/staging/netlogic/xlr_net.c:310: + void *accel_priv, select_queue_fallback_t fallback) This patch fixes the

Re: [PATCH 03/03] staging: dgap: remove more unneeded brd-state states

2014-03-28 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 09:08:34AM -0400, Mark Hounschell wrote: On 03/28/2014 07:34 AM, Dan Carpenter wrote: These patches are fine and they were applied already. On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote: @@ -4368,15 +4364,16 @@ static void

Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote: On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote: Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Making code checkpatch clean shouldn't be the primary goal here. Perhaps not, but it was *my* goal :) Removing uses of

[PATCH v2 1/1] staging/bcm: fix hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
From: Jake Edge j...@edge2.net Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Against next-20140328 tree Signed-off-by: Jake Edge j...@edge2.net --- There were two 80 lines that I couldn't find a sensible way to split up, otherwise it is checkpatch clean v2: fixes suggested by Joe

I need your help,

2014-03-28 Thread H . Khan
Good Day, Going through dossiers of personalities and properties in your Country, I discretely selected you for this proposition I am about to make you in,I am Khan Habib a personal consultant to Colonel Mauma Gaddafi of Libya. As you may be aware of the civil revolution that has just engulfed

[PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

2014-03-28 Thread K. Y. Srinivasan
commit 3c86726cfe38952f0366f86acfbbb025813ec1c2 Author: Benjamin Tissoires benjamin.tissoi...@redhat.com Date: Thu Feb 20 15:24:49 2014 -0500 HID: make .raw_request mandatory SET_REPORT and GET_REPORT are mandatory in the HID specification. Make the corresponding API in hid-core