Re: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread Jan Beulich
On 12.04.14 at 07:56, k...@microsoft.com wrote: --- a/arch/x86/kernel/i8259.c +++ b/arch/x86/kernel/i8259.c @@ -299,11 +299,30 @@ static void unmask_8259A(void) static void init_8259A(int auto_eoi) { unsigned long flags; + unsigned char probe_val = ~(1 PIC_CASCADE_IR); +

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Lucas Stach
Am Sonntag, den 13.04.2014, 15:58 +0100 schrieb Russell King - ARM Linux: On Fri, Apr 11, 2014 at 04:13:33PM +0200, Lucas Stach wrote: Make sure that we probe for a display on detect regardless of previous hotplug events. Don't handle connector hotplug state ourselves, but let DRM do the

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 10:42:32AM +0200, Lucas Stach wrote: Am Sonntag, den 13.04.2014, 15:58 +0100 schrieb Russell King - ARM Linux: On Fri, Apr 11, 2014 at 04:13:33PM +0200, Lucas Stach wrote: Make sure that we probe for a display on detect regardless of previous hotplug events. Don't

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Lucas Stach
Am Montag, den 14.04.2014, 10:10 +0100 schrieb Russell King - ARM Linux: On Mon, Apr 14, 2014 at 10:42:32AM +0200, Lucas Stach wrote: Am Sonntag, den 13.04.2014, 15:58 +0100 schrieb Russell King - ARM Linux: On Fri, Apr 11, 2014 at 04:13:33PM +0200, Lucas Stach wrote: Make sure that we

Re: [PATCH] staging: iio: fix coding style

2014-04-14 Thread Dan O'Donovan
On Sat, 2014-04-12 at 18:28 +0100, Jonathan Cameron wrote: On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet j...@porquet.org --- Only tested by compilation.

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 11:38:43AM +0200, Lucas Stach wrote: Am Montag, den 14.04.2014, 10:10 +0100 schrieb Russell King - ARM Linux: On Mon, Apr 14, 2014 at 10:42:32AM +0200, Lucas Stach wrote: Am Sonntag, den 13.04.2014, 15:58 +0100 schrieb Russell King - ARM Linux: On Fri, Apr 11,

Re: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread Olaf Hering
On Fri, Apr 11, K. Y. Srinivasan wrote: Probe for the existance of legacy PIC, if one does not exist, use the null_legacy_pic. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Tested-by: Olaf Hering o...@aepfle.de Fixes the crash on Gen1 VMs for me, which was introduced by

Re: [PATCH] staging: iio: fix coding style

2014-04-14 Thread Joël Porquet
On Saturday, April 12, 2014 06:28:07 PM Jonathan Cameron wrote: On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet j...@porquet.org --- Only tested by compilation.

[PATCH 7/7] imx-drm: ipuv3-crtc: Change display enable/disable order

2014-04-14 Thread Philipp Zabel
Now that ipu_dc_disable_channel correctly waits for the channel to finish, we can reorder the enable/disable order to first stop the DC and DI and only then disable the IDMAC. Enabling is done the other way around: IDMAC first, then DC, then DI. This avoids an issue where sometimes the channel

[PATCH 5/7] imx-drm: ipu-dp: Split disabling the DP foreground channel from disabling the DP module

2014-04-14 Thread Philipp Zabel
The former has to be done before disabling the DMFC, the latter has to be done afterwards. Otherwise the DMFC FIFOs never get cleared properly. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu-dp.c

[PATCH 1/7] imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts

2014-04-14 Thread Philipp Zabel
This allows to request the DC related interrupts. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 19 +-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH 0/7] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Philipp Zabel
Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. This series reorders the enable/disable sequence so that we first wait for the DC/DP to

[PATCH 6/7] imx-drm: imx-dp: When disabling the DP foreground channel, wait until the DP background channel is finished before disabling the IDMAC channel

2014-04-14 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c index 6980fa1..d90f82a 100644 ---

[PATCH 2/7] imx-drm: ipu-common: Add helpers to check for a busy IDMAC channel and to busywait for an interrupt

2014-04-14 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 22 ++ drivers/staging/imx-drm/ipu-v3/ipu-prv.h| 3 +++ 2 files changed, 25 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c

[PATCH 3/7] imx-drm: ipu-dmfc: Wait for FIFOs to run empty before disabling

2014-04-14 Thread Philipp Zabel
Disabling the DMFC module while there is still data in the FIFOs could cause the new frame before end of frame error state when the DMFC is enabled again. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 25 +++-- 1 file

RE: [PATCH V2 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread KY Srinivasan
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Monday, April 14, 2014 1:15 AM To: KY Srinivasan Cc: o...@aepfle.de; a...@canonical.com; x...@kernel.org; t...@linutronix.de; de...@linuxdriverproject.org; gre...@linuxfoundation.org; jasow...@redhat.com; linux-

Re: [PATCH] staging: iio: fix coding style

2014-04-14 Thread Jonathan Cameron
On April 14, 2014 2:59:32 PM GMT+01:00, Joël Porquet j...@porquet.org wrote: On Saturday, April 12, 2014 06:28:07 PM Jonathan Cameron wrote: On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message.

Fwd: [PATCH] [PATCH/RESENT] staging] speakup: fix typo in kobjects.c

2014-04-14 Thread Masanari Iida
Hi Maintainers, This patch did not pick up during 3.15-rc1 merge period. Please don't forget to pick up in 3.16. Regards, Masanari -- Forwarded message -- From: suzuki hyt...@gmail.com Date: Fri, Feb 28, 2014 at 1:10 AM Subject: [PATCH] [PATCH/RESENT] staging] speakup: fix typo

[PATCH] staging/lustre: fix sparse warning

2014-04-14 Thread Denis Pithon
Fix sparse complaint: Using plain integer as NULL pointer Signed-off-by: Denis Pithon denis.pit...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c

Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c

2014-04-14 Thread Pascal COMBES
Le 13/04/2014 23:36, Paul Bolle a écrit : On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote: From: Pascal COMBES pas...@orange.fr Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c: No space needed before a cast. Signed-off-by: Pascal COMBES pas...@orange.fr ---

[PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread K. Y. Srinivasan
This patch implements the proposal put forth by H. Peter Anvin h...@linux.intel.com. In version V1 of the patch, I had cleaned up the code based on comments from Peter. In version V2 of the patch, I have addressed additional comments from Peter. In this version of the patch, I have addressed

[PATCH 2/2] staging: unisys: Fix typo in comment and printk

2014-04-14 Thread Masanari Iida
Fix spelling typo in comments and printk within unisys. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/unisys/common-spar/include/channels/channel.h | 2 +- drivers/staging/unisys/common-spar/include/channels/diagchannel.h | 2 +-

[PATCH 1/2] staging: unisys: Fix format string mismatch in virthba.c

2014-04-14 Thread Masanari Iida
Fix format string mismatch in info_proc_read() within virthba.c. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/unisys/virthba/virthba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread H. Peter Anvin
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: This patch implements the proposal put forth by H. Peter Anvin h...@linux.intel.com. In version V1 of the patch, I had cleaned up the code based on comments from Peter. In version V2 of the patch, I have addressed additional comments from

RE: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread KY Srinivasan
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Monday, April 14, 2014 10:02 AM To: KY Srinivasan; x...@kernel.org; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread H. Peter Anvin
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote: + new_val = inb(PIC_MASTER_IMR); + if (probe_val != new_val) { Nitpick: Linux coding style should have this as: if (new_val != probe_val) -hpa ___ devel mailing list

RE: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread KY Srinivasan
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Monday, April 14, 2014 10:08 AM To: KY Srinivasan; x...@kernel.org; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;

[PATCH V4 1/1] X86: Probe for PIC and set legacy_pic appropriately

2014-04-14 Thread K. Y. Srinivasan
The legacy PIC may or may not be available and we need a mechanism to detect the existence of the legacy PIC that is applicable for all hardware (both physical as well as virtual) currently supported by Linux. On Hyper-V, our legacy firmware presented to the guests, emulates the legacy PIC while

Re: [PATCH 02/06] staging: dgap: Only read config file dgap.conf once

2014-04-14 Thread Greg Kroah-Hartman
On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote: The config file is currently read for each board found. It only needs to be read one time. The buffer it is read into can now be freed immediately after it is parsed instead of at driver unload time. Signed-off-by: Mark

Re: Fwd: [PATCH] [PATCH/RESENT] staging] speakup: fix typo in kobjects.c

2014-04-14 Thread Greg KH
On Tue, Apr 15, 2014 at 01:17:42AM +0900, Masanari Iida wrote: Hi Maintainers, This patch did not pick up during 3.15-rc1 merge period. That is because you didn't send it to the correct people :( Always use the scripts/get_maintainer.pl tool, it will tell you the correct addresses to use.

Re: [PATCH] staging: dgap: change all uchar to u8

2014-04-14 Thread Mark Hounschell
On 04/14/2014 12:00 PM, Greg Kroah-Hartman wrote: On Thu, Apr 03, 2014 at 08:57:56AM -0400, Mark Hounschell wrote: This patch removes the uchar define in dgap.h and changes all uses of uchar to u8. Signed-off-by: Mark Hounschell ma...@compro.net Tested-by: Mark Hounschell ma...@compro.net

Re: Fwd: [PATCH] [PATCH/RESENT] staging] speakup: fix typo in kobjects.c

2014-04-14 Thread Greg KH
On Tue, Apr 15, 2014 at 01:17:42AM +0900, Masanari Iida wrote: Hi Maintainers, This patch did not pick up during 3.15-rc1 merge period. Please don't forget to pick up in 3.16. Regards, Masanari -- Forwarded message -- From: suzuki hyt...@gmail.com Date: Fri, Feb 28,

Re: [PATCH 02/06] staging: dgap: Only read config file dgap.conf once

2014-04-14 Thread Mark Hounschell
On 04/14/2014 11:49 AM, Greg Kroah-Hartman wrote: On Tue, Mar 25, 2014 at 04:38:14PM -0400, Mark Hounschell wrote: The config file is currently read for each board found. It only needs to be read one time. The buffer it is read into can now be freed immediately after it is parsed instead of

Re: [PATCH 0/7] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 05:21:28PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. Well done at finding

[PATCH] staging: dgap: remove uchar typedef and replace use with u8

2014-04-14 Thread Mark Hounschell
This patch removes the uchar typedef in dgap.h and changes all uses of it to u8. Signed-off-by: Mark Hounschell ma...@compro.net Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/dgap/dgap.c | 100 ++-- drivers/staging/dgap/dgap.h | 65

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 12:24:45PM +0200, Lucas Stach wrote: Am Montag, den 14.04.2014, 11:09 +0100 schrieb Russell King - ARM Linux: Now *you* please go back and read what you said about kms/userspace being able to poll the connector, thereby causing an EDID read attempt while HPD may not

Re: [PATCH 0/7] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 05:21:28PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. I'm afraid to say that

Re: [PATCH 4/7] imx-drm: ipu-dc: Wait for DC_FC_1 / DP_SF_END interrupt

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 05:21:32PM +0200, Philipp Zabel wrote: Wait for the DC Frame Complete or DP Sync Flow End interrupts before disabling DC channels. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 71

[PATCH v2 3/8] imx-drm: ipu-dmfc: Wait for FIFOs to run empty before disabling

2014-04-14 Thread Philipp Zabel
Disabling the DMFC module while there is still data in the FIFOs could cause the new frame before end of frame error state when the DMFC is enabled again. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 25 +++-- 1 file

[PATCH v2 6/8] imx-drm: imx-dp: When disabling the DP foreground channel, wait until the DP background channel is finished before disabling the IDMAC channel

2014-04-14 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c index 6980fa1..d90f82a 100644 ---

[PATCH v2 4/8] imx-drm: ipu-dc: Wait for DC_FC_1 / DP_SF_END interrupt

2014-04-14 Thread Philipp Zabel
Wait for the DC Frame Complete or DP Sync Flow End interrupts before disabling DC channels. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Moved disable_irq() out of dc_irq_handler() --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 71 +++--

[PATCH v2 5/8] imx-drm: ipu-dp: Split disabling the DP foreground channel from disabling the DP module

2014-04-14 Thread Philipp Zabel
The former has to be done before disabling the DMFC, the latter has to be done afterwards. Otherwise the DMFC FIFOs never get cleared properly. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu-dp.c

[PATCH v2 1/8] imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts

2014-04-14 Thread Philipp Zabel
This allows to request the DC related interrupts. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 19 +-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 0/8] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 11:53:15PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. Yes, this appears to

Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c

2014-04-14 Thread Jingoo Han
On Tuesday, April 15, 2014 1:38 AM, Pascal COMBES wrote: Le 13/04/2014 23:36, Paul Bolle a écrit : On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote: From: Pascal COMBES pas...@orange.fr Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c: No space needed before

[no subject]

2014-04-14 Thread Leopold Victoria (Queen)
I am Leopold Victoria, i need your aid on something vital and important. Best Regards Leopold Victoria (Queen). Queen Elizabeth House 3 Mansfield Road Oxford OX1 3TB ___ devel mailing list de...@linuxdriverproject.org

[PATCH 1/2] staging: comedi: addi_apci_1564: remove use of devpriv-iobase

2014-04-14 Thread Chase Southwood
devpriv-iobase is currently being used to hold the iobase address used to read/write the board's registers. The same address is stored in the comedi_device dev-iobase. We use that instead. The eventual goal is to decrease the driver's use of the struct addi_private, so that it may eventually

[PATCH 2/2] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-14 Thread Chase Southwood
We can remove this function from the boardinfo and move the code from hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function used by the driver. The function was also messy and failed to reset a few registers, these issues were fixed on the move. Signed-off-by: Chase