On Sat, May 03, 2014 at 11:08:36PM -0400, Oleg Drokin wrote:
> Hello!
>
> On May 3, 2014, at 10:33 PM, Greg Kroah-Hartman wrote:
> >> I don't think I saw complaints about proc files, the complaints I saw were
> >> mostly about
> >> reading env variables directly and the like so that was the focus
return -EFAULT instead of the value returned by copy_from_user()
Signed-off-by: Vitaly Osipov
---
Revised against today's staging-next branch.
.../lustre/lustre/libcfs/linux/linux-module.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lus
Hello!
On May 3, 2014, at 10:33 PM, Greg Kroah-Hartman wrote:
>> I don't think I saw complaints about proc files, the complaints I saw were
>> mostly about
>> reading env variables directly and the like so that was the focus of this
>> patch.
>> Did I miss some side discussion? Any pointers?
> N
On Sat, May 03, 2014 at 09:20:06PM -0400, Oleg Drokin wrote:
>
> On May 3, 2014, at 7:29 PM, Greg Kroah-Hartman wrote:
>
> > On Sun, Apr 27, 2014 at 10:21:52PM -0400, Oleg Drokin wrote:
> >> Insted of meddling directly in process environment variables
> >> (which is also not possible on certain p
On Sat, May 03, 2014 at 09:28:03PM -0400, Oleg Drokin wrote:
> percpu_pagelist_fraction_sysctl_handler calls proc_dointvec_minmax
> and blindly assumes that return value of 0 means success.
> In fact the other valid case is when it got a zero length input.
>
> After that it proceeds to a division
percpu_pagelist_fraction_sysctl_handler calls proc_dointvec_minmax
and blindly assumes that return value of 0 means success.
In fact the other valid case is when it got a zero length input.
After that it proceeds to a division by percpu_pagelist_fraction
value which is conveniently set to a defaul
On May 3, 2014, at 7:29 PM, Greg Kroah-Hartman wrote:
> On Sun, Apr 27, 2014 at 10:21:52PM -0400, Oleg Drokin wrote:
>> Insted of meddling directly in process environment variables
>> (which is also not possible on certain platforms due to not exported
>> symbols), create jobid_name proc file to
On Thu, May 01, 2014 at 11:54:02PM +0200, Christian Engelmayer wrote:
> Fix potential leaks in the error paths of r8712_set_key(). In case the
> algorithm specific checks fail, the function returns without enqueuing
> or freeing the already allocated command and parameter structs. Use a
> centraliz
On Sat, May 03, 2014 at 05:10:48PM +0200, Martin Kepplinger wrote:
> pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
> fixes sparse warnings.
>
> Signed-off-by: Martin Kepplinger
> ---
> drivers/staging/rtl8821ae/pci.c |4 ++--
> 1 file changed, 2 insertions(+), 2 delet
On Thu, May 01, 2014 at 12:30:57PM +0200, Christian Engelmayer wrote:
> Fix a potential leak in the error path of rtw_set_key(). In case the requested
> algorithm is not supported by the driver, the function returns without
> enqueuing or freeing the already allocated command and parameter structs.
On Sat, Apr 26, 2014 at 10:10:29PM +0200, Christian Engelmayer wrote:
> Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it.
>
> Signed-off-by: Christian Engelmayer
> ---
> Compile tested and applies against v3.15-rc2 as well as branch staging-next
> of tree git.kernel.org
On Fri, May 02, 2014 at 08:53:54PM +0100, Ian Abbott wrote:
> On 02/05/14 18:40, Hartley Sweeten wrote:
> > On Friday, May 02, 2014 5:50 AM, Ian Abbott wrote:
> >> For comedi subdevices that support asynchronous commands, the `async`
> >> member of `struct comedi_subdevice` points to a `struct come
On Tue, Apr 29, 2014 at 08:07:55PM +, Hartley Sweeten wrote:
> On Tuesday, April 29, 2014 12:59 PM, H Hartley Sweeten wrote:
> > Remove some unnecessary pacer divisor calculations. The divisors are
> > calculated
> > as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
> >
> > Re
On Mon, Apr 28, 2014 at 12:40:05PM +0300, Dan Carpenter wrote:
> Nice, Chase, you've become an expert on comedi, it seems.
>
> I can't say how happy comedi patches make me these days. Ian, you and
> Hartley are doing a fantastic job.
Same here, it's great to see all of this cleanup happening. M
On Tue, Apr 29, 2014 at 08:32:21PM +0300, Dan Carpenter wrote:
> On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
> > This patch fixes "Missing a blank line after declarations" warnings.
> >
> > Signed-off-by: Seunghun Lee
>
> Quite a few of these are false checkpatch.pl false posit
On Sun, Apr 27, 2014 at 01:02:03AM +1000, Vitaly Osipov wrote:
> return -EFAULT instead of the value returned by copy_from_user()
>
> Signed-off-by: Vitaly Osipov
> ---
> .../lustre/lustre/libcfs/linux/linux-module.c | 11 ---
This patch doesn't apply at all, can you refresh it ag
On Sun, Apr 27, 2014 at 10:21:52PM -0400, Oleg Drokin wrote:
> Insted of meddling directly in process environment variables
> (which is also not possible on certain platforms due to not exported
> symbols), create jobid_name proc file to represent this info
> (to be filled by job scheduler epilogue
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards.
The -2a version has 32 on-board DIO channels. In case this variant is
detected, local variable 'has_dio' is set accordingly. Otherwise it is
left uninitialized and the following subdevice instantiation depends on
the stack. De
Fix the error path when a cookie mismatch is detected. In that case the
function jumps to the exit label without setting the uninitialized, local
variable 'return_error'. Detected by Coverity - CID 201453.
Signed-off-by: Christian Engelmayer
---
Compile tested and applies against branch staging-n
CE MESSAGE PROVIENT DE NOTRE ÃQUIPE DE SUPPORT TECHNIQUE :
Ce message est envoyé automatiquement par notre équipe de courrier web. Si vous
recevez ce message, que cela signifie que votre adresse e-mail est sur le point
d'être mis hors tension ; C'était en raison d'un code de script erreur co
CE MESSAGE PROVIENT DE NOTRE ÃQUIPE DE SUPPORT TECHNIQUE :
Ce message est envoyé automatiquement par notre équipe de courrier web. Si vous
recevez ce message, que cela signifie que votre adresse e-mail est sur le point
d'être mis hors tension ; C'était en raison d'un code de script erreur co
Dan Carpenter writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains. The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter
Urgh yes, that should be cleaned up!
Acked-by: Jes Sorensen
>
> diff --git a/drivers/staging/rtl8723
On Sat, 3 May 2014 23:06:50 +0300, Dan Carpenter
wrote:
> Many of my other comments apply.
>
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 23d539d..1d4475d 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux
On 64 bit systems there is a 4 byte hole after the last member of the
struct. We should clear it to avoid disclosing stack information.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c
b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 85b8d81..d4cacb90 100644
The break and the "unknown++" are at the same indent level so my static
checker complains. The if statement should be indented more.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index eb7b98e..4ad80e7 10
Many of my other comments apply.
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 23d539d..1d4475d 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -170,7 +
On Sat, May 03, 2014 at 06:12:11PM +0200, Rickard Strandqvist wrote:
> Hi
>
> The static code analysis program called cppcheck.
> http://cppcheck.sourceforge.net/
>
> I found code that I think are bugs, or at least inappropriate or
> unnecessary code, in the files:
> drivers/staging/tidspbridge/p
This patch wasn't sent in the correct way. The subject should be:
[PATCH] staging: tidspbridge: silence some uninitialized variable warnings
On Sat, May 03, 2014 at 06:12:11PM +0200, Rickard Strandqvist wrote:
> Hi
>
> The static code analysis program called cppcheck.
> http://cppcheck.sourcefo
On Sat, May 03, 2014 at 06:33:11PM +0200, Rickard Strandqvist wrote:
> Hi
>
> The static code analysis program called cppcheck.
> http://cppcheck.sourceforge.net/
>
> I found code that I think are bugs, or at least inappropriate or
> unnecessary code, in the files:
> drivers/staging/rtl8712/rtl87
Hi
The static code analysis program called cppcheck.
http://cppcheck.sourceforge.net/
I found code that I think are bugs, or at least inappropriate or
unnecessary code, in the files:
drivers/staging/tidspbridge/pmgr/dspapi.c
drivers/staging/tidspbridge/rmgr/node.c
I have created a patch, and in
Hi
The static code analysis program called cppcheck.
http://cppcheck.sourceforge.net/
I found code that I think are bugs, or at least inappropriate or
unnecessary code, in the files:
drivers/staging/rtl8712/rtl871x_ioctl_linux.c
drivers/staging/rtl8712/rtl871x_mlme.c
drivers/staging/rtl8712/usb_i
pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
fixes sparse warnings.
Signed-off-by: Martin Kepplinger
---
drivers/staging/rtl8821ae/pci.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae
rtl8188eu_init_recvbuf() function definition is empty now,
so remove it.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c|4
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |2 --
drivers/staging/rtl8188eu/include/rtl8188e_recv.h |1 -
3 file
Instead of using pbuf to pass sbk data pointer to usb_fill_bulk_urb(),
we can use precvbuf->pskb->data to do that.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |5 +
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
drivers/staging/rtl8188eu/os_dep
Driver isn't making any use of value stored in variable ref_cnt.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 --
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 -
3 files changed, 4 deletio
Remove unused variable 'u32 len'.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/stag
irp_pending is initialized to false inside rtw_os_recvbuf_resource_alloc()
and value of irq_pending never changed after that, so 'if
(!precvbuf->irp_pending)'
inside rtw_os_read_port() function will be always true.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/rtw_recv.h |
Driver isn't making any use of value stored in alloc_sz variable.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188
pallocated_buf is not being used by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/stagi
Driver is not making use of value stored in removed variables.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |8
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |9 -
drivers/staging/rtl8188eu/include/rtw_recv.h |4
drivers/sta
Driver is not making any use of value stored in this variable.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 --
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |1 -
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
drivers/staging/rtl8188eu/os
Remove unused variable dma_transfer_addr.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index 4a19a06..bf9af77 100644
recvbuf_lock is initialized inside rtl8188eu_init_recv_priv() but never used.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu
rtw_enqueue_recvbuf() is not being used by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 12
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b
Users of 'struct list_head list' variable e.g. rtw_enqueue_recvbuf(),
rtw_enqueue_recvbuf_to_head() and rtw_dequeue_recvbuf() are
already removed.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 -
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
2
rtw_enqueue_recvbuf_to_head() is not being used by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 12
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_r
rtw_dequeue_recvbuf() is not being used by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 25 -
drivers/staging/rtl8188eu/include/rtw_recv.h |1 -
2 files changed, 26 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/
Following patches remove unnecessary member variables of struct recv_buf.
navin patidar (15):
staging: rtl8188eu: Remove function rtw_dequeue_recvbuf()
staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head()
staging: rtl8188eu: Remove function rtw_enqueue_recvbuf()
staging: rtl81
This is the only reset fuction used by this driver. We can remove it from
the boardinfo and absorb the code from hwdrv_apci1564.c into the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 32 --
Remove the boardinfo about the interrupt function and just call it
directly.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/d
The addi-data common code always allocates 7 subdevices. This driver
cannot or will not use the ones we are currently allocating for analog
input and output or EEPROM, so just don't allocate these subdevices at
all.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drive
This board always has 32 digital outputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver, remove
the boardinfo about the digital outputs and just use the data directly in
the subdevice init.
Signed-off-by: Chase Southwood
Cc: Ian
Latest patchset in a continuing cleanup of addi_apci_1564.c. Main focus
is on the auto_attach() function, but also cleaning up some of the old addi
common code wrappers.
To be applied on top of my prior patchset to this file (the one beginning
with [PATCH 1/6] staging: comedi: addi_apci_1564: rem
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
2: Incorrect patch title fix
54 matches
Mail list logo
