[PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Adithya K
This is patch for fixing of minor coding style problems. Signed-off-by: Adithya K linux.challen...@gmail.com --- drivers/staging/gdm72xx/gdm_qos.c |3 ++- drivers/staging/gdm72xx/gdm_sdio.c |1 + drivers/staging/gdm72xx/gdm_usb.c |2 +- drivers/staging/gdm72xx/gdm_wimax.c |3

Re: [PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 11:53:57AM +0530, Adithya K wrote: This is patch for fixing of minor coding style problems. Signed-off-by: Adithya K linux.challen...@gmail.com --- drivers/staging/gdm72xx/gdm_qos.c |3 ++- drivers/staging/gdm72xx/gdm_sdio.c |1 +

Re: [PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Dan Carpenter
On Wed, May 07, 2014 at 11:40:50PM -0700, Joe Perches wrote: On Thu, 2014-05-08 at 11:53 +0530, Adithya K wrote: This is patch for fixing of minor coding style problems. [] diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c [] @@ -229,6 +229,7 @@ static

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Roger
On 04/30/2014 04:19 PM, Ulf Hansson wrote: On 30 April 2014 05:34, Roger rogera...@realtek.com wrote: On 04/29/2014 08:46 PM, Arnd Bergmann wrote: On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote: On 29 April 2014 11:45, Arnd Bergmann a...@arndb.de wrote: drivers/built-in.o: In

Re: [PATCH 1/2] mmc: rtsx: Revert mmc: rtsx: modify error handleandremove smatch warnings

2014-05-08 Thread Lee Jones
It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. H... that's pretty bad timing. I've literally just sent the pull-request containing the MFD/MMC fixup branch to Linus. I guess Ulf will have to do it. From: Micky Chingmicky_ch...@realsil.com.cn

Re: [PATCH 1/2] mmc: rtsx: Revert mmc: rtsx: modify error handleandremove smatch warnings

2014-05-08 Thread Ulf Hansson
On 8 May 2014 09:55, Lee Jones lee.jo...@linaro.org wrote: It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. H... that's pretty bad timing. I've literally just sent the pull-request containing the MFD/MMC fixup branch to Linus. I guess Ulf

Re: [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx: add support for pre_req and post_req

2014-05-08 Thread Lee Jones
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. commit mmc: rtsx: add support for pre_req and post_req did use mutex_unlock() in tasklet, but mutex_unlock() can't used in tasklet(atomic context). The driver need use mutex to avoid concurrency, so we can't use tasklet

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Arnd Bergmann
On Thursday 08 May 2014 16:08:15 Roger wrote: Would this patch be merged into linux-next or Lee's mfd.git ib-mfd-mmc-memstick-3.16 branch? It should get merged into whatever tree holds the existing patches, yes By the way, should I resend my version? Actually I found another issue with it

[PATCH v2] mmc: rtsx: fix possible linking error if built-in

2014-05-08 Thread Arnd Bergmann
rtsx_usb_sdmmc module uses the LED classdev if available, but the code failed to consider the situation that it is built-in and the LED classdev is a module, leading to following linking error: LD init/built-in.o drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Lee Jones
From: Roger Tseng rogera...@realtek.com Date: Wed, 30 Apr 2014 11:11:25 +0800 Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in rtsx_usb_sdmmc module uses the LED classdev if available, but the code failed to consider the situation that it is built-in and the LED classdev

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Ulf Hansson
From: Roger Tseng rogera...@realtek.com Date: Wed, 30 Apr 2014 11:11:25 +0800 Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in rtsx_usb_sdmmc module uses the LED classdev if available, but the code failed to consider the situation that it is built-in and the LED classdev

Re: [PATCH v2] mmc: rtsx: fix possible linking error if built-in

2014-05-08 Thread Ulf Hansson
On 8 May 2014 10:27, Arnd Bergmann a...@arndb.de wrote: rtsx_usb_sdmmc module uses the LED classdev if available, but the code failed to consider the situation that it is built-in and the LED classdev is a module, leading to following linking error: LD init/built-in.o

[patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Dan Carpenter
These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Fixed changelog diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 4e30eba..9004a5fd 100644 ---

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Julian Andres Klode
On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote: +as raw text including all the headers. Run `cat raw_email.txt | git am` `cat raw_email.txt | git am` seems a bit pointless. Why not simply `git am raw_email.txt`? `git am raw_email.txt` does the same too and avoids the useless cat

Re: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Greg KH
On Wed, May 07, 2014 at 03:45:04PM -0700, Haiyang Zhang wrote: This change ensures the driver can be built successfully without the CONFIG_SYSFS flag. MS-TFS: 182270 Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com ---

Re: [PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Joe Perches
On Thu, 2014-05-08 at 11:53 +0530, Adithya K wrote: This is patch for fixing of minor coding style problems. [] diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c [] @@ -229,6 +229,7 @@ static u32 extract_qos_list(struct nic *nic, struct list_head *head)

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Hillf Danton
On Thu, May 8, 2014 at 5:05 PM, Julian Andres Klode j...@jak-linux.org wrote: On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote: +as raw text including all the headers. Run `cat raw_email.txt | git am` `cat raw_email.txt | git am` seems a bit pointless. Why not simply `git am

Re: [PATCH] staging: lirc: Fix sparse warnings

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 01:11:48PM +0300, Tuomas Tynkkynen wrote: Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. Signed-off-by: Tuomas Tynkkynen tuomas.tynkky...@iki.fi This patch adds spaces between the cast and the

Re: [PATCH] staging: lirc: Fix sparse warnings

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 01:30:28PM +0300, Dan Carpenter wrote: On Thu, May 08, 2014 at 01:11:48PM +0300, Tuomas Tynkkynen wrote: Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. Signed-off-by: Tuomas Tynkkynen

[PATCH v2] staging: lirc: Fix sparse warnings

2014-05-08 Thread Tuomas Tynkkynen
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by: Tuomas Tynkkynen tuomas.tynkky...@iki.fi --- Compile tested only. v2 changes: - introduce variable 'uptr' instead

Re: [PATCH v2] staging: lirc: Fix sparse warnings

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 02:13:17PM +0300, Tuomas Tynkkynen wrote: Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by: Tuomas Tynkkynen tuomas.tynkky...@iki.fi Thanks.

[PATCH] staging: winbond: use dev_err() instead of printk()

2014-05-08 Thread Martin Kepplinger
For obvious error messages, use dev_err() in order to provide userspace with more useful information and use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de --- this applies to v3.15-rc4 greetings from Linuxdays Vienna, Austria

Re: [PATCH] staging: winbond: use dev_err() instead of printk()

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 01:38:33PM +0200, Martin Kepplinger wrote: For obvious error messages, use dev_err() in order to provide userspace with more useful information and use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de --- this applies to v3.15-rc4

RE: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Thursday, May 8, 2014 5:13 AM To: Haiyang Zhang Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- ker...@vger.kernel.org Subject: Re:

[PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
This change ensures the driver can be built successfully without the CONFIG_SYSFS flag. MS-TFS: 182270 Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com --- drivers/net/hyperv/hyperv_net.h | 28

RE: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Thursday, May 8, 2014 3:07 PM To: Haiyang Zhang Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- ker...@vger.kernel.org Subject: Re:

Re: [PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Greg KH
On Thu, May 08, 2014 at 01:41:33PM -0700, Haiyang Zhang wrote: This change ensures the driver can be built successfully without the CONFIG_SYSFS flag. MS-TFS: 182270 Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com ---

RE: [PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
-Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Thursday, May 8, 2014 4:04 PM To: Haiyang Zhang Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- ker...@vger.kernel.org Subject: Re:

RE: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Thursday, May 8, 2014 4:45 PM To: Haiyang Zhang Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- de...@linuxdriverproject.org Subject:

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Namhyung Kim
Hi Dan, On Thu, 8 May 2014 11:44:12 +0300, Dan Carpenter wrote: These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Fixed changelog diff --git a/Documentation/email-clients.txt

Re: [PATCH 1/2] mmc: rtsx: Revert mmc: rtsx: modify errorhandleandremovesmatch warnings

2014-05-08 Thread micky
Hi Ulf On 05/08/2014 04:22 PM, Ulf Hansson wrote: On 8 May 2014 09:55, Lee Jones lee.jo...@linaro.org wrote: It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. H... that's pretty bad timing. I've literally just sent the pull-request containing

[PATCH 2/3] Staging: cxt1e1: Fix line length over 80 characters in musycc.c

2014-05-08 Thread Daeseok Youn
clean up checkpatch.pl warning WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/musycc.c | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/cxt1e1/musycc.c