On 2014-05-13 at 16:43:57 +0200, Masanari Iida standby2...@gmail.com wrote:
This patch replaced printk with pr_info.
It would be even better to use dev_err(), since these are error messages
and you can use the struct dev from link-dev. You can also drop the
ft1000: prefix then.
Cheers
Tobias
Send the patch inline so it can be applied automatically with git am.
On Sat, May 10, 2014 at 04:56:51PM +0200, Pawel Lebioda wrote:
Hi,
Please find attached patch which fixes most of
Missing blank line after declaration in drivers/staging/usbip
directory.
There are still two WARNINGS
On Sat, May 10, 2014 at 09:16:29PM +0530, Raghavendra Ganiga wrote:
This is a patch to fix
the warnings shown
by checkpatch tool on file
cb_das16_cs.c file
Emails should be line wrapped at 72 characters. 30 is too small.
Subject prefix should be: [patch] Staging: comedi: ...
regards,
dan
On Sat, May 10, 2014 at 09:53:18PM +0530, Raghavendra Ganiga wrote:
This is a patch to remove warnings
reported by checkpatch tool on
comedi_test.c file
Same complaints as before.
regards,
dan carpenter
___
devel mailing list
This one is better. Just fix the subject and it will be ok.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote:
@@ -684,8 +685,9 @@ static int p80211knetdev_set_mac_address(netdevice_t
*dev, void *addr)
* change the netdev address
*/
if (result != 0 || resultcode-data != P80211ENUM_resultcode_success) {
-
fix the sparse warnings
drivers/staging/dgap/dgap.c:689:28: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/dgap/dgap.c:689:28:expected void volatile [noderef]
asn:2*addr
drivers/staging/dgap/dgap.c:689:28:got unsigned char [usertype] *re_map_port
You should be working against linux-next. Also Mark Hounschell has sent
a fix for this already but it hasn't been applied yet. The subject
should have Staging in it.
[PATCH] Staging: dgap: addd __iomem annotations.
Otherwise looks ok.
regards,
dan carpenter
The UART_IIR_XOFF was supposed to be a no-op but, because there was a
missing semi-colon, the if statement is not Empty. I have just deleted
this code because it was supposed to be a no-op anyway. UART_IIR_XOFF
is a standard define and not something specific to this driver.
Signed-off-by: Dan
Fix Missing a blank line after declaration style problems
for all files in drivers/staging/usbip.
Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com
---
drivers/staging/usbip/stub_dev.c | 1 +
drivers/staging/usbip/stub_tx.c | 1 +
On Wed, May 14, 2014 at 07:20:27PM +0200, Pawel Lebioda wrote:
Fix Missing a blank line after declaration style problems
for all files in drivers/staging/usbip.
Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com
Great. Thanks.
regards,
dan carpenter
On Sun, Apr 27, 2014 at 12:00:25AM +0100, Russell King - ARM Linux wrote:
A while back, Laurent raised some comments about the component helper,
which this patch set starts to address.
The first point it addresses is the repeated parsing inefficiency when
deferred probing occurs. When DT is
Fix bad function definitions in all files from drivers/staging/usbip directory
Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com
---
drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 +-
drivers/staging/usbip/userspace/libsrc/vhci_driver.c | 2 +-
On Wed, May 14, 2014 at 09:28:27PM +0200, Pawel Lebioda wrote:
Fix bad function definitions in all files from drivers/staging/usbip directory
Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com
This is fine, but next time try to be more specific in the subject and
also in the changelog.
On 05/13/2014 06:32 AM, Dan Carpenter wrote:
These days most people use git to send patches so I have added a section
about that.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: fix typo in commit message
v3: update git am and log commands. Mention the man pages.
diff
Move memory allocation and resource acquisition from the bind function into
the probe function. This calls the devres managed functions once instead of
possibly multiple times in the bind function and avoids leaking memory (as
long as the hdmi platform device stays bound).
While at it, request
Philipp,
On Wed, May 14, 2014 at 6:24 PM, Philipp Zabel philipp.za...@gmail.com wrote:
Move memory allocation and resource acquisition from the bind function into
the probe function. This calls the devres managed functions once instead of
possibly multiple times in the bind function and avoids
Remove unnecessary brackets from return statements in socklnd.c
to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git
On Wed, May 14, 2014 at 11:24:14PM +0200, Philipp Zabel wrote:
Move memory allocation and resource acquisition from the bind function into
the probe function. This calls the devres managed functions once instead of
possibly multiple times in the bind function and avoids leaking memory (as
long
Fixed indenting of if statement in socklnd.c to meet kernel coding style.
Signed-off-by: Masaru Nomura massa.nom...@gmail.com
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Remove support for building against ancient WIRELESS_EXT versions,
only leaving support for the current version: 22
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 -
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +--
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c |
21 matches
Mail list logo
