From: Julia Lawall
Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
p
Sometimes a local variable is used as a return value in a case where the
return value is always 0. The result is more apparent if this variable is
just replaced by 0. This is done by the following semantic patch, although
some cleanups may be needed. (http://coccinelle.lip6.fr/)
//
@r exists@
l
From: Julia Lawall
Delete unnecessary use of a local variable to immediately return 0.
A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@r exists@
local idexpression ret;
expression e;
position p;
@@
-ret = 0;
... when != ret =
Code have skein_512_ctx and skein_256_ctx but skein1024_ctx.
It would be logical to convert these names to a single form.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/include/skein.h | 14 +++---
drivers/staging/skein/include/skeinApi.h| 2 +-
drivers/staging/skein/in
camelCase is not accepted in the Linux Kernel. To prepare skein
driver for mainline inclusion, we rename all files to
non-camelCase equivalents.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/Makefile | 10 +-
drivers/staging/skein/TODO
Linux Kernel use capitalized names for enum. To prepare skein
driver to mainline inclusion, we rename all enums to capitalized
names.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/include/skein.h| 6 +++---
drivers/staging/skein/include/skeinApi.h | 8
drivers/stag
Hi! To prepare skein driver for mainline inclusion we fixing most of
style issues (wrong names of functions, vars, macros, files) and
checkpatch problems in this patch set. For example, existing code
is widely use camelCase names. This patch fix it.
Anton Saraev (6):
staging: crypto: skein: re
camelCase is not accepted in the Linux Kernel. To prepare skein
driver for mainline inclusion, we rename all functions to
non-camelCase equivalents.
Signed-off-by: Anton Saraev
---
drivers/staging/skein/TODO | 1 -
drivers/staging/skein/include/skein.h| 66 --
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
- If both of drivers are r
>From 3acdda98e73a153a5fb32c2cd401d2dde1653b0a Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 25 Apr 2014 16:04:59 +0900
Subject: [PATCH] staging: dgap: implement error handling in dgap_tty_register()
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers whi
On Mon, 2014-05-19 at 00:50 +0100, Ben Hutchings wrote:
> These patches fix a deadlock that can occur when using speakup to paste
> a selection. I tested them against 3.12.9, but there don't appear to be
> any later changes in this area.
[...]
Actually, these have also been tested on top of 3.14.
This function is largely a duplicate of paste_selection() in
drivers/tty/vt/selection.c, but with its own selection state. The
speakup selection mechanism should really be merged with vt.
For now, apply the changes from 'TTY: vt, fix paste_selection ldisc
handling', 'tty: Make ldisc input flow co
Input is handled in softirq context, but when pasting we may
need to sleep. speakup_paste_selection() currently tries to
bodge this by busy-waiting if in_atomic(), but that doesn't
help because the ldisc may also sleep.
For bonus breakage, speakup_paste_selection() changes the
state of current, e
These patches fix a deadlock that can occur when using speakup to paste
a selection. I tested them against 3.12.9, but there don't appear to be
any later changes in this area.
Ben.
Ben Hutchings (2):
Staging: speakup: Move pasting into a work item
Staging: speakup: Update __speakup_paste_sel
On Sun, May 18, 2014 at 05:04:50PM -0600, Jake Edge wrote:
> On Sun, 18 May 2014 18:52:31 -0400 Jason Cooper wrote:
>
> > Jake, would you mind dropping this patch and perhaps assisting me with
> > reviewing Anton's series? I'll have him resend it as-is and we can go
> > from there.
>
> No, that'
On Sun, 18 May 2014 18:52:31 -0400 Jason Cooper wrote:
> Jake, would you mind dropping this patch and perhaps assisting me with
> reviewing Anton's series? I'll have him resend it as-is and we can go
> from there.
No, that's fine. Guess I'll put my patches to clean up some other
stuff (function
Jake, Anton,
On Sun, May 18, 2014 at 12:56:15PM -0600, Jake Edge wrote:
>
> Clean up file names and locations. Get rid of include/ directory and move
> those up to the top-level. Rename files to get rid of upper case. Remove
> skeinBlockNo3F.c as it was unused (temporary file or something?).
>
On Sat, May 17, 2014 at 9:51 PM, David Matlack wrote:
> On Sat, May 17, 2014 at 9:12 PM, Joe Perches wrote:
>> The if seems unnecessary.
>>
>> Perhaps declare a u16 return var or use
>>
>> return lower_16 + upper_16;
>
> I agree it's fishy... but using overflow doesn't produce the same re
On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote:
> Remove prohibited space and fix line over 80 characters of
> memset(...) to meet kernel coding style.
[]
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
[]
> @@ -113
On Sun, May 18, 2014 at 06:19:12PM +0100, Masaru Nomura wrote:
> These patches fix warnings below in socklnd.c to meet coding style.
> Also fix some indenting due to changes to keep readability.
>
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: line over 80 ch
>> - memset (peer, 0, sizeof (*peer)); /* NULL pointers/clear flags
>> etc */
>> + memset(peer, 0, sizeof(*peer)); /* NULL pointers/clear flags etc */
>
> It looks like this memset is unnecessary
> as it's already zeroed by LIBCFS_ALLOC->
> LIBCFS_ALLOC_GFP->LIBCFS_ALLOC_POST->me
On Sun, 2014-05-18 at 12:36 -0600, Jake Edge wrote:
> Clean up file names and locations. Get rid of include/ directory and move
> those up to the top-level. Rename files to get rid of upper case. Remove
> skeinBlockNo3F.c as it was unused (temporary file or something?).
[]
> Diff appears to be h
Clean up file names and locations. Get rid of include/ directory and move
those up to the top-level. Rename files to get rid of upper case. Remove
skeinBlockNo3F.c as it was unused (temporary file or something?).
Signed-off-by: Jake Edge
---
Against next-20140516
v2: use git format-patch -M
On Sun, 18 May 2014 11:42:53 -0700 Joe Perches wrote:
> On Sun, 2014-05-18 at 12:36 -0600, Jake Edge wrote:
> > Clean up file names and locations. Get rid of include/ directory
> > and move those up to the top-level. Rename files to get rid of
> > upper case. Remove skeinBlockNo3F.c as it was un
Remove prohibited space and fix indenting of following parameters
of CDEBUG(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lnet
Remove prohibited space and fix indenting of following parameter
of ksocknal_get_peer_info(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/st
Remove prohibited space between open parenthesis and
function name to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c| 226 ++--
1 file changed, 113 insertions(+), 113 deletions(-)
diff --git a/drivers/staging/lustr
Remove prohibited space and fix indenting of following parameters
of ksocknal_create_conn(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Remove prohibited space and fix line over 80 characters of
memset(...) to meet kernel coding style.
Signed-off-by: Masaru Nomura
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd
These patches fix warnings below in socklnd.c to meet coding style.
Also fix some indenting due to changes to keep readability.
WARNING: space prohibited between function name and open parenthesis '('
WARNING: line over 80 characters
Masaru Nomura (5):
staging: lustre: lnet: socklnd: Remove pro
Hi
The approximately 5,000 errors were not only null pointers, but
uninitialized variables, etc. also a mixture of error and warnings.
Same I did not consider a reall error. Then a bunch of warnings for
printf("%d", unsigned int) and vice versa, which I have not even
bothered to check even.
Rega
On Sun, May 18, 2014 at 12:55:16PM +0200, Lubomir Rintel wrote:
> There's no more printk abuse, it's been sorted out in
> 448810662ac3 ("Staging: xgifb: Remove printk usage.")
Yes, but there are still lots of pr_* calls that should be switched to
dev_* calls instead. Or just removed entirely.
I'
On Sun, May 18, 2014 at 12:55:13PM +0200, Lubomir Rintel wrote:
> It is neither used nor useful.
Not true at all.
>
> Signed-off-by: Lubomir Rintel
> ---
> drivers/staging/xgifb/XGI_main_26.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c
> b/dr
On Mon, May 12, 2014 at 12:38:30PM -0400, Benjamin Romer wrote:
> Convert /proc/uislib/platform to an equivalent entry in debugfs.
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/uislib/uislib.c | 62
> ++
> 1 file changed, 17 insertions(+), 45 d
On Sun, May 18, 2014 at 05:49:52PM +0200, Rickard Strandqvist wrote:
> Hi
>
> When I run cppcheck find the about 5,000 errors, of these, I selected
> the 100 most serious and has made patches. But my ability to immerse
> myself in each failure has been limited unfortunately.
>
I am familiar with
Sorry, I should have noticed this before, but the subject doesn't match
the patch any more.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Removde unnecessary check for null pointer.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/tidspbridge/rmgr/node.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/rmgr/node.c
Hi
When I run cppcheck find the about 5,000 errors, of these, I selected
the 100 most serious and has made patches. But my ability to immerse
myself in each failure has been limited unfortunately.
Okay, I send it through the scripts instead.
Best regards
Rickard Strandqvist
2014-05-17 20:56 G
Subject line of this patch isn't correct, so please ignore it.
I've submitted new patch with "[PATCH 13/28] staging: rtl8188eu:
Remove unused funtion PHY_ScanOperationBackup8188E()"
subject line.
regards,
navin patidar
On Sun, May 18, 2014 at 8:49 PM, navin patidar wrote:
> Signed-off-by: navin
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index a7872c8..941ff74 100644
--- a/drivers/staging/rtl
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c |1 -
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |5 -
drivers/staging/rtl8188eu/include/odm_RTL8188E.h |2 --
3 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
index 7c1043c..a90b2c5 100644
--- a/drivers/staging/rtl8188eu/hal
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c
index 323eb93..7c1043c 100644
--- a/drivers/staging/rtl8188
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
index 056052d..7c22658 100644
--- a/drivers/staging
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c | 25 -
1 file changed, 25 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index 4442181..425c50a4 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index 8dd5f7e..4442181 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/driv
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c |9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index cc73188..8dd5f7e 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/stag
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index 01946cc..cc73188 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/r
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index 7319b3e..01946cc 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/r
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c | 34 --
1 file changed, 34 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index e8ad880..7319b3e 100644
--- a/drivers/staging/rtl8188eu/ha
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index 2e105b4..e8ad880 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drive
odm_DynamicBBPowerSaving() has empty defination.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index d8482ab..2e105b4 100644
--- a/drivers
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/odm.c | 45 ---
1 file changed, 45 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
index 89a26e3..d8482ab 100644
--- a/drivers/staging/rtl8188eu/h
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 23 ---
1 file changed, 23 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
index 2f1348f..52103da 100644
--- a/dri
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c
index b1cb5c4..2f1348f 100644
--- a/driv
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index a7872c8..941ff74 100644
--- a/drivers/staging/rtl
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 34 ---
1 file changed, 34 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 099345f..a7872c8 100644
--- a/dri
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 46 ---
1 file changed, 46 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 16f46c3..099345f 100644
--- a/dri
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37
drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 -
2 files changed, 38 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 44 ---
1 file changed, 44 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 7cc7f44..16f46c3 100644
--- a/dri
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index 8079fc6..b50df3e 100644
--- a/drive
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
index b50df3e..79f86db 100644
--- a/drivers/
Function has empty defination.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 4c3f8c8..141f85a 100644
--- a/dr
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 1a83d31..4c3f8c8 100644
--- a/drivers/staging/rtl8188eu/hal/u
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 2fe1135..1a83d31 100644
--- a/drivers/staging/rtl8188eu/hal/us
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |7 ---
drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
ind
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 9ce6173..2e7b81ce 100644
--- a/drivers/staging/rtl8188eu/hal/usb
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 617e4c6..9ce6173 100644
--- a/drivers/staging/rtl8188eu/hal/u
Following patches remove functions which are unused or have empty
definition.
navin patidar (28):
staging: rtl8188eu: Remove function with empty definition
_InitBeaconMaxError().
staging: rtl8188eu: Remove function with empty definition
_InitOperationMode()
staging: rtl8188eu: Remove
Hi,
I've cleaned up some small issues in xgifb driver as part of a solution to an
Eudyptula Challenge [1] task. The patches are chained to this message.
[1] http://eudyptula-challenge.org/
Lubo
___
devel mailing list
de...@linuxdriverproject.org
http
It was left uninitialized, likely overseen, in this commit:
56810a92c689c6 ("staging: xgifb: use XGIRegInit()
Avoid copy-paste and use XGIRegInit() to initialize registers addresses.")
Signed-off-by: Lubomir Rintel
---
drivers/staging/xgifb/XGI_main_26.c | 1 +
1 file changed, 1 insertion(+)
di
XGI_VB_CHIP_TYPE, PCI_DEVICE_ID_XGI_42 and PCI_DEVICE_ID_XGI_27
are never defined.
Signed-off-by: Lubomir Rintel
---
drivers/staging/xgifb/XGI_main.h | 4
drivers/staging/xgifb/vgatypes.h | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/stagin
It is neither used nor useful.
Signed-off-by: Lubomir Rintel
---
drivers/staging/xgifb/XGI_main_26.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index a62d4dd..d61e03f 100644
--- a/drivers/staging/xgifb/XGI_main_
There's no more printk abuse, it's been sorted out in
448810662ac3 ("Staging: xgifb: Remove printk usage.")
Extra ifdefs have been fixed too, mostly in
800d67cf9f77 ("staging: xgifb: eliminate #ifdef Tap4"),
c39aada6926c ("staging: xgifb: eliminate #ifdef XGIFB_PAN"),
fa4c212f2b81 ("staging: xgifb
SetLCDStdMode is not supported as of 34c13ee2b690 ("staging: xgifb: drop
code for legacy VGA modes").
DisableLCD24bpp defined to zero was never realy useful and went away with
aa56b2790a8b ("staging: xgifb: vb_table: delete XGI21_LCDCapList").
Signed-off-by: Lubomir Rintel
---
drivers/staging/x
75 matches
Mail list logo
