Dan Carpenter dan.carpen...@oracle.com writes:
On Wed, May 21, 2014 at 09:38:36AM +0200, jes.soren...@redhat.com wrote:
@@ -6243,7 +6241,7 @@ int setkey_hdl23a(struct rtw_adapter *padapter, const
u8 *pbuf)
pmlmeinfo-key_index = pparm-keyid;
/* write cam */
-ctrl =
On Wed, May 21, 2014 at 10:39:43PM -0400, Sean MacLennan wrote:
On Sat, 19 Apr 2014 16:57:45 -0400
Sean MacLennan se...@seanm.ca wrote:
A sparse error fixup removed a htons() which is required for the
driver to function. This patch puts the htons() back and fixes the
sparse warning
Emma Mobile USB driver and KZM9D board code
[PATCH 01/03] staging: emxx_udc: Add Emma Mobile USB Gadget driver
[PATCH 02/03] staging: emxx_udc: I/O memory and IRQ resource support
[PATCH 03/03] staging: board: kzm9d: Board staging support for emxx_udc
This patch series contains an old USB Gadget
Hi Magnus,
Thanks for your series! This looks like a good solution for interim board
support.
On Thu, May 22, 2014 at 10:53 AM, Magnus Damm magnus.d...@gmail.com wrote:
Olof, patch 3/3 contains some board staging code for KZM9D. As it is
today the EMEV2 SoC is DT-only and we neither have
Hi Geert,
On Thu, May 22, 2014 at 6:19 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
Hi Magnus,
On Thu, May 22, 2014 at 10:54 AM, Magnus Damm magnus.d...@gmail.com wrote:
Add staging board support for the KZM9D board and add
an emxx_udc platform device to allow in-tree continous
Hi Dan,
On Thu, May 22, 2014 at 6:17 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
Generally we take things as is into staging so there is no need for a
re-work if you don't want to. But we do need a TODO file. Read the
TODO files for other staging drivers.
Thanks for pointing that out,
Hi Geert,
On Thu, May 22, 2014 at 6:21 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
Hi Magnus,
Thanks for your series! This looks like a good solution for interim board
support.
Thanks!
On Thu, May 22, 2014 at 10:53 AM, Magnus Damm magnus.d...@gmail.com wrote:
Olof, patch 3/3
Hi,
I updated my patches as suggested by Dan Carpenter. Thank you for your
suggestions!
The patchset grew by one patch which fixes indentations in the whole file as
suggested by Dan. I didn't split this patch up as it does _only_ indentation
fixes. If you want me to split it up, tell me!
Note:
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 76 ---
1 file changed, 50 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index ae7490b..e5283dd 100644
---
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 98 ---
1 file changed, 55 insertions(+), 43 deletions(-)
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 70 ++-
1 file changed, 42
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 218 ++
1 file changed, 115 insertions(+), 103 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 93b94b4..52809dc 100644
---
Looks ok now. Thanks. :)
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
-Original Message-
From: Andy Whitcroft [mailto:a...@canonical.com]
Sent: Wednesday, May 21, 2014 7:25 AM
To: Ian Abbott
Cc: linux-s...@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan;
Haiyang Zhang; James E.J. Bottomley; Tim Gardner
Subject: Re: [PATCH 0/2] scsi:
This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci, and tested by compilation.
Signed-off-by: Benoit Taine benoit.ta...@lip6.fr
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |3 +--
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
On Thu, 2014-05-22 at 10:49 +, KY Srinivasan wrote:
-Original Message-
From: Andy Whitcroft [mailto:a...@canonical.com]
Sent: Wednesday, May 21, 2014 7:25 AM
To: Ian Abbott
Cc: linux-s...@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan;
Haiyang Zhang; James
On Wednesday, May 21, 2014 5:40 PM, Chase Southwood wrote:
This function is already compliant with the comedi API and is behaving as
comedi core expects. This patch moves it out of
addi-data/hwdrv_apci1564.c and into the driver proper since no further
work needs to be done on it.
Cc: Ian
On Wednesday, May 21, 2014 5:41 PM, Chase Southwood wrote:
This function is already compliant with the comedi API and is behaving as
comedi core expects. This patch moves it out of
addi-data/hwdrv_apci1564.c and into the driver proper since no further
work needs to be done on it.
Cc: Ian
On Wed, 21 May 2014 01:52:17 +0400 Anton Saraev wrote:
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
but some kind of tests are needed to ensure nothing breaks before
digging into that ...
I have some test: slightly
On Thu, May 22, 2014 at 10:52:06AM -0600, Jake Edge wrote:
On Wed, 21 May 2014 01:52:17 +0400 Anton Saraev wrote:
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
but some kind of tests are needed to ensure nothing breaks
Fix sparse warnings caused by incorrect references to IO space.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/uislib/uislib.c | 2 +-
drivers/staging/unisys/visorchannel/visorchannel.h | 6 +++---
This series of patches cleans up the unisys driver code in various ways:
-fix sparse warnings related to accessing I/O space
-fix sparse warnings related to dereferencing noderef types
-add static to function declration
-remove unused functions and macros
virthba_queue_command() is only used inside virthba.c so declare it static.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/virthba/virthba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
Added ULTRA_VBUS_IOinit_channel() and modified ULTRA_VBUS_init_channel()
function so that it can operate on both memory space and IO space
without getting sparse warnings.
Signed-off-by: Ken Cox j...@redhat.com
---
.../unisys/common-spar/include/channels/vbuschannel.h| 12 ++--
Fixed the usage of the following so they don't try to dereference
pointers to iomem.
CHANNEL_U64_MISMATCH
CHANNEL_U32_MISMATCH
wait_for_valid_guid
Signed-off-by: Ken Cox j...@redhat.com
---
.../unisys/common-spar/include/channels/channel.h | 16 ---
There is not any code using the functionality in filexfer.c so I removed it
and filexfer.h.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/visorchipset/Makefile | 2 +-
drivers/staging/unisys/visorchipset/filexfer.c | 506 -
VISORCHANNEL_CHANGE_SERVER_STATE and VISORCHANNEL_CHANGE_CLIENT_STATE
are never used in any of the source so they have been removed.
VISORCHANNEL_CHANGE_CLIENT_STATE would have caused a broken kernel build
after commit a8d7f21d, but since it was never used the kernel continued
to build.
This makes sure the cfg-name can never accidentally be processed as a
format string in the worker thread name.
Signed-off-by: Kees Cook keesc...@chromium.org
---
drivers/staging/rtl8821ae/base.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 110 +--
1 file changed, 52 insertions(+), 58 deletions(-)
diff --git
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/rtl8192u/r8192U_core.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
On Thu, May 22, 2014 at 01:49:22PM -0400, Mark Hounschell wrote:
I understand that unnecessarily initializing them is wrong. But if they
do need initialized, is it preferred to do it in the declaration or in
the code before it is used?
Which ever is more clear. It's up to you. Or do you mean
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 05/22/2014 04:38 PM, Dan Carpenter wrote:
On Thu, May 22, 2014 at 01:49:22PM -0400, Mark Hounschell wrote:
I understand that unnecessarily initializing them is wrong. But if they
do need initialized, is it preferred to do it in the declaration or in
the code before it is used?
Which ever
On Thu, May 22, 2014 at 09:58:02PM +0200, Rickard Strandqvist wrote:
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
Reviewed-by: Josh Triplett j...@joshtriplett.org
drivers/staging/rtl8188eu/os_dep/usb_intf.c
-Original Message-
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
Sent: Thursday, May 22, 2014 7:38 AM
To: KY Srinivasan
Cc: Andy Whitcroft; Ian Abbott; linux-s...@vger.kernel.org;
de...@linuxdriverproject.org; Haiyang Zhang; Tim Gardner
Subject: Re: [PATCH
Fixed the ERROR thrown off by checkpatch.pl.
Signed-off-by: Chaitanya Hazarey c...@24.io
---
drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c
Hyper-V hosts can support multiple targets and multiple channels and larger
number of
LUNs per target. Update the code to reflect this. With this patch we can
correctly
enumerate all the paths in a multi-path storage environment.
MS-TFS: 173725
Signed-off-by: K. Y. Srinivasan
On Thu, May 22, 2014 at 06:32:03PM +0900, Magnus Damm wrote:
Hi Dan,
On Thu, May 22, 2014 at 6:17 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Generally we take things as is into staging so there is no need for a
re-work if you don't want to. But we do need a TODO file. Read the
First, don't print pci device information or driver prefixes, this
is already printed by dev_err. Next, don't report error messages
via dev_err when the failing function already reports all errors
via dev_err.
Signed-off-by: David Matlack matlackda...@gmail.com
---
Removes two fields from the private struct adapter.
memorybase duplicate of slic_regs
memorylengthwritten once and never read. This field is trivially
computed with pci_resource_len if it's ever needed in
the future.
This patch has no noticable effect.
Fix a use-after-free bug that can cause a kernel oops. If
slic_card_init fails then slic_entry_probe() (the pci probe()
function for this device) will return error without cleaning
up memory (including the registered netdev struct).
Signed-off-by: David Matlack matlackda...@gmail.com
---
This
Fix two trivial free-after-free bugs in slic_entry_remove.
1. Don't iounmap() the same address twice. adapter-slic_regs
(iounmap()'ed in slic_unmap_mmio_space()) and dev-base_addr
(iounmap()'ed in slic_entry_remove()) are the same region.
2. Don't call release_mem_region() and
Fix a use-after-free bug that causes a null pointer dereference in
slic_entry_halt().
Since unregister_netdev() will ultimately call slic_entry_halt() (the
net_device ndo_stop() virtual function for this device), we should
call it before freeing the memory that is used by slic_entry_halt().
Fix a bug that only manifests when the physical address of the
interrupt status register is 4GB. Specifically, the driver was only
telling the device about the lower 32 bits of the ISR. This patch adds
the upper 32 bits.
Without this patch, polling the ISR times out whenever the physical
address
As per the TODO file, this patch removes the gratuitous debug
infrastructure. As an extra incentive for removing this code,
the debugfs files are not cleaned up properly. For example, if
register_netdev() fails in slic_entry_probe() then all debugfs
files get left behind, even after the driver
Remove the private linked list of netdev structs. This list isn't
being used anyway.
This patch has no noticable effect.
Signed-off-by: David Matlack matlackda...@gmail.com
---
drivers/staging/slicoss/slic.h| 1 -
drivers/staging/slicoss/slicoss.c | 4
2 files changed, 5 deletions(-)
This patchset fixes two bugs in slic_card_init(). They are grouped in
a series because the second patch depends on the first (for a merge
without conflicts). In content, they are completely separate changes.
They just touch a few of the same lines.
David Matlack (2):
staging: slicoss: fix dma
Fix memory leak in slic_card_init. If the driver fails to poll for an
interrupt after requesting config data from the device the dma memory
is never freed.
Signed-off-by: David Matlack matlackda...@gmail.com
---
This patch was originally sent here https://lkml.org/lkml/2014/5/6/7 with
my
slic_config_get() can fail. Change the return type from void to
int and handle the error in slic_card_init(). So now, instead of
silently failing (and then timing out waiting for the config data),
the driver will fail loudly at request time.
Signed-off-by: David Matlack matlackda...@gmail.com
---
49 matches
Mail list logo
