On Tue, 2014-05-27 at 14:44 +0800, hnnne...@gmail.com wrote:
> From: kevin
Hi Kevin.
You subject line should be something like:
[PATCH] Add support for GeneralTouch serial screen
There should be a commit message too.
> ---
> gtserio.c | 188
> +
When dgap_tty_init() and dgap_tty_register_ports() are failed,
these are needed to free some memory properly.
It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board().
But tty's ports are not registered yet when these function are failed,
so it need to switch with boolean value whet
Hi Kevin,
I suggest reading the file Documentation/SubmittingPatches for general
guidance as how to submit patches.
> +#define MAJOR_NUM 100
> +#define MAJOR_MIN 0
Fixed device numbers need to be allocated from
(currently managed by Alan Cox). However, this should pro
On 26 May 2014 23:03, Greg KH wrote:
> On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote:
>> 'ret' is not used in the function. Remove it.
>>
>> Signed-off-by: Sachin Kamat
>> ---
>> drivers/staging/imx-drm/imx-tve.c |1 -
>> 1 file changed, 1 deletion(-)
>
> This doesn't apply pr
On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote:
> Hello Carpenter,
>
> On 05/26/2014 07:36 PM, Dan Carpenter wrote:
> >On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> >>@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct
> >>ion_system_heap *hea
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/include/osdep_service.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/include/osdep_service.h
b/drivers/staging/rtl8723au/include/osdep_serv
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/os_dep/os_intfs.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c
b/drivers/staging/rtl8723au/os_dep/os_intfs.c
index 5b27
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8192ee/wifi.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192ee/wifi.h b/drivers/staging/rtl8192ee/wifi.h
index 9cb0811..96fa261 100644
--- a/drivers/st
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80
Fixes the followign build error:
drivers/staging/rtl8192ee/btcoexist/halbtc8723b1ant.c:1387:6: error: called
object is not a function or function pointer
("[BTCoex], Wifi non connected-idle + BT Busy!!\n"));
Signed-off-by: Sachin Kamat
---
.../staging/rtl8192ee/btcoexist/halbtc8723b1ant.c
The "brd->nasync = 0;" was wrong, yes, but my main complaint was that
you are writing complicated error handling. This v2 patch makes the
error handling even more complicated. If dgap_tty_init() fails it
should free the things it allocates itself, instead of the caller
handling errors for it.
It
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
This series is based on latest staging-next and is compile tested.
---
drivers/staging/rtl8821ae/base.c | 46 +-
1 file changed, 1 inser
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/cam.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
index 72743e7..3bc6b
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/debug.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8821ae/debug.c
b/drivers/staging/rtl8821ae/debug.c
index 8a6c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/compat.h | 57
1 file changed, 57 deletions(-)
diff --git a/drivers/staging/rtl8821ae/compat.h
b/drivers/st
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/core.c | 156 +-
1 file changed, 2 insertions(+), 154 deletions(-)
diff --git a/drivers/staging/rtl8821ae/core
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/regd.h |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8821ae/regd.h b/drivers/staging/rtl8821ae/regd.h
index dceb3
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/rtl8821ae/trx.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.h
b/drivers/staging/rtl88
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/ps.c | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/rtl8821ae/ps.c b/drivers/staging/rtl8821ae/ps.
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/efuse.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/efuse.c
b/drivers/staging/rtl8821ae/efuse.c
index 250aae1
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/regd.c | 52 --
1 file changed, 52 deletions(-)
diff --git a/drivers/staging/rtl8821ae/regd.c b/drivers/stagi
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/rc.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rc.c b/drivers/staging/rtl8821ae/rc.c
index
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/pci.c | 120 ---
1 file changed, 120 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/stagi
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/rtl8821ae/sw.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/sw.c
b/drivers/stagi
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/pci.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.h b/drivers/staging/rtl8821ae/pci.h
index 06eaa52..3f
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/rtl8821ae/trx.c | 45 -
1 file changed, 45 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.c
b/dri
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8821ae/stats.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/stats.c
b/drivers/staging/rtl8821ae/stats.c
index a20c0f8
After the commit 91d435f replaced _malloc with kmalloc, smatch picked up a
couple of new warnings. This fixes warnings:
warn: struct type mismatch 'writePTM_parm vs setdig_parm'
warn: struct type mismatch 'writePTM_parm vs setra_parm'
The difference is u8 vs unsigned char.
Signed-off-by: Vitaly
After the commit 91d435f replaced _malloc with kmalloc, smatch picked up a
couple of new warnings. This fixes the warning:
warn: returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Vitaly Osipov
---
drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
On Mon, May 26, 2014 at 09:12:52AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman
> wrote:
> >
> > On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
> > > Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left
> > > va
The `in_request_module` member of `struct comedi_device` is only ever
set to `false`, so remove the code that checks for it being `true` and
remove the member.
Signed-off-by: Ian Abbott
---
For "staging-next".
---
drivers/staging/comedi/comedi_fops.c | 26 --
drivers/stag
Signed-off-by: navin patidar
---
drivers/staging/rtl8712/osdep_service.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
b/drivers/staging/rtl8712/osdep_service.h
index 09e1561..66ed7f1 100644
--- a/drivers/staging/rtl8712/osdep_service.h
+++ b
rtw_set_tx_chksum_offload() has empty defination.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_xmit.c |2 --
drivers/staging/rtl8188eu/include/xmit_osdep.h |2 --
drivers/staging/rtl8188eu/os_dep/xmit_linux.c |4
3 files changed, 8 deletions(-)
diff
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |6 --
drivers/staging/rtl8188eu/include/usb_ops.h |1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
index
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
index 6089bae..9172380 100644
--- a/drivers/staging/rtl8188eu/os
Assign RTL8188E to padapter->chip_type directly instead of calling
chip_by_usb_id() function to do same.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_in
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index c1195a0..6fb8caa 100644
--- a/drivers/staging/rtl8188eu/co
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index 6c9e9a1..c1195a0 100644
--- a/drivers/
rtw_usb_if1_init() initializes pbuddy_padapter variable which is not
being used.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/stagi
rtw_usb_if1_init() assign NULL to pbuddy_padapter variable which is not
being used.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/u
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index fbf967d..1e62713 100644
--- a/drivers/staging/rtl8188eu/os_dep
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 ++--
drivers/staging/rtl8188eu/os_dep/usb_intf.c |4 ++--
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/sta
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188e
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include/osdep_service.h
index 9d32bb2..b500991 100644
--- a/drivers/staging/
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188e
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/osdep_service.h | 39 -
1 file changed, 39 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include/osdep_service.h
index b500991..3859acd 100644
--- a
This commit refactors the iwctl_giwaplist() function so that the sparse
warning "the frame size of 1292 bytes is larger than 1024 bytes
[-Wframe-larger-than=]" is no more.
The root cause of this warning were two arrays allocated on the stack
and this commit changes this - these arrays are now kmal
On 2014-05-24 23:24, Chase Southwood wrote:
This board supports an interrupt that can be generated by an AND/OR
combination of 16 of the input channels.
Create a separate subdevice to handle this interrupt.
In doing this, this patch moves the apci1564_di_config() operation from
the digital inpu
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local variable
to i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the time
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Also, change the 'err' variable to the correct type.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Tidy up the local varaibles in the function.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 32 +++
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
arguments for the TRIG_TIMER command sources. Pass the local variable to
i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer w
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate
the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local
variable to i8253_cascade_ns_to_timer() instead of the cmd argument.
This value is modified by that function to return the actual time
(in nanoseconds) that the time
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic re
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd->scan_begin_arg for the scan_begin_src TRIG_TIMER. Pass the local
variable to dt2k_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer w
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc:
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local vari
We try to free two pages when only one has been allocated.
Cleanup path is unlikely, so I haven't found any trace that would fit,
but I hope that free_pages_prepare() does catch it.
Cc: sta...@vger.kernel.org
Signed-off-by: Radim Krčmář
---
Cc'd stable because the worst-case looks hard to debug.
Use the comedi_fc helpers to validate the timer arguments.
This is a repost of a series that Ian Abbott has already reviewed. I have
udated his sign off on all the patches.
H Hartley Sweeten (23):
staging: comedi: adl_pci9111: use comedi_fc helpers to validate timer args
staging: comedi: adv_
Use the local variable to access the comedi_cmd as a pointer
in dio200_read_scan_intr() instead of getting to it from the
comedi_subdevice pointer.
Remove the unnecessary local variable 'len', this is just the
cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Har
For aesthetics, use a local variable to access the comedi_cmd as a
pointer in das800_ai_do_cmd() instead of getting to it from the
comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das800.c | 15 ---
1 fi
Use the local variable to access the comedi_cmd as a pointer in
pci230_handle_ai() instead of getting to it from the comedi_async
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 6 +++---
1 file changed, 3 inse
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
Tidy up the local variables so that the comedi_cmd is accessed as a pointer
instead of getting to it from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 14 ++
1 file changed, 6 insertions
This member of the private data is just a copy of the channels from
the cmd->chanlist. Remove the member and just use the cmd->chanlist
directly.
Remove the unneeded 'len' local variable in usbdux_ao_isoc_irq().
This is just the cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
The cmd->chanlist_len will always be >= 1 in this function. Remove the
unnecessary checks.
Use the comedi_fc helper function to get the 'bytes_per_scan'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 11 ++-
Use the 'cmd' pointer to access the chanlist instead of getting to it
using the comedi_subdevice pointer.
Remove the unneeded 'n' local variable, this is just the cmd->chanlist_len.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdu
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl711.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The calculation for the total number of bytes in the DMA transfer
is incorrect. Fix it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/come
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 10 ++
1 file changed, 6 insertions(+), 4 deletio
This function does not use the comedi_cmd. Remove the commented out
local variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_65xx.c
b
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/s
This member of the private data can be determined from the cmd->stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
This series continues the cleanup of the comedi driver async command support.
H Hartley Sweeten (38):
staging: comedi: usbdux: remove 'ai_continuous' from private data
staging: comedi: usbdux: remove 'ao_continuous' from private data
staging: comedi: usbduxfast: remove 'ai_continuous' from p
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
The (*do_cmdtest) validates that the 'stop_arg' is >= 1 for a 'stop_src'
of TRIG_COUNT and the 'scan_end_arg' is validated to be the 'chanlist_len'
which will always be >= 1. Remove the unreachable error code for an
'ai_sample_count < 1'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
THe comedi core ensures that the chanlist will be valid for any async operation
other than Step 1 of the (*do_cmdtest) to get the trigger source masks.
Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ampl
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_isadma.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(
Tidy up the local variables so that the comedi_cmd is accessed as a pointer
instead of getting to it from the comedi_subdevice pointer.
Remove the local variable 'len' and use the cmd->chanlist_len directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/st
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_fc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Use the comedi_fc helper function to get the 'bytes_per_scan'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pc
Factor the fifo half-full handling out of the interrupt function to reduce
the indent level of the code.
Tidy up the factored out code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 128 +--
1
Use the local variable to access the comedi_cmd as a pointer in
pci224_ao_munge() instead of getting to it from the comedi_async
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 4 ++--
1 file changed, 2 inserti
This member of the private data can be determined from the
cmd->stop_src. Do that instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das800.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a
1 - 100 of 154 matches
Mail list logo