Re: [PATCH] This is my first commit

On Tue, 2014-05-27 at 14:44 +0800, hnnne...@gmail.com wrote: > From: kevin Hi Kevin. You subject line should be something like: [PATCH] Add support for GeneralTouch serial screen There should be a commit message too. > --- > gtserio.c | 188 > +

[PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

When dgap_tty_init() and dgap_tty_register_ports() are failed, these are needed to free some memory properly. It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board(). But tty's ports are not registered yet when these function are failed, so it need to switch with boolean value whet

Re: [PATCH] This is my first commit

Hi Kevin, I suggest reading the file Documentation/SubmittingPatches for general guidance as how to submit patches. > +#define MAJOR_NUM 100 > +#define MAJOR_MIN 0 Fixed device numbers need to be allocated from (currently managed by Alan Cox). However, this should pro

Re: [PATCH 1/1] staging: imx-drm: Remove unused variable

On 26 May 2014 23:03, Greg KH wrote: > On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote: >> 'ret' is not used in the function. Remove it. >> >> Signed-off-by: Sachin Kamat >> --- >> drivers/staging/imx-drm/imx-tve.c |1 - >> 1 file changed, 1 deletion(-) > > This doesn't apply pr

Re: [PATCH 1/9] staging: ion: tidy up a bit

On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote: > Hello Carpenter, > > On 05/26/2014 07:36 PM, Dan Carpenter wrote: > >On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: > >>@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct > >>ion_system_heap *hea

[PATCH 1/3] staging: rtl8723au: Remove unneeded version.h inclusion in osdep_service.h

version.h inclusion is not needed as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8723au/include/osdep_service.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/osdep_service.h b/drivers/staging/rtl8723au/include/osdep_serv

[PATCH 3/3] staging: rtl8723au: Remove unneeded version.h inclusion in os_intfs.c

version.h inclusion is not needed as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8723au/os_dep/os_intfs.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c b/drivers/staging/rtl8723au/os_dep/os_intfs.c index 5b27

[PATCH 2/2] staging: rtl8192ee: Remove unneeded version.h inclusion

version.h inclusion is not needed as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8192ee/wifi.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192ee/wifi.h b/drivers/staging/rtl8192ee/wifi.h index 9cb0811..96fa261 100644 --- a/drivers/st

[PATCH 2/3] staging: rtl8723au: Remove unneeded version.h inclusion in ioctl_cfg80211.c

version.h inclusion is not needed as detected by versioncheck. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80

[PATCH 1/2] staging: rtl8192ee: Fix build error

Fixes the followign build error: drivers/staging/rtl8192ee/btcoexist/halbtc8723b1ant.c:1387:6: error: called object is not a function or function pointer ("[BTCoex], Wifi non connected-idle + BT Busy!!\n")); Signed-off-by: Sachin Kamat --- .../staging/rtl8192ee/btcoexist/halbtc8723b1ant.c

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

The "brd->nasync = 0;" was wrong, yes, but my main complaint was that you are writing complicated error handling. This v2 patch makes the error handling even more complicated. If dgap_tty_init() fails it should free the things it allocates itself, instead of the caller handling errors for it. It

[PATCH 01/16] staging: rtl8821ae: base.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- This series is based on latest staging-next and is compile tested. --- drivers/staging/rtl8821ae/base.c | 46 +- 1 file changed, 1 inser

[PATCH 02/16] staging: rtl8821ae: cam.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/cam.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c index 72743e7..3bc6b

[PATCH 05/16] staging: rtl8821ae: debug.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/debug.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug.c index 8a6c

[PATCH 03/16] staging: rtl8821ae: compat.h: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/compat.h | 57 1 file changed, 57 deletions(-) diff --git a/drivers/staging/rtl8821ae/compat.h b/drivers/st

[PATCH 04/16] staging: rtl8821ae: core.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/core.c | 156 +- 1 file changed, 2 insertions(+), 154 deletions(-) diff --git a/drivers/staging/rtl8821ae/core

[PATCH 12/16] staging: rtl8821ae: regd.h: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/regd.h |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8821ae/regd.h b/drivers/staging/rtl8821ae/regd.h index dceb3

[PATCH 15/16] staging: rtl8821ae: trx.h: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/rtl8821ae/trx.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.h b/drivers/staging/rtl88

[PATCH 09/16] staging: rtl8821ae: ps.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/ps.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/rtl8821ae/ps.c b/drivers/staging/rtl8821ae/ps.

[PATCH 06/16] staging: rtl8821ae: efuse.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/efuse.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/efuse.c b/drivers/staging/rtl8821ae/efuse.c index 250aae1

[PATCH 11/16] staging: rtl8821ae: regd.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/regd.c | 52 -- 1 file changed, 52 deletions(-) diff --git a/drivers/staging/rtl8821ae/regd.c b/drivers/stagi

[PATCH 10/16] staging: rtl8821ae: rc.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/rc.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8821ae/rc.c b/drivers/staging/rtl8821ae/rc.c index

[PATCH 07/16] staging: rtl8821ae: pci.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/pci.c | 120 --- 1 file changed, 120 deletions(-) diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/stagi

[PATCH 13/16] staging: rtl8821ae: sw.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/rtl8821ae/sw.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/sw.c b/drivers/stagi

[PATCH 08/16] staging: rtl8821ae: pci.h: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/pci.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8821ae/pci.h b/drivers/staging/rtl8821ae/pci.h index 06eaa52..3f

[PATCH 14/16] staging: rtl8821ae: trx.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/rtl8821ae/trx.c | 45 - 1 file changed, 45 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.c b/dri

[PATCH 16/16] staging: rtl8821ae: stats.c: Remove version specific code

The code should be for the current kernel version. Remove conditional version based code. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/stats.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/stats.c b/drivers/staging/rtl8821ae/stats.c index a20c0f8

[PATCH 1/2] staging: rtl8712: fix kmalloc parameters

After the commit 91d435f replaced _malloc with kmalloc, smatch picked up a couple of new warnings. This fixes warnings: warn: struct type mismatch 'writePTM_parm vs setdig_parm' warn: struct type mismatch 'writePTM_parm vs setra_parm' The difference is u8 vs unsigned char. Signed-off-by: Vitaly

[PATCH 2/2] staging: rtl8712: return -ENOMEM instead of -1

After the commit 91d435f replaced _malloc with kmalloc, smatch picked up a couple of new warnings. This fixes the warning: warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Vitaly Osipov --- drivers/staging/rtl8712/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH linux-next] imx-drm: imx-tve: remove unused variable

On Mon, May 26, 2014 at 09:12:52AM +1000, Stephen Rothwell wrote: > Hi all, > > On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman > wrote: > > > > On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote: > > > Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left > > > va

[PATCH] staging: comedi: remove in_request_module

The `in_request_module` member of `struct comedi_device` is only ever set to `false`, so remove the code that checks for it being `true` and remove the member. Signed-off-by: Ian Abbott --- For "staging-next". --- drivers/staging/comedi/comedi_fops.c | 26 -- drivers/stag

[PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8712/osdep_service.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index 09e1561..66ed7f1 100644 --- a/drivers/staging/rtl8712/osdep_service.h +++ b

[PATCH 01/15] staging: rtl8188eu:Remove function rtw_set_tx_chksum_offload()

rtw_set_tx_chksum_offload() has empty defination. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_xmit.c |2 -- drivers/staging/rtl8188eu/include/xmit_osdep.h |2 -- drivers/staging/rtl8188eu/os_dep/xmit_linux.c |4 3 files changed, 8 deletions(-) diff

[PATCH 06/15] staging: rtl8188eu:Remove unused function rtl8188eu_set_hw_type()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |6 -- drivers/staging/rtl8188eu/include/usb_ops.h |1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c index

[PATCH 02/15] staging:rtl8188eu:Remove code specific to kernel version < 2.6.35

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c index 6089bae..9172380 100644 --- a/drivers/staging/rtl8188eu/os

[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to padapter->chip_type directly

Assign RTL8188E to padapter->chip_type directly instead of calling chip_by_usb_id() function to do same. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_in

[PATCH 10/15] staging: rtl8188eu:Remove unused variable struct adapter *pbuddy_padapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index c1195a0..6fb8caa 100644 --- a/drivers/staging/rtl8188eu/co

[PATCH 09/15] staging: rtl8188eu:Remove unused function rtw_handle_dualmac()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index 6c9e9a1..c1195a0 100644 --- a/drivers/

[PATCH 07/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_init()

rtw_usb_if1_init() initializes pbuddy_padapter variable which is not being used. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/stagi

[PATCH 08/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_deinit()

rtw_usb_if1_init() assign NULL to pbuddy_padapter variable which is not being used. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/u

[PATCH 05/15] staging: rtl8188eu:Remove unused function chip_by_usb_id()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index fbf967d..1e62713 100644 --- a/drivers/staging/rtl8188eu/os_dep

[PATCH 13/15] staging: rtl8188eu:Remove inline function rtw_netif_stop_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 ++-- drivers/staging/rtl8188eu/os_dep/usb_intf.c |4 ++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/sta

[PATCH 11/15] staging: rtl8188eu:Remove inline function rtw_netif_wake_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188e

[PATCH 14/15] staging: rtl8188eu:Remove unused inline function res_to_status()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index 9d32bb2..b500991 100644 --- a/drivers/staging/

[PATCH 12/15] staging: rtl8188eu:Remove inline function rtw_netif_start_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188e

[PATCH 15/15] staging: rtl8188eu:Remove unused macros defined in osdep_service.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index b500991..3859acd 100644 --- a

[PATCH v2] staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.

This commit refactors the iwctl_giwaplist() function so that the sparse warning "the frame size of 1292 bytes is larger than 1024 bytes [-Wframe-larger-than=]" is no more. The root cause of this warning were two arrays allocated on the stack and this commit changes this - these arrays are now kmal

Re: [PATCH 1/3] staging: comedi: addi_apci_1564: add a subdevice for Change-of-State interrupt support

On 2014-05-24 23:24, Chase Southwood wrote: This board supports an interrupt that can be generated by an AND/OR combination of 16 of the input channels. Create a separate subdevice to handle this interrupt. In doing this, this patch moves the apci1564_di_config() operation from the digital inpu

[PATCH 02/23] staging: comedi: adv_pci1710: use comedi_fc helpers to validate timer args

Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local variable to i8253_cascade_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the time

[PATCH 15/23] staging: comedi: pcl711: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 08/23] staging: comedi: das16m1: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. For aesthetics, rename the local variable 'tmp' to 'arg'. Also, change the 'err' variable to the correct type. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg

[PATCH 07/23] staging: comedi: das16: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Tidy up the local varaibles in the function. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 32 +++

[PATCH 18/23] staging: comedi: pcl818: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. The minimum test is not needed, this was already validated in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic re

[PATCH 04/23] staging: comedi: adl_pci9118: use comedi_fc helpers to validate timer args

Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the arguments for the TRIG_TIMER command sources. Pass the local variable to i8253_cascade_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the timer w

[PATCH 22/23] staging: comedi: skel: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local vari

[PATCH 17/23] staging: comedi: pcl816: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. The minimum test is not needed, this was already validated in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic re

[PATCH 14/23] staging: comedi: ni_pcidio: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 19/23] staging: comedi: quatech_daqp_cs: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 01/23] staging: comedi: adl_pci9111: use comedi_fc helpers to validate timer args

Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local variable to i8253_cascade_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the time

[PATCH 16/23] staging: comedi: pcl812: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. The minimum test is not needed, this was already validated in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic re

[PATCH 09/23] staging: comedi: das800: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 13/23] staging: comedi: ni_at_a2150: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 21/23] staging: comedi: s626: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local vari

[PATCH 03/23] staging: comedi: dt3000: use comedi_fc helpers to validate timer args

Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the cmd->scan_begin_arg for the scan_begin_src TRIG_TIMER. Pass the local variable to dt2k_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the timer w

[PATCH 05/23] staging: comedi: cb_pcidas: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 23/23] staging: comedi: addi_apci_3xxx: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. For aesthetics, rename the local variable 'tmp' to 'arg'. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi

[PATCH 12/23] staging: comedi: dt282x: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 06/23] staging: comedi: comedi_test: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 20/23] staging: comedi: rtd520: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local vari

[PATCH 11/23] staging: comedi: dt2814: use comedi_fc helpers to validate timer arg

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc:

[PATCH 10/23] staging: comedi: dmm32at: use comedi_fc helpers to validate timer args

Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local vari

[PATCH] hv: use correct order when freeing monitor_pages

We try to free two pages when only one has been allocated. Cleanup path is unlikely, so I haven't found any trace that would fit, but I hope that free_pages_prepare() does catch it. Cc: sta...@vger.kernel.org Signed-off-by: Radim Krčmář --- Cc'd stable because the worst-case looks hard to debug.

[PATCH 00/23] staging: comedi: cleanup timer arg calidation

Use the comedi_fc helpers to validate the timer arguments. This is a repost of a series that Ian Abbott has already reviewed. I have udated his sign off on all the patches. H Hartley Sweeten (23): staging: comedi: adl_pci9111: use comedi_fc helpers to validate timer args staging: comedi: adv_

[PATCH 11/38] staging: comedi: amplc_dio200_common: use comedi_cmd pointer

Use the local variable to access the comedi_cmd as a pointer in dio200_read_scan_intr() instead of getting to it from the comedi_subdevice pointer. Remove the unnecessary local variable 'len', this is just the cmd->chanlist_len. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Har

[PATCH 09/38] staging: comedi: das800: add a local var for the comedi_cmd pointer

For aesthetics, use a local variable to access the comedi_cmd as a pointer in das800_ai_do_cmd() instead of getting to it from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das800.c | 15 --- 1 fi

[PATCH 13/38] staging: comedi: amplc_pci230: use comedi_cmd pointer

Use the local variable to access the comedi_cmd as a pointer in pci230_handle_ai() instead of getting to it from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci230.c | 6 +++--- 1 file changed, 3 inse

[PATCH 01/38] staging: comedi: usbdux: remove 'ai_continuous' from private data

This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH 16/38] staging: comedi: mite: tidy up local variables in mite_sync_output_dma()

Tidy up the local variables so that the comedi_cmd is accessed as a pointer instead of getting to it from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mite.c | 14 ++ 1 file changed, 6 insertions

[PATCH 06/38] staging: comedi: usbdux: remove 'ao_chanlist' from private data

This member of the private data is just a copy of the channels from the cmd->chanlist. Remove the member and just use the cmd->chanlist directly. Remove the unneeded 'len' local variable in usbdux_ao_isoc_irq(). This is just the cmd->chanlist_len. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH 30/38] staging: comedi: amplc_pci224: use cfc_bytes_per_scan()

The cmd->chanlist_len will always be >= 1 in this function. Remove the unnecessary checks. Use the comedi_fc helper function to get the 'bytes_per_scan'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 11 ++-

[PATCH 07/38] staging: comedi: usbdux: use 'cmd' pointer in usbduxsub_ai_isoc_irq()

Use the 'cmd' pointer to access the chanlist instead of getting to it using the comedi_subdevice pointer. Remove the unneeded 'n' local variable, this is just the cmd->chanlist_len. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdu

[PATCH 23/38] staging: comedi: pcl711: use comedi_cmd pointer

Use a local variable to access the comedi_cmd as a pointer instead of getting to from the comedi_subdevice pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl711.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 22/38] staging: comedi: pcl816: fix DMA 'bytes' calculation

The calculation for the total number of bytes in the DMA transfer is incorrect. Fix it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/come

[PATCH 05/38] staging: comedi: usbduxsigma: remove 'ao_continuous' from private data

This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/s

[PATCH 14/38] staging: comedi: cb_pcidas: use comedi_cmd pointer

Use the local variable to access the comedi_cmd as a pointer instead of getting to it from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletio

[PATCH 17/38] staging: comedi: ni_65xx: remove commented out local variable

This function does not use the comedi_cmd. Remove the commented out local variable. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_65xx.c b

[PATCH 04/38] staging: comedi: usbduxsigma: remove 'ai_continuous' from private data

This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/s

[PATCH 02/38] staging: comedi: usbdux: remove 'ao_continuous' from private data

This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

[PATCH 00/38] staging: comedi: more async command cleanup

This series continues the cleanup of the comedi driver async command support. H Hartley Sweeten (38): staging: comedi: usbdux: remove 'ai_continuous' from private data staging: comedi: usbdux: remove 'ao_continuous' from private data staging: comedi: usbduxfast: remove 'ai_continuous' from p

[PATCH 15/38] staging: comedi: das1800: use comedi_cmd pointer

Use the local variable to access the comedi_cmd as a pointer instead of getting to it from the comedi_subdevice pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 37/38] staging: comedi: usbduxfast: remove unreachable code in usbduxfast_ai_cmd()

The (*do_cmdtest) validates that the 'stop_arg' is >= 1 for a 'stop_src' of TRIG_COUNT and the 'scan_end_arg' is validated to be the 'chanlist_len' which will always be >= 1. Remove the unreachable error code for an 'ai_sample_count < 1'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg

[PATCH 32/38] staging: comedi: amplc_pci230: chanlist is valid after Step 1 of (*do_cmdtest)

THe comedi core ensures that the chanlist will be valid for any async operation other than Step 1 of the (*do_cmdtest) to get the trigger source masks. Remove the unnecessary checks. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ampl

[PATCH 25/38] staging: comedi: ni_labpc_isadma: use comedi_cmd pointer

Use a local variable to access the comedi_cmd as a pointer instead of getting to from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_isadma.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(

[PATCH 19/38] staging: comedi: pcmuio: tidy up local variables in pcmuio_handle_intr_subdev()

Tidy up the local variables so that the comedi_cmd is accessed as a pointer instead of getting to it from the comedi_subdevice pointer. Remove the local variable 'len' and use the cmd->chanlist_len directly. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/st

[PATCH 27/38] staging: comedi: cb_pcidas64: use comedi_cmd pointer

Use a local variable to access the comedi_cmd as a pointer instead of getting to from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 29/38] staging: comedi: comedi_fc: use comedi_cmd pointer

Use a local variable to access the comedi_cmd as a pointer instead of getting to from the comedi_subdevice pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_fc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 31/38] staging: comedi: amplc_pci230: use cfc_bytes_per_scan()

Use the comedi_fc helper function to get the 'bytes_per_scan'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci230.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pc

[PATCH 38/38] staging: comedi: adl_pci9111: factor fifo handling out of pci9111_interrupt()

Factor the fifo half-full handling out of the interrupt function to reduce the indent level of the code. Tidy up the factored out code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 128 +-- 1

[PATCH 12/38] staging: comedi: amplc_pci224: use comedi_cmd pointer

Use the local variable to access the comedi_cmd as a pointer in pci224_ao_munge() instead of getting to it from the comedi_async pointer. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 4 ++-- 1 file changed, 2 inserti

[PATCH 10/38] staging: comedi: das800: remove 'forever' from private data

This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das800.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a

  1   2   >