This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579.
This patch removes kfree for serial_ports in dgap_tty_register_ports()
if the "brd->printer_ports" allocation fails and serial_ports may be
freed by calling dgap_tty_uninit() within other patch.
That patch has an error handling but inco
On 2014-05-29 00:34, H Hartley Sweeten wrote:
Cleanup this driver and remove the unnecessary private data members.
H Hartley Sweeten (8):
staging: comedi: adq12b: fix ctreg (ai channel/range) programming
staging: comedi: adq12b: tidy up adq12b_ai_rinsn()
staging: comedi: adq12b: remove
The dgap_probe1() function is just calling dgap_found_board().
So it is removed and dgap_found_board() is called directly.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/dri
Adds a label for "kfree(brd)". And also remove
a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
Because "brd" will free after failure.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 19 ++-
1 files changed, 14 insertions(+), 5 deletions(-)
di
On Thu, May 29, 2014 at 06:11:09PM +0900, Daeseok Youn wrote:
> Adds a label for "kfree(brd)". And also remove
> a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
> Because "brd" will free after failure.
Yes. Perfect. Eventually BOARD_FAILED will be removed completely.
Review
On 2014-05-29 00:26, H Hartley Sweeten wrote:
I have not determined if the code in these functions is actually
usable. For now just move the disabled code closer to the working
gpct functions.
I think they became obsolete when the ni_tio and ni_tiocmd modules were
implemented.
--
-=( Ian Abb
On Wed, May 28, 2014 at 09:49:21PM -0700, Chaitanya Hazarey wrote:
> static iw_handler r8192_private_handler[] = {
> - /* r8192_wx_set_monitor, */ /* SIOCIWFIRSTPRIV */
> r8192_wx_set_crcmon, /*SIOCIWSECONDPRIV*/
> - /* r8192_wx_set_forceassociate, */
The SIOCIWSECONDPRIV comment
On 2014-05-29 00:26, H Hartley Sweeten wrote:
Remove all the forward declarations and do a bit of cleanup to this
file.
H Hartley Sweeten (31):
staging: comedi: ni_mio_common: remove forward declaration 1
staging: comedi: ni_mio_common: remove forward declaration 2
staging: comedi: ni_m
From: David Daney
This prevents PHY not found types of errors for PHY drivers that are
probed after the Ethernet driver is probed, because the ifconfig UP is
done from userspace after all drivers have been probed.
Also avoid the cvmx-helper-board.c PHY code if a real PHY driver is
present, this
Fixes the below warnings:
drivers/staging/rtl8192ee/core.c:342:14: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
drivers/staging/rtl8192ee/core.c:344:11: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
Si
Reformat the comment describing this comedi driver to use the usual
block comment format.
Also remove reference to digital I/O emulating an 8255, because it
doesn't, and remove "DIO only" from the "Description:" line as it also
supports analog inputs.
Signed-off-by: Ian Abbott
---
drivers/stagi
I received a patch from the original author of the driver, Fred Brooks,
to add support for switching the input range and the
single-ended/differential input mode for the AI subdevice.
I used the patch as-is apart from minor whitespace fixes and
reformatting the changes to the driver description co
The first patch reformats (and slightly changes) the driver comment to
avoid checkpatch warnings for the second patch.
The second patch adds functionality to the AI subdevice and is the work
of the original author, Fred Brooks.
1) staging: comedi: ni_daq_700: update driver comment
2) staging: com
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/bcm/Bcmchar.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 606d5f5e9216..c1e01f7d64ba 100644
--- a/drivers/s
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_mlme.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 7170258d2601
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 27 +
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au
These days, I don't barely look at comedi changes at all because you
guys do such a great job. I just had a process/git comment on this one.
Normally, these changelogs look like:
From: Fred Brooks
Add support for switching the input range and the
single-ended/differential input mode for the AI
On 2014/05/29 12:51 PM, Dan Carpenter wrote:
> These days, I don't barely look at comedi changes at all because you
> guys do such a great job. I just had a process/git comment on this one.
> Normally, these changelogs look like:
>
> From: Fred Brooks
>
> Add support for switching the input ran
From: Fred Brooks
Add support for switching the input range and the single-ended/
differential input mode for the AI subdevice. We needed to clear the
FIFO of data before the conversion to handle card mode switching
glitches.
[ Minor whitespace fixes and driver comment reformatting. - Ian ]
S
staging: Emma Mobile USB driver and KZM9D board code V2
[PATCH v2 01/05] staging: emxx_udc: Add Emma Mobile USB Gadget driver
[PATCH v2 02/05] staging: emxx_udc: I/O memory and IRQ resource support
[PATCH v2 03/05] staging: emxx_udc: Add TODO file
[PATCH v2 04/05] staging: board: Initial board sta
From: Magnus Damm
Adjust the emxx_udc driver to make use of the standard
driver model to pass I/O memory and IRQ as resources
instead of hard coding those things in the driver.
Needs more work - the VBUS signal is yet not handled.
Signed-off-by: Magnus Damm
---
Changes since V1:
- None
dr
From: Magnus Damm
Add staging board base support to allow continuous upstream
in-tree development and integration of platform devices.
Helps developers integrate devices as platform devices for
device drivers that only provide platform device bindings.
This in turn allows for incremental develop
From: Magnus Damm
Add a TODO file for emxx_udc to show what is left to do.
Signed-off-by: Magnus Damm
---
Changes since V1:
- New patch
drivers/staging/emxx_udc/TODO |4
1 file changed, 4 insertions(+)
--- /dev/null
+++ work/drivers/staging/emxx_udc/TODO 2014-05-29 18:08:58.
From: Magnus Damm
Add staging board support for the KZM9D board and add
an emxx_udc platform device to allow in-tree continous
development of the driver on the KZM9D board.
When DT bindings are ready for the emxx_udc driver then
the platform device in the KZM9D staging board code can
easily be
On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
> --- /dev/null
> +++ work/drivers/staging/board/Kconfig2014-05-29 21:40:41.0
> +0900
> @@ -0,0 +1,7 @@
> +config STAGING_BOARD
> + boolean "Staging Board Support"
> + help
> + Select to enable per-board sta
Hi Dan,
On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
wrote:
> On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
>> --- /dev/null
>> +++ work/drivers/staging/board/Kconfig2014-05-29 21:40:41.0
>> +0900
>> @@ -0,0 +1,7 @@
>> +config STAGING_BOARD
>> + boolean "Sta
On Thu, May 29, 2014 at 10:27 PM, Magnus Damm wrote:
> Hi Dan,
>
> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
> wrote:
>> On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
>>> --- /dev/null
>>> +++ work/drivers/staging/board/Kconfig2014-05-29 21:40:41.0
>>> +0900
On Thu, 2014-05-29 at 22:53 +0900, Magnus Damm wrote:
> --- 0011/drivers/staging/board/Kconfig
> +++ work/drivers/staging/board/Kconfig2014-05-29 22:32:39.0 +0900
> @@ -1,5 +1,6 @@
> config STAGING_BOARD
> boolean "Staging Board Support"
> +depends on OF && OF_ADDRESS
I have
On Thu, May 29, 2014 at 04:01:27PM +0900, Daeseok Youn wrote:
> This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579.
>
> This patch removes kfree for serial_ports in dgap_tty_register_ports()
> if the "brd->printer_ports" allocation fails and serial_ports may be
> freed by calling dgap_tt
Ok I will edit PATCH[5/5] and resend.
On Thu, May 29, 2014 at 2:54 AM, Dan Carpenter wrote:
> On Wed, May 28, 2014 at 09:49:21PM -0700, Chaitanya Hazarey wrote:
>> static iw_handler r8192_private_handler[] = {
>> - /* r8192_wx_set_monitor, */ /* SIOCIWFIRSTPRIV */
>> r8192_wx_set_crcmo
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..ceb06d8 10
Fixed a misplaced brace in the r8192_wx_set_scan_type function.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
On Thursday, May 29, 2014 5:29 AM, Ian Abbott wrote:
> From: Fred Brooks
>
> Add support for switching the input range and the single-ended/
> differential input mode for the AI subdevice. We needed to clear the
> FIFO of data before the conversion to handle card mode switching
> glitches.
>
> [
On Thursday, May 29, 2014 4:16 AM, Ian Abbott wrote:
>
> Reformat the comment describing this comedi driver to use the usual
> block comment format.
>
> Also remove reference to digital I/O emulating an 8255, because it
> doesn't, and remove "DIO only" from the "Description:" line as it also
> supp
On Thursday, May 29, 2014 2:58 AM, Ian Abbott wrote:
> On 2014-05-29 00:26, H Hartley Sweeten wrote:
>> Remove all the forward declarations and do a bit of cleanup to this
>> file.
[snip]
>> drivers/staging/comedi/drivers/ni_mio_common.c | 4536
>>
>> 1 file changed,
These defines don't add any additional clarity to the addi_data drivers.
Just remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_common.h | 5 -
drivers/staging/comedi/drivers/addi_apci_035.c | 2 +-
This define is not used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_common.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/addi_common.h
b/drivers/staging/com
These macros don't add any additional clarity to the addi_data drivers.
Just remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_common.h | 3 ---
.../staging/comedi/drivers/addi-data/hwdrv_apci3120.c| 16
This member is set but never used. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_common.c | 10 +++---
drivers/staging/comedi/drivers/addi-data/addi_common.h | 1 -
drivers/staging/comedi/drivers/ad
Many of the ADDI-DATA drivers have been separated from the "addi_common"
code and cleaned up. Because of this cleanup there are some unnecessary
members hanging around in the private data struct and a number of defines
that don't add any sigificant clarity to the remaining drivers in the
addi-data
These defines don't add any additional clarity to the addi_data drivers.
They are also only used in the addi_apci_3120 driver. Just remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/addi_common.h | 3 ---
drivers/st
These defines don't add any additional clarity to the addi_data drivers.
Just remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_common.h | 7 --
.../comedi/drivers/addi-data/hwdrv_apci035.c | 9 +-
.../co
This define is only used in the pci_device_id table and doesn't add
any additional clarity to the code. Remove the define and just open
code the value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 4 +---
1 file chang
This define is only used in a comedi_error() message. The addition of
the driver name to the message is not necessary. Remove the define.
For aesthetics, convert the comedi_error() into a dev_dbg().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
A couple more cleanup patches for the adl_pci9111 driver.
H Hartley Sweeten (3):
staging: comedi: adl_pci9111: remove PCI9111_DRIVER_NAME define
staging: comedi: adl_pci9111: remove PCI9111_HR_DEVICE_ID define
staging: comedi: adl_pci9111: simplify A/D trigger selection code
drivers/stagin
The functions pci9111_trigger_source_set(), pci9111_pretrigger_set(),
and pci9111_autoscan_set() are all used to select the A/D trigger type.
They all do a read/mask/set/write of the A/D Trigger Mode Control register.
Simplify the code by removing these helper functions and combining all
the trigg
Introduce a helper function to return the number of bytes that are
ready to read/write from/to the comedi_async buffer. The "write to"
use doesn't really make much sense but is handled for completeness.
Use the helper function in the comedi drivers that currently do the
calculation as part of the
The Diamond Systems IR104-PBF board is a PC/104 module with 20
optoisolated inputs and 20 relay outputs.
This board can be supported by the pcl730 driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 1 +
drivers/staging
This addes support to comedi for a couple more Diamond Systems PC/104 boards.
The IR104-PBF board is a PC/104 module with 20 optoisolated inputs and 20 relay
outputs.
The ONYX-MM-DIO board is a PC/104 module with two 8255 chips providing 48
digital I/O channels.
H Hartley Sweeten (2):
staging
The Diamond Systems ONYX-MM-DIO board is a PC/104 module with two 8255
chips providing 48 digital I/O channels.
This board can be supported by the pcl724 driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/Kconfig | 15 ---
Add an (*insn_config) to the counter subdevice to allow the user to select
the clock source for the counters using the INSN_CONFIG_SET_CLOCK_SRC
instruction. The current selection can be queried with the instruction
INSN_CONFIG_GET_CLOCK_SRC.
Also, handle the INSN_CONFIG_RESET instruction to reset
psrtpriv->silent_reset_inprogress is always false.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_sreset.c|4
drivers/staging/rtl8188eu/include/rtw_sreset.h |1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c
b/dr
We can replace rtw_hal_sreset_reset_value() with rtw_hal_sreset_init() because
both function call sreset_reset_value() and sreset_init_value() respectively at
the end of code path, and function defination of sreset_reset_value() and
sreset_init_value() is identical.
Signed-off-by: navin patidar
-
silentreset_mutex initialized but not being used.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_sreset.c|1 -
drivers/staging/rtl8188eu/include/rtw_sreset.h |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c
b/driver
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
drivers/staging/rtl8188eu/include/hal_intf.h |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_in
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/hal_intf.c |6 --
drivers/staging/rtl8188eu/include/hal_intf.h |1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging/rtl8188eu/hal/hal_intf.c
index d0ac4a1..699
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_sreset.c|9 -
drivers/staging/rtl8188eu/include/rtw_sreset.h |1 -
2 files changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c
b/drivers/staging/rtl8188eu/core/rtw_sreset.c
inde
rtw_hal_sreset_xmit_status_check() is a wrapper to call
rtl8188e_sreset_xmit_status_check(), which calls
rtl8188e_silentreset_for_specific_platform() in case of transmission has
stopped to do a silent reset and restore the transmission but
rtl8188e_silentreset_for_specific_platform() has empty defi
Remove rtl8188e_sreset_xmit_status_check() and function pointer
->sreset_xmit_status_check pointing to it.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c| 35
drivers/staging
rtw_hal_sreset_linked_status_check() is a wrapper to call
rtl8188e_sreset_linked_status_check(), which doesn't do anything
useful.
rtl8188e_sreset_linked_status_check() will also be removed later.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |2 --
drivers/
Remove rtl8188e_sreset_linked_status_check() and function pointer
->sreset_linked_status_check pointing to it.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c | 17 -
drivers/stag
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile |1 -
drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c| 25 -
drivers/staging/rtl8188eu/include/rtl8188e_hal.h |3 +--
.../staging/rtl8188eu/include/rtl8188e_sreset.h| 28 -
rtw_hal_sreset_reset() is a wrapper to call
rtl8188e_silentreset_for_specific_platform(), which has empty defination.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_mlme.c |2 --
drivers/staging/rtl8188eu/hal/hal_intf.c |6 --
drivers/staging/rtl8188eu
Remove rtl8188e_silentreset_for_specific_platform() and function pointer
->silentreset pointing to it.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c |3 ---
drivers/staging/rtl8188eu/include/
Driver doesn't need Hal8188EReg.h file.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/Hal8188EReg.h | 46 ---
drivers/staging/rtl8188eu/include/odm_precomp.h |1 -
2 files changed, 47 deletions(-)
delete mode 100644 drivers/staging/rtl8188eu/includ
value stored in variable last_tx_complete_time isn't being used
by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_sreset.c |1 -
drivers/staging/rtl8188eu/include/rtw_sreset.h |1 -
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |5 -
3 files
value stored in variable last_tx_time isn't being used
by driver.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_sreset.c |1 -
drivers/staging/rtl8188eu/include/rtw_sreset.h |1 -
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |6 +-
3 files changed
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/usb_osintf.h |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/usb_osintf.h
b/drivers/staging/rtl8188eu/include/usb_osintf.h
index 9de99ca..2dce3bf 100644
--- a/drivers/staging/rtl8188eu/i
driver doesn't need usb_vendor_req.h.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/usb_osintf.h |1 -
drivers/staging/rtl8188eu/include/usb_vendor_req.h | 52
drivers/staging/rtl8188eu/os_dep/usb_intf.c|1 -
3 files changed, 54 del
The comedi drivers that use the ni_mio_common.c source share a private data
struct. This struct is defined in ni_stc.h as a macro so that the real driver
can add additional members to the struct. These additional members are not
actually needed since they are either unused or can be found when need
Remove all the unsed members from the private data for the ni mio drivers.
The ao0p and ao1p members are only used in the ni_ao_reset() function and
the code is commented out. Remove them, and the commented out code, as well.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartma
The {read,write}[bwl] macros used to access the registers in the ni_atmio,
ni_mio_cs, and ni_pcimio drivers and the included ni_mio_common.c file all
rely on a local variable having a specific name. They also require some of
the ni_mio_common code to need a __maybe_unused tag on the devpriv local
v
This macro is used to create the private data structure that is used by
the ni_atmio, ni_mio_cs, and ni_pcimio drivers. These drivers all include
the ni_mio_common.c source to provide most of the driver functionality.
The only driver specific information needed to convert the macro into a
proper s
On Wed, May 28, 2014 at 03:52:52PM +0900, Heesub Shin wrote:
> For aesthetics and readability, rename goto labels, remove
> useless code lines, and clarify function return type.
>
> Signed-off-by: Heesub Shin
> Reviewed-by: Mitchel Humpherys
> Tested-by: John Stultz
Not all of these would appl
On Wed, May 28, 2014 at 04:23:47PM -0700, Chaitanya Hazarey wrote:
> Fixed a misplaced brace in a function
>
> Signed-off-by: Chaitanya Hazarey
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Where is patch 2/2 ?
__
I have 1/5 through to 5/5. Will resend rightaway with slightly changed
subjects.
Chaitanya
On Thu, May 29, 2014 at 1:43 PM, Greg KH wrote:
> On Wed, May 28, 2014 at 04:23:47PM -0700, Chaitanya Hazarey wrote:
>> Fixed a misplaced brace in a function
>>
>> Signed-off-by: Chaitanya Hazarey
>> ---
Fixed a misplaced brace in the r8192_wx_set_scan_type function.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u
On Thu, May 29, 2014 at 09:43:27AM -0700, Chaitanya Hazarey wrote:
> Ok I will edit PATCH[5/5] and resend.
Sorry, I didn't mean that. It's a very minor thing and anyway you
didn't introduce it. I see you have already fixed this, but you could
have just fixed it up in a later patch.
I am always
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..ceb06d8 10
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192
On Thu, May 29, 2014 at 09:40:39AM +0300, Dan Carpenter wrote:
> On Thu, May 29, 2014 at 09:17:09AM +0900, DaeSeok Youn wrote:
> > Hi, Dan.
> >
> > 2014-05-28 19:11 GMT+09:00 Dan Carpenter :
> > > On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
> > >> > In your patch it has:
> > >> >
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
> I have 1/5 through to 5/5. Will resend rightaway with slightly changed
> subjects.
What does that have to do with patch 2/2 here?
On Thu, May 29, 2014 at 02:00:51PM -0700, Greg KH wrote:
> On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
> > I have 1/5 through to 5/5. Will resend rightaway with slightly changed
> > subjects.
>
> What does that have to do with patch 2/2 here? You sent a 1/2 patch, so
> obvi
I have reviewed this patchset.
Reviewed-by: Dan Carpenter
Btw, I wish you would fold some of these patches together next time.
For example, patches 3-6 are very closely related and they should have
just been one thing.
Or the times where the change log says, "I am going to delete function
frob_
Ok will be quite for till the last ones get accepted.
Sorry for the bother !
Chaitanya
On Thu, May 29, 2014 at 2:41 PM, Dan Carpenter wrote:
> On Thu, May 29, 2014 at 02:00:51PM -0700, Greg KH wrote:
>> On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
>> > I have 1/5 through t
On Fri, May 30, 2014 at 12:41:15AM +0300, Dan Carpenter wrote:
> On Thu, May 29, 2014 at 02:00:51PM -0700, Greg KH wrote:
> > On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
> > > I have 1/5 through to 5/5. Will resend rightaway with slightly changed
> > > subjects.
> >
> > What
On 05/29/2014 02:54 PM, abdoulaye berthe wrote:
Did you forget a changelog explaining why this is either needed, or even
a good idea? I joined the conversation late and don't know why you are
doing this.
Thanks,
David Daney
Signed-off-by: abdoulaye berthe
---
arch/arm/common/scoop.c
On Thu, May 29, 2014 at 11:54:52PM +0200, abdoulaye berthe wrote:
> Signed-off-by: abdoulaye berthe
Why?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, May 29, 2014 at 10:27:30PM +0900, Magnus Damm wrote:
> Hi Dan,
>
> On Thu, May 29, 2014 at 10:20 PM, Dan Carpenter
> wrote:
> > On Thu, May 29, 2014 at 10:17:32PM +0900, Magnus Damm wrote:
> >> --- /dev/null
> >> +++ work/drivers/staging/board/Kconfig2014-05-29
> >> 21:40:41.
Hi abdoulaye,
On Fri, 30 May 2014 01:16:22 +0200 abdoulaye berthe wrote:
>
> The aim of this patch is to make gpiochip_remove() behavior consistent,
> especially when issuing a remove request while the chipio chip is
> still requested. A patch has been submitted to change the return value of
> gp
On 05/30/2014 05:42 AM, Greg Kroah-Hartman wrote:
On Wed, May 28, 2014 at 03:52:52PM +0900, Heesub Shin wrote:
For aesthetics and readability, rename goto labels, remove
useless code lines, and clarify function return type.
Signed-off-by: Heesub Shin
Reviewed-by: Mitchel Humpherys
Tested-by:
struct ion_system_heap has an array for storing pointers to page pools
and it is allocated separately from the containing structure. There is
no point in allocating those two small objects individually, bothering
slab allocator. Using a variable length array simplifies code lines and
reduces overhe
ION system heap creates a temporary list of pages to build
scatter/gather table, introducing an internal data type, page_info. Now
that the order field has been removed from it, we do not need to depend
on such data type anymore.
Signed-off-by: Heesub Shin
Reviewed-by: Mitchel Humpherys
Tested-b
ION system heap uses an internal data structure, struct page_info, for
tracking down the meta information of the pages allocated from the pool.
Now that the pool returns compound pages, we don't need to store page
order in struct page_info.
Signed-off-by: Heesub Shin
Reviewed-by: Mitchel Humphery
Now that the pages returned from the pool are compound pages, we do not
need to pass the order information to free_buffer_page().
Signed-off-by: Heesub Shin
Reviewed-by: Mitchel Humpherys
Tested-by: John Stultz
---
drivers/staging/android/ion/ion_system_heap.c | 9 -
1 file changed, 4
1 - 100 of 111 matches
Mail list logo
