What Neil said.
On Fri, May 30, 2014 at 10:31:20PM -0600, Daniel Dressler wrote:
> From: danieru
This is wrong and we also get your name and email address from the
email headers so leave this line out.
>
> Following Greg Kroah-Hartman's newbie guide to hacking
> the linux kernel this patch add
On Fri, 30 May 2014 22:31:20 -0600 Daniel Dressler
wrote:
> From: danieru
>
> Following Greg Kroah-Hartman's newbie guide to hacking
> the linux kernel this patch addresses only coding style
> issues.
>
> Binder still has many too-long lines but I'm worried
> doing too much work in a single pa
From: danieru
Following Greg Kroah-Hartman's newbie guide to hacking
the linux kernel this patch addresses only coding style
issues.
Binder still has many too-long lines but I'm worried
doing too much work in a single patch is unfair to the
reviewers. So this patch address 20% of the file's
issu
On Fri, May 30, 2014 at 03:56:44PM +1000, Scott Weir wrote:
> On Wed, May 28, 2014 at 02:30:27PM -0700, Greg KH wrote:
> > On Wed, May 28, 2014 at 06:52:51PM +1000, Scott Weir wrote:
> > > This patch corrects coding style issue:
> > > WARNING: Missing a black line after declarations
> > >
> > > Si
On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote:
> On 05/30/2014 07:33 PM, David Daney wrote:
> >On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
> >>On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe
> >>wrote:
> >>>--- a/drivers/gpio/gpiolib.c
> >>>+++ b/drivers/gpio/gpiolib.c
On Fri 2014-05-30 17:44:26, Miguel Oliveira wrote:
> Inserted a blank line after a declaration.
>
> Signed-off-by: Miguel Oliveira
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
Sorry I didn't know staging patches should be based against
linux-next. Please disregard this patch and the previous one.
Best regards
Nicolas
On 30 May 2014 21:23, Christian Engelmayer wrote:
> On Fri, 30 May 2014 20:47:44 +0200, Nicolas Thery wrote:
>> Fix memory leaks in ioctl error handlin
On Fri, 30 May 2014 20:47:44 +0200, Nicolas Thery wrote:
> Fix memory leaks in ioctl error handling paths.
>
> Signed-off-by: Nicolas Thery
> ---
> drivers/staging/vt6656/hostap.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
This doesn't apply against staging-next.
The change
Fix memory leaks in ioctl error handling paths.
Signed-off-by: Nicolas Thery
---
drivers/staging/vt6656/hostap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c
index 506e5d3..a25bfef 100644
--- a/drivers
On Fri, May 30, 2014 at 11:20:05AM -0700, Thomas Wood wrote:
> When using scripts/checkpatch.pl, there are errors about trailing whitespace.
> Use scripts/cleanfile to remove these errors.
>
Someone already fixed these. Work against linux-next.
regards,
dan carpenter
_
On 05/30/2014 07:33 PM, David Daney wrote:
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe
wrote:
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct
gpio_chip *gpiochip)
When using scripts/checkpatch.pl, there are errors about trailing whitespace.
Use scripts/cleanfile to remove these errors.
Signed-off-by: Thomas Wood
---
drivers/staging/goldfish/goldfish_nand.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/goldfi
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote:
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe wrote:
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip
*gpiochip);
*
* A gpio_chip with any GPIOs stil
On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote:
> Move the function apci1564_interrupt() from hwdrv_apci1564.c to
> addi_apci_1564.c. On moving, for now just strip out all of the
> code for interrupts that the driver does not yet support at this
> time.
>
> Rename the variable ui_Interru
On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote:
> The board supported by this driver can generate an interrupt based
> on the state of input channels 0-15.
>
> The apci1564_di_config() function is used to configure which
> inputs are used to generate the interrupt. Currently this function
On Thursday, May 29, 2014 9:43 PM, Chase Southwood wrote:
> This board supports an interrupt that can be generated by an AND/OR
> combination of 16 of the input channels.
>
> Create a separate subdevice to handle this interrupt.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley
On Thursday, May 29, 2014 9:43 PM, Chase Southwood wrote:
> The addi_private struct defined in addi-data/addi_common.h is very bloated
> and contains many fields which addi_apci_1564 does not require. In the
> interest of eventually removing this driver's dependency on
> addi_common.h, we can crea
Inserted a blank line after a declaration.
Signed-off-by: Miguel Oliveira
---
drivers/staging/nokia_h4p/nokia_core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/nokia_h4p/nokia_core.c
b/drivers/staging/nokia_h4p/nokia_core.c
index 5e19cd6..775e1d0 100644
--- a/drivers
On Thursday, May 29, 2014 9:42 PM, Chase Southwood wrote:
> This member of the private data struct is only set at one location in the
> entire driver, and then never even used for anything. Let's just remove
> its use.
>
> Signed-off-by: Chase Southwood
> Cc: Ian Abbott
> Cc: H Hartley Sweeeten
On Thursday, May 29, 2014 9:42 PM, Chase Southwood wrote:
> The addi-data drivers use send_sig() to let the user know when an
> interrupt has occurred. The "standard" way to do this in the comedi
> subsystem is to have a subdevice that supports asynchronous commands
> and use comedi_event() to sign
On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote:
> > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> > + panic("gpio: removing gpiochip with gpios still
> > requested\n");
>
> panic?
>
> Is this likely to happen?
And while we're a
Ever since rtl8192u was added as a staging driver in v2.6.33 it contained
checks for CONFIG_IEEE80211_CRYPT_TKIP. But the Kconfig symbol
IEEE80211_CRYPT_TKIP was renamed to LIB80211_CRYPT_TKIP in v2.6.29. So
these checks have always evaluated to false. And these checks were rather
odd to begin with
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe wrote:
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip
> *gpiochip);
> *
> * A gpio_chip with any GPIOs still requested may not be removed.
> */
> -i
This avoids handling gpiochip remove error in device
remove handler.
Signed-off-by: abdoulaye berthe
---
drivers/gpio/gpiolib.c | 24 +++-
include/linux/gpio/driver.h | 2 +-
2 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/driver
When you do a v2 patchset, put a v2 in the subject and say which things
changed since v1. https://www.google.com/search?q=how+to+send+a+v2+patch
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproje
25 matches
Mail list logo
