Re: [PATCH] Staging/comedi: Fixes static analysis warning raised by sparse

On Tue, Jun 10, 2014 at 10:36:13PM +, Hartley Sweeten wrote: > On Monday, June 09, 2014 10:48 PM, Dan Carpenter wrote: > > On Mon, Jun 09, 2014 at 09:24:35PM -0400, Marcos A. Di Pietro wrote: > >> Fixes warning static analysis warning raised by sparse in > >> drivers/staging/comedi/drivers/ni_

Re: [PATCH 2/7] Staging: bcm: replaced member accessing by variable

On Tue, Jun 10, 2014 at 08:55:37PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/InterfaceInit.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/bcm/InterfaceInit.c > b/drivers/staging/bcm/Int

Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call

On Tue, Jun 10, 2014 at 10:48:35PM +0200, Rickard Strandqvist wrote: > Hi > > True! > Sorry :-( > > But then one would either operate strcpy outright. > > Or use strlcpy then the code would be: > > /* strlcpy() handles not include \0 */ > len = strlcpy(busid, buf + 4, BUSID_SIZE); > >

[PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues

Replaced 'printk' with 'netdev_' function Signed-off-by: A Raghavendra Rao --- drivers/staging/rtl8192e/dot11d.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c index 53da610..bfcc935 100644 ---

Re: [PATCH v2] Staging: bcm: Shortened lines

On Tue, Jun 10, 2014 at 08:09:29PM +0200, Matthias Beyer wrote: > - if (psIntfAdapter->bSuspended == TRUE || > psIntfAdapter->bPreparingForBusSuspend == TRUE) { > - BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, RDM, > DBG_LVL_ALL, "Bus is in suspended states hence RDM

Re: [PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues

On Wed, Jun 11, 2014 at 10:11:55AM +0530, A Raghavendra Rao wrote: > Replaced 'printk' with 'netdev_' function > > Signed-off-by: A Raghavendra Rao > --- > drivers/staging/rtl8192e/dot11d.c |9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8

[PATCH] Staging: rtl8192e: dot11d: Fixed printk coding style issues

Replaced 'printk' with 'netdev_' function Signed-off-by: A Raghavendra Rao --- drivers/staging/rtl8192e/dot11d.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c index 53da610..ef9da86 100644 --

Re: [PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues

On Wed, Jun 11, 2014 at 09:25:47AM +0530, A Raghavendra Rao wrote: > From: Raghavendra > > Fixed coding style issues Which specific coding style issue? Be exact please. And don't try to fix more than one type of coding style issue at a time... > > Signed-off-by: A Raghavendra Rao This name

Re: [PATCH 06/13] staging: rtl8188eu: Remove unused funtion _rtw_read_mem()

some times i get confused by one patch should do only one thing policy, for example this patch removes many other things along _rtw_read_mem(). But you are also right it's much easier to review when they are all folded together. I'm glad, i did it right this time. :) regards, navin patidar On Tu

[PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues

From: Raghavendra Fixed coding style issues Signed-off-by: A Raghavendra Rao --- drivers/staging/rtl8192e/dot11d.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c index 53da610..ef9da86 10064

RE: [PATCH] Staging/comedi: Fixes static analysis warning raised by sparse

On Monday, June 09, 2014 10:48 PM, Dan Carpenter wrote: > On Mon, Jun 09, 2014 at 09:24:35PM -0400, Marcos A. Di Pietro wrote: >> Fixes warning static analysis warning raised by sparse in >> drivers/staging/comedi/drivers/ni_stc.h >> >> warning: shift too big (4294967295) for type int > > This wa

Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call

Hi True! Sorry :-( But then one would either operate strcpy outright. Or use strlcpy then the code would be: /* strlcpy() handles not include \0 */ len = strlcpy(busid, buf + 4, BUSID_SIZE); /* busid needs to include \0 termination */ if (!(len < BUSID_SIZE)) return -E

[PATCH] staging: line6: do not return 0 from probe if no initialization done

There is a strange "return 0" in line6_probe() before any initialization of the module is done. It can lead to NULL pointer dereference in other functions. The patch proposes to return -ENODEV in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoro

[PATCH 5/6] Staging: bcm: Moved doubled if-block

This patch moves the doubled if block inside the retval-checking one level up. As the if-else-block it was in is now a one-statement if-else block, I removed the braces from it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 16 +--- 1 file changed, 5 insertions(+

[PATCH 0/6] Cleanup patches for bcm staging driver, DDRInit.c file

Hi, These are some patches for the drivers/staging/bcm/DDRInit.c file. The patchset contains: * Indention/Whitespace fixes * Line length fixes * Simplifying of logic Please notice: I'm not able to test these patches, as I do not have the appropriate hardware. I compiled them,

[PATCH 2/6] Staging: bcm: Indentation fixes

This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.

[PATCH 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 423bfd9..4564f40 100644 --- a/drivers/staging/bcm/DDRInit.c +++

[PATCH 1/6] Staging: bcm: Misc whitespace fixes

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index f1d7cb8..b4f0ea3 100644 --- a/drivers/staging/bcm/DDRInit.c +++ b/drivers/staging/bcm/

[PATCH 4/6] Staging: bcm: Fixed indention for inner if-block

The inner if-statement was aligned just like the outer one. Why? This indention was introduced by f34c488c3894968e8cdbdc3b1ed617d78315cace which is a indention-fix patch itself. That's why I'm curious about it. I did not merge these nested if-statements, as I don't know if I'm destroying lo

[PATCH 3/6] Staging: bcm: Lines shortened in ddr_init()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 176 -- 1 file changed, 134 insertions(+), 42 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 4c7f518..cfaa2c1 100644 --- a/drivers/staging/bcm/

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

Hi Tim, On Tue, Jun 10, 2014 at 3:54 PM, Tim Harvey wrote: > Fabio, > > I'm following along with this thread as I see the same thing you do on > our Ventana boards that support both LVDS and HDMI: without > hot-plugging the HDMI connector I get not HDMI out simply by having > the LVDS node popul

[PATCH 6/7] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff --

[PATCH 1/7] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b/

[PATCH 2/7] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..539f830 100644 --- a/drivers/staging/bcm/Interface

[PATCH 0/7] Cleanup patches for bcm staging driver

Hi, I did some cleanup patches on the drivers/staging/bcm/InterfaceInit.c file. I hope you like them. The cleanup contains: * Line shortenings * Merging of multi-line statements which fit in one line * Replacing member-accessing with variables * Outsourcing a code junk into

[PATCH 3/7] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 539f830..ab4c65a 100644 --- a/drivers/staging/bcm/Interf

[PATCH 4/7] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index ab4c65a..e334ca7 100644 --- a/drivers/

[PATCH 7/7] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index a1fa3d5..ea19436 100644 --- a/drivers/

[PATCH 5/7] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index e334ca7..19e0f17 100644 --- a/drivers/

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 9, 2014 at 7:29 AM, Fabio Estevam wrote: > On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux > wrote: > >> Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This >> should report the current state of the hotplug detection. > > /sys/class/drm/card0-HDMI-A-1/stat

[PATCH v2] Staging: bcm: Shortened lines

This patch fixes line lengths in the drivers/staging/bcm/InterfaceMisc.c file. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceMisc.c | 98 + 1 file changed, 67 insertions(+), 31 deletions(-) diff --git a/drivers/staging/bcm/InterfaceMisc

[PATCH] staging: r8192ee: avoid leaking format string

This makes sure a format string cannot leak into the work queue name nor the printk buffer. Signed-off-by: Kees Cook --- drivers/staging/rtl8192ee/base.c |2 +- drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) d

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Tue, Jun 10, 2014 at 2:04 PM, Russell King - ARM Linux wrote: > This diagram is drawn from the code in clk-imx6.c, and it does not > agree with what is in the SoC manuals - this is the representation > redrawn from the manuals: > The difference is, there is no clock gate between the LDB

Re: [PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues

On Tue, Jun 10, 2014 at 10:33:51PM +0530, Raghavendra wrote: > Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary. > Also fixed the coding issue cooresponding to line gap after the declarations. Please don't do multiple things in the same patch, a single patch should only do

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Tue, Jun 10, 2014 at 05:14:21PM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 10, 2014 at 04:13:06PM +0100, Russell King - ARM Linux wrote: > > where 'M' is the IPU DI clock muxer. However, we're currently setting > > this up as: > > > > LM --+ LDB serial > > `- /7

[PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues

Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary. Also fixed the coding issue cooresponding to line gap after the declarations. Signed-off-by: Raghavendra --- drivers/staging/rtl8192e/dot11d.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dr

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Tue, Jun 10, 2014 at 04:13:06PM +0100, Russell King - ARM Linux wrote: > where 'M' is the IPU DI clock muxer. However, we're currently setting > this up as: > > LM --+ LDB serial > `- /7 -+ LDB DI clock > IPM --- /N IM --- IPU DI clock > > and hoping that th

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Tue, Jun 10, 2014 at 09:58:54AM -0300, Fabio Estevam wrote: > Booting the kernel with the HDMI cable connected (no image is seen on > HDMI, only on LVDS): Reformatting a bit: > disp 0: panel size = 1920 x 1080 > Clocks: IPU 26400Hz DI 2400Hz Needed 13850Hz > IPU clock can give 13

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Tue, Jun 10, 2014 at 9:58 AM, Fabio Estevam wrote: > On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux > wrote: > >> Right, so the problem isn't at the HDMI level, but at the DI level... so >> that's where we need to debug what's being setup. I left some debugging >> in ipu-di.c - coul

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux wrote: > Right, so the problem isn't at the HDMI level, but at the DI level... so > that's where we need to debug what's being setup. I left some debugging > in ipu-di.c - could you try enabling that please? Booting the kernel with the HD

[PATCH v13 07/10] imx-drm: Use drm_display_mode timings flags.

The previous hardware behaviour was kept if the flags are not set. Signed-off-by: Denis Carikli --- ChangeLog v12->v13: - This patch doesn't need the DRM_MODE_FLAG_POL_*_PRESERVE flags anymore. - code cleanup to improve readability: - ENABLE_POL_PRESERVE is now gone - Less modifications in ip

[PATCH v13 06/10] drm: drm_display_mode: add signal polarity flags

We need a way to pass signal polarity informations between DRM panels, and the display drivers. To do that, a pol_flags field was added to drm_display_mode. Signed-off-by: Denis Carikli --- ChangeLog v12->v13: - Added Docbook documentation for pol_flags the struct field. - Removed the _PRESERV

[PATCH v13 10/10] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support.

Signed-off-by: Denis Carikli --- ChangeLog v11->v13: - No changes ChangeLog v9->v11: - Now uses the drm-panel instead of the display-timings. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - The backlight is now on at boot. ChangeLog v6->v7: - Shrinked even more

[PATCH v13 08/10] drm/panel: Add Eukrea mbimxsd51 displays.

Signed-off-by: Denis Carikli --- ChangeLog v12->v13: - Added a note explaining why the size is zero in the eukrea_mbimxsd51_dvi(s)vga structs. ChangeLog v11->v12: - Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names ChangeLog v10->v11: - New patch. --- .../bindings/panel/euk

[PATCH v13 09/10] ARM: dts: mbimx51sd: Add display support.

The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Signed-off-by: Denis Carikli --- ChangeLog v10->v13: - Rebased - Removed enable-active-high in reg_lcd_3v3: its GPIO already has the GPIO_ACTIVE_HIGH flag. Without this removal, the display was off at boot and powering it off and on was necessar

[PATCH v13 05/10] ARM: dts: imx5*, imx6*: correct display-timings nodes.

The imx-drm driver can't use the de-active and pixelclk-active display-timings properties yet. Instead the data-enable and the pixel data clock polarity are hardcoded in the imx-drm driver. So theses properties are now set to keep the same behaviour when imx-drm will start using them. Signed-off

[PATCH v13 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

That new macro is needed by the imx_drm staging driver for supporting the QVGA display of the eukrea-cpuimx51 board. Signed-off-by: Denis Carikli Acked-by: Mauro Carvalho Chehab Acked-by: Laurent Pinchart Acked-by: Philipp Zabel --- ChangeLog v10->v13: - No changes ChangeLog v9->v10: - Rebas

[PATCH v13 02/10] imx-drm: Add RGB666 support for parallel display.

Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v9->v13: - Rebased ChangeLog v8->v9: - Rebased. - Added Philipp Zabel's ack. - Shortened the patch title. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - Rebased. ChangeLog v7->v8: - Shrinked e

[PATCH v13 03/10] imx-drm: Correct BGR666 and the board's dts that use them.

The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v10->v13: - Rebased ChangeLog v9->v10: - Rebased. - Added Philipp Zabel's Ack. - Included Lothar Wa

[PATCH v13 04/10] imx-drm: use defines for clock polarity settings

Signed-off-by: Denis Carikli --- ChangeLog 12->v13: - No changes ChangeLog 11->v12: - Improved the define names to match the hardware: ENABLE_POL is not a clock signal but instead an enable signal. ChangeLog v9->v10: - New patch which was splitted out from: "staging: imx-drm: Use de-active an

Re: [PATCH] Staging: rtl8821ae: use kmalloc instead of variable length stack arrays

On Wed, Jun 04, 2014 at 07:45:45PM +0200, Remi Pommarel wrote: > This removes stack arrays of variable length and use kmalloc() instead, thus > removing the sparse warnings "Variable length array is used". > > Signed-off-by: Remi Pommarel > --- > drivers/staging/rtl8821ae/efuse.c | 38 ++

Re: [PATCH 06/13] staging: rtl8188eu: Remove unused funtion _rtw_read_mem()

Thanks. This is much nicer to review when they are all folded together like this. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: XVME 6300 with TSI148 bridge on 64 bit Debian (Linux 3.2.57) vme_user issue

I have added Martyn and Manohar to the CC list since they might know the answer. Are you using the latest kernel, btw? regards, dan carpenter On Wed, Jun 04, 2014 at 02:43:29PM -0700, Maurice Moss wrote: > Dear All, > > I came across the link here and decided to write to you, as I am > facing a