On Thu, Jun 12, 2014 at 04:17:36AM +, Nick Krause wrote:
> Here is the fixed patch as per Greg's recommendations. Unforunalty my email
> client removes tabs so I will have to be sending it as a patch file if that's
> Ok.
> Nick
HTML is rejected by the mailing lists, and we can't take a base64
On Thu, Jun 12, 2014 at 03:44:34AM +, Nick Krause wrote:
> Hey Fellow Developers,
> This is my first patch so if there are any errors please reply as i will
> fix them. Below is the patch.
> -- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939
> -0400
> +++ drivers/vme
Hey Fellow Developers,
This is my first patch so if there are any errors please reply as i will
fix them. Below is the patch.
-- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939
-0400
+++ drivers/vme/bridges/vme_ca91cx42.h 2014-06-11 23:15:36.027685173 -0400
@@ -526,7
On Wed, Jun 11, 2014 at 11:13:57PM +0200, Mathias Engan wrote:
> On Wed, Jun 11, 2014 at 01:50:51PM -0700, Greg KH wrote:
> > On Wed, Jun 11, 2014 at 10:23:09PM +0200, mathias.en...@gmail.com wrote:
> > > From: Mathias Engan
>
> > > static int eucr_suspend(struct usb_interface *iface, pm_message
On Thu, Jun 12, 2014 at 12:24:25AM +0300, Dan Carpenter wrote:
> Let's forward this to the Sparse mailing list.
>
> We're seeing a Sparse false positive testing
> drivers/staging/comedi/drivers/ni_pcimio.c.
>
> CHECK drivers/staging/comedi/drivers/ni_pcimio.c
> drivers/staging/comedi/drivers/
Let's forward this to the Sparse mailing list.
We're seeing a Sparse false positive testing
drivers/staging/comedi/drivers/ni_pcimio.c.
CHECK drivers/staging/comedi/drivers/ni_pcimio.c
drivers/staging/comedi/drivers/ni_stc.h:720:26: warning: shift too big
(4294967295) for type int
drivers/st
On Wed, Jun 11, 2014 at 01:50:51PM -0700, Greg KH wrote:
> On Wed, Jun 11, 2014 at 10:23:09PM +0200, mathias.en...@gmail.com wrote:
> > From: Mathias Engan
> > static int eucr_suspend(struct usb_interface *iface, pm_message_t message)
> > {
> > struct us_data *us = usb_get_intfdata(iface);
On Wed, Jun 11, 2014 at 10:23:09PM +0200, mathias.en...@gmail.com wrote:
> From: Mathias Engan
>
> Add blank lines after declarations in eucr_suspend and eucr_resume
> as reported by checkpatch.
>
> Signed-off-by: Mathias Engan
> ---
>
> This patch is a response to task 10 of the Eudyptula ch
From: Mathias Engan
Add blank lines after declarations in eucr_suspend and eucr_resume
as reported by checkpatch.
Signed-off-by: Mathias Engan
---
This patch is a response to task 10 of the Eudyptula challenge.
drivers/staging/keucr/usb.c |5 -
1 file changed, 4 insertions(+), 1 del
_rtw_write16() is a wrapper function, being used to call usb_write16().
Call usb_write16() directly and drop _rtw_write16().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c |2 +-
drivers/staging/rtl8188eu/core/rtw_io.c| 13
drivers/stag
Fixed open brace placement to address the following code-style errors:
ERROR: that open brace { should be on the previous line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 69 --
1 file changed, 23 insertions(+), 46 deletions(-)
Converted a C99 comment to fix the following error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile |1 -
drivers/staging/rtl8188eu/core/rtw_io.c | 53 --
drivers/staging/rtl8188eu/include/drv_types.h|1 -
drivers/staging/rtl8188eu/include/rtw_io.h | 36 --
_rtw_read8() is a wrapper function, being used to call usb_read8().
Call usb_read8() directly and drop _rtw_read8().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c|2 +-
drivers/staging/rtl8188eu/core/rtw_efuse.c| 24 +++---
drivers/staging/rtl8
_rtw_read32() is a wrapper function, being used to call usb_read32().
Call usb_read32() directly and drop _rtw_read32().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c | 14 ++---
drivers/staging/rtl8188eu/core/rtw_efuse.c |6 +-
drivers/staging
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |1 -
drivers/staging/rtl8188eu/include/rtw_io.h| 42 -
2 files changed, 43 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/includ
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c|1 +
drivers/staging/rtl8188eu/core/rtw_efuse.c|3 +--
drivers/staging/rtl8188eu/core/rtw_mp.c |2 +-
drivers/staging/rtl8188eu/core/rtw_mp_ioctl.c |2 +-
drivers/staging/rtl8
_rtw_read16() is a wrapper function, being used to call usb_read16().
Call usb_read16() directly and drop _rtw_read16().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c|2 +-
drivers/staging/rtl8188eu/core/rtw_io.c | 12
drivers/st
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/usb_ops_linux.h |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h
b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
index e722c45..0a6e5d0 100644
--- a/drivers/staging/rt
we have removed all rtw_[read,write]() function calls,
so no need to initialize structures used to build rtw_[read,write]
abstraction.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c | 16
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |4
_rtw_write32() is a wrapper function, being used to call usb_write32().
Call usb_write32() directly and drop _rtw_write32().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c|2 +-
drivers/staging/rtl8188eu/core/rtw_io.c | 12 ---
drivers/staging
_rtw_write_port() is a wrapper function, being used to call usb_write_port().
Call usb_write_port() directly and drop _rtw_write_port().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c| 16
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c |4
_rtw_write_port_cancel() is a wrapper function, being used to call
usb_write_port_cancel().
Call usb_write_port_cancel() directly and drop _rtw_write_port_cancel().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12
drivers/staging/rtl8188eu/hal/u
_rtw_read_port_cancel() is a wrapper function, being used to call
usb_read_port_cancel().
Call usb_read_port_cancel() directly and drop _rtw_read_port_cancel().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c | 12
drivers/staging/rtl8188eu/hal/usb_h
_rtw_read_port() is a wrapper function, being used to call usb_read_port().
use usb_read_port() directly and drop _rtw_read_port().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c | 20
drivers/staging/rtl8188eu/hal/usb_halinit.c |7 +--
intf_hdl is passed in usb_[read,write][8,16,32]() functions, which
is then passed to vender_request() there it's used to get adapter pointer,
so instead of passing intf_hdl we can directly pass adapter.
This change will also help in removing rtw_[read,write][8,16,32]() wrapper
functions being used
_rtw_writeN() is a wrapper function, being used to call usb_writeN().
Call usb_writeN() directly and drop _rtw_writeN().
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c | 13 -
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |4 ++--
drivers
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/rtw_io.h | 43
1 file changed, 43 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h
b/drivers/staging/rtl8188eu/include/rtw_io.h
index 4c8a8c1..5c76815 100644
--- a/drivers/stagi
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c| 17 -
drivers/staging/rtl8188eu/include/rtw_io.h |4
2 files changed, 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/drivers/staging/rtl8188eu/core/rtw_io.c
index ed6
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c| 13 -
drivers/staging/rtl8188eu/include/rtw_io.h |5 -
2 files changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/drivers/staging/rtl8188eu/core/rtw_io.c
index 420b84
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c| 13 -
drivers/staging/rtl8188eu/include/rtw_io.h |4
2 files changed, 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/drivers/staging/rtl8188eu/core/rtw_io.c
index 009dca5
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_io.c| 12
drivers/staging/rtl8188eu/include/rtw_io.h |4
2 files changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c
b/drivers/staging/rtl8188eu/core/rtw_io.c
index 292b6a1.
rect thing is to
> fix Sparse.
I don't think sparse has a way to query the version so I'm not sure. But, I
just pulled the latest from git://git.kernel.org/pub/scm/devel/sparse/sparse.git
and built that so now I _should_ have the latest version regardless.
With today's next-
drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’:
drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects
type ‘signed size_t’, but argument 6 has type ‘long int’
drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects
type ‘sig
On Sun, Jun 08, 2014 at 01:37:43PM -0700, David Rientjes wrote:
> > drivers/staging/rtl8821ae/rtl8821ae/hw.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c
> > b/drivers/staging/rtl8821ae/rtl8821ae/hw.c
> > index 1b8583b
Hi Russell,
Am Mittwoch, den 11.06.2014, 09:17 +0100 schrieb Russell King - ARM
Linux:
> On Tue, Jun 10, 2014 at 10:32:25AM -0300, Fabio Estevam wrote:
> > On Tue, Jun 10, 2014 at 9:58 AM, Fabio Estevam wrote:
> > > On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
> > > wrote:
> > >
> >
Geert Uytterhoeven writes:
> Gcc versions before 4.3 do not support -Wtype-limits:
>
> cc1: error: unrecognized command line option "-Wtype-limits"
>
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/staging/rtl8723au/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Museum s
Gcc versions before 4.3 do not support -Wtype-limits:
cc1: error: unrecognized command line option "-Wtype-limits"
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/rtl8723au/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/Makefile
b
On Wed, Jun 11, 2014 at 09:50:18AM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
> ---
> drivers/staging/bcm/InterfaceInit.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/bcm/InterfaceInit.c
> b/drivers/staging/bcm/Int
Hi Maurice,
On 04/06/14 22:43, Maurice Moss wrote:
Dear All,
I came across the link here and decided to write to you, as I am
facing a very similar problem:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-May/037941.html
With the above linux, I have recompiled the kernel
This patch fixes line lengths in the
drivers/staging/bcm/InterfaceMisc.c
file.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceMisc.c | 98 +
1 file changed, 67 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc
Hi,
I fixed what Dan suggested.
Kind regards,
Matthias Beyer
Matthias Beyer (2):
Staging: bcm: Shortened lines
Staging: bcm: InterfaceMisc.c: Outsourced doubled error checking
drivers/staging/bcm/InterfaceMisc.c | 125 ++--
1 file changed, 77 insertions(+),
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceMisc.c | 69 +
1 file changed, 31 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c
b/drivers/staging/bcm/InterfaceMisc.c
index fff7d68..a0f159e 100644
--- a/drivers/
On Wed, Jun 11, 2014 at 09:44:31AM +0200, Matthias Beyer wrote:
> Signed-off-by: Matthias Beyer
> ---
> drivers/staging/bcm/InterfaceMisc.c | 74
> ++---
> 1 file changed, 35 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/staging/bcm/InterfaceMisc.c
> b
On Tue, Jun 10, 2014 at 10:32:25AM -0300, Fabio Estevam wrote:
> On Tue, Jun 10, 2014 at 9:58 AM, Fabio Estevam wrote:
> > On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
> > wrote:
> >
> >> Right, so the problem isn't at the HDMI level, but at the DI level... so
> >> that's where we nee
Hi,
I'm so sorry, I forgot the "--in-reply-to" flag for this patchset. Do
you want me to resend with the appropriate flag?
On 11-06-2014 09:50:16, Matthias Beyer wrote:
> Hi,
>
> I fixed what Dan suggested.
>
> Please notice: I cannot test these patches. I compiled them successfully, but
> for
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index d61a688..039408d 100644
--- a/drivers/staging/bcm/Interface
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index 039408d..b6238f0 100644
--- a/drivers/staging/bcm/Interf
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 53 +++--
1 file changed, 27 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index b6238f0..4c26de1 100644
--- a/drivers/
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index 7c04c73..d61a688 100644
--- a/drivers/staging/bcm/InterfaceInit.c
+++ b/
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 43 +++--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index 4c26de1..3fb8f4a 100644
--- a/drivers/
Hi,
I fixed what Dan suggested.
Please notice: I cannot test these patches. I compiled them successfully, but
for testing I do not have the appropriate hardware.
Kind regards,
Matthias Beyer
Matthias Beyer (7):
Staging: bcm: Shortened some lines
Staging: bcm: replaced member accessing by va
This patch outsources a chunk of code which is for selecting an
alternate setting for highspeed modem into a new function.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 207 +++-
1 file changed, 112 insertions(+), 95 deletions(-)
diff --
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceInit.c | 47 ++---
1 file changed, 18 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index c7a2afe..b51f4e8 100644
--- a/drivers/
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceMisc.c | 74 ++---
1 file changed, 35 insertions(+), 39 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c
b/drivers/staging/bcm/InterfaceMisc.c
index fff7d68..51f6e1f 100644
--- a/drivers/
This patch fixes line lengths in the
drivers/staging/bcm/InterfaceMisc.c
file.
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/InterfaceMisc.c | 98 +
1 file changed, 67 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc
Hi,
I reworked what Dan suggested. I also added another patch which outsources a
chunk of code from the InterfaceRDM() and InterfaceRWM() functions, which was
doubled. I missed that one in the first place.
I hope you like the changes.
Kind regards,
Matthias Beyer
Matthias Beyer (2):
Staging:
On Tue, Jun 10, 2014 at 09:22:03PM +0200, Matthias Beyer wrote:
> The inner if-statement was aligned just like the outer one. Why?
>
> This indention was introduced by
>
> f34c488c3894968e8cdbdc3b1ed617d78315cace
>
> which is a indention-fix patch itself. That's why I'm curious about it.
>
58 matches
Mail list logo
