"remove" parameter is not used in dgap_parsefile().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 38749d0..c1f2798 100644
--- a/drivers/stag
firstminor in struct borad_t is always zero, so it
can be removed.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |9 -
drivers/staging/dgap/dgap.h |1 -
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
It should be called after dgap_tty_register_ports() is failed.
So channels which are allocated in dgap_tty_init() will be freed.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/d
dgap_free_irq() will free the irq which is requested in
dgap_request_irq().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index eab8fd5..497e6
dgap_tty_unregister() will unregister serial_driver
and print_driver, and also free related variables.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/d
dgap_after_config_loaded() as function name doesn't tell
what it does.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 4ea7a33..db8c93b 100644
dgap_free_flipbuf() will free flipbuf and flipflagbuf which
are allocated in dgap_alloc_flipbuf()
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
i
The dgap_firmware_load() has a lot of stuff beside
loding firmware. So some registering and initializing
for device are moved into dgap_init_one().
And also adds unwinding on error in dgap_init_one().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 81 ++-
The dgap_found_board() did request some memory region and
call ioremap, these should be released and unmaped
when one of functions which are called after dgap_found_board()
in dgap_init_one() is failed.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 14 +++---
1 files ch
On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
> dgap_tty_unregister() will unregister serial_driver
> and print_driver, and also free related variables.
>
Introducing a static function without a caller will cause a GCC warning
about unused functions.
Fold 5,7 and 8 together into
Hi, Dan
2014-06-13 17:00 GMT+09:00 Dan Carpenter :
> On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
>> dgap_tty_unregister() will unregister serial_driver
>> and print_driver, and also free related variables.
>>
>
> Introducing a static function without a caller will cause a GCC w
On Fri, Jun 13, 2014 at 04:43:37PM +0900, Daeseok Youn wrote:
> @@ -583,8 +585,51 @@ static int dgap_init_one(struct pci_dev *pdev, const
> struct pci_device_id *ent)
> if (rc)
> return rc;
>
> - dgap_numboards++;
> - return dgap_firmware_load(pdev, ent->driver_data);
On Fri, Jun 13, 2014 at 04:44:11PM +0900, Daeseok Youn wrote:
> The dgap_found_board() did request some memory region and
> call ioremap, these should be released and unmaped
> when one of functions which are called after dgap_found_board()
> in dgap_init_one() is failed.
>
Oh... Here you clean
On Fri, Jun 13, 2014 at 05:16:27PM +0900, DaeSeok Youn wrote:
> Hi, Dan
>
>
>
> 2014-06-13 17:00 GMT+09:00 Dan Carpenter :
> > On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
> >> dgap_tty_unregister() will unregister serial_driver
> >> and print_driver, and also free related varia
2014-06-13 17:38 GMT+09:00 Dan Carpenter :
> On Fri, Jun 13, 2014 at 05:16:27PM +0900, DaeSeok Youn wrote:
>> Hi, Dan
>>
>>
>>
>> 2014-06-13 17:00 GMT+09:00 Dan Carpenter :
>> > On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
>> >> dgap_tty_unregister() will unregister serial_driver
>
"remove" parameter is not used in dgap_parsefile().
Signed-off-by: Daeseok Youn
---
resend: reorder this series of patches
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 38
firstminor in struct borad_t is always zero, so it
can be removed.
Signed-off-by: Daeseok Youn
---
resend: reordering this series of patches
drivers/staging/dgap/dgap.c |9 -
drivers/staging/dgap/dgap.h |1 -
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers
It should be called after dgap_tty_register_ports() is failed.
So channels which are allocated in dgap_tty_init() will be freed.
Signed-off-by: Daeseok Youn
---
resend: reordering this series of patches
drivers/staging/dgap/dgap.c | 17 -
1 files changed, 16 insertions(+), 1 d
dgap_free_irq() will free the irq which is requested in
dgap_request_irq().
Signed-off-by: Daeseok Youn
---
resend: reordering this series of patches, because some patches are
merged to one.
drivers/staging/dgap/dgap.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --
dgap_after_config_loaded() as function name doesn't tell
what it does.
Signed-off-by: Daeseok Youn
---
resend: reordering this series of patches, becasue some patches
are merged into one.
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
The dgap_firmware_load() has a lot of stuff which are
unrelated with loading firmware.
So just moved to dgap_init_one().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 70 ---
1 files changed, 39 insertions(+), 31 deletions(-)
diff --git
The dgap_init_one() needs to handle error properly
if one of functions in dgap_init_one() is failed.
Introduce some functions for handling error in dgap_init_one()
- dgap_tty_unregister() : unregister tty driver
- dgap_free_flipbuf() : free flip buffer
- dgap_release_remap() : release memory re
Fix the sparse error: cast removes address space of expression.
---
Is that even correct? I haven't signed-off on it yet.
ethtool_ioctl() takes a (void *) as user data, dereferenced and assigend to u32.
applies to next-20140611
drivers/staging/vt6655/device_main.c |2 +-
1 file changed, 1 ins
Remove a totally unnecessary typedef. This is more readable now.
Signed-off-by: Martin Kepplinger
---
applies to next-20140611
drivers/staging/vt6655/card.c |2 +-
drivers/staging/vt6655/device.h |6 +++---
drivers/staging/vt6655/wmgr.c |2 +-
3 files changed, 5 insertions(+), 5
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 98343ff7..b87cd6b 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+
Hi, Greg
I scaned the git log of linux-next/drivers/staging. It seems all
patches for coding style clean up had been signed off/picked up by
you. Could you please sign or reject these patches?
I worte these patches for task 10 of Eudyptula Challenge.
thanks
On Thu, Jun 12, 2014 at 03:13:37PM
On Fri, Jun 13, 2014 at 10:59:30PM +0800, Real Name wrote:
> Hi, Greg
> I scaned the git log of linux-next/drivers/staging. It seems all
> patches for coding style clean up had been signed off/picked up by
> you. Could you please sign or reject these patches?
You sent these patches:
> On Thu,
Fix a coding style issue found by checkpatch.pl.
Use ether_addr_copy instead of memcpy.
Done to complete a eudyptula task.
Signed-off-by: Benedict Boerger
---
drivers/staging/slicoss/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c
On Fri, Jun 13, 2014 at 05:52:33PM +0200, Benedict Boerger wrote:
> Fix a coding style issue found by checkpatch.pl.
> Use ether_addr_copy instead of memcpy.
>
> Done to complete a eudyptula task.
>
> Signed-off-by: Benedict Boerger
>
> ---
> drivers/staging/slicoss/slicoss.c | 2 +-
> 1 file
On Fri, Jun 13, 2014 at 10:58:14PM +0800, Cheng-Wei Lee wrote:
> Signed-off-by: Quentin Lee
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c |4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
On Fri, 2014-06-13 at 10:15 -0700, Greg Kroah-Hartman wrote:
> On Fri, Jun 13, 2014 at 10:58:14PM +0800, Cheng-Wei Lee wrote:
> > Signed-off-by: Quentin Lee
[]
> > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> > @@ -3533,7 +3533,6 @@ static void hfa384x_usbin_rx(wlandevice_t
> > *wlandev
Simple coding style changes
This is for the Eudyptula Challenge task 10
Signed-off-by: Jeff Oczek
---
drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
Simple coding style changes
This is for Eudyptula Challenge task 10
Signed-off-by: Jeff Oczek
---
drivers/staging/tidspbridge/include/dspbridge/dblldefs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
b/drivers/s
On Fri, 2014-06-13 at 22:48 -0400, Jeff Oczek wrote:
> Simple coding style changes
[]
> diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
> b/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
[]
> @@ -168,11 +168,11 @@ struct dbll_attrs {
[]
> - s32(*fread) (void *,
This patch fixes below warning.
drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in assignment
(different address spaces)
drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype]
lpvBuff
drivers/staging/ced1401/ced_ioc.c:703:30:got char [noderef
35 matches
Mail list logo
