On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote:
> Checks if dev_skb_alloc returns Null in function, fw_download_code.
> If the return value of dev_skb_alloc is NULL return false and exit
> this function.
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192e/rtl8192e/r
On Sat, Jun 14, 2014 at 02:04:38PM +0900, Seunghun Lee wrote:
> This patch fixes below warning.
>
> drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in
> assignment (different address spaces)
> drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype]
> lpvBuf
On Wed, 2014-06-18 at 22:24 -0400, Nicholas Krause wrote:
> Checks if dev_skb_alloc returns Null in function, fw_download_code.
> If the return value of dev_skb_alloc is NULL return false and exit
> this function.
Hello Nicholas.
If you're going to try add these checks, please look at
the code a
From: Adithya Krishnamurthy
Fixed checkpatch "WARNING: Missing a blank line after declarations"
Signed-off-by: Adithya Krishnamurthy
---
drivers/staging/tidspbridge/core/chnl_sm.c |1 +
drivers/staging/tidspbridge/core/io_sm.c |1 +
drivers/staging/tidspbridge/core/tiom
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote:
> Checks if dev_skb_alloc returns Null in function, fw_download_code.
> If the return value of dev_skb_alloc is NULL return false and exit
> this function.
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192e/rtl8192e/r
Checks if dev_skb_alloc returns Null in function, fw_download_code.
If the return value of dev_skb_alloc is NULL return false and exit
this function.
Signed-off-by: Nicholas Krause
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/driver
On 06/18/2014 07:03 PM, Ulf Hansson wrote:
On 18 June 2014 12:08, micky wrote:
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17, micky wrote:
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 Ju
On Thu, Jun 19, 2014 at 12:07:38AM +, Naren (Narendra) Sankar wrote:
> We have EOL this part and have not been selling it for a while and there has
> been no new customer interest in a long time.
>
> So I am also ok with this moving off the kernel and being dropped.
Great, thanks for the qui
On Wed, Jun 18, 2014 at 07:10:30PM -0400, Nicholas Krause wrote:
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..1a90546 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/st
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -61,6 +61,10 @@ static bool fw
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -61,6 +61,10 @@ static bool fw
Most popular linux distro do not understand the need to have kernel and
userland in sync and because of this, the distros that actual use it will tend
to handle both kernel and userland themselves. As the userland cross section is
rather small now. I recommend that kernel drop it. It’s been an n
On Wed, Jun 18, 2014 at 06:23:00PM -0400, Nicholas Krause wrote:
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 11e915e..fde17ff 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/st
Variable reg is not initialized.
Random values are written to OMAP4 ISS registers if !ctx->eof_enabled.
Signed-off-by: Heinrich Schuchardt
---
drivers/staging/media/omap4iss/iss_csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss_csi2.c
On Thu, Jun 12, 2014 at 07:27:12PM +0400, Andrey Skvortsov wrote:
>
> Signed-off-by: Andrey Skvortsov
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c |8
This patch does not apply to my tree for one chunk. Can you please
refresh it against the staging-next branc
On Mon, Jun 16, 2014 at 08:59:45AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Wed, Jun 11, 2014 at 7:00 PM, Geert Uytterhoeven
> wrote:
> > drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’:
> > drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 11e915e..fde17ff 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -62,12 +62,15 @@ static bool f
On Sat, Jun 14, 2014 at 09:39:53PM +0200, Benedict Boerger wrote:
> fix two Missing blank line after declarations issue reported by checkpatch.pl
>
> Done to complete an eudyptula task.
>
> Signed-off-by: Benedict Boerger
> ---
> drivers/staging/keucr/usb.c | 2 ++
> 1 file changed, 2 insertion
On Sun, Jun 08, 2014 at 02:26:20PM +0530, Adithya Krishnamurthy wrote:
> From: Adithya Krishnamurthy
>
> Fixed checkpatch "WARNING: Missing a blank line after declarations"
>
> Signed-off-by: Adithya Krishnamurthy
> ---
> drivers/staging/tidspbridge/core/chnl_sm.c |1 +
> drivers/sta
Signed-off-by: Nicholas Krause
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/sta
On Wed, Jun 18, 2014 at 05:26:18PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4
> 1 file changed, 4 insertions(+)
Some more meta-comments. Your subject: should give people a clue as to
where in the kernel yo
On Thu, Jun 05, 2014 at 01:11:26PM +0100, Ian Abbott wrote:
> Signed-off-by: Ian Abbott
> ---
> I was originally going to put it in comedidev.h but as that gets passed
> through the compiler more often, I thought it would be better in
> comedi_buf.c.
Stripping out comments is fast, please put it
On Tue, Jun 03, 2014 at 09:33:37PM -0500, Chase Southwood wrote:
> This member of the private data struct is only set at one location in the
> entire driver, and then never even used for anything. Let's just remove
> its use.
>
> Signed-off-by: Chase Southwood
> Reviewed-by: Ian Abbott
> Cc: H
On Thu, May 29, 2014 at 11:41:53PM -0500, Chase Southwood wrote:
> The addi-data drivers use send_sig() to let the user know when an
> interrupt has occurred. The "standard" way to do this in the comedi
> subsystem is to have a subdevice that supports asynchronous commands
> and use comedi_event()
On Thu, May 29, 2014 at 01:29:26PM +0100, Ian Abbott wrote:
> From: Fred Brooks
>
> Add support for switching the input range and the single-ended/
> differential input mode for the AI subdevice. We needed to clear the
> FIFO of data before the conversion to handle card mode switching
> glitches
On Thu, May 29, 2014 at 04:47:00PM +, Hartley Sweeten wrote:
> On Thursday, May 29, 2014 5:29 AM, Ian Abbott wrote:
> > From: Fred Brooks
> >
> > Add support for switching the input range and the single-ended/
> > differential input mode for the AI subdevice. We needed to clear the
> > FIFO o
Signed-off-by: Nicholas Krause
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/sta
On Wed, Jun 18, 2014 at 10:24:56PM +0200, Jes Sorensen wrote:
> Greg KH writes:
> > On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote:
> >> From: Jes Sorensen
> >>
> >> Hi Greg,
> >>
> >> A smaller set of patches this time. It's mainly cleanups, removal of
> >> yet more lo
Greg KH writes:
> On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> Greg,
>>
>> Thanks for pushing my other changes to Linus. This set goes on top of
>> the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you
>> prefer I go back an
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Greg,
>
> Thanks for pushing my other changes to Linus. This set goes on top of
> the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you
> prefer I go back and submit it all as one lar
So sorry Greg,
I pulled the git in this morning for kernel-3.16-r2 ,I will resend the
patch from the clean tree.
I will also fix the tabs.'
Sorry :( Nick
On Wed, Jun 18, 2014 at 2:14 PM, Greg KH wrote:
> On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote:
>> Signed-off-by: Nicholas K
Greg KH writes:
> On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> Hi Greg,
>>
>> A smaller set of patches this time. It's mainly cleanups, removal of
>> yet more locally duplicated structs, and some endian fixes. Note the
>> endian fixes shou
Greg KH writes:
> On Tue, Jun 03, 2014 at 11:41:22PM +0200, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> commit 2dc5e6e90892d7247fbe8c25714dba3c0ba744e8
>
> That commit is in your tree, not Linus's :)
>
> I'll edit it with the proper number now...
Thanks, appreciate it!
Cheers,
J
On Tue, Jun 03, 2014 at 11:41:22PM +0200, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> commit 2dc5e6e90892d7247fbe8c25714dba3c0ba744e8
That commit is in your tree, not Linus's :)
I'll edit it with the proper number now...
___
devel mailing
On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Hi Greg,
>
> A smaller set of patches this time. It's mainly cleanups, removal of
> yet more locally duplicated structs, and some endian fixes. Note the
> endian fixes shouldn't really cause an urge
v2: removed braces from if statement
If ieee == NULL we jump to rx_dropped. Therefore we have to check again,
if ieee == NULL before we use it.
Signed-off-by: Andreas Platschek
---
drivers/staging/rtl8192e/rtllib_rx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driv
On Wed, Jun 18, 2014 at 06:16:09PM +, Andreas Platschek wrote:
> If ieee == NULL we jump to rx_dropped. Therefore we have to check again,
> if ieee != NULL before we use it.
Take a look at the caller as well. It doesn't check ieee for NULL so
probably this can never be NULL. How would that m
v2: removed braces from if statement
If ieee == NULL we jump to rx_dropped. Therefore we have to check again,
if ieee == NULL before we use it.
Signed-off-by: Andreas Platschek
---
drivers/staging/rtl8192e/rtllib_rx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driv
There was significant work done out-of-tree, and I believe possibly
posted, but never accepted, and some work has continued there, I
believe, but I've not had the time or energy to work on that code in a
few years myself. I'd say just drop it, most people that care about
video acceleration just
On Wed, Jun 18, 2014 at 11:16 AM, Andreas Platschek
wrote:
>
> rx_dropped:
> -ieee->stats.rx_dropped++;
> +if (ieee != NULL) {
> +ieee->stats.rx_dropped++;
> +}
> return 0;
Style nit: don't use braces around a single statement.
Tina
If ieee == NULL we jump to rx_dropped. Therefore we have to check again,
if ieee != NULL before we use it.
Signed-off-by: Andreas Platschek
---
drivers/staging/rtl8192e/rtllib_rx.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/dr
On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> b/driv
Signed-off-by: Nicholas Krause
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 11e915e..fde17ff 100644
-
On Wed, Jun 18, 2014 at 02:10:21PM +0200, Tobias Klauser wrote:
> No need for two return statements, just call xillybus_do_cleanup() in
> case of an error before returning.
>
> Signed-off-by: Tobias Klauser
> ---
> drivers/staging/xillybus/xillybus_pcie.c |7 ++-
> 1 file changed, 2 inse
Two Kconfig entries default to (uppercase) "N". It was clearly intended
to use "default n". But since (lowercase) "n" is the default anyway,
these lines might as well be removed.
Reported-by: Martin Walch
Signed-off-by: Paul Bolle
---
Tested with "make menuconfig"and "make oldconfig". I think Ma
Hi Eli
On 2014-06-18 at 14:30:35 +0200, Eli Billauer wrote:
> Hello,
>
> Thanks for the patch. However in the patch I'm trying to push,
> xillybus_do_cleanup() is eliminated completely from the code (with
> no success so far, because it depends on inserting a patch that adds
> a devres version o
Hello,
Thanks for the patch. However in the patch I'm trying to push,
xillybus_do_cleanup() is eliminated completely from the code (with no
success so far, because it depends on inserting a patch that adds a
devres version of dma_map_single).
See https://lkml.org/lkml/2014/6/1/10
So your pa
No need for two return statements, just call xillybus_do_cleanup() in
case of an error before returning.
Signed-off-by: Tobias Klauser
---
drivers/staging/xillybus/xillybus_pcie.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xillybus/xillybus_pcie
Hi Ganesan and Jayachandran,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving netlogic out of staging in
over a year. Are there any plans to clean it up and move it out soon?
Because otherwise we're going to have to delete the driv
Hi Al,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving keucr out of staging in over
a year. Are there any plans to clean it up and move it out soon? Because
otherwise we're going to have to delete the driver, as we don't want
stag
Hi David,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving frontier out of staging in
over a year. Are there any plans to clean it up and move it out soon?
Because otherwise we're going to have to delete the driver, as we don't
wan
Hi Naren, Jarod, Scott, Manu,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving crystalhd out of staging in
over a year. Are there any plans to clean it up and move it out soon?
Because otherwise we're going to have to delete the dr
Hi Alois,
I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
nobody seems to have worked towards moving ced1401 out of staging in
over a year. Are there any plans to clean it up and move it out soon?
Because otherwise we're going to have to delete the driver, as we don't
want
On 18 June 2014 12:08, micky wrote:
> On 06/18/2014 03:39 PM, Ulf Hansson wrote:
>>
>> On 18 June 2014 03:17, micky wrote:
>>>
>>> On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky wrote:
>
> On 06/16/2014 08:40 PM, Ulf Hansson wrote:
>>
>> On 16 J
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17, micky wrote:
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7
On Mon, 16 Jun 2014, Ulf Hansson wrote:
> On 16 June 2014 14:20, Lee Jones wrote:
> >> From: Micky Ching
> >>
> >> rtsx driver using a single function for transfer data, dma map/unmap are
> >> placed in one fix function. We need map/unmap dma in different place(for
> >> mmc async driver), so add
On 18 June 2014 03:17, micky wrote:
> On 06/17/2014 03:45 PM, Ulf Hansson wrote:
>>
>> On 17 June 2014 03:04, micky wrote:
>>>
>>> On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky wrote:
>
> On 06/16/2014 04:42 PM, Ulf Hansson wrote:
>>>
>>> @@ -3
Greg KH writes:
> On Wed, Jun 18, 2014 at 12:15:46AM -0700, Greg KH wrote:
>> On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote:
>> > Greg KH writes:
>> > > On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
>> > >> From: Jes Sorensen
>> > >>
>> > >> Signed-off-
On Wed, Jun 18, 2014 at 12:15:46AM -0700, Greg KH wrote:
> On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote:
> > Greg KH writes:
> > > On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
> > >> From: Jes Sorensen
> > >>
> > >> Signed-off-by: Jes Sorensen
> > >>
On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote:
> Greg KH writes:
> > On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
> >> From: Jes Sorensen
> >>
> >> Signed-off-by: Jes Sorensen
> >> ---
> >> drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29
> >> +++
Greg KH writes:
> On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote:
>> From: Jes Sorensen
>>
>> Signed-off-by: Jes Sorensen
>> ---
>> drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29
>> +-
>> 1 file changed, 14 insertions(+), 15 deletions(-)
61 matches
Mail list logo