[PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue

2014-06-19 Thread Andrey Skvortsov
From: Andrey Skvortsov andrej.skvort...@gmail.com Signed-off-by: Andrey Skvortsov andrej.skvort...@gmail.com --- Changes since PATCHv1: I refreshed patch against the staging-next branch of the staging.git tree and added some other coding style fixes as separate patches.

[PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue

2014-06-19 Thread Andrey Skvortsov
From: Andrey Skvortsov skvortsov...@summatechnology.ru Signed-off-by: Andrey Skvortsov andrej.skvort...@gmail.com --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCHv2 2/3] staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers

2014-06-19 Thread Andrey Skvortsov
From: Andrey Skvortsov skvortsov...@summatechnology.ru Signed-off-by: Andrey Skvortsov andrej.skvort...@gmail.com --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/20] staging: rtl8723au: Save timestamp for network in collect_bss_info() and report it to the stack

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 drivers/staging/rtl8723au/include/wlan_bssdef.h | 1 + drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 3 ++- 3 files changed, 7

[PATCH 16/20] staging: rtl8723au: issue_assocreq(): Use struct ieee80211_mgmt to build assoc_req frame

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 38 +++ 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 17/20] staging: rtl8723au: rtw_get_bcn_info23a(): Use capability from wlan_bssid_ex

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This eliminates yet another user of rtw_get_capability23a_from_ie() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 00/20] staging-next: rtl8723au: Improve connection parameter management

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Greg, Please find attached my current set of 8723au pending changes for staging-next. This set primarily improves the handling of connection parameters obtained from the received beacon frame and reduces the constant traversal of the saved frame. It

[PATCH 11/20] staging: rtl8723au: ConstructBeacon(): Use struct ieee80211_mgmt to build beacon

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This gets rid of a bunch of hard coded offsets and reduces the dependency of the ugly rtw_get_*_from_ie() functions. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 37 +++-

[PATCH 15/20] staging: rtl8723au: issue_assocrsp(): Use capability from struct wlan_bssid_ex

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 12/20] staging: rtl8723au: issue_beacon23a(): Do not copy IEs in front of beacon data

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Not sure how this happened, but one should never copy the IEs in front of the beacon frame info. This could lead to some nasty corrupted beacon frames hitting the wire if running AP mode - ouf! Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 09/20] staging: rtl8723au: Update bss beacon info in rtw_add_beacon()

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Pull out the core info beacon_interval, capability, and tsf and update cur_network.network with the info in rtw_add_beacon() instead of relying on it being in -IEs. This will help later when getting rid of the beacon struct info from -IEs and only

[PATCH 20/20] staging: rtl8723au: Eliminate last rtw_get_beacon_interval*() usage

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c| 5 - drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 4 ++-- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 8

[PATCH 06/20] staging: rtl8723au: rtw_cfg80211_inform_bss(): Use the capability info we already saved

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com No point in pulling capability info out of the IE array when it's already stored in struct wlan_bssid_ex Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 +-- 1 file changed, 1

[PATCH 14/20] staging: rtl8723au: issue_probersp(): Do not copy the IEs in front of probe_resp data

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Another case where the driver was copying IEs in front of the probe_resp data in the management frame, when running in AP mode. This would result in badly corrupted frames hitting the wire - ouf ouf ouf! Signed-off-by: Jes Sorensen

[PATCH 05/20] staging: rtl8723au: collect_bss_info(): Save capability in struct wlan_bssid_ex

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 16 +--- drivers/staging/rtl8723au/include/wlan_bssdef.h | 1 + 2 files changed, 10 insertions(+), 7 deletions(-) diff --git

[PATCH 18/20] staging: rtl8723au: rtw_get_bcn_info23a(): Use __func__ in debug prints

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH 13/20] staging: rtl8723au: issue_beacon23a(): Use struct ieee80211_mgmt to build beacon

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Why on Earth we have two functions in the driver constructing beacon frames is beyond me ... but one step at a time Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 42 +--

[PATCH 02/20] staging: rtl8723au: rtw_cfg80211_inform_bss(): Use cfg80211_inform_bss()

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com There is no point in creating a fake beacon frame to call cfg80211_inform_bss_frame() when we can just call cfg80211_inform_bss() with the parameters we were sticking into the fake frame. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 07/20] staging: rtl8723au: struct wlan_bssid_ex: Rename BeaconPeriod to beacon_interval

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This is to be more consistent mapping the names in wlan_bssid_ex to those in struct ieee80211_mgmt. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 4 ++--

[PATCH 10/20] staging: rtl8723au: is_same_network23a(): Use the capability info from wlan_bssid_ex

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We already have the capability info in struct wlan_bssid_ex, no point in searching for it once again. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 08/20] staging: rtl8723au: rtw_add_beacon(): Replace magic constant with appropriate struct size

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 04/20] staging: rtl8723au: rtw_cfg80211_inform_bss(): Report the beacon interval already retrieved

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Use the beacon interval we already retreived in collect_bss_info() instead of pulling it out of the saved IE array again. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++- 1 file

[PATCH 01/20] staging: rtl872au: rtw_cfg80211_inform_bss(): timestamp isn't used

2014-06-19 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 2/6] staging: comedi: ni_stc.h: cleanup ni_e_series_enable_second_irq()

2014-06-19 Thread H Hartley Sweeten
This function is used to enable/disable the second irq on NI e-series boards. This irq used used to generate dma requests for the counters. There are only 2 counters (NUM_GPCT) so the default case of the switch can never occur. Tidy up this function and remove the unreachable BUG().

[PATCH 5/6] staging: comedi: ni_stc.h: remove read/write callbacks from ni_private

2014-06-19 Thread H Hartley Sweeten
The drivers that include ni_mio_common.c set the read/write callbacks to private functions that handle the read/write operations in the correct manner for the hardware. The ni_atmio and ni_mio_cs drivers use ioport register access and the ni_pcimio driver uses memory mapped register access. The

[PATCH 6/6] staging: comedi: ni_stc.h: remove stc read/write callbacks from ni_private

2014-06-19 Thread H Hartley Sweeten
The drivers that include ni_mio_common.c set the stc register read/write callbacks to private functions that handle the read/write operations in the correct manner for the hardware. The ni_atmio and ni_mio_cs drivers use identical code to handle the operations. The ni_pcimio driver is a bit

[PATCH 4/6] staging: comedi: ni_mio_common.c: wrap the read/write operations

2014-06-19 Thread H Hartley Sweeten
The ni_atmio, ni_pcimio, and ni_mio_cs drivers all include this source file to handle the common functionality of the drivers. Each of those drivers set some function pointers in the private data to handle the read/write operations to the normal registers. Like done for the stc register

[PATCH 1/6] staging: comedi: ni_stc.h: add a 'is_m_series' flag to private data

2014-06-19 Thread H Hartley Sweeten
The (board-reg_type ni_reg_m_series_mask) test is commonly used in ni_mio_common.c to detect if the driver is being used with a National Instruments M series DAQ board. Simplify the code a bit by adding an 'is_m_series' bit-field flag to the private data. Signed-off-by: H Hartley Sweeten

[PATCH] staging: sep: Fix checkpatch.pl warnings

2014-06-19 Thread Benedict Boerger
Fix checkpatch.pl warnings: Missing blank line after Declarations Signed-off-by: Benedict Boerger benedict.boer...@cs.tu-dortmund.de --- drivers/staging/sep/sep_crypto.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/staging/sep/sep_crypto.c

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Nick Krause
Hey guys, Sorry about no reply, my power supply died last night, have to get a new one. I will be RMAing the old old in order to get a packup in case this PSU dies. Cheers Nick On Thu, Jun 19, 2014 at 1:29 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Wed, Jun 18, 2014 at 10:24:41PM

lustre virtual block device doesn't build w/ CONFIG_ARM64_64K_PAGES=y

2014-06-19 Thread dann frazier
With current git, lustre fails to build with CONFIG_ARM64_64K_PAGES=y and CONFIG_LUSTRE_LLITE_LLOOP=m: make -f scripts/Makefile.build obj=drivers/staging/lustre/lustre/llite gcc -Wp,-MD,drivers/staging/lustre/lustre/llite/.lloop.o.d -nostdinc -isystem

Re: lustre virtual block device doesn't build w/ CONFIG_ARM64_64K_PAGES=y

2014-06-19 Thread Greg KH
On Thu, Jun 19, 2014 at 12:33:21PM -0600, dann frazier wrote: With current git, lustre fails to build with CONFIG_ARM64_64K_PAGES=y and CONFIG_LUSTRE_LLITE_LLOOP=m: make -f scripts/Makefile.build obj=drivers/staging/lustre/lustre/llite gcc

[PATCH] Checks if dev_skb_alloc returns Null in function,

2014-06-19 Thread Nicholas Krause
--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 ---

[PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Nicholas Krause
--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..d8a9427 100644 ---

Re: [PATCH 2/8] wlan-ng/prism2mgmt:checkpatch: Fix string split

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:14PM +0200, Johannes Stadlinger wrote: This patch fixes all warnings of checkpatch about string splitting. Signed-off-by: Johannes Stadlinger johannes.stadlin...@fau.de Signed-off-by: Maximilian Eschenbacher maximilian@eschenbacher.email CC:

Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote: This patch inserts a blank line after a declaration to avoid checkpatch warning. Signed-off-by: Johannes Stadlinger johannes.stadlin...@fau.de Signed-off-by: Maximilian Eschenbacher maximilian@eschenbacher.email CC:

Re: [PATCH 4/8] wlan-ng/prism2mib:checkpatch: Fix string split

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:16PM +0200, Johannes Stadlinger wrote: This patch fixes a warning of checkpatch about string splitting. Signed-off-by: Johannes Stadlinger johannes.stadlin...@fau.de Signed-off-by: Maximilian Eschenbacher maximilian@eschenbacher.email CC:

Re: [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:17PM +0200, Johannes Stadlinger wrote: This patch inserts blank lines after declarations to avoid checkpatch warning. After our fixes in 'wlan-ng/prism2mib.c' there are still two checkpatch warnings about lines over 80 characters remaining. Signed-off-by:

Re: [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:18PM +0200, Johannes Stadlinger wrote: This patch fixes all warning of checkpatch about lines over 80 characters. Signed-off-by: Johannes Stadlinger johannes.stadlin...@fau.de Signed-off-by: Maximilian Eschenbacher maximilian@eschenbacher.email CC:

Re: [PATCH 7/8] wlan-ng/prism2sta:checkpatch: Fix string split

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:19PM +0200, Johannes Stadlinger wrote: This patch fixes a warning of checkpatch about string splitting. Signed-off-by: Johannes Stadlinger johannes.stadlin...@fau.de Signed-off-by: Maximilian Eschenbacher maximilian@eschenbacher.email CC:

Re: [PATCH 8/8] wlan-ng/prism2sta:checkpatch: Insert blank lines

2014-06-19 Thread josh
On Thu, Jun 19, 2014 at 09:20:20PM +0200, Johannes Stadlinger wrote: This patch inserts blank lines after declarations to avoid checkpatch warnings. After our fixes in 'wlan-ng/prism2sta' there is still a checkpatch warning about prefering 'ether_addr_copy' instead of 'memcpy' remaining.

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
Hey Guys, So Sorry about wasting your time with bad patchs. I feel bad about that. I hope this patch is O.K. now. :( Nicholas Krause On Thu, Jun 19, 2014 at 4:18 PM, Nicholas Krause xerofo...@gmail.com wrote: Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns

Re: [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 21:20 +0200, Johannes Stadlinger wrote: This patch fixes all warning of checkpatch about lines over 80 characters. trivia: diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c [] @@ -1271,7 +1275,8 @@ void

Re: [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 13:14 -0700, j...@joshtriplett.org wrote: On Thu, Jun 19, 2014 at 09:20:17PM +0200, Johannes Stadlinger wrote: This patch inserts blank lines after declarations to avoid checkpatch warning. [] diff --git a/drivers/staging/wlan-ng/prism2mib.c

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote: Hey Guys, So Sorry about wasting your time with bad patchs. I feel bad about that. I hope this patch is O.K. now. :( It's not. diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote: Hey Guys, So Sorry about wasting your time with bad patchs. I feel bad about that. I hope this patch is O.K. now. :( Oh, one other thing... diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c

[PATCH] staging: iio: kernel style neatening

2014-06-19 Thread Federico Di Pierro
Hi! I've finally found some spare time from my studies to sit back and try again this eudyptula challenge task. This is a very small patch that fixes 3 little coding style problems. I'm using linux-next. Signed-off-by: Federico Di Pierro nierr...@gmail.org ---

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
Thanks Joe, I need to read my patches more carefully. Nick :) On Thu, Jun 19, 2014 at 4:53 PM, Joe Perches j...@perches.com wrote: On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote: Hey Guys, So Sorry about wasting your time with bad patchs. I feel bad about that. I hope this patch is

[PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nicholas Krause
Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to returning true of false directly. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 7

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 15:29 -0400, Nicholas Krause wrote: diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c [] @@ -59,7 +58,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,

Re: [PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed one misplaced brace

2014-06-19 Thread Greg KH
On Thu, May 29, 2014 at 01:45:17PM -0700, Chaitanya Hazarey wrote: Fixed a misplaced brace in the r8192_wx_set_scan_type function. Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/rtl8192u/r8192U_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented dead code

2014-06-19 Thread Greg KH
On Thu, May 29, 2014 at 01:45:21PM -0700, Chaitanya Hazarey wrote: Removed dead code from the file. Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/rtl8192u/r8192U_wx.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git

Re: [PATCH 1/4] Staging: rtl8192u: r8192U_wx.c removed some dead code

2014-06-19 Thread Greg KH
On Mon, Jun 02, 2014 at 09:11:42AM -0700, Chaitanya Hazarey wrote: Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey c...@24.io This patch does not apply :( ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: iio: kernel style neatening

2014-06-19 Thread Joe Perches
On Thu, 2014-06-19 at 23:04 +0200, Federico Di Pierro wrote: This is a very small patch that fixes 3 little coding style problems. I'm using linux-next. Hello Federico. Your patch is word wrapped and can't be applied. Please read Documentation/SubmittingPatches and

Re: [PATCH] staging: rts5139: remove unnecessary parenthesis

2014-06-19 Thread Greg KH
On Fri, May 30, 2014 at 12:38:53PM +1000, Sam Bobroff wrote: Remove some unnecessary parenthesis as recommended by checkpatch.pl. Signed-off-by: Sam Bobroff sam.bobr...@au1.ibm.com --- drivers/staging/rts5139/rts51x_scsi.c |8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] staging: android: binder: Fix 10 overlong lines

2014-06-19 Thread Greg KH
On Sat, May 31, 2014 at 05:29:53PM -0600, Daniel Dressler wrote: This patch was made following Greg Kroah-Hartman's newbie guide. It is not intended to make any logical alterations to codeflow. Of note to reviews this patch switch's a call to kzalloc to kcalloc on line 2837 Neil Brown gave

Re: [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable

2014-06-19 Thread Greg Kroah-Hartman
On Sun, Jun 15, 2014 at 01:35:21AM +0200, Rickard Strandqvist wrote: Before when there was an error a uninitialized variable would be returnd. Now it returns -ENODEV Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/imx-drm/ipu-v3/ipu-common.c |

Re: [PATCH 2/2] staging: vt6656: fix leaks in error path

2014-06-19 Thread Greg KH
On Fri, May 30, 2014 at 08:47:44PM +0200, Nicolas Thery wrote: Fix memory leaks in ioctl error handling paths. Signed-off-by: Nicolas Thery nth...@gmail.com --- drivers/staging/vt6656/hostap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) This patch is not in the kernel tree

Re: [PATCH 1/3] staging: vt6655: update out-of-date function declaration

2014-06-19 Thread Greg KH
On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote: The function iwctl_siwscan() is defined in iwctl.c as: int iwctl_siwscan(struct net_device *dev, struct iw_request_info *info, struct iw_point *wrq, char *extra) { ...

Re: [PATCH v3] staging: vt6655: preserve address space in ethtool_ioctl()

2014-06-19 Thread Greg KH
On Tue, Jun 17, 2014 at 02:40:27PM +0200, Martin Kepplinger wrote: Fix the sparse error: cast removes address space of expression and add __user annotation to the driver's ethtool_ioctl(). Signed-off-by: Martin Kepplinger mart...@posteo.de --- I think I forgot to change the declaration on

Re: [PATCH] Staging: panel: fixed checkpatch errors in panel.c

2014-06-19 Thread Greg KH
On Sun, Jun 01, 2014 at 03:20:55AM -0700, Vincent Heuken wrote: This patch simply fixes the style errors in panel.c that scripts/checkpatch.pl reported Which style errors? Please be specific. And break the patch up into only doing one type of fix at a time, otherwise it's hard to review.

Re: [PATCH v2 5/5] staging: ft1000: ft1000-usb: ft1000_debug.c: Misc. fixes.

2014-06-19 Thread Greg KH
On Fri, Jun 06, 2014 at 08:02:18PM -0700, Thomas Wood wrote: Remove initialization of static value. Invert the empty if statement's test to replace the else statement. Remove parentheses from a return statement. Fix some code indentation. Signed-off-by: Thomas Wood tommyandr...@gmail.com

Re: [PATCH 1/2] Staging: bcm: Prototypes.h: fix checkpatch errors

2014-06-19 Thread Greg KH
On Wed, Jun 18, 2014 at 04:10:05PM +0200, Christian Bay wrote: This patch fixes all errors, excluding 80 character warnings, shown by the checkpatch script. In detail whitespace changes according to the coding guideline are meant. Additionally there is exactly one newline after every

Re: [PATCH 2/2] Staging: bcm: Queue.h: fix checkpatch errors

2014-06-19 Thread Greg KH
On Wed, Jun 18, 2014 at 04:10:06PM +0200, Christian Bay wrote: This patch fixes all checkpatch errors and warnings in Queue.h: Whitespaces, brackets and comments according to the coding guideline Same as the previous one, thanks. greg k-h ___ devel

Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static

2014-06-19 Thread Greg Kroah-Hartman
On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: Fix sparse warning. Signed-off-by: L. Alberto Giménez agime...@sysvalve.es --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH linux-next] staging: r8192ee: Adapt flush function prototype

2014-06-19 Thread Greg Kroah-Hartman
On Sat, Jun 07, 2014 at 07:39:19PM +0200, Vincent Stehlé wrote: Commit 77be2c54c5bd 'mac80211: add vif to flush call' modifies the flush operation prototype. Update r8192ee function accordingly. This fixes the following compilation warnings: drivers/staging/rtl8192ee/core.c: At top

Re: [PATCH]staging: rtl8821ae: translate some comments

2014-06-19 Thread Greg KH
On Mon, Jun 16, 2014 at 07:35:34PM +0200, Toralf Förster wrote: comments were translated with https://translate.google.com/ this enables python to parse that file right This patch fails to apply :( ___ devel mailing list de...@linuxdriverproject.org

[PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Haiyang Zhang
The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host sleep or hibernation. We refresh network at this time. MS-TFS: 135162 Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by: K. Y. Srinivasan k...@microsoft.com --- drivers/net/hyperv/hyperv_net.h |3 ++-

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
If anyone able to check this patch it would be great. Thanks Nick On Thu, Jun 19, 2014 at 5:18 PM, Nicholas Krause xerofo...@gmail.com wrote: Checks for Null return from dev_skb_alloc if it returns Null, fw_download returns false. Otherwise it returns true.Also removed rt_status due to

[PATCH] staging: ion: fixup invalid kfree() calls on heap destroy

2014-06-19 Thread Heesub Shin
I've noticed that the last commit to ion_system_heap.c ('staging: ion: optimize struct ion_system_heap') has an omission, so an invalid kfree() gets called on ion_system_heap_destroy(). As ION system heap is never destroyed until system shutdown, it may not cause any harm, but should be fixed. I

Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

2014-06-19 Thread Nick Krause
Our you Guys just removing me from your emails I have checked this patch and it seems right. If you don't want to accept it , the less you can do is give me a reply. Nick On Thu, Jun 19, 2014 at 10:12 PM, Nick Krause xerofo...@gmail.com wrote: If anyone able to check this patch it would be

staging driver patch queue is empty

2014-06-19 Thread Greg KH
Hi all, I've now caught up with all pending staging driver patches that I had, with the exception of 2 android binder patches that I want to get some review / acks from some android developers on before applying. If you have sent me a patch for the staging tree that has not been applied,

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Thu, 19 Jun 2014 18:34:36 -0700 The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host sleep or hibernation. We refresh network at this time. MS-TFS: 135162 Signed-off-by: Haiyang Zhang haiya...@microsoft.com Reviewed-by:

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Olaf Hering
On Thu, Jun 19, Haiyang Zhang wrote: The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host sleep or hibernation. We refresh network at this time. + char *argv[] = { /etc/init.d/network, restart, NULL }; What happens if that file does not exist? Dead network in the

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Greg KH
On Fri, Jun 20, 2014 at 06:57:04AM +0200, Olaf Hering wrote: On Thu, Jun 19, Haiyang Zhang wrote: The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host sleep or hibernation. We refresh network at this time. + char *argv[] = { /etc/init.d/network, restart, NULL };

[PATCH] staging: dgap: make dgap_found_board() return a brd pointer

2014-06-19 Thread Daeseok Youn
Make dgap_found_board() return a brd pointer and that brd pointer assign to dgap_board[] in the end of the dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff