On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote:
> Thanks for the feedback I will resend the patch fixed.
Please do not.
> Otherwise please use Larry's idea.
It's not Larry's idea. Larry is the primary
contributor for Realtek drivers in staging.
__
The functions iwctl_giwscan() and iwctl_siwscan() are only referenced
within iwctl.c -- so, remove their function declarations from iwctl.h
and mark these functions as static.
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/iwctl.c |4 ++--
drivers/staging/vt6655/iwctl.h | 10
Is this patch being merged or is this not an issue. I am confused
did I make a mistake in my patch or is there being a different
patch being merged.
Thank Nick
On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote:
> On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote:
>> Thanks for the feedback I
Thanks for the feedback I will resend the patch fixed.
Otherwise please use Larry's idea.
Cheers Nick
On Fri, Jun 20, 2014 at 4:08 PM, Joe Perches wrote:
> On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote:
>> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
>> > Rewrites the
This patch fixes the following checkpatch.pl issue in
ft1000/ft1000-pcmcia/ft1000_dnld.c
ERROR: code indent should use tabs where possible
Signed-off-by: Quentin Lee
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
On Fri, Jun 20, 2014 at 12:40:40PM -0700, Greg KH wrote:
> On Fri, Jun 20, 2014 at 03:02:11PM -0400, Kevin McKinney wrote:
> > On Fri, Jun 20, 2014 at 11:46:06AM -0700, Greg KH wrote:
> > > On Fri, Jun 20, 2014 at 02:07:32PM -0400, Kevin McKinney wrote:
> > > > On Fri, Jun 20, 2014 at 1:13 PM, Step
> -Original Message-
> From: Jens Axboe [mailto:ax...@kernel.dk]
> Sent: Friday, June 6, 2014 11:23 AM
> To: James Bottomley; micha...@cs.wisc.edu
> Cc: linux-ker...@vger.kernel.org; h...@infradead.org;
> de...@linuxdriverproject.org; a...@canonical.com; KY Srinivasan; linux-
> s...@vger.
From: Ramesh Basukala
Attached is a patch which fixes coding style warning message while
running checkpatch script.
This patch is currently against a linux 3.15.0-rc15-next kernel. I am
submitting this patch as a part of Eudyptula Challenge task.
Signed-off-by: Ramesh Basukala
--- xlr_net.c
On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote:
> Kristina wrote:
>
> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > nobody seems to have worked towards moving rtl8712 out of staging in
> > over a year. Are there any plans to clean it up and move it o
This is all #if 0'ed out, and it contains some rather weird stuff
(post-increment of a bool, for example). Nuke it.
Signed-off-by: Rasmus Villemoes
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl88
On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote:
> Greg Kroah-Hartman writes:
>
> > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
> >> All of the code is #if 0'd out, and the change just replaces a
> >> space with a newline, so this obviously doesn't change an
There are two functions used for the 'get_int_src' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_get_int_srsc() function and use
the encoder channel number to handle the differences.
Remove the then unn
This member of the encoder private data can be calculated based on
the comedi channel stored in the 'chan' member of the private data.
Do that instead and remove the unnecessary member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s6
Start cleaning up the 'struct s626_enc_info' by redefining the my_cra
and my_crb members based on the comedi channel number.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 24
drivers/staging/comedi/dr
There are two functions used for the 'set_mode' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Add a helper function, s626_set_mode(), that uses the encoder channel number
to determine which function to call.
Remove the then unnecessary 'set_mode' m
There are two functions used for the 'set_int_src' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_set_int_src() function and use
the encoder channel number to handle the differences.
Remove the then unne
On Thu, Jun 19, 2014 at 04:35:02PM -0700, Greg KH wrote:
> On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> > The function iwctl_siwscan() is defined in iwctl.c as:
> > int iwctl_siwscan(struct net_device *dev,
> > struct iw_request_info *info,
> >
There are two functions used for the 'get_mode' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Add a helper function, s626_get_mode(), that uses the encoder channel number
to determine which function to call.
Remove the then unnecessary 'get_mode' m
There are two functions used for the 'get_load_trig' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_get_load_trig() function and use
the encoder channel number to handle the differences.
Remove the then
Abosorb the s626_read_latch() helper and tidy up this function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 43 ++-
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/sta
Redefining the Counter Preload/Latch registers as a macro that calculates
the register offset based on the comedi channel number.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 12 ++--
drivers/staging/comedi/drivers/s
The only member left in this struct is the 'chan' which is the
comedi channel of the encoder.
Remove the struct and refactor the code to pass/use the comedi
channel instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 334
Add the comedi "chan" number to the encoder private data so we can then
remove some of the members of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 8
1 file changed, 8 insertions(+)
diff --git a/d
There are two functions used for the 'reset_cap_flags' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_reset_cap_flags() function and use
the encoder channel number to handle the differences.
Remove the t
There are two functions used for the 'set_load_trig' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_set_load_trig() function and use
the encoder channel number to handle the differences.
Remove the then
There are two functions used for the 'pulse_index' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_pulse_index() function and use
the encoder channel number to handle the differences.
Remove the then unne
The struct s626_enc_info is used in this driver to defined the callbacks and
other data needed to handle each encoder "channel". These "channel" numbers
are the same as the comedi_subdevice channels.
The channels specific stuff can easily be handled run-time by just using
the subdevice channel num
There are two functions used for the 'get_enable' callback, s626_get_enable_a()
function is used for the channel 0-2 encoders and s626_get_enable_b() is used
for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_get_enable() function and use the
encoder channel number to hand
These members of the encoder private data can be calculated based on
the comedi channel stored in the 'chan' member of the private data.
Do that instead and remove the unnecessary members.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers
This array in the encoder private data just makes the driver harder to
follow.
The S626_EVBITS() macro is used to initialize the member in the declaration.
This macro creates a array of four values, based on the encoder channel, that
are used to mask and set the private data 'counter_int_enabs' me
There are two functions used for the 'set_enable' callback, s626_set_enable_a()
function is used for the channel 0-2 encoders and s626_set_enable_b() is used
for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_set_enable() function and use the
encoder channel number to hand
Greg Kroah-Hartman writes:
> On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
>> All of the code is #if 0'd out, and the change just replaces a
>> space with a newline, so this obviously doesn't change anything.
>
> How about just deleting all the #if 0 code out entirely so no on
On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote:
> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> > Rewrites the wireless check for legacy checking in function
> > halbtc_legacy to check for both Mode A and B.
>
> You're just guessing that A and B were intended but it co
A common timer is used for analog input and output async commands. The
(*do_cmdtest) for both subdevices calculates the divisor as part of
Step 4 when validating the trigger arguments. The divisor is calculated
again in the (*do_cmd) for both subdevices in order to set the timer.
The comedi core o
The main interrupt handler already has the comedi_subdevice pointer
needed in this function. Pass that subdevice pointer so that it does
not need to be fetched as a local variable.
Tidy up the function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/s
The comedi core expects the (*insn_read) functions to return 'insn->n'
samples. Fix this function to work like the core expects.
For aesthetics, rename the private data 'ao' member to clarify its
use. Also, remove the unnecessary comment.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
The DT2821 series board have jumpers that set the output range for
the two Analog Output channels. The range_table for the Analog Output
subdevice provides all possible ranges to the user. When a unipolar
range is selected the board expects the data to be in a straight
binary format. When a bipolar
For aesthetics, rename the register map defines so that the bit defines
are associated with the registers. Also, convert all the bit defines into
bit-shifts to make them clear.
Remove all the verbose comments. All the registers and bits are named
according to the User Manual for the DT2821 Series,
The main interrupt handler already has the comedi_subdevice pointer
needed in this function. Pass that subdevice pointer so that it does
not need to be fetched as a local variable.
Tidy up the function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/s
The direction of the 16 DIO channels is controlled with two bits in the
DACSR register. The HBOE bit controls the direction of channels 15-8 and
the LBOE bit channels 7-0.
The DACSR register is also used to control the Analog Output async command
support. Currently, starting or canceling an Analog
From: H Hartley Sweeten
All unlisted members in the boardinfo declaraction will default to '0'.
Remove the unnecessary code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 25 -
1 file changed, 25 d
Tidy up the multi-line comments at the beginning of the file to follow
the CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 112 +---
1 file changed, 61 insertions(+), 51 deletions(-)
The comedi core sanity checks that the subdevice has a buffer allocated
before allowing an async command to start. The helper functions in comedi_buf
will also sanity check the buffer as a side effect of the 'alloc' helpers
with reading or writing data for the buffer.
Remove the unnecessary sanity
The (*insn_write) functions are expected to write 'insn->n' samples to the
hardware. Fix this function so it works like the comedi core expects.
The comedi core sanity checks that the samples are within the 'maxdata' range
of the subdevice before calling the (*insn_write) so this function does not
For aesthetics, add some whitespace to the Analog Input subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/stagi
For aesthetics, factor the code that initializes the then checks to see
if it is actually a DT2821 series board out of the (*attach).
For clarity, remove the MASK and VAL defines used to check the board and
jsut open code the values.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroa
This enum is used to index the 'options' values that are passed
by the user attaches to the driver. These options are identified
in the comedi comment block.
For aesthetics, remove the enum and just open code the index values.
Refactor the Analog Input subdevice init so that the it->options[4],
i
From: H Hartley Sweeten
For asethetics, move the boardinfo declaration closer to the struct
definition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 260
1 file changed, 130 insertions(+)
The DT2821 series boards do not have programmable analog output ranges.
The range is set, per-channel, with jumpers on the board.
Currently the user has to pass some configuration options when attaching
to the driver in order to set the range for each channel. If they do not
pass the range options
This member of the boardinfo is the number of bits in the analog output data.
Convert this member into the subdevice 'maxdata', (1 << board->dabits) - 1,
to avoid needing to do the calculation.
Use the subdevice 'maxdata' in the driver instead of using the boardinfo and
use the comedi_offset_munge
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stag
Convert the '2scomp' flags in the private data into bit-fields to save
a bit of space.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/sta
From: H Hartley Sweeten
Move some of the functions to remove the need for the forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 199 +++-
1 file changed, 94 insertions(+), 105
For aesthetics, add some whitespace to the Analog Output subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drive
This define is only used in the comedi_request_region() call to specify
the size of the I/O region. Remove it and just open code the value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 4 +---
1 file changed, 1 insertion(+
This driver requires an IRQ and 2 DMA channels in order to execute async
commands.
Modify the (*attach) so that command support is only hooked up if
DMA is available. This allows removing the extra checks in the
command support functions.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
Most of the boards supported by this driver can do either single-ended or
differential Analog Input but there are a couple that can only do one or
the other. On the boards that can do both the type of input is set with
jumpers on the board.
The 'it->options[4]' passed by the user during the board
For aesthetics, add some whitespace to the Digital I/O subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/
Rename these functions so they have namespace associated with the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/come
This series cleans up the comedi dt282x driver.
H Hartley Sweeten (29):
staging: comedi: dt282x: remove forward declarations
staging: comedi: dt282x: move boardinfo declaration
staging: comedi: dt282x: remove '= 0' boardinfo
staging: comedi: dt282x: convert 'adbits' boardinfo to 'ai_maxdat
This member of the boardinfo is the number of bits in the analog input data.
Convert this member into the subdevice 'maxdata', (1 << board->adbits) - 1,
to avoid needing to do the calculation.
Use the subdevice 'maxdata' in the driver instead of using the boardinfo and
use the comedi_offset_munge(
As indicated by checkpatch.pl, "WARNING: Use of volatile is usually
wrong: ...". The variables in the private data that are marked
volatile don't need to be. Remove the volatile.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c
This macro is not used in the driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt282x.c
b/drivers/staging/comedi/drivers/
On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
> All of the code is #if 0'd out, and the change just replaces a
> space with a newline, so this obviously doesn't change anything.
How about just deleting all the #if 0 code out entirely so no one has to
worry about it anymore?
th
All of the code is #if 0'd out, and the change just replaces a
space with a newline, so this obviously doesn't change anything.
However, the code is highly suspect: The b_c2h_bt_inquiry_page member
has type bool, and applying the ++ operator to a bool is equivalent to
setting it true (using -- is
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.16-rc2
for you to fetch changes up to c026a3f3972
On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> Rewrites the wireless check for legacy checking in function
> halbtc_legacy to check for both Mode A and B.
You're just guessing that A and B were intended but it could have been
something B and G...
Don't do this. Just leave the
On Fri, Jun 20, 2014 at 12:49:55PM -0400, Nicholas Krause wrote:
> Checks for Null return from dev_skb_alloc if it returns Null,
> fw_download returns false. Otherwise it returns true.Also
> removed rt_status due to returning true of false directly.
>
> Signed-off-by: Nicholas Krause
> ---
What
On Fri, Jun 20, 2014 at 10:13:27AM -0700, Stephen Hemminger wrote:
> On Fri, 20 Jun 2014 19:49:33 +0300
> Kristina Martšenko wrote:
>
> > Hi Stephen,
> >
> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > nobody seems to have worked towards moving bcm out of staging
On Fri, Jun 20, 2014 at 03:02:11PM -0400, Kevin McKinney wrote:
> On Fri, Jun 20, 2014 at 11:46:06AM -0700, Greg KH wrote:
> > On Fri, Jun 20, 2014 at 02:07:32PM -0400, Kevin McKinney wrote:
> > > On Fri, Jun 20, 2014 at 1:13 PM, Stephen Hemminger
> > >
> > > wrote:
> > >
> > > On Fri, 20 Ju
I will be offline for the next two weeks. Cya. :)
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
We should be returning a negative error code instead of success here.
This would have been detected by GCC, except that the "ret" variable was
initialized with a bogus value to disable GCC's uninitialized variable
warnings. I've cleaned that up, as well.
Signed-off-by: Dan Carpenter
diff --git
Kristina wrote:
> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> nobody seems to have worked towards moving rtl8712 out of staging in
> over a year. Are there any plans to clean it up and move it out soon?
> Because otherwise we're going to have to delete the driver, as
Im not sure what was intended with this boardinfo.
It appears to be trying to handle the sink/source output type of the
boards supported by the driver. But, some of the boardinfo does not
match the actual hardware descriptions in the manual. The manual also
does not mention anything about the port
These static arrays are used to program the range regiser with the
correct values to select the analog input range. The values in the
arrays are incrememntal for the bipolar and unipolar ranges and
have bit 4 set when the range is unipolar.
Modify the (*attach) of the analog input subdevice to fin
Introduce a helper function to flush the fifo and clear the INT
request.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/dr
The Analog Output channels on the PCI-1720 board are all set to 0V when
the board is 'reset'. Instead of setting the output ranges to bipolar 5V
and having to deal with the two's complement values, set them to unipolar
5V (which is the power-on default).
For aesthetics, redefine the register map f
Some additional cleanup for this driver.
H Hartley Sweeten (8):
staging: comedi: adv_pci1710: remove the 'muxonechan' static array
staging: comedi: adv_pci1710: remove the 'range_codes_*' static arrays
staging: comedi: adv_pci1710: tidy up setup_channel_list()
staging: comedi: adv_pci1710:
Each Analog input channel on this board has its own input range. This
function programms the ranges for each channel and sets up the private
data 'act_chalist' array for sample dropout detection.
Refactor this function to use a single for () loop to program the
channel list.
For aesthetics, renam
For aesthetics, rename this function to follow the typical naming
convention for comedi drivers.
Tidy the function up a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 30 ++--
1 file change
To program the channel ranges the mux register needs to be programmed
to with the 'chan | (chan << 8)' select the correct range register in
the hardware. The static array 'muxonechan' contains these values based
on the 'chan' index. Just calculate the values for the mux register and
remove the unne
On the PCI-1720 board, bipolar analog output ranges use two's
complement data. Use comedi_offset_munge() to munge the comedi
offset binary values before writing them to the hardware.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_p
The PCI-1720 board can be configured to store the value for the analog channels
then simultaneously update each of the channels by writing to a 'sync output'
register. This mode is enabled in the reset function so that the four channels
are reset to 0V at the same time. This mode is never cleared s
On Fri, Jun 20, 2014 at 11:46:06AM -0700, Greg KH wrote:
> On Fri, Jun 20, 2014 at 02:07:32PM -0400, Kevin McKinney wrote:
> > On Fri, Jun 20, 2014 at 1:13 PM, Stephen Hemminger
> >
> > wrote:
> >
> > On Fri, 20 Jun 2014 19:49:33 +0300
> > Kristina Martšenko wrote:
> >
> > > Hi Ste
Clean up the multi-line comments at the beginning of the file so they
follow the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 95 +++-
1 file changed, 57 insertions(+), 38 d
On Fri, Jun 20, 2014 at 11:46:45AM -0700, Greg KH wrote:
> On Fri, Jun 20, 2014 at 09:39:26PM +0300, Kristina Mart??enko wrote:
> > On 20/06/14 19:52, Willy Tarreau wrote:
> > > Hi Kristina,
> > >
> > > On Fri, Jun 20, 2014 at 06:35:03PM +0300, Kristina Mart?enko wrote:
> > >> Hi Willy,
> > >>
> >
Remove the need for the 'output_bits' in the private data by just
reading the current state of the data port when updating the output
channels in the (*insn_bits) function.
Rename the local variable 'port_read_bits' to 'bits' so that we can
use it for updating the output channels and reading back
Introduce some convienence macros to handle the port to channel,
channel to port, and channel mask calculations based on the 8
channels per port of the hardware.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 29 +++
Refactor this function to follow the standard (*insn_config) form.
Add a sanity check of the number of data parameters (insn->n). Currently
the core does not check INSN_CONFIG_CHANGE_NOTIFY.
Fix the writes to the rise/fall edge enable registers. The macro expects
a "port" value not the port offse
Rename the CamelCase defines used for the non-recurring registers.
Define all the non-recurring registers and bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 99
1 file changed, 62 ins
Subdevice 3 is used in this driver to provide edge detection of the input
channels.
Move the reset/disable of the interrupts and the request_irq() so that
when subdevice 3 is setup we can conditionally hookup the async command
support only if the irq is available.
Also, remove the noise when the
Update the MODULE_DESCRIPTION to better describe the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_65xx.c
b/drive
Convert the inline functions used to calculate the offsets to the
recurring port registers and rename them to remove the CamelCase.
Define all the recurring registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 88
For aesthetics, add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 42
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/
For aesthetics, add some whitespace to the comedi_driver declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/n
There is only one member in the subdevice private data, an unsigned value
that is the 'base_port' that the subdevice uses to access the port registers.
Just cast the appropriate value into s->private instead of allocating the
private data for each subdevice. The casts are a bit of a nusance but it
The INSN_CONFIG_FILTER instruction is used to set the deglitch filter
interval used to debounce the input channels.
Absorb the helper function into the (*insn_config) function and refactor
the code to not require the 'filter_interval' and 'filter_enable' members
in the private data.
Signed-off-by
According to the register programming manual, the filter interval
register is 32-bit. Fix the writes to this register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
For aesthetics, factor the code that disables the input filters out of
ni_65xx_auto_attach().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions
The IO Select registers are readable. Remove the need for the
'dio_direction' member in the private data by just checking the
register value for the INSN_CONFIG_DIO_QUERY instruction.
Also, refactor the switch statement to return -EINVAL for unhandled
instructions and have the (*insn_config) retur
1 - 100 of 228 matches
Mail list logo
