Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static

2014-06-21 Thread L . Alberto Giménez
On Thu, Jun 19, 2014 at 05:14:26PM -0700, Greg Kroah-Hartman wrote: On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: Fix sparse warning. Signed-off-by: L. Alberto Giménez agime...@sysvalve.es --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- 1 file

Re: [patch] staging: iio/ad7291: fix error code in ad7291_probe()

2014-06-21 Thread Jonathan Cameron
On 20/06/14 20:22, Dan Carpenter wrote: We should be returning a negative error code instead of success here. This would have been detected by GCC, except that the ret variable was initialized with a bogus value to disable GCC's uninitialized variable warnings. I've cleaned that up, as well.

[PATCH v3] staging: xillybus: Use devm_ API for memory allocation and DMA mapping

2014-06-21 Thread Eli Billauer
Managed device resource API replaces code that reinvents it for memory allocation, page allocation and DMA mapping. devm_add_action() is used for unwinding DMA mappings, since there is no devm_* API for dma_map_single(). A recent patch that introduces such API was rejected, mainly on the grounds

[PATCH 0/7] staging: rtl8188eu: Consolidate usb operation code.

2014-06-21 Thread navin patidar
navin patidar (7): staging: rtl8188eu: Merge hal/usb_ops_linux.c into os_dep/usb_ops_linux.c staging: rtl8188eu: Remove macros specific to kernel version 2.6.12 staging:rtl8188eu:usb_ops.h:Remove unused enum, macros and function declaration staging: rtl8188eu: usb_ops.h: Remove

[PATCH 4/7] staging: rtl8188eu: usb_ops.h: Remove macro rtw_usb_control_msg()

2014-06-21 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/usb_ops.h |5 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h

[PATCH 2/7] staging: rtl8188eu: Remove macros specific to kernel version 2.6.12

2014-06-21 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/usb_ops.h | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h b/drivers/staging/rtl8188eu/include/usb_ops.h index

[PATCH 3/7] staging:rtl8188eu:usb_ops.h:Remove unused enum, macros and function declaration

2014-06-21 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/usb_ops.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h b/drivers/staging/rtl8188eu/include/usb_ops.h index e10b711..74009ca 100644 ---

[PATCH 5/7] staging: rtl8188eu: Remove inline function rtw_inc_and_chk_continual_urb_error()

2014-06-21 Thread navin patidar
rtw_inc_and_chk_continual_urb_error() is used to check if device is removed unexpectedly, to do that we can just check status of urb in usb_read_port_complete() and usbctrl_vendorreq() doed that by checking return value of usb_control_msg(). Signed-off-by: navin patidar navin.pati...@gmail.com

[PATCH 6/7] staging: rtl8188eu: Remove continual_urb_error from struct dvobj_priv

2014-06-21 Thread navin patidar
rtw_inc_and_chk_continual_urb_error() was only user of continual_urb_error, which has been removed. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/drv_types.h|2 -- drivers/staging/rtl8188eu/include/usb_ops.h |8

[PATCH 7/7] staging: rtl8188eu: Merge usb_ops.h into usb_ops_linux.h

2014-06-21 Thread navin patidar
Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c|1 - drivers/staging/rtl8188eu/core/rtw_recv.c |1 - drivers/staging/rtl8188eu/core/rtw_xmit.c |1 - drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |2 -

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-21 Thread Larry Finger
On 06/20/2014 09:52 PM, Nick Krause wrote: Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged. Thank Nick On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches j...@perches.com wrote: On Fri, 2014-06-20 at

[PATCH 11/11] staging: rtl8723au: issue_probersp(): No need to calculate location of IEs, we know where they are

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 08/11] staging: rtl8723au: rtw_survey_event_cb23a(): Remember to clone beacon data

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We need to clone all the beacon information, not just the IE data, in particular as the long term goal is to stop carrying this information in the IE data. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 03/11] staging: rtl8723au: Remove unused struct mlme_priv-wps_probe_resp_ie

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 42 ++-

[PATCH 02/11] staging: rtl8723au: Remove unused mlme_priv-wps_assoc_resp_ie and friends

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 1 - drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 --

[PATCH 05/11] staging: rtl8723au: Remove unused struct mlme_priv-wfd_* entries

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 1 - drivers/staging/rtl8723au/core/rtw_mlme.c| 11 --- drivers/staging/rtl8723au/include/rtw_mlme.h | 12 3 files changed,

[PATCH 09/11] staging: rtl8723au: rtw_joinbss_update_network23a(): update beacon info as well

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We need to copy over the beacon info (interval, capability, tsf) as well as the IE data. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 06/11] staging: rtl8723au: Remove write-only struct security_priv-authenticator_ie

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 13 - drivers/staging/rtl8723au/include/rtw_security.h | 1 - 2 files changed, 14 deletions(-) diff --git

[PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for merging the last set. I starting going through the code again, and removed a pile of dead code (patches 1-7). However in the process I noticed a couple of cases where raw beacon frame information was copied to a new wlan network

[PATCH 01/11] staging: rtl8723au: struct mlme_priv-wps_beacon_ie is never set

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Remove all code trying to use it Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 54 +-- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -

[PATCH 07/11] staging: rtl8723au: Remove (hopefully) last duplicate define of WLAN_EID_RSN

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com So much for thinking the removal of the previous 217 duplicate copies would suffice Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme.c|

[PATCH 04/11] staging: rtl8723au: Remove obsolete mlme_priv-p2p_* entries

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 3 --- drivers/staging/rtl8723au/core/rtw_mlme.c| 11 --- drivers/staging/rtl8723au/include/rtw_mlme.h | 10 -- 3 files changed,

[PATCH 10/11] staging: rtl8723au: issue_probersp(): Don't insert beacon data twice

2014-06-21 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com In case of AP mode, we were inserting the beacon data twice in the probe_resp frame, leading to a corrupted on the wire frame. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 3 ++- 1 file

[PATCH] Staging: rtl8192e: adjust error handling

2014-06-21 Thread Himangi Saraogi
This patch removes a test in error handling code by adding a return path. The Coccinelle semantic match that found the problem is: // smpl @@ expression E,E1,E2; @@ E = alloc_etherdev(...) ... when != E = E1 if (...) { ... free_netdev(E); ... return ...; } ... when != E = E2 ( if (...) {

Re: Fwd: Re: Anybody working on rtl8712?

2014-06-21 Thread Kristina Martšenko
On 20/06/14 23:52, Christian Lamparter wrote: On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: Kristina wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving rtl8712 out of staging in over a year. Are there

Re: Anybody working on rtl8712?

2014-06-21 Thread Kristina Martšenko
On 20/06/14 20:15, Larry Finger wrote: On 06/20/2014 10:40 AM, Kristina Martšenko wrote: Hi Larry and Florian, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving rtl8712 out of staging in over a year. Are there any plans to

[PATCH] staging: cxt1e1: fix sbeCrc function declaration

2014-06-21 Thread Pawel Lebioda
Hi, This patch fixes the following sparse warning: drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static? Furthermore it fixes wring sbeCrc return type in function declaration. Regards Pawel Lebioda Signed-off-by: Pawel Lebioda

Re: Anybody working on wlags49_h2?

2014-06-21 Thread Dave Kilroy
On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving wlags49_h2(5) out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going

Re: Fwd: Re: Anybody working on rtl8712?

2014-06-21 Thread Christian Lamparter
On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote: On 20/06/14 23:52, Christian Lamparter wrote: On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: Kristina wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have

Re: Anybody working on winbond?

2014-06-21 Thread Pavel Machek
On Fri 2014-06-20 18:45:08, Kristina Martšenko wrote: Hi Pavel, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving winbond out of staging in over a year. Are there any plans to clean it up and move it out soon? Plans, yes, but

Re: Fwd: Re: Anybody working on rtl8712?

2014-06-21 Thread Larry Finger
On 06/21/2014 12:52 PM, Christian Lamparter wrote: On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote: On 20/06/14 23:52, Christian Lamparter wrote: On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: Kristina wrote: I'm helping Greg do a bit of cleanup in the

Re: Anybody working on wlags49_h2?

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving wlags49_h2(5) out of staging in over a year. Are there any plans to

Re: Anybody working on winbond?

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 08:03:25PM +0200, Pavel Machek wrote: On Fri 2014-06-20 18:45:08, Kristina Martšenko wrote: Hi Pavel, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving winbond out of staging in over a year. Are

Re: Anybody working on wlags49_h2?

2014-06-21 Thread Kristina Martšenko
On 21/06/14 22:46, Greg KH wrote: On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving wlags49_h2(5) out of staging in

Re: Anybody working on wlags49_h2?

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 10:54:29PM +0300, Kristina Martšenko wrote: On 21/06/14 22:46, Greg KH wrote: On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody

Re: [PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

2014-06-21 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Sat, Jun 21, 2014 at 04:50:08PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for merging the last set. I starting going through the code again, and removed a pile of dead code (patches 1-7).

Re: [PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 10:20:12PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Sat, Jun 21, 2014 at 04:50:08PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for merging the last set. I starting going

[PATCH v3 5/5] staging: comedi: addi_apci_1564: move apci1564_interrupt() into addi_apci_1564.c

2014-06-21 Thread Chase Southwood
On moving the function into the driver proper, also check the device is asserting the shared interrupt line. This patch also fixes the interrupt handling for the digital input change-of-state interrupts. Signed-off-by: Chase Southwood chase.southw...@gmail.com Cc: Ian Abbott abbo...@mev.co.uk

[PATCH v3 3/5] staging: comedi: addi_apci_1564: introduce apci1564_private struct

2014-06-21 Thread Chase Southwood
The addi_private struct defined in addi-data/addi_common.h is very bloated and contains many fields which addi_apci_1564 does not require. In the interest of eventually removing this driver's dependency on addi_common.h, we can create a private data struct specifically for addi_apci_1564

[PATCH v3 4/5] staging: comedi: addi_apci_1564: add Change-of-State interrupt subdevice and required functions

2014-06-21 Thread Chase Southwood
This board supports an interrupt that can be generated by an AND/OR combination of 16 of the input channels. Create a separate subdevice to handle this interrupt. The apci1564_di_config() function is used to configure which inputs are used to generate the interrupt. Currently this function is