[PATCH v3 4/5] staging: comedi: addi_apci_1564: add Change-of-State interrupt subdevice and required functions

This board supports an interrupt that can be generated by an AND/OR combination of 16 of the input channels. Create a separate subdevice to handle this interrupt. The apci1564_di_config() function is used to configure which inputs are used to generate the interrupt. Currently this function is bro

[PATCH v3 5/5] staging: comedi: addi_apci_1564: move apci1564_interrupt() into addi_apci_1564.c

On moving the function into the driver proper, also check the device is asserting the shared interrupt line. This patch also fixes the interrupt handling for the digital input change-of-state interrupts. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- .../comedi/driver

[PATCH v3 3/5] staging: comedi: addi_apci_1564: introduce apci1564_private struct

The addi_private struct defined in addi-data/addi_common.h is very bloated and contains many fields which addi_apci_1564 does not require. In the interest of eventually removing this driver's dependency on addi_common.h, we can create a private data struct specifically for addi_apci_1564 containin

[PATCH v3 1/5] staging: comedi: addi_apci_1564: remove use of devpriv->b_OutputMemoryStatus

This member of the private data struct is only set at one location in the entire driver, and then never even used for anything. Let's just remove its use. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeeten --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5 ---

[PATCH v3 2/5] staging: comedi: addi_apci_1564: remove unused static variables

The global variables ui_InterruptStatus_1564 and ui_InterruptData are both set but never used. Just remove them from the driver. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 7 +-- 1 file changed, 1 ins

[PATCH v3 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality

This patchset introduces a new private data struct for this driver, adds all of the code required to support Change-of-State interrupts for the digital input subdevice, and finally fixes apci1564_interrupt() to service this type of interrupt correctly. CHANGES FROM v1: *leave the send_sig() calls

Re: [PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

On Sat, Jun 21, 2014 at 10:20:12PM +0200, Jes Sorensen wrote: > Greg KH writes: > > On Sat, Jun 21, 2014 at 04:50:08PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> > >> Greg, > >> > >> Thanks for merging the last set. I starting going through the code > >> again, and remov

Re: [PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

Greg KH writes: > On Sat, Jun 21, 2014 at 04:50:08PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Greg, >> >> Thanks for merging the last set. I starting going through the code >> again, and removed a pile of dead code (patches 1-7). >> >> However in the process I noticed

Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static

On Sat, Jun 21, 2014 at 12:04:44PM +0200, L. Alberto Giménez wrote: > On Thu, Jun 19, 2014 at 05:14:26PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: > > > Fix sparse warning. > > > > > > Signed-off-by: L. Alberto Giménez > > > --- > > >

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

On Sat, Jun 21, 2014 at 12:46:33PM -0400, Nick Krause wrote: > Hope you enjoyed your trips , Larry. > It would be great if you researched > this issue in order for me to send in > a correct patch to fix this bug. That is not how kernel development is done, you need to do the work, not ask others t

Re: [PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

On Sat, Jun 21, 2014 at 04:50:08PM +0200, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Greg, > > Thanks for merging the last set. I starting going through the code > again, and removed a pile of dead code (patches 1-7). > > However in the process I noticed a couple of cases where raw

Re: Anybody working on wlags49_h2?

On Sat, Jun 21, 2014 at 10:54:29PM +0300, Kristina Martšenko wrote: > On 21/06/14 22:46, Greg KH wrote: > > On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: > >> On 20/06/2014 17:18, Kristina Martšenko wrote: > >>> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that

Re: Anybody working on wlags49_h2?

On 21/06/14 22:46, Greg KH wrote: > On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: >> On 20/06/2014 17:18, Kristina Martšenko wrote: >>> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that >>> nobody seems to have worked towards moving wlags49_h2(5) out of staging

Re: Anybody working on winbond?

On Sat, Jun 21, 2014 at 08:03:25PM +0200, Pavel Machek wrote: > On Fri 2014-06-20 18:45:08, Kristina Martšenko wrote: > > Hi Pavel, > > > > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > > nobody seems to have worked towards moving winbond out of staging in > > over a y

Re: Anybody working on wlags49_h2?

On Sat, Jun 21, 2014 at 06:35:41PM +0100, Dave Kilroy wrote: > On 20/06/2014 17:18, Kristina Martšenko wrote: > >I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > >nobody seems to have worked towards moving wlags49_h2(5) out of staging > >in over a year. Are there any plans

Re: Fwd: Re: Anybody working on rtl8712?

On 06/21/2014 12:52 PM, Christian Lamparter wrote: On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote: On 20/06/14 23:52, Christian Lamparter wrote: On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: Kristina wrote: I'm helping Greg do a bit of cleanup in the staging

Re: Anybody working on winbond?

On Fri 2014-06-20 18:45:08, Kristina Martšenko wrote: > Hi Pavel, > > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > nobody seems to have worked towards moving winbond out of staging in > over a year. Are there any plans to clean it up and move it out soon? Plans, yes,

Re: Fwd: Re: Anybody working on rtl8712?

On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote: > On 20/06/14 23:52, Christian Lamparter wrote: > > On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: > >> Kristina wrote: > >> > >>> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > >>> nobody s

Re: Anybody working on wlags49_h2?

On 20/06/2014 17:18, Kristina Martšenko wrote: I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving wlags49_h2(5) out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to

[PATCH] staging: cxt1e1: fix sbeCrc function declaration

Hi, This patch fixes the following sparse warning: drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static? Furthermore it fixes wring sbeCrc return type in function declaration. Regards Pawel Lebioda Signed-off-by: Pawel Lebioda --- drivers/stag

Re: Anybody working on rtl8712?

On 20/06/14 20:15, Larry Finger wrote: > On 06/20/2014 10:40 AM, Kristina Martšenko wrote: >> Hi Larry and Florian, >> >> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that >> nobody seems to have worked towards moving rtl8712 out of staging in >> over a year. Are there any pl

Re: Fwd: Re: Anybody working on rtl8712?

On 20/06/14 23:52, Christian Lamparter wrote: > On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote: >> Kristina wrote: >> >>> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that >>> nobody seems to have worked towards moving rtl8712 out of staging in >>> over a year.

[PATCH] Staging: rtl8192e: adjust error handling

This patch removes a test in error handling code by adding a return path. The Coccinelle semantic match that found the problem is: // @@ expression E,E1,E2; @@ E = alloc_etherdev(...) ... when != E = E1 if (...) { ... free_netdev(E); ... return ...; } ... when != E = E2 ( if (...) { ...

[PATCH] staging: wlags49_h2: Fix use of skb after netif_rx

This patch moves a call to netif_rx(skb) after a subsequent reference to skb, because netif_rx may call kfree_skb via enqueue_to_backlog on its argument. This was found using the following semantic match. // @@ expression skb, e,e1; @@ ( netif_rx(skb); | netif_rx_ni(skb); ) ... when != skb

[PATCH 01/11] staging: rtl8723au: struct mlme_priv->wps_beacon_ie is never set

From: Jes Sorensen Remove all code trying to use it Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 54 +-- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 - drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 25 - drivers/st

[PATCH 04/11] staging: rtl8723au: Remove obsolete mlme_priv->p2p_* entries

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 3 --- drivers/staging/rtl8723au/core/rtw_mlme.c| 11 --- drivers/staging/rtl8723au/include/rtw_mlme.h | 10 -- 3 files changed, 24 deletions(-) diff --git a/drivers/staging/r

[PATCH 06/11] staging: rtl8723au: Remove write-only struct security_priv->authenticator_ie

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_cmd.c | 13 - drivers/staging/rtl8723au/include/rtw_security.h | 1 - 2 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/c

[PATCH 00/11] staging-next: rtl8723au: Serious fixes and some removal of dead code

From: Jes Sorensen Greg, Thanks for merging the last set. I starting going through the code again, and removed a pile of dead code (patches 1-7). However in the process I noticed a couple of cases where raw beacon frame information was copied to a new wlan network struct, but the retrieved info

[PATCH 07/11] staging: rtl8723au: Remove (hopefully) last duplicate define of WLAN_EID_RSN

From: Jes Sorensen So much for thinking the removal of the previous 217 duplicate copies would suffice Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme.c| 6 +++--- drivers/staging/rtl8723au/include/rt

[PATCH 10/11] staging: rtl8723au: issue_probersp(): Don't insert beacon data twice

From: Jes Sorensen In case of AP mode, we were inserting the beacon data twice in the probe_resp frame, leading to a corrupted on the wire frame. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

[PATCH 11/11] staging: rtl8723au: issue_probersp(): No need to calculate location of IEs, we know where they are

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c index 4f9e5a9..03ced01 100

[PATCH 08/11] staging: rtl8723au: rtw_survey_event_cb23a(): Remember to clone beacon data

From: Jes Sorensen We need to clone all the beacon information, not just the IE data, in particular as the long term goal is to stop carrying this information in the IE data. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 11 +++ 1 file changed, 11 insertio

[PATCH 03/11] staging: rtl8723au: Remove unused struct mlme_priv->wps_probe_resp_ie

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 42 ++- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 --

[PATCH 02/11] staging: rtl8723au: Remove unused mlme_priv->wps_assoc_resp_ie and friends

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 1 - drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 -- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 -- 4 files changed,

[PATCH 05/11] staging: rtl8723au: Remove unused struct mlme_priv->wfd_* entries

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 1 - drivers/staging/rtl8723au/core/rtw_mlme.c| 11 --- drivers/staging/rtl8723au/include/rtw_mlme.h | 12 3 files changed, 24 deletions(-) diff --git a/drivers/staging/r

[PATCH 09/11] staging: rtl8723au: rtw_joinbss_update_network23a(): update beacon info as well

From: Jes Sorensen We need to copy over the beacon info (interval, capability, tsf) as well as the IE data. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/sta

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

On 06/20/2014 09:52 PM, Nick Krause wrote: Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged. Thank Nick On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote: On Fri, 2014-06-20 at 22:26 -0400, Nic

[PATCH 7/7] staging: rtl8188eu: Merge usb_ops.h into usb_ops_linux.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c|1 - drivers/staging/rtl8188eu/core/rtw_recv.c |1 - drivers/staging/rtl8188eu/core/rtw_xmit.c |1 - drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |2 - drivers/staging/rtl8188

[PATCH 6/7] staging: rtl8188eu: Remove continual_urb_error from struct dvobj_priv

rtw_inc_and_chk_continual_urb_error() was only user of continual_urb_error, which has been removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h|2 -- drivers/staging/rtl8188eu/include/usb_ops.h |8 drivers/staging/rtl8188eu/os_dep/usb_

[PATCH 3/7] staging:rtl8188eu:usb_ops.h:Remove unused enum, macros and function declaration

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/usb_ops.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h b/drivers/staging/rtl8188eu/include/usb_ops.h index e10b711..74009ca 100644 --- a/drivers/staging/rtl8188eu/

[PATCH 5/7] staging: rtl8188eu: Remove inline function rtw_inc_and_chk_continual_urb_error()

rtw_inc_and_chk_continual_urb_error() is used to check if device is removed unexpectedly, to do that we can just check status of urb in usb_read_port_complete() and usbctrl_vendorreq() doed that by checking return value of usb_control_msg(). Signed-off-by: navin patidar --- drivers/staging/rtl81

[PATCH 4/7] staging: rtl8188eu: usb_ops.h: Remove macro rtw_usb_control_msg()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/usb_ops.h |5 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h b/drivers/staging/rtl8188eu/inclu

[PATCH 1/7] staging: rtl8188eu: Merge hal/usb_ops_linux.c into os_dep/usb_ops_linux.c

Consolidate all usb operation related functions in one file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |1 - drivers/staging/rtl8188eu/hal/usb_ops_linux.c| 665 -- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 642 +++

[PATCH 2/7] staging: rtl8188eu: Remove macros specific to kernel version < 2.6.12

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/usb_ops.h | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_ops.h b/drivers/staging/rtl8188eu/include/usb_ops.h index ff730f4..e10b711 100644 --- a/drive

[PATCH 0/7] staging: rtl8188eu: Consolidate usb operation code.

navin patidar (7): staging: rtl8188eu: Merge hal/usb_ops_linux.c into os_dep/usb_ops_linux.c staging: rtl8188eu: Remove macros specific to kernel version < 2.6.12 staging:rtl8188eu:usb_ops.h:Remove unused enum, macros and function declaration staging: rtl8188eu: usb_ops.h: Remove ma

[PATCH v3] staging: xillybus: Use devm_ API for memory allocation and DMA mapping

Managed device resource API replaces code that reinvents it for memory allocation, page allocation and DMA mapping. devm_add_action() is used for unwinding DMA mappings, since there is no devm_* API for dma_map_single(). A recent patch that introduces such API was rejected, mainly on the grounds t

Re: [patch] staging: iio/ad7291: fix error code in ad7291_probe()

On 20/06/14 20:22, Dan Carpenter wrote: We should be returning a negative error code instead of success here. This would have been detected by GCC, except that the "ret" variable was initialized with a bogus value to disable GCC's uninitialized variable warnings. I've cleaned that up, as well.

Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static

On Thu, Jun 19, 2014 at 05:14:26PM -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: > > Fix sparse warning. > > > > Signed-off-by: L. Alberto Giménez > > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- > > 1 file changed,