We should schedule the 5s timer work before starting the data transfer,
otherwise, the data transfer code may finish so fast on another
virtual cpu that when the code(fcopy_write()) trying to cancel the 5s
timer work can occasionally fail because the timer work may haven't
been scheduled yet and
From: Igor bezukh igb...@gmail.com
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by: Igor Bezukh igb...@gmail.com
---
drivers/staging/vt6655/card.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/vt6655/card.c
On 14/07/14 19:29, Maurice Moss wrote:
Hi all,
I have updated my Linux Kernel to the latest. I am on Debian 64bit
3.15.5. I issue the following Kernel command line, and the vme_user
module seems to load correctly, however the vme bus is neither mounted
on /dev nor /proc.
Just to make
* Kristina Martšenko kristina.martse...@gmail.com [140715 16:33]:
It was added to support DSP Bridge. Since DSP Bridge was removed, and
nothing else is using the platform device, remove it too.
Signed-off-by: Kristina Martšenko kristina.martse...@gmail.com
Cc: Omar Ramirez Luna
* Kristina Martšenko kristina.martse...@gmail.com [140716 02:33]:
The driver has been broken and disabled for several kernel versions now.
It doesn't have a maintainer anymore, and most of the people who've
worked on it have moved on. There's also still a long list of issues in
the TODO file
On 2014-07-14 20:23, H Hartley Sweeten wrote:
The comedi_krange includes a flags member that currently identifies the
'units' of the range (RF_UNIT) and if the range is from an internal or
external source (RF_EXTERNAL).
Introduce some helper functions to check if a given range is from an
On Tue, Jul 15, 2014 at 01:30:47PM -0400, Benjamin Romer wrote:
+ char msgtype[64];
+ int msgparam;
+
+ if (sscanf(buf, %64s %d, msgtype, msgparam) == 2) {
The 64 in %s64s is off by one because of the NUL.
[ This is where I do my memory corruption preventing dance of success.
I
2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message
On Wed, Jul 16, 2014 at 10:45:30AM +0300, Igor Bezukh wrote:
From: Igor bezukh igb...@gmail.com
Just leave this line out. The capitalization is wrong anyway.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
On 2014-07-14 20:23, H Hartley Sweeten wrote:
The ni_mio_common.c file is included by a number of National Instruments
drivers to provide the common driver support. This series does some
more cleanup to get the file closer to being changed into a module instead
of including it in the drivers.
H
On Sun, Jul 13, 2014 at 08:58:34AM -0400, Martin K. Petersen wrote:
KY == KY Srinivasan k...@microsoft.com writes:
KY Windows hosts do support UNMAP and set the field in the
KY EVPD. However, since the host advertises SPC-2 compliance, Linux
KY does not even query the VPD page.
If we
On 07/15/2014 07:31 PM, Jonathan Cameron wrote:
On 14/07/14 21:31, Himangi Saraogi wrote:
Hi,
The code seems to have a memory leak. The function ad7280_attr_init
calls kasprintf a number of times, which calls kmalloc (or more
precisely kmalloc_track_caller), but this data does not ever seem to
From: Kiran Padwal kiran.pad...@gmail.com
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by:Kiran Padwal kiran.padwa...@gmail.com
---
drivers/staging/gdm724x/gdm_lte.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
On 2014-07-15 01:20, H Hartley Sweeten wrote:
The ADC conversions are enabled and the FIFO is flushed by daq700_ai_config()
when the driver is initially attached. There is no reason to repeat the ADC
enable and flush the FIFO before each sample read in the (*insn_read).
Signed-off-by: H Hartley
On 2014-07-15 01:20, H Hartley Sweeten wrote:
Clarify the timer operations by using the helper functions in 8253.h.
For aesthetics, factor the ai start conversion code out of daq700_ai_rinsn().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
On 2014-07-15 01:21, H Hartley Sweeten wrote:
This board has 8 digital output and 8 digital input channels. The direction
of these channels is not configurable. For convienence all 16 channels are
packed into one DIO subdevice.
The (*insn_config) for this subdevice currently uses the comedi
'quoted string split across lines' warning in checkpatching fixed
by group whole string in one line.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com
---
drivers/staging/gdm724x/gdm_tty.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/gdm724x/gdm_tty.c
b/drivers/staging/gdm724x/gdm_tty.c
index
On 07/15/2014 11:30 AM, Greg KH wrote:
On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
configuration files should not be parsed in the kernel at all. That
logic should be
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek a...@atx.name
---
drivers/staging/iio/magnetometer/Kconfig | 1 +
This patch series modifies the hmc5843 driver to support the hmc5983 i2c and
spi interfaces.
v2:
* Reverted the changed order of iio unregister and setting hmc mode to
sleep
v3:
* Fixed bug introduced in the first patch
* Readded few comment lines which have gone missing
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off-by: Josef Gajdusek a...@atx.name
---
drivers/staging/iio/magnetometer/Kconfig
Changed structure of struct hmc5843_chip_info to include length of translation
arrays. Code previously using #defined constant has been changed accordingly.
This allows to integrate devices which do have different amounts of available
rates/scales.
Signed-off-by: Josef Gajdusek a...@atx.name
---
This patch adds support for the hmc5983 i2c interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek a...@atx.name
---
This patch adds support for the hmc5983 spi interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek a...@atx.name
---
On Tue, 2014-07-15 at 21:50 -0700, Greg KH wrote:
On Tue, Jul 15, 2014 at 01:30:42PM -0400, Benjamin Romer wrote:
All sysfs files need a Documentation/ABI/ entry. As this isn't in the
real part of the kernel yet, just create the entries in the unisys/
subdir and then when it moves out, we can
-Original Message-
From: Dexuan Cui [mailto:de...@microsoft.com]
Sent: Wednesday, July 16, 2014 12:01 AM
To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Cc: KY
On Wed, Jul 16, 2014 at 08:39:33AM -0400, Mark Hounschell wrote:
We also have this DIGI_EXPANDERS_SUPPORTED thingy. I have none of
these cards. These cards interrogate the expander to find out how
many ports there are. Then configure accordingly. Should we just
remove all that code and NOT
This includes:
- keep else on the same line as the closing brace
- don't use else after return
- don't issue a message for an out-of-memory error
- blank line after a declaration
Signed-off-by: Vincent Bernat vinc...@bernat.im
---
drivers/staging/xillybus/xillybus_core.c | 13 +
On Wed, 2014-07-16 at 15:24 +0300, Sam Asadi wrote:
'quoted string split across lines' warning in checkpatching fixed
by group whole string in one line.
[]
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/drivers/staging/comedi/drivers/adl_pci9118.c
[]
@@ -412,8 +412,7 @@ static
On 07/16/2014 05:26 AM, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn
On Wed, 2014-07-16 at 04:01 -0700, h...@infradead.org wrote:
On Sun, Jul 13, 2014 at 08:58:34AM -0400, Martin K. Petersen wrote:
KY == KY Srinivasan k...@microsoft.com writes:
KY Windows hosts do support UNMAP and set the field in the
KY EVPD. However, since the host advertises SPC-2
'quoted string split across lines' warning in checkpatching fixed
by group whole string in one line.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
2 style issues fixed: one misspelling a quoted string split across lines.
Sam Asadi (2):
Staging: comedi: adl_pci9118: a style issue fixed
Staging: comedi: adl_pci9118: fractured spelling fixed
drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
1 file changed, 1 insertion(+), 2
a fractured spelling in previous style issue fix mended.
Signed-off-by: Sam Asadi asadi.sam...@gmail.com
---
drivers/staging/comedi/drivers/adl_pci9118.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
On 07/15/2014 06:30 PM, Kristina Martšenko wrote:
The driver has been broken and disabled for several kernel versions now.
It doesn't have a maintainer anymore, and most of the people who've
worked on it have moved on. There's also still a long list of issues in
the TODO file before it can be
On 07/15/2014 06:30 PM, Kristina Martšenko wrote:
It was added to support DSP Bridge. Since DSP Bridge was removed, and
nothing else is using the platform device, remove it too.
Signed-off-by: Kristina Martšenko kristina.martse...@gmail.com
Cc: Omar Ramirez Luna omar.rami...@copitl.com
Cc:
hch == hch@infradead org h...@infradead.org writes:
hch read_capacity_16 calls sd_config_discard(sdkp, SD_LBP_WS16) if the
hch LPBME bit is set. At least older SBC drafts left it wide open if a
hch target supports WRITE SAME with UNMAP or UNMAP in this case.
Correct.
hch So I think we'd still
This patch fixes a checkpatch warning by replacing printk
by dev_warn. Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V5
- Refresh for staging-next of 16/07/2014
drivers/staging/vt6656/main_usb.c | 3 ++-
1 file changed, 2 insertions(+),
This patch removes uneeded typedefs reported by chackpatch and removes
one enum that is not in use. As checkpatch complained about the typedef
and the enum is not being used, this patch removes both typedef and enum.
The removed enum from card.h:
typedef enum _CARD_PHY_TYPE {
PHY_TYPE_AUTO =
On Wednesday, July 16, 2014 3:54 AM, Ian Abbott wrote:
On 2014-07-14 20:23, H Hartley Sweeten wrote:
The ni_mio_common.c file is included by a number of National Instruments
drivers to provide the common driver support. This series does some
more cleanup to get the file closer to being changed
On Wednesday, July 16, 2014 4:35 AM, Ian Abbott wrote:
On 2014-07-15 01:20, H Hartley Sweeten wrote:
The ADC conversions are enabled and the FIFO is flushed by daq700_ai_config()
when the driver is initially attached. There is no reason to repeat the ADC
enable and flush the FIFO before each
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Monday, July 14, 2014 1:58 AM
To: Christoph Hellwig
Cc: KY Srinivasan; jasow...@redhat.com; a...@canonical.com; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;
On Wed, Jul 16, 2014 at 05:26:48PM +, KY Srinivasan wrote:
Christoph,
Is this patch-set ready to be checked in. Let me know if you want me to make
any
further corrections.
Hi Ky,
I've applied it locally, but I'm still waiting on reviews for two
important core fixes before pushing out
-Original Message-
From: Christoph Hellwig [mailto:h...@infradead.org]
Sent: Wednesday, July 16, 2014 10:29 AM
To: KY Srinivasan
Cc: Hannes Reinecke; jasow...@redhat.com; a...@canonical.com; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;
On Wed, Jul 16, 2014 at 11:44:18AM -0400, Martin K. Petersen wrote:
There are lots of devices out there that support WRITE SAME(10) or (16)
without the UNMAP bit. And there are devices that support WRITE SAME w/
UNMAP functionality but not regular WRITE SAME.
Oh, we actually have devices that
Fix the two checkpatch.pl warnings in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/comedi_fops.c
Start cleaning up the checkpatch.pl issues. This pass gets most of the:
WARNING: else is not generally useful after a break or return
WARNING: break is not useful after a goto or return
H Hartley Sweeten (32):
staging: comedi: comedi_fops: checkpatch.pl cleanup (else after return)
staging:
Fix the checkpatch.pl warning in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
Fix these checkpatch.pl warnings:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/daqboard2000.c | 3
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 1 -
1 file
Fix the two checkpatch.pl warnings in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/comedi.h | 8
Fix the checkpatch.pl warnings:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c | 38
Fix the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbduxsigma.c | 12
Fix the checkpatch.pl warnings:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 60
Fix checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt282x.c | 8
1
Fix these checkpatch.pl warnings:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pc236.c | 8
Fix the checkpatch.pl warnings:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c | 67
Fix this checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci224.c | 3 +--
Fix the checkpatch.pl warning in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/8255_pci.c
Fix the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl724.c | 6 ++
1
Fix the checkpatch.pl warning in this file:
WARNING: else is not generally useful after a break or return
Also, for aesthetics, rename the comedi_subdevice parameter from
'subd' to 's' since this is the norm for comedi source files.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Fix the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 12
Refactor this inline function to fix the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Fix the checkpatch.pl warnings:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas.c | 3 ---
1 file
Fix these checkpatch.pl warnings:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
Fix the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_660x.c | 5 +
1
Fix the checkpatch.pl warnings:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das1800.c | 8
1 file
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 41
Fix these checkpatch.pl warnings:
WARNING: else is not generally useful after a break or return
Also, remove an unnecessary trailing ';' at the end of a function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Fix the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbdux.c | 12
Fix the checkpatch.pl warning in this file:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/8255.c | 3
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das08.c | 1 -
1 file changed, 1
Fix the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_labpc.c | 4 ++--
1
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s526.c | 1 -
1 file changed, 1
Fix the checkpatch.pl warnings:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 9 -
1
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio_internal.h | 2 --
1 file
Christoph == hch@infradead org h...@infradead.org writes:
Christoph Oh, we actually have devices that support WRITE SAME with
Christoph unmap, but not without? That's defintively a little strange.
Yep :(
There were several SSDs that did not want to support wearing out flash
by writing gobs of
Fix the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tiocmd.c | 1 -
1 file
On Wed, Jul 16, 2014 at 01:47:35PM -0400, Martin K. Petersen wrote:
There were several SSDs that did not want to support wearing out flash
by writing gobs of zeroes and only support the UNMAP case.
Given that SSDs usually aren't hard provisioned anyway that seems like
an odd decision. But SAS
Fix the checkpatch.pl warning in this file:
WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/8253.h
Continue cleaning up the checkpatch.pl issues. This pass gets the:
WARNING: void function return statements are not generally useful
WARNING: Missing a blank line after declarations
It also fixes this one that was missed in the serial2000 driver:
WARNING: else is not generally useful after a
Fix the checkpatch.pl warning in this file:
WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
Fix this checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1723.c | 5 ++---
1 file
Fix this checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4
1 file
Fix the checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das1800.c | 13
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/multiq3.c | 4 ++--
1 file changed,
Fix checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2815.c | 1 +
1 file changed, 1
Fix the checkpatch.pl warning:
WARNING: void function return statements are not generally useful
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 2
Fix checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt9812.c | 1 +
1 file changed, 1
Fix thess checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16.c | 8
1 file
Tidy up this function a bit to reduce the indent level.
This also fixex the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Fix this checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pc236.c | 1 +
1 file
Fix the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_tio.c | 1 +
1 file changed, 1
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_pcidio.c | 2 ++
1 file changed,
Fix the checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmuio.c | 1 +
1 file changed, 1
Fix the checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mite.c | 3 +++
1 file changed, 3
Fix checkpatch.pl warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/jr3_pci.c | 5 -
1 file changed, 4
On Wed, 2014-07-16 at 13:47 -0400, Martin K. Petersen wrote:
Christoph == hch@infradead org h...@infradead.org writes:
Christoph Oh, we actually have devices that support WRITE SAME with
Christoph unmap, but not without? That's defintively a little strange.
Yep :(
There were several
Fix these checkpatch.pl warnings:
WARNING: Possible switch case/default not preceeded by break or fallthrough
comment
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
1 - 100 of 156 matches
Mail list logo
