Re: [PATCH] staging: Fix a Fix me in tranzport.c

2014-07-19 Thread Dan Carpenter
On Sat, Jul 19, 2014 at 01:26:52AM -0400, Nicholas Krause wrote: This patch add a atomic lock in usb_tranzport_usb for preventing a tiny race in this function. Signed-off-by: Nicholas Krause xerofo...@gmail.com Is this a guess work patch or have you tested it? regards, dan carpenter

[PATCH 1/4] Solves some problems reported by checkpatch

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 75ca15e..177e4b9 100644 ---

[PATCH 4/4] Fix blank lines issue reported by checkpatch

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 47 -- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 6f98881..89a1d53 100644

[PATCH 3/4] Fix misceanellous problems reported by checkpatch

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 1580d95f..6f98881 100644 --- a/drivers/staging/sep/sep_main.c

[PATCH 2/4] No else is necessary after a break (reported by checkpatch)

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 177e4b9..1580d95f 100644 --- a/drivers/staging/sep/sep_main.c

[PATCH] staging:iio:ad7280a: Use managed interfaces

2014-07-19 Thread Himangi Saraogi
This patch moves data allocated using unmanaged interfaces to managed interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf, devm_request_threaded_irq and does away with the calls to free the allocated memory in the probe and remove functions. Some labels in the probe function are

[PATCH 1/1] Staging: comedi: adl_paci9118: organized entry comments

2014-07-19 Thread Sam Asadi
Introductory comments organized according to Linux's comment coding style. Signed-off-by: Sam Asadi asadi.sam...@gmail.com --- drivers/staging/comedi/drivers/adl_pci9118.c | 109 +- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git

[PATCH 6/8] staging: unisys: clean up diagdump proc entry code

2014-07-19 Thread Benjamin Romer
Remove remnant code left over from the diagdump proc entry. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Benjamin Romer
This patch set moves several interfaces in the visorchipset module from procfs to sysfs, and removes the remaining proc interfaces from the module. It includes documentation for the new interfaces in Documentation/ABI, and some code cleanup in the new sysfs handler functions. Benjamin Romer (8):

[PATCH 4/8] staging: unisys: move chipsetready to sysfs

2014-07-19 Thread Benjamin Romer
Move the chipsetready proc entry to sysfs under a new directory guest. This entry is used by Unisys application software on the guest to acknowledge completion of specific events for integration purposes, but these acknowledgements are not required for the guest to operate correctly. The store

[PATCH 8/8] staging: unisys: ABI documentation for new sysfs entries

2014-07-19 Thread Benjamin Romer
This patch adds a documentation file for all of the interfaces that were moved to sysfs by the other patches in this set. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- .../Documentation/ABI/sysfs-platform-visorchipset | 74 ++ 1 file changed, 74 insertions(+)

[PATCH 5/8] staging: unisys: move parahotplug to sysfs

2014-07-19 Thread Benjamin Romer
Move the /proc/visorchipset/parahotplug interface to sysfs under /sys/devices/platform/visorchipset/guest/parahotplug. The parahotplug interface is used to deal with recovery situations on s-Par guest partitions. The command service partition will send a message to a guest when a device that

[PATCH 1/8] staging: unisys: add toolaction to sysfs

2014-07-19 Thread Benjamin Romer
Move the proc entry for controlling the toolaction field to sysfs. The field appears in /sys/devices/platform/visorchipset/install/toolaction. This field is used to tell s-Par which type of recovery tool action to perform on the next guest boot-up. The meaning of the value is dependent on the

[PATCH 3/8] staging: unisys: move installer to sysfs and split fields

2014-07-19 Thread Benjamin Romer
The installer entry in /proc/visorchipset/installer was composed of three separate fields as one entry. This patch removes the proc entry and associated functions, and creates new fields with distinct entries under sysfs in the visorchipset/install directory. The fields are: textid: used

Re: [PATCH 1/8] staging: unisys: add toolaction to sysfs

2014-07-19 Thread Greg KH
On Sat, Jul 19, 2014 at 10:26:54AM -0400, Benjamin Romer wrote: Move the proc entry for controlling the toolaction field to sysfs. The field appears in /sys/devices/platform/visorchipset/install/toolaction. This field is used to tell s-Par which type of recovery tool action to perform on the

[PATCH] staging: sep: Fix issues reported by checkpatch

2014-07-19 Thread LABBE Corentin
Hello The drivers/staging/sep/sep_main.c have lots of checkpatch issue. This patch series solves them and since there are many, I have splitted corrections in 4 patch. Note that this work is done for the Eudyptulla Challenge. Best regards ___ devel

[PATCH 2/4] staging: sep: No else is necessary after a break (reported by checkpatch)

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 177e4b9..1580d95f 100644 --- a/drivers/staging/sep/sep_main.c

[PATCH 3/4] staging: sep: Fix misceanellous problems reported by checkpatch

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 1580d95f..6f98881 100644 --- a/drivers/staging/sep/sep_main.c

[PATCH 1/4] staging: sep: Solves some problems reported by checkpatch

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 75ca15e..177e4b9 100644 ---

[PATCH 4/4] staging: sep: Fix blank lines issue reported by checkpatch

2014-07-19 Thread LABBE Corentin
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 47 -- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c index 6f98881..89a1d53 100644

Re: [PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Ben Romer
Greg KH gre...@linuxfoundation.org wrote: What happened to the idea of only creating the sysfs files _if_ it is needed? You are always creating these files, and then can return -ENODEV if the device really isn't there, that's not what you should do for a sysfs file. If the file is present,

staging: lustre/lustre/lov: Cleanup style issues in lov_request.c

2014-07-19 Thread Riccardo Lucchese
Hello, This patch series fixes two coding style issues and removes an unneeded 'if' statement in lov_request.c. Thanks, riccardo ___ devel mailing list de...@linuxdriverproject.org

[PATCH 2/3] staging: lustre/lustre/lov: Add a blank line after declarations in lov_request.c

2014-07-19 Thread Riccardo Lucchese
Fix the following checkpatch.pl issue in lov_request.c: WARNING: Missing a blank line after declarations Signed-off-by: Riccardo Lucchese riccardo.lucch...@gmail.com --- drivers/staging/lustre/lustre/lov/lov_request.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

2014-07-19 Thread Riccardo Lucchese
It is silly to go through an if statement to set a single boolean value in function of a single boolean expression. In the function lov_check_set, assign the return value directly. Signed-off-by: Riccardo Lucchese riccardo.lucch...@gmail.com --- drivers/staging/lustre/lustre/lov/lov_request.c |

[PATCH 3/3] staging: lustre/lustre/lov: Add a space before open braces '{' in lov_request.c

2014-07-19 Thread Riccardo Lucchese
Fix the following checkpatch.pl issue in lov_request.c: ERROR: space required before the open brace '{' Signed-off-by: Riccardo Lucchese riccardo.lucch...@gmail.com --- drivers/staging/lustre/lustre/lov/lov_request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Greg KH
On Sat, Jul 19, 2014 at 02:26:48PM -0400, Ben Romer wrote: Greg KH gre...@linuxfoundation.org wrote: What happened to the idea of only creating the sysfs files _if_ it is needed? You are always creating these files, and then can return -ENODEV if the device really isn't there, that's not

Re: [PATCH 1/8] staging: unisys: add toolaction to sysfs

2014-07-19 Thread Greg KH
On Sat, Jul 19, 2014 at 10:26:54AM -0400, Benjamin Romer wrote: +ssize_t show_toolaction(struct device *dev, struct device_attribute *attr, + char *buf) +{ + if (ControlVm_channel) { + U8 toolAction; + + visorchannel_read(ControlVm_channel, +

Re: [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

2014-07-19 Thread Joe Perches
On Sat, 2014-07-19 at 21:34 +0200, Riccardo Lucchese wrote: It is silly to go through an if statement to set a single boolean value in function of a single boolean expression. In the function lov_check_set, assign the return value directly. [] diff --git

Re: [PATCH] staging:iio:ad7280a: Use managed interfaces

2014-07-19 Thread Julia Lawall
On Sat, 19 Jul 2014, Jonathan Cameron wrote: On 19/07/14 11:33, Himangi Saraogi wrote: This patch moves data allocated using unmanaged interfaces to managed interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf, devm_request_threaded_irq and does away with the calls to

Re: [PATCH] staging:iio:ad7280a: Use managed interfaces

2014-07-19 Thread Jonathan Cameron
On 19/07/14 21:46, Julia Lawall wrote: On Sat, 19 Jul 2014, Jonathan Cameron wrote: On 19/07/14 11:33, Himangi Saraogi wrote: This patch moves data allocated using unmanaged interfaces to managed interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf,

Re: [PATCH] staging: Fix a Fix me in tranzport.c

2014-07-19 Thread Nick Krause
On Sat, Jul 19, 2014 at 5:14 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Jul 19, 2014 at 12:09:53PM +0300, Dan Carpenter wrote: On Sat, Jul 19, 2014 at 01:26:52AM -0400, Nicholas Krause wrote: This patch add a atomic lock in usb_tranzport_usb for preventing a tiny race in this

[PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed

2014-07-19 Thread Sam Asadi
A line over 80 issue fixed, which is a comment. Signed-off-by: Sam Asadi asadi.sam...@gmail.com --- drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c

Re: [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed

2014-07-19 Thread Joe Perches
On Sun, 2014-07-20 at 03:43 +0300, Sam Asadi wrote: A 'Missing a blank line after declarations' issue fixed and also tested by 'make M=...'. It seems that after 'unsigned long iobase' declaration a blank line is desperately needed. [] diff --git a/drivers/staging/comedi/drivers/8255.c

Re: [PATCH 2/4] staging: sep: No else is necessary after a break (reported by checkpatch)

2014-07-19 Thread Joe Perches
(Adding Mark Allyn and Jayant Mangalampalli) Is this still project still active? On Sat, 2014-07-19 at 19:34 +0200, LABBE Corentin wrote: Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- drivers/staging/sep/sep_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [PATCH 2/2] Staging: comedi: adv_pci1710.c line over 80 fixed

2014-07-19 Thread Greg KH
On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote: A line over 80 issue fixed, which is a comment. Signed-off-by: Sam Asadi asadi.sam...@gmail.com --- drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] staging: android: ion: ion_cma_heap.c: Fix checkpatch warning

2014-07-19 Thread Phong Tran
This patch fix coding style: - Remove fail memory allocation waring - Remove return of void function Tested by compilation only Signed-off-by: Phong Tran tranmanph...@gmail.com --- drivers/staging/android/ion/ion_cma_heap.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

[PATCH 1/1] Staging: comedi: adv_pci1710: a line over 80 fixed

2014-07-19 Thread Sam Asadi
a line over 80 issue fixed by removing the cross-lined comment to the previous line. Signed-off-by: Sam Asadi asadi.sam...@gmail.com --- drivers/staging/comedi/drivers/adv_pci1710.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set()

2014-07-19 Thread Dan Carpenter
On Sat, Jul 19, 2014 at 09:34:56PM +0200, Riccardo Lucchese wrote: It is silly to go through an if statement to set a single boolean value in function of a single boolean expression. In the function lov_check_set, assign the return value directly. Signed-off-by: Riccardo Lucchese

[PATCH] Staging: vt6655: remove redundant comments

2014-07-19 Thread Igor Bezukh
Clean redundant comments in the code. Since I perform single fix type per patch, I've ignored the 80 line warning when checking the patch against checkpatch. I will fix the 80 line warnings on further patches. Signed-off-by: Igor Bezukh igb...@gmail.com --- drivers/staging/vt6655/wcmd.c | 46