- this fixes sparse warning for directly deferencing user space buffer
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33: warning: incorrect
type in argument 2 (different address spaces)
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33:expected void
const [noderef]
You need to compile these things before sending them...
This adds a GCC warning about uncalled functions.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
On Wed, Jul 30, 2014 at 08:47:19PM -0300, Murilo Opsfelder Araujo wrote:
Thanks for reviewing my first patch, Joe. How about this new one,
guys?
-- 8 --
Consequently, made checkpatch.pl happy.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
This changelog is all mangled.
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 21 -
drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 1 -
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c
b/drivers/staging/rtl8723au/os_dep/usb_intf.c
index
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/os_dep/usb_intf.c | 45 +++--
1 file changed, 10 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c
From: Jes Sorensen jes.soren...@redhat.com
struct registry_priv.usbss_enable and
struct pwrctrl_priv.bHWPwrPindetect are never set.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/core/rtw_cmd.c| 13 -
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/hal/odm_HWConfig.c | 7 ++-
drivers/staging/rtl8723au/include/odm.h | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git
El 31/07/2014 10:21, Dan Carpenter dan.carpen...@oracle.com escribió:
You need to compile these things before sending them...
This adds a GCC warning about uncalled functions.
Sorry, but I did compile it with
make C=1 M=drivers/staging
But for the function to be called, DEBUG_EPROM must be
These conditions can never be true because i is always one more than
NI_660X_MAX_RTSI_CHAN after the loop.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/comedi/drivers/ni_tio.c
b/drivers/staging/comedi/drivers/ni_tio.c
index f9f6320..9d4b46c 100644
---
On 2014-07-31 10:29, Dan Carpenter wrote:
These conditions can never be true because i is always one more than
NI_660X_MAX_RTSI_CHAN after the loop.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail:
On Thu, Jul 31, 2014 at 11:10:33AM +0200, Fernando Apesteguía wrote:
El 31/07/2014 10:21, Dan Carpenter dan.carpen...@oracle.com escribió:
You need to compile these things before sending them...
This adds a GCC warning about uncalled functions.
Sorry, but I did compile it with
make
On 07/30/2014 09:17 PM, Greg KH wrote:
Does not apply to my tree at all :(
I was using linux-next. No checkpatch.pl warnings for sw_sync.c in
staging-next.
--
Murilo
___
devel mailing list
de...@linuxdriverproject.org
On 07/31/2014 12:02 AM, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed
Hi,
Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a
écrit :
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
Is this some kind of game ?
The *same* patch was sent three times from three different email
addresses:
On Thu, Jul 31, 2014 at 03:00:19PM +0200, Yann Droneaud wrote:
Hi,
Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a
écrit :
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
Is this some kind of game ?
The *same* patch was sent
Removes unneeded dgnc_trace.c and dgnc_trace.h
CC: Lidza Louina lidza.lou...@gmail.com
CC: Mark Hounschell ma...@compro.net
Signed-off-by: Seunghun Lee way...@gmail.com
---
drivers/staging/dgnc/Makefile |2 +-
drivers/staging/dgnc/dgnc_cls.c|1 -
On 31/07/14 13:11, Dexuan Cui wrote:
-Original Message-
From: Tomi Valkeinen [mailto:tomi.valkei...@ti.com]
Sent: Wednesday, July 30, 2014 22:24 PM
+static struct fb_info *hvfb_info;
Static variables like these are usually a no-no. This prevents you from
having multiple device
Hi,
Le jeudi 31 juillet 2014 à 16:30 +0300, Dan Carpenter a écrit :
On Thu, Jul 31, 2014 at 03:00:19PM +0200, Yann Droneaud wrote:
Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a
écrit :
Fix coding style issue.
Signed-off-by: Murilo Opsfelder Araujo
Fix checkpatch issue: CHECK: multiple assignments should be avoided.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 53 +--
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
b/drivers/staging/comedi/drivers/amplc_pci224.c
index
Reformat comments to fit in with the preferred coding style, including
the copyright and comedi driver description comments at the start of the
file. Also, remove a boiler-plate comment for the comedi device private
data structure.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
Fix checkpatch issues: CHECK: Blank lines aren't necessary before a
close brace '}'.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
Since anything non-zero is logically true, don't bother doing
not-equal comparisons with zero, except when testing for an explicit
number 0 (not as a result of bit tests for example).
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 16
The `driver_data` member value from the matched entry of the PCI module
device table `amplc_pci224_pci_table[]` is passed through to our comedi
auto_attach handler, `pci224_auto_attach()`. Use that to index
directly into our static board data array `pci224_boards[]` instead of
calling
Remove the address-of operator when the operand is a function.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
b/drivers/staging/comedi/drivers/amplc_pci224.c
index 8ce0f4f..f786237 100644
---
The comedi core module calls `comedi_set_hw_dev()` to associate the
hardware `struct device` with the `struct comedi_device` before it calls
the comedi driver's auto_attach hook `pci224_auto_attach()`. There is
no need for `pci224_auto_attach()` to call `comedi_set_hw_dev()` itself,
so remove the
Since the driver no longer supports options in its legacy attach
mechanism to describe the jumper settings (or any options beyond
restricting a PCI search to a particular bus and/or slot), there is no
need to retain this mechanism in the driver. Remove the comedi driver
attach handler
When attaching a PCI224 or PCI234 manually via the `COMEDI_DEVCONFIG`
ioctl, there are several options the user can supply that describe the
state of the hardware jumpers (LK1 for PCI224, LK1 thru LK5 for PCI234).
These options control how the driver sets up the AO range tables for the
device.
Fix checkpatch issue: CHECK: spinlock_t definition without comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
The macros `PCI_DEVICE_ID_AMPLICON_PCI224` and
`PCI_DEVICE_ID_AMPLICON_PCI234` are only used in the PCI module device
table `amplc_pci224_pci_table[]`. Just expand the macros where they are
used and remove them. The macro `PCI_DEVICE_ID_INVALID` is no longer
used either, so remove it.
`pci224_attach_common()` is now only called from `pci225_auto_attach()`,
so absorb it into that function.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 56 +++
1 file changed, 22 insertions(+), 34 deletions(-)
diff --git
Add a bit of whitespace to the initializer of `pci224_boards[]` for
aesthetic reasons.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git
This driver no longer supports a legacy attach mechanism that searches
for a suitable PCI device and increments it's reference count, but since
the common detach handler `pci224_detach()` still has a left-over
`pci_dev_put()`, a matching `pci_dev_get()` is needed in the
auto_attach handler
The ii_pci20kc module is a comedi driver for Intelligent Instruments
PCI-20001C carrier board and modules. Despite the name, this is
actually an ISA board and uses 1K of ISA memory space (below 1M) for the
main board plus up to three modules. The address is set by hardware
jumpers.
When the
Bitwise AND was intended here obviously.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static analysis. I wasn't able to compile this.
Also lustre needs an entry in MAINTAINERS because otherwise
get_maintainer.pl still sends everything to Peng Tao only.
diff --git
This patch switches all use of the U16 typedef to use the kernel's u16 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../include/channels/controlframework.h| 18
.../include/channels/controlvmchannel.h| 24
Delete the S32 type from commontypes.h since it wasn't being used.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/commontypes.h
The include/commontypes.h file defines many types and functions locally when the
kernel's existing definitions should have been used instead. This patch series
converts UINTN and all of the U16 through U64 and S8 through S64 types to kernel
types, and gets rid of the MEMCMP, MEMSET, STRLEN,
This patch switches all use of the S16 typedef to use the kernel's s16 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/channels/diagchannel.h | 2 +-
drivers/staging/unisys/include/commontypes.h | 1 -
2
This patch deletes everything in common types that was in the else section
of a #ifdef __KERNEL__ block.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 62
1 file changed, 62 deletions(-)
diff --git
This patch removes UINTN from commontypes.h, using u64 in the one spot this
type was used.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 4 ++--
drivers/staging/unisys/include/commontypes.h | 6 --
Remove the redundant MEMSET define in commontypes.h and fix everyplace that
uses it.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 2 +-
drivers/staging/unisys/common-spar/include/channels/iochannel.h | 6 +++---
This patch removes MEMCMP_IO from commontypes.h and fixes the one use of the
macro so it calls uuid_cmp_le() instead. The old code was comparing UUIDs
directly.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 4 ++--
This patch switches all use of the S64 typedef to use the kernel's s64 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 2 --
drivers/staging/unisys/include/uisutils.h| 4 ++--
drivers/staging/unisys/visorchipset/file.c
Delete the S8 type from commontypes.h since it wasn't being used.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/commontypes.h
Delete #defines that aren't used anywhere.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/include/commontypes.h
b/drivers/staging/unisys/include/commontypes.h
This patch switches all use of the U32 typedef to use the kernel's u32 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/channels/channel.c | 8 +-
drivers/staging/unisys/channels/chanstub.c | 4 +-
On Thursday, July 31, 2014 7:57 AM, Ian Abbott wrote:
The ii_pci20kc module is a comedi driver for Intelligent Instruments
PCI-20001C carrier board and modules. Despite the name, this is
actually an ISA board and uses 1K of ISA memory space (below 1M) for the
main board plus up to three
On Thursday, July 31, 2014 2:29 AM, Dan Carpenter wrote:
These conditions can never be true because i is always one more than
NI_660X_MAX_RTSI_CHAN after the loop.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com
WARNING: Unnecessary space before function pointer arguments
+ int (*func) (struct mibrec *mib,
WARNING: Missing a blank line after declarations
+ hfa384x_WPAData_t wpa;
+ if (isget) {
Signed-off-by: Modestas Stankus stankus.modes...@gmail.com
WARNING: break is not useful after a goto or return
201: FILE: drivers/staging/wlan-ng/p80211conv.c:201:
+ return 1;
+ break;
Signed-off-by: Modestas Stankus stankus.modes...@gmail.com
---
drivers/staging/wlan-ng/p80211conv.c | 1 -
1 file changed, 1 deletion(-)
diff
On 7/17/2014 5:05 PM, Arnd Bergmann wrote:
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote:
On 7/17/2014 7:28 AM, Chen Gang wrote:
According to current source code, tile still has chance to choose
NO_IOMEM, for me, welcome the tile's maintainer's ideas or suggestions.
I'm not really
On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
The amplc_pci224 driver retains a legacy attach mechanism via the
`COMEDI_DEVCONFIG` ioctl and the comedi driver attach hook, but
usually attaches PCI devices automatically via the comedi driver's
auto_attach hook. The legacy mechanism is
On Thursday, July 31, 2014 1:28 PM, Hartley Sweeten wrote:
On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
The amplc_pci224 driver retains a legacy attach mechanism via the
`COMEDI_DEVCONFIG` ioctl and the comedi driver attach hook, but
usually attaches PCI devices automatically via the
Some functions defined in r8192U_core.c and only used locally are marked as
static.
This fixes some warnings issues by sparse.
Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr
---
drivers/staging/rtl8192u/r8192U_core.c | 8 +---
1 file changed, 5 insertions(+), 3
function dump_eprom is only used when DEBUG_EPROM is set.
function txqueue2outpipe is only used when USE_ONE_PIPE is unset.
function GetRxPacketShiftBytes819xUsb is only used when
USB_RX_AGGREGATION_SUPPORT is set.
Compile these functions only when they will actually be used.
Signed-off-by:
On Wed, Jul 30, 2014 at 05:06:41PM -0700, Greg Kroah-Hartman wrote:
On Mon, Jul 28, 2014 at 05:52:46PM +0200, Antoine Schweitzer-Chaput wrote:
Some functions defined in r8192U_core.c and only used locally are marked as
static.
This fixes some warnings issued by sparse.
Signed-off-by:
On Thu, Jul 31, 2014 at 08:47:07AM -0300, Murilo Opsfelder Araujo wrote:
On 07/30/2014 09:17 PM, Greg KH wrote:
Also doesn't apply, are you sure you are using the staging-next branch
of staging.git on git.kernel.org?
I was using linux-next, not staging-next. sync.c has no checkpatch.pl
This patch adds missing blank line after declarations.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/adis16203_core.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/accel/adis16203_core.c
This patch adds missing blank line after declaration.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/adis16209_core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/accel/adis16209_core.c
The following patches fix (almost) all warnings reported by
checkpatch.pl.
Murilo Opsfelder Araujo (8):
staging: iio: accel: adis16203_core.c: fix coding style
staging: iio: accel: adis16201_core.c: fix coding style
staging: iio: accel: adis16204_core.c: fix coding style
staging: iio:
This patch adds missing blank line after declaration.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/adis16204_core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/accel/adis16204_core.c
This patch adds missing blank line after declaration and fixes lines
starting by space.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/adis16201_core.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
This patch adds missing blank line after declaration and keep line in
80-chars limit.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/sca3000_core.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
This patch adds missing blank line after declarations.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/lis3l02dq_core.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/iio/accel/lis3l02dq_core.c
This patch adds missing blank lines after declarations.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/lis3l02dq_ring.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/accel/lis3l02dq_ring.c
This patch adds missing blank line after declaration.
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
drivers/staging/iio/accel/adis16240_core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/accel/adis16240_core.c
On Thu, 2014-07-31 at 19:34 -0300, Murilo Opsfelder Araujo wrote:
The following patches fix (almost) all warnings reported by
checkpatch.pl.
Murilo Opsfelder Araujo (8):
staging: iio: accel: adis16203_core.c: fix coding style
staging: iio: accel: adis16201_core.c: fix coding style
Hi, Mark
2014-07-31 21:44 GMT+09:00 Mark Hounschell ma...@compro.net:
On 07/31/2014 12:02 AM, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
This patchset creates a simple subdevice to allow for reading of the
board's diagnostic status, and then removes any code which is related to
diagnostic interrupts, as the driver will not support these at this time.
Chase Southwood (2):
staging: comedi: addi_apci_1564: add subdevice to check
This board provides VCC/CC diagnostic information, and it also supports
diagnostic interrupts. However, as per Ian, these interrupts aren't very
useful and it is enough to simply provide an interface for accessing the
diagnostic status on-demand. This patch adds a 2-channel digital input
As per Ian, at this point in time it is not worth implementing an async
command interface for diagnostic interrupts for this board. As this is
the case, this patch removes the code which supports such interrupts as it
is now unused.
This includes removing apci1564_do_read(), which was the
From: K. Y. Srinivasan k...@microsoft.com
Date: Wed, 30 Jul 2014 18:35:49 -0700
For forwarding scenarios, it will be useful to allocate larger
sendbuf. Make the necessary adjustments to permit this.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
This needs more information.
You're
75 matches
Mail list logo
