Re: [PATCH 1/1] Drivers: net-next: hyperv: Increase the size of the sendbuf region

2014-07-31 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 30 Jul 2014 18:35:49 -0700 > For forwarding scenarios, it will be useful to allocate larger > sendbuf. Make the necessary adjustments to permit this. > > Signed-off-by: K. Y. Srinivasan This needs more information. You're increasing the size by 16 times, 1M

[PATCH 2/2] staging: comedi: addi_apci_1564: remove diagnostic interrupt support code

2014-07-31 Thread Chase Southwood
As per Ian, at this point in time it is not worth implementing an async command interface for diagnostic interrupts for this board. As this is the case, this patch removes the code which supports such interrupts as it is now unused. This includes removing apci1564_do_read(), which was the insn_re

[PATCH 1/2] staging: comedi: addi_apci_1564: add subdevice to check diagnostic status

2014-07-31 Thread Chase Southwood
This board provides VCC/CC diagnostic information, and it also supports diagnostic interrupts. However, as per Ian, these interrupts aren't very useful and it is enough to simply provide an interface for accessing the diagnostic status on-demand. This patch adds a 2-channel digital input subdevic

[PATCH 0/2] staging: comedi: addi_apci_1564: provide interface to read diagnostic status

2014-07-31 Thread Chase Southwood
This patchset creates a simple subdevice to allow for reading of the board's diagnostic status, and then removes any code which is related to diagnostic interrupts, as the driver will not support these at this time. Chase Southwood (2): staging: comedi: addi_apci_1564: add subdevice to check dia

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-31 Thread DaeSeok Youn
Hi, Mark 2014-07-31 21:44 GMT+09:00 Mark Hounschell : > On 07/31/2014 12:02 AM, Daeseok Youn wrote: >> >> When a configration file is parsed with dgap_parsefile(), >> makes nodes for saving configrations for board. >> >> Making a node will allocate node memory and strings for saving >> configratio

Re: [PATCH 0/8] staging: iio: accel: multiple coding style fixes

2014-07-31 Thread Joe Perches
On Thu, 2014-07-31 at 19:34 -0300, Murilo Opsfelder Araujo wrote: > The following patches fix (almost) all warnings reported by > checkpatch.pl. > > Murilo Opsfelder Araujo (8): > staging: iio: accel: adis16203_core.c: fix coding style > staging: iio: accel: adis16201_core.c: fix coding style

[PATCH 5/8] staging: iio: accel: adis16240_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declaration. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/adis16240_core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c index 74ace2

[PATCH 8/8] staging: iio: accel: sca3000_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declaration and keep line in 80-chars limit. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/sca3000_core.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/

[PATCH 6/8] staging: iio: accel: lis3l02dq_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declarations. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/lis3l02dq_core.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/iio/accel/lis3l02dq_core.c b/drivers/staging/iio/accel/lis3l02dq_core.c index 8

[PATCH 7/8] staging: iio: accel: lis3l02dq_ring.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank lines after declarations. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/lis3l02dq_ring.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/lis3l02dq_ring.c b/drivers/staging/iio/accel/lis3l02dq_ring.c index bf33

[PATCH 2/8] staging: iio: accel: adis16201_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declaration and fixes lines starting by space. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/adis16201_core.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201_core.c b/

[PATCH 4/8] staging: iio: accel: adis16209_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declaration. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/adis16209_core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c index 374dc6

[PATCH 0/8] staging: iio: accel: multiple coding style fixes

2014-07-31 Thread Murilo Opsfelder Araujo
The following patches fix (almost) all warnings reported by checkpatch.pl. Murilo Opsfelder Araujo (8): staging: iio: accel: adis16203_core.c: fix coding style staging: iio: accel: adis16201_core.c: fix coding style staging: iio: accel: adis16204_core.c: fix coding style staging: iio: acce

[PATCH 3/8] staging: iio: accel: adis16204_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declaration. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/adis16204_core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/adis16204_core.c b/drivers/staging/iio/accel/adis16204_core.c index 19eaeb

[PATCH 1/8] staging: iio: accel: adis16203_core.c: fix coding style

2014-07-31 Thread Murilo Opsfelder Araujo
This patch adds missing blank line after declarations. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/adis16203_core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/accel/adis16203_core.c b/drivers/staging/iio/accel/adis16203_core.c index f47

Re: [PATCH] Staging: android: sync.c: fix missing blank line after declaration

2014-07-31 Thread Greg KH
On Thu, Jul 31, 2014 at 08:47:07AM -0300, Murilo Opsfelder Araujo wrote: > On 07/30/2014 09:17 PM, Greg KH wrote: > >Also doesn't apply, are you sure you are using the staging-next branch > >of staging.git on git.kernel.org? > > I was using linux-next, not staging-next. sync.c has no checkpatch.p

Re: [PATCH 1/1] staging: rtl8192u: mark some functions as static.

2014-07-31 Thread Antoine Schweitzer-Chaput
On Wed, Jul 30, 2014 at 05:06:41PM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 28, 2014 at 05:52:46PM +0200, Antoine Schweitzer-Chaput wrote: > > Some functions defined in r8192U_core.c and only used locally are marked as > > static. > > This fixes some warnings issued by sparse. > > > > Signe

[PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

2014-07-31 Thread Antoine Schweitzer-Chaput
function dump_eprom is only used when DEBUG_EPROM is set. function txqueue2outpipe is only used when USE_ONE_PIPE is unset. function GetRxPacketShiftBytes819xUsb is only used when USB_RX_AGGREGATION_SUPPORT is set. Compile these functions only when they will actually be used. Signed-off-by: Antoi

[PATCH 1/2] staging: rlt8192u: mark some functions as static

2014-07-31 Thread Antoine Schweitzer-Chaput
Some functions defined in r8192U_core.c and only used locally are marked as static. This fixes some warnings issues by sparse. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/

RE: [PATCH 00/18] staging: comedi: amplc_pci224: remove legacy stuff

2014-07-31 Thread Hartley Sweeten
On Thursday, July 31, 2014 1:28 PM, Hartley Sweeten wrote: > On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote: >> The "amplc_pci224" driver retains a "legacy" attach mechanism via the >> `COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but >> usually attaches PCI devices automatica

RE: [PATCH 00/18] staging: comedi: amplc_pci224: remove legacy stuff

2014-07-31 Thread Hartley Sweeten
On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote: > The "amplc_pci224" driver retains a "legacy" attach mechanism via the > `COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but > usually attaches PCI devices automatically via the comedi driver's > "auto_attach" hook. The legacy me

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-31 Thread Chris Metcalf
On 7/17/2014 5:05 PM, Arnd Bergmann wrote: On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote: On 7/17/2014 7:28 AM, Chen Gang wrote: According to current source code, tile still has chance to choose NO_IOMEM, for me, welcome the tile's maintainer's ideas or suggestions. I'm not really sure

[PATCH] staging: wlan-ng: coding style problem fix

2014-07-31 Thread Modestas Stankus
WARNING: break is not useful after a goto or return 201: FILE: drivers/staging/wlan-ng/p80211conv.c:201: + return 1; + break; Signed-off-by: Modestas Stankus --- drivers/staging/wlan-ng/p80211conv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wl

[PATCH] staging: wlan-ng: fixing coding style problems

2014-07-31 Thread Modestas Stankus
WARNING: Unnecessary space before function pointer arguments + int (*func) (struct mibrec *mib, WARNING: Missing a blank line after declarations + hfa384x_WPAData_t wpa; + if (isget) { Signed-off-by: Modestas Stankus --- drivers/staging/wlan-ng/

RE: [patch] staging: comedi: ni_tio: remove some dead code

2014-07-31 Thread Hartley Sweeten
On Thursday, July 31, 2014 2:29 AM, Dan Carpenter wrote: > These conditions can never be true because "i" is always one more than > NI_660X_MAX_RTSI_CHAN after the loop. > > Signed-off-by: Dan Carpenter Reviewed-by: H Hartley Sweeten ___ devel mailing

RE: [PATCH] staging: comedi: ii_pci20kc: request and ioremap memory

2014-07-31 Thread Hartley Sweeten
On Thursday, July 31, 2014 7:57 AM, Ian Abbott wrote: > The "ii_pci20kc" module is a comedi driver for Intelligent Instruments > PCI-20001C carrier board and modules. Despite the name, this is > actually an ISA board and uses 1K of ISA memory space (below 1M) for the > main board plus up to three

[PATCH 02/12] staging: unisys: remove U32 type

2014-07-31 Thread Benjamin Romer
This patch switches all use of the U32 typedef to use the kernel's u32 type instead. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/channels/channel.c | 8 +- drivers/staging/unisys/channels/chanstub.c | 4 +- drivers/staging/unisys/channels/chanstub.h |

[PATCH 03/12] staging: unisys: remove U64 type

2014-07-31 Thread Benjamin Romer
This patch switches all use of the U64 typedef to use the kernel's u64 type instead. Signed-off-by: Benjamin Romer --- .../unisys/common-spar/include/channels/channel.h | 42 ++--- .../include/channels/controlframework.h| 2 +- .../include/channels/controlvmchannel.

[PATCH 07/12] staging: unisys: remove S64 type

2014-07-31 Thread Benjamin Romer
This patch switches all use of the S64 typedef to use the kernel's s64 type instead. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 2 -- drivers/staging/unisys/include/uisutils.h| 4 ++-- drivers/staging/unisys/visorchipset/file.c | 4 ++-- 3 files change

[PATCH 04/12] staging: unisys: remove S8 type

2014-07-31 Thread Benjamin Romer
Delete the S8 type from commontypes.h since it wasn't being used. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/include/commontypes.h b/drivers/staging/unisys/include/commontypes.h index 2

[PATCH 09/12] staging: unisys: remove unused defines from commontypes.h

2014-07-31 Thread Benjamin Romer
Delete #defines that aren't used anywhere. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/include/commontypes.h b/drivers/staging/unisys/include/commontypes.h index 2aac0dd..b569c34 1006

[PATCH 12/12] staging: unisys: remove MEMCMP_IO

2014-07-31 Thread Benjamin Romer
This patch removes MEMCMP_IO from commontypes.h and fixes the one use of the macro so it calls uuid_cmp_le() instead. The old code was comparing UUIDs directly. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/channel.h | 4 ++-- drivers/staging/unisys/includ

[PATCH 11/12] staging: unisys: remove MEMSET define

2014-07-31 Thread Benjamin Romer
Remove the redundant MEMSET define in commontypes.h and fix everyplace that uses it. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/channel.h | 2 +- drivers/staging/unisys/common-spar/include/channels/iochannel.h | 6 +++--- drivers/staging/unisys/includ

[PATCH 05/12] staging: unisys: remove S16 type

2014-07-31 Thread Benjamin Romer
This patch switches all use of the S16 typedef to use the kernel's s16 type instead. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/diagchannel.h | 2 +- drivers/staging/unisys/include/commontypes.h | 1 - 2 files changed, 1 insertion(+

[PATCH 08/12] staging: unisys: remove non-kernel code from commontypes.h

2014-07-31 Thread Benjamin Romer
This patch deletes everything in common types that was in the else section of a #ifdef __KERNEL__ block. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 62 1 file changed, 62 deletions(-) diff --git a/drivers/staging/unisys/include/

[PATCH 10/12] staging: unisys: remove UINTN type

2014-07-31 Thread Benjamin Romer
This patch removes UINTN from commontypes.h, using u64 in the one spot this type was used. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/channel.h | 4 ++-- drivers/staging/unisys/include/commontypes.h | 6 -- 2 files changed, 2 insert

[PATCH 00/12] staging: unisys: common types cleanup

2014-07-31 Thread Benjamin Romer
The include/commontypes.h file defines many types and functions locally when the kernel's existing definitions should have been used instead. This patch series converts UINTN and all of the U16 through U64 and S8 through S64 types to kernel types, and gets rid of the MEMCMP, MEMSET, STRLEN, STRCPY,

[PATCH 01/12] staging: unisys: remove U16 type

2014-07-31 Thread Benjamin Romer
This patch switches all use of the U16 typedef to use the kernel's u16 type instead. Signed-off-by: Benjamin Romer --- .../include/channels/controlframework.h| 18 .../include/channels/controlvmchannel.h| 24 +++--- .../common-spar/include

[PATCH 06/12] staging: unisys: remove S32 type

2014-07-31 Thread Benjamin Romer
Delete the S32 type from commontypes.h since it wasn't being used. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/commontypes.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/include/commontypes.h b/drivers/staging/unisys/include/commontypes.h index

[patch] staging: lustre: bitwise vs logical typo

2014-07-31 Thread Dan Carpenter
Bitwise AND was intended here obviously. Signed-off-by: Dan Carpenter --- Static analysis. I wasn't able to compile this. Also lustre needs an entry in MAINTAINERS because otherwise get_maintainer.pl still sends everything to Peng Tao only. diff --git a/drivers/staging/lustre/lustre/obdecho/ec

[PATCH] staging: comedi: ii_pci20kc: request and ioremap memory

2014-07-31 Thread Ian Abbott
The "ii_pci20kc" module is a comedi driver for Intelligent Instruments PCI-20001C carrier board and modules. Despite the name, this is actually an ISA board and uses 1K of ISA memory space (below 1M) for the main board plus up to three modules. The address is set by hardware jumpers. When the bo

[PATCH 14/18] staging: comedi: amplc_pci224: no need to manipulate PCI ref count

2014-07-31 Thread Ian Abbott
This driver no longer supports a "legacy" attach mechanism that searches for a suitable PCI device and increments it's reference count, but since the common "detach" handler `pci224_detach()` still has a left-over `pci_dev_put()`, a matching `pci_dev_get()` is needed in the "auto_attach" handler `p

[PATCH 16/18] staging: comedi: amplc_pci224: remove PCI_DEVICE_ID_... macros

2014-07-31 Thread Ian Abbott
The macros `PCI_DEVICE_ID_AMPLICON_PCI224` and `PCI_DEVICE_ID_AMPLICON_PCI234` are only used in the PCI module device table `amplc_pci224_pci_table[]`. Just expand the macros where they are used and remove them. The macro `PCI_DEVICE_ID_INVALID` is no longer used either, so remove it. Signed-off

[PATCH 05/18] staging: comedi: amplc_pci224: fix spinlock_t definition without comment

2014-07-31 Thread Ian Abbott
Fix checkpatch issue: "CHECK: spinlock_t definition without comment". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/am

[PATCH 06/18] staging: comedi: amplc_pci224: add whitespace to pci224_boards[]

2014-07-31 Thread Ian Abbott
Add a bit of whitespace to the initializer of `pci224_boards[]` for aesthetic reasons. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/drivers/ampl

[PATCH 13/18] staging: comedi: amplc_pci224: remove "legacy" attach mechanism

2014-07-31 Thread Ian Abbott
Since the driver no longer supports options in its "legacy" attach mechanism to describe the jumper settings (or any options beyond restricting a PCI search to a particular bus and/or slot), there is no need to retain this mechanism in the driver. Remove the comedi driver "attach" handler `pci224_

[PATCH 17/18] staging: comedi: amplc_pci224: absorb pci224_attach_common()

2014-07-31 Thread Ian Abbott
`pci224_attach_common()` is now only called from `pci225_auto_attach()`, so absorb it into that function. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 56 +++ 1 file changed, 22 insertions(+), 34 deletions(-) diff --git a/drivers/staging/

driverdev-devel@linuxdriverproject.org

2014-07-31 Thread Ian Abbott
Remove the "address-of" operator when the operand is a function. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/d

[PATCH 07/18] staging: comedi: amplc_pci224: set a more descriptive MODULE_DESCRIPTION()

2014-07-31 Thread Ian Abbott
Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c index 8ce0f4f..f786237 100644 --- a/drivers/staging/comedi

[PATCH 18/18] staging: comedi: amplc_pci224: no need to comedi_set_hw_dev() here

2014-07-31 Thread Ian Abbott
The comedi core module calls `comedi_set_hw_dev()` to associate the hardware `struct device` with the `struct comedi_device` before it calls the comedi driver's "auto_attach" hook `pci224_auto_attach()`. There is no need for `pci224_auto_attach()` to call `comedi_set_hw_dev()` itself, so remove th

[PATCH 12/18] staging: comedi: amplc_pci224: remove options to select output ranges

2014-07-31 Thread Ian Abbott
When attaching a PCI224 or PCI234 manually via the `COMEDI_DEVCONFIG` ioctl, there are several options the user can supply that describe the state of the hardware jumpers (LK1 for PCI224, LK1 thru LK5 for PCI234). These options control how the driver sets up the AO range tables for the device. Tho

[PATCH 08/18] staging: comedi: amplc_pci224: omit '!= 0' from logical expressions

2014-07-31 Thread Ian Abbott
Since anything non-zero is logically "true", don't bother doing "not-equal" comparisons with zero, except when testing for an explicit number 0 (not as a result of bit tests for example). Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 16 1 file ch

[PATCH 15/18] staging: comedi: amplc_pci224: put board indices in PCI driver_data

2014-07-31 Thread Ian Abbott
The `driver_data` member value from the matched entry of the PCI module device table `amplc_pci224_pci_table[]` is passed through to our comedi "auto_attach" handler, `pci224_auto_attach()`. Use that to index directly into our static board data array `pci224_boards[]` instead of calling `pci224_fi

[PATCH 09/18] staging: comedi: amplc_pci224: remove some unnecessary parentheses

2014-07-31 Thread Ian Abbott
Remove some pairs of parentheses that don't really improve readability. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/dri

[PATCH 03/18] staging: comedi: amplc_pci224: blank lines aren't necessary before a close brace '}'

2014-07-31 Thread Ian Abbott
Fix checkpatch issues: "CHECK: Blank lines aren't necessary before a close brace '}'". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/driv

[PATCH 01/18] staging: comedi: amplc_pci224: reformat some comments

2014-07-31 Thread Ian Abbott
Reformat comments to fit in with the preferred coding style, including the copyright and comedi driver description comments at the start of the file. Also, remove a boiler-plate comment for the comedi device private data structure. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/am

[PATCH 02/18] staging: comedi: amplc_pci224: fix checkpatch line over 80 characters

2014-07-31 Thread Ian Abbott
Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c index 72506bf..6a570ef 100644 --- a/drivers/staging/come

[PATCH 00/18] staging: comedi: amplc_pci224: remove legacy stuff

2014-07-31 Thread Ian Abbott
The "amplc_pci224" driver retains a "legacy" attach mechanism via the `COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but usually attaches PCI devices automatically via the comedi driver's "auto_attach" hook. The legacy mechanism is only retained so that options can be passed via the

[PATCH 10/18] staging: comedi: amplc_pci224: reduce leading whitespace in a few places

2014-07-31 Thread Ian Abbott
Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 53 +-- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c index a7f3454..68fc407 10064

[PATCH 04/18] staging: comedi: amplc_pci224: multiple assignments should be avoided

2014-07-31 Thread Ian Abbott
Fix checkpatch issue: "CHECK: multiple assignments should be avoided". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci224.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/driv

Re: [PATCH] Staging: android: sw_sync.c: fix missing blank line after declaration

2014-07-31 Thread Yann Droneaud
Hi, Le jeudi 31 juillet 2014 à 16:30 +0300, Dan Carpenter a écrit : > On Thu, Jul 31, 2014 at 03:00:19PM +0200, Yann Droneaud wrote: > > Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a > > écrit : > > > Fix coding style issue. > > > > > > Signed-off-by: Murilo Opsfelder Araujo

Re: [PATCH v3] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-31 Thread Tomi Valkeinen
On 31/07/14 13:11, Dexuan Cui wrote: >> -Original Message- >> From: Tomi Valkeinen [mailto:tomi.valkei...@ti.com] >> Sent: Wednesday, July 30, 2014 22:24 PM >>> +static struct fb_info *hvfb_info; >> >> Static variables like these are usually a no-no. This prevents you from >> having multipl

[PATCH 2/2] staging: dgnc: Remove unneeded dgnc_trace.c and dgnc_trace.h

2014-07-31 Thread Seunghun Lee
Removes unneeded dgnc_trace.c and dgnc_trace.h CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/Makefile |2 +- drivers/staging/dgnc/dgnc_cls.c|1 - drivers/staging/dgnc/dgnc_driver.c |1 - drivers/staging/dgnc/dgnc_neo.c|1

Re: [PATCH] Staging: android: sw_sync.c: fix missing blank line after declaration

2014-07-31 Thread Dan Carpenter
On Thu, Jul 31, 2014 at 03:00:19PM +0200, Yann Droneaud wrote: > Hi, > > Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a > écrit : > > Fix coding style issue. > > > > Signed-off-by: Murilo Opsfelder Araujo > > Is this some kind of game ? > > The *same* patch was sent three ti

[PATCH 1/2] staging: dgnc: rephrase comment

2014-07-31 Thread Seunghun Lee
Rephrase comment to explain original intention of function. CC: Lidza Louina CC: Mark Hounschell Suggested-by: Tobias Klauser Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_cls.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgn

Re: [PATCH] Staging: android: sw_sync.c: fix missing blank line after declaration

2014-07-31 Thread Yann Droneaud
Hi, Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a écrit : > Fix coding style issue. > > Signed-off-by: Murilo Opsfelder Araujo Is this some kind of game ? The *same* patch was sent three times from three different email addresses: http://lkml.kernel.org/r/1406170403-4506

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-31 Thread Mark Hounschell
On 07/31/2014 12:02 AM, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed t

Re: [PATCH] Staging: android: sync.c: fix missing blank line after declaration

2014-07-31 Thread Murilo Opsfelder Araujo
On 07/30/2014 09:17 PM, Greg KH wrote: Also doesn't apply, are you sure you are using the staging-next branch of staging.git on git.kernel.org? I was using linux-next, not staging-next. sync.c has no checkpatch.pl warnings in staging-next. Sorry for the false alarm, guys. -- Murilo ___

Re: [PATCH] Staging: android: sw_sync.c: fix missing blank line after declaration

2014-07-31 Thread Murilo Opsfelder Araujo
On 07/30/2014 09:17 PM, Greg KH wrote: Does not apply to my tree at all :( I was using linux-next. No checkpatch.pl warnings for sw_sync.c in staging-next. -- Murilo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

[PATCH v2] Staging: android: timed_gpio.c: improved logic of gpio_get_time()

2014-07-31 Thread Murilo Opsfelder Araujo
This patch improves the logic of gpio_get_time() and, thereafter, makes checkpatch.pl happy. Signed-off-by: Murilo Opsfelder Araujo --- Thanks for reviweing my patch, Dan. I think I got the proper way without using option --scissors in git-am. What about this new commit message? drivers/stag

Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

2014-07-31 Thread Dan Carpenter
On Thu, Jul 31, 2014 at 11:10:33AM +0200, Fernando Apesteguía wrote: > El 31/07/2014 10:21, "Dan Carpenter" escribió: > > > > You need to compile these things before sending them... > > > > This adds a GCC warning about uncalled functions. > > Sorry, but I did compile it with > > make C=1 M=driv

RE: [PATCH v3] video: hyperv: hyperv_fb: refresh the VM screen by force on VM panic

2014-07-31 Thread Dexuan Cui
> -Original Message- > From: Tomi Valkeinen [mailto:tomi.valkei...@ti.com] > Sent: Wednesday, July 30, 2014 22:24 PM > > +static struct fb_info *hvfb_info; > > Static variables like these are usually a no-no. This prevents you from > having multiple device instances. I agree. > > static

Re: [patch] staging: comedi: ni_tio: remove some dead code

2014-07-31 Thread Ian Abbott
On 2014-07-31 10:29, Dan Carpenter wrote: These conditions can never be true because "i" is always one more than NI_660X_MAX_RTSI_CHAN after the loop. Signed-off-by: Dan Carpenter Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd.E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX:

[patch] staging: comedi: ni_tio: remove some dead code

2014-07-31 Thread Dan Carpenter
These conditions can never be true because "i" is always one more than NI_660X_MAX_RTSI_CHAN after the loop. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c index f9f6320..9d4b46c 100644 --- a/drivers/staging/comedi/dri

Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

2014-07-31 Thread Fernando Apesteguía
El 31/07/2014 10:21, "Dan Carpenter" escribió: > > You need to compile these things before sending them... > > This adds a GCC warning about uncalled functions. Sorry, but I did compile it with make C=1 M=drivers/staging But for the function to be called, DEBUG_EPROM must be defined and I had i

[PATCH 0/5] staging: rtl8723au: Removing more unused and duplicate code

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Greg, Please find attached another small set of fixes for the 8723au driver, mostly removing unused code, but also duplication of some in-kernel Linux USB functions. Thanks, Jes Jes Sorensen (5): staging: rtl8723au: RSSI_test is never set staging: rtl8723au: Remove two

[PATCH 1/5] staging: rtl8723au: RSSI_test is never set

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 7 ++- drivers/staging/rtl8723au/include/odm.h | 1 - 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl8723

[PATCH 4/5] staging: rtl8723au: Do not duplicate kernel provided USB macros

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 45 +++-- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c index 06c

[PATCH 2/5] staging: rtl8723au: Remove two never set variables

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen struct registry_priv.usbss_enable and struct pwrctrl_priv.bHWPwrPindetect are never set. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_cmd.c| 13 - drivers/staging/rtl8723au/core/rtw_pwrctrl.c| 22 -- drivers/s

[PATCH 5/5] staging: rtl8723au: usb_dvobj_init(): Remove unused variable 'pdev_desc'

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c b/drivers/staging/rtl8723au/os_dep/usb_intf.c index c5ff1b8..865743e 100644 --- a/drivers/staging/rtl

[PATCH 3/5] staging: rtl8723au: Remove never set struct pwrctrl_priv.bHWPowerdown

2014-07-31 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 21 - drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 1 - 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/d

Re: [PATCH] Staging: android: timed_gpio.c: improved logic of gpio_get_time()

2014-07-31 Thread Dan Carpenter
On Wed, Jul 30, 2014 at 08:47:19PM -0300, Murilo Opsfelder Araujo wrote: > Thanks for reviewing my first patch, Joe. How about this new one, > guys? > > -- >8 -- > Consequently, made checkpatch.pl happy. > > Signed-off-by: Murilo Opsfelder Araujo This changelog is all mangled. Try applying it

Re: [PATCH] Staging: rtl8192u: Staticfy debug method.

2014-07-31 Thread Dan Carpenter
You need to compile these things before sending them... This adds a GCC warning about uncalled functions. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-deve

[PATCH] staging: lustre: ptlrpc: lproc_ptlrpc.c - fix dereferenceing user space buffer

2014-07-31 Thread Anil Belur
- this fixes sparse warning for directly deferencing user space buffer drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33: warning: incorrect type in argument 2 (different address spaces) drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:652:33:expected void const [noderef] *from d