[PATCH] staging:r819xU: coding style: Fixed commenting style

This is a patch to the r819xU_phyreg.h file that fixes commenting style warning Signed-off-by: Sanjeev Sharma --- drivers/staging/rtl8192u/r819xU_phyreg.h | 188 --- 1 file changed, 97 insertions(+), 91 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phyreg

Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote: > Signed-off-by: A Raghavendra Rao This looks very similar to what I submitted on July 31st. At this time Greg had additional comments which led to a quite different patchset (though its review is not completed yet), you may find

Re: [PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

On Thu, Aug 07, 2014 at 10:10:47AM +0530, A Raghavendra Rao wrote: > Fix the following sparse warnings: > drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' > was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol > 'txqueue2

[PATCH] Staging: rtl8192u: fix sparse warnings in r8192U_core.c

Fix the following sparse warnings: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol 'txqueue2outpipe' was not declared. Should it be static? drivers/staging/rtl8192u/r819

[PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/speakup/speakup_soft.c b/drivers/staging/speak

Re: [PATCH] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

On Wed, 6 Aug 2014, Greg KH wrote: On Wed, Aug 06, 2014 at 06:03:42PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 fi

Re: [PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c

On Wed, Aug 06, 2014 at 02:14:16PM +0530, A Raghavendra Rao wrote: > Fix the following sparse warnings: > drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' > was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol > 'txqueue2

Re: [PATCH] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

On Wed, Aug 06, 2014 at 06:03:42PM +1000, Artemiy Volkov wrote: > This patch fixes the checkpatch.pl 'Missing a blank line after declarations' > warning in speakup_soft.c. > > Signed-off-by: Artemiy Volkov > --- > drivers/staging/speakup/speakup_soft.c | 3 +++ > 1 file changed, 3 insertions(+)

RE: [PATCH] Input: hyperv-keyboard: register as a wakeup source

> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Dmitry Torokhov > > Hi Dmitry, > > Sorry, I didn't realize it's not public... :-) > > > > I'll remove the line and re-send the patch. > > > > No need to resend, I alr

[PATCH v3 0/2] staging: iio: accel: Multiple coding style fixes

The following patches fix almost all warnings reported by checkpatch.pl. v2 -> v3 changes: - Folded blank line patches into a single patch. - Fit code in 80-chars limit and still be human-readable. Murilo Opsfelder Araujo (2): staging: iio: accel: Add blank lines between declarations and code

[PATCH v3 2/2] staging: iio: accel: sca3000_core.c: Adjust code to fit 80-chars limit

Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/sca3000_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index bc53fedb..e4e5639 100644 --- a/drivers/staging/iio/a

Re: [PATCH] Input: hyperv-keyboard: register as a wakeup source

On Wed, Aug 6, 2014 at 5:19 PM, Dexuan Cui wrote: > > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: Thursday, August 7, 2014 4:34 AM > > To: Dexuan Cui > > On Fri, Aug 01, 2014 at 07:28:24AM -0700, Dexuan Cui wrote: > > > With this patch, we ca

[PATCH v3 1/2] staging: iio: accel: Add blank lines between declarations and code

This patch adds missing blank lines between declarations and code and fixes lines starting by spaces, satisfying checkpatch.pl. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/iio/accel/adis16201_core.c | 5 +++-- drivers/staging/iio/accel/adis16203_core.c | 2 ++ drivers/staging/iio/

RE: [PATCH] Input: hyperv-keyboard: register as a wakeup source

> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Thursday, August 7, 2014 4:34 AM > To: Dexuan Cui > On Fri, Aug 01, 2014 at 07:28:24AM -0700, Dexuan Cui wrote: > > With this patch, we can press a key to wake up the VM after the VM > executes > > "echo

Re: [PATCH 0/5] staging: dgnc: Fix checkpath issues in dgnc_neo.c

On Wed, Aug 06, 2014 at 09:01:21PM +0200, Konrad Zapalowicz wrote: > This series of patches deals with the checkpatch error and warnings, > other than 'line length over 80 chars', found in dgnc_neo.c file. All > except of patch 5/5 do not change the behavior. > > Konrad Zapalowicz (5): > staging

Re: [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

On Wed, 2014-08-06 at 23:45 +0300, Dan Carpenter wrote: > On Wed, Aug 06, 2014 at 01:31:46PM -0700, Joe Perches wrote: > > On Wed, 2014-08-06 at 23:13 +0300, Dan Carpenter wrote: > > > On Wed, Aug 06, 2014 at 10:42:55PM +0530, Srikrishan Malik wrote: > > > > diff --git a/drivers/staging/lustre/lust

[PATCH] Staging: android: sw_sync.c: Fixed coding style issue.

Fixed coding style issue where blank line is missing after declaration. Signed-off-by: Yee Chin, Chiam --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index a76db3f..863d4b1 100644

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

On Wed, Aug 06, 2014 at 09:22:43PM +0300, Evgeny Budilovsky wrote: > > > Signed-off-by: Evgeny Budilovsky Why is this needed? Is the current code a bug? Where was the reference added? Is this causing a problem without this patch applied? How far back should it be backported, if at all? I n

Re: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2

From: "K. Y. Srinivasan" Date: Wed, 6 Aug 2014 11:11:00 -0700 > WS2008R2 is a supported platform and it turns out that the maximum sendbuf > size that ws2008R2 can support is only 15MB. Make the necessary > adjustment. > > Signed-off-by: K. Y. Srinivasan Applied, thanks. _

Re: [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

On Wed, 2014-08-06 at 23:13 +0300, Dan Carpenter wrote: > On Wed, Aug 06, 2014 at 10:42:55PM +0530, Srikrishan Malik wrote: > > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c > > b/drivers/staging/lustre/lustre/mdc/mdc_reint.c [] > > @@ -71,7 +71,7 @@ int mdc_resource_get_unused(struct

Re: [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

On Wed, Aug 06, 2014 at 01:31:46PM -0700, Joe Perches wrote: > On Wed, 2014-08-06 at 23:13 +0300, Dan Carpenter wrote: > > On Wed, Aug 06, 2014 at 10:42:55PM +0530, Srikrishan Malik wrote: > > > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c > > > b/drivers/staging/lustre/lustre/mdc/md

Caro usuário de e-mail

Caro usuário de e-mail Temos notado que a sua conta está conectado a partir de um server.You diferente são para verificar esta conta, por favor, preencha esta questão de teste. Qual é seu nome . ??, endereço de email . ?? senha ??, n

Re: [PATCH 3/5] staging: dgnc: Fix that open brace { should be on the previous line

On 08/06, Dan Carpenter wrote: > On Wed, Aug 06, 2014 at 09:01:24PM +0200, Konrad Zapalowicz wrote: > > @@ -1935,8 +1935,8 @@ static void neo_vpd(struct dgnc_board *brd) > > > > if (((brd->vpd[0x08] != 0x82) /* long resource name tag */ > > && (brd->vpd[0x10] != 0x82)) /*

Re: [PATCH] Input: hyperv-keyboard: register as a wakeup source

On Fri, Aug 01, 2014 at 07:28:24AM -0700, Dexuan Cui wrote: > With this patch, we can press a key to wake up the VM after the VM executes > "echo freeze > /sys/power/state". > > This addresses part of https://bugzilla.redhat.com/show_bug.cgi?id=1086100 I am sorry but this bug is not open to the p

Re: [PATCH 3/5] staging: dgnc: Fix that open brace { should be on the previous line

On Wed, Aug 06, 2014 at 09:01:24PM +0200, Konrad Zapalowicz wrote: > @@ -1935,8 +1935,8 @@ static void neo_vpd(struct dgnc_board *brd) > > if (((brd->vpd[0x08] != 0x82) /* long resource name tag */ > && (brd->vpd[0x10] != 0x82)) /* long resource name tag > (PCI-66 fil

Re: [PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote: > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > b/drivers/staging/lustre/lustre/mdc/mdc_locks.c > index c03d77c9c5b8..09209171b50c 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_locks.c > +++ b/drivers/staging/l

[PATCH 2/2] staging: dgnc: Remove unnecessary 'return' statement

This commit fixes the checkpath warning 'void function return statements are not generally useful' caused by the 'return' at the end of 'void' function. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_cls.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/dgnc/

[PATCH 1/2] staging: dgnc: Fix missing blank line after declarations

This commit fixes the missing blank lines after declarations checkpath warnings found in dgnc_cls.c file. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_cls.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cl

[PATCH 0/2] staging: dgnc: Fix checkpatch warnings in dgnc_cls.c

This series of patches fixes the checkpatch issues found in dgnc_cls.c file: - missing blank line after declaration - void function return statements are not generally useful Konrad Zapalowicz (2): staging: dgnc: Fix missing blank line after declarations staging: dgnc: Remove u

Re: [PATCH 06/12] staging: lustre: replace c99 style comments with C89

On Wed, Aug 06, 2014 at 10:42:56PM +0530, Srikrishan Malik wrote: > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c > b/drivers/staging/lustre/lustre/mdc/mdc_lib.c > index 35ce2fdf696c..7f9b6eb51860 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_lib.c > +++ b/drivers/staging/lustre/

Re: [PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

On Wed, Aug 06, 2014 at 10:42:55PM +0530, Srikrishan Malik wrote: > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_reint.c > b/drivers/staging/lustre/lustre/mdc/mdc_reint.c > index c5420a42bc33..c40304bf0b62 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_reint.c > +++ b/drivers/staging/l

[PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

Signed-off-by: Evgeny Budilovsky --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lproc_llite.c index 77f68b5..7e61468 100644 --- a

[PATCH 3/5] staging: dgnc: Fix that open brace { should be on the previous line

This commit fixes the following checkpath error in dgnc_neo.c file: 'that open brace { should be on the previous line' Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_neo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/

[PATCH 5/5] staging: dgnc: Remove 'volatile' modifier where it is not needed

This commit fixes the checkpath warning about misused 'volatile' modifier. In this case the 'volatile' was not needed as it was used for regular automatic variable. Thos commit removes the 'volatile'. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1

[PATCH 4/5] staging: dgnc: Fix braces {} are not necessary for single statement blocks

This commit fixes the following checkpath warning in dgnc_neo.c file: 'braces {} are not necessary for single statement blocks' Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_neo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo

[PATCH 2/5] staging: dgnc: Fix missing blank line after declarations

This commit deals with the checkapth warnings 'missing line after declarations' in the dgnc_neo.c file. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_neo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c

[PATCH 1/5] staging: dgnc: Fix included header from 'asm'

This commit fixes the checkpatch warning: drivers/staging/dgnc/dgnc_neo.c:37: WARNING: Use #include instead of Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers

[PATCH 0/5] staging: dgnc: Fix checkpath issues in dgnc_neo.c

This series of patches deals with the checkpatch error and warnings, other than 'line length over 80 chars', found in dgnc_neo.c file. All except of patch 5/5 do not change the behavior. Konrad Zapalowicz (5): staging: dgnc: Fix included header from 'asm' staging: dgnc: Fix missing blank line

[PATCH] staging: unisys: uislib: Fixed missing blank line coding style issue

Fixed coding style issue "Missing a blank line after declarations" detected by the 'checkpatch.pl' script. Signed-off-by: Tobenna P. Igwe --- drivers/staging/unisys/uislib/uisutils.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/unisys/uislib/uisutils.c b/drivers/s

[PATCH] staging: comedi: fixing coding style problems

This patch fixes warnings of checkpatch.pl script: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around devpriv->timer +init_timer(&(devpriv->timer)); CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis +dev_info(dev->class_dev, +"%s: %i m

Re: WiFi+BT AR5B22. When starting linux - BT disappears. Disappears at all.

Hi all! Had busy time, but today I've installed vanilla kernel into openSUSE 13.1. uname -a says: "Linux linux-bekh.site 3.16.0-3638-g8e099d1-1.g4b43f13-vanilla #1 SMP Tue Aug 5 10:03:55 UTC 2014 (4b43f13) x86_64 x86_64 x86_64 GNU/Linux" My first reboot using vanilla kernel and Broadcom module show

RE: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2

> WS2008R2 is a supported platform and it turns out that the maximum sendbuf > size that ws2008R2 can support is only 15MB. Make the necessary > adjustment. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/net/hyperv/hyperv_net.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >

RE: [PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2

> -Original Message- > From: Jeff Leung [mailto:jle...@v10networks.ca] > Sent: Wednesday, August 6, 2014 10:19 AM > To: KY Srinivasan; da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...

[PATCH 08/12] staging: lustre: fix multi line strings

Fixes the following checkpatch warning: WARNING: quoted string split across lines Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++ drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc/mdc_request.c | 36

[PATCH 09/12] staging: lustre: Added space between type name and *

Fixes the following checkpatch error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c b/drivers/staging/lustre

[PATCH 11/12] staging: lustre: move else on the same line as closing brace

Fix the following checkpatch error: ERROR: else should follow close brace '}' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c b/drivers/stag

[PATCH 10/12] staging: lustre: Fix misplaced opening brace warnings

Fixes the following checkpatch error: ERROR: that open brace { should be on the previous line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 12 ++-- drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +-- drivers/staging/lustre/lustre/mdc/mdc_re

[PATCH 12/12] staging: lustre: remove parentheses usage with return

Fix the following checkpatch error: ERROR: return is not a function, parentheses are not required Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request

[PATCH 07/12] staging: lustre: add blank lines after declarations

Fixes the following checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 1 + drivers/staging/lustre/lustre/mdc/mdc_locks.c | 3 +++ drivers/staging/lustre/lustre/mdc/mdc_request.c | 5 +

[PATCH 06/12] staging: lustre: replace c99 style comments with C89

Fixes the following checkpatch error: ERROR: do not use C99 // comments Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c b/drivers/staging/lustre

[PATCH 04/12] staging: lustre: fix lines over 80 chars

Fixes the following checkpatch warning: WARNING: line over 80 characters Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 6 -- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 9 ++--- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 7 --- d

[PATCH 05/12] staging: lustre: Add missing spaces around operators and braces.

Fixes the following checkpatch errors: ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that close brace '}' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 25 + drivers/staging/lustre/lustre/mdc/mdc_locks.

[PATCH 02/12] staging: lustre: remove spaces from start of line

Fixes the following checkpatch warning: WARNING: please, no spaces at the start of a line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b/dr

[PATCH 03/12] staging: lustre: move open brace to next line after functions

Fixes the following checkpatch error: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 ++- drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 ++- 2 files changed, 4 insertions(+),

[PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

Fixes following checkpatch warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Srikrishan Malik --- drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4 ++-- drivers/staging/lustre/lustre/md

[PATCH 1/1] Drivers: net-next: hyperv: Adjust the size of sendbuf region to support ws2008r2

WS2008R2 is a supported platform and it turns out that the maximum sendbuf size that ws2008R2 can support is only 15MB. Make the necessary adjustment. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dri

[PATCH] staging: iio: adis16060: Fix coding style problem

This patch fixes a warning from checkpatch.pl script : "WARNING: Missing a blank line after declarations" Signed-off-by: Oussama Jabbari --- The reason of this patch is for completing one task of the Eudyptula Challenge. drivers/staging/iio/gyro/adis16060_core.c |1 + 1 file changed, 1 inse

Dear Winner.

Dear winner, Your email address has won you One Million Euro, from Online Lotto, all the E-mail addresses were selected from a data base of internet e-mail users, from which your e-mail address came out as the winning coupon. Winning expiring date 30th of August, 2014. Contact our fiduciary Agen

Re: [PATCH v2 3/3] staging:r8190: coding style: Fixed checkpatch reported Error

On Wed, Aug 06, 2014 at 09:33:56AM +, Sharma, Sanjeev wrote: > Hello All, > > I have submitted few patches last week and also get reply from Greg that > patches will show up in linux-next tree and in parallel I need to submit new > patches and now Looks like I need to > Sync my tree with li

Re: [PATCH v3 6/7] staging: dgnc: Siplify the dgnc_start function

On Wed, Aug 06, 2014 at 03:40:11PM +0200, Konrad Zapalowicz wrote: > This commit slightly simplifies the sgnc_start() function by > rearranging it. As a result the indentation level is reduced. > This is not the functional change. > > Signed-off-by: Konrad Zapalowicz Great. Thanks. regards, da

[PATCH v3 6/7] staging: dgnc: Siplify the dgnc_start function

This commit slightly simplifies the sgnc_start() function by rearranging it. As a result the indentation level is reduced. This is not the functional change. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_driver.c | 91 ++ 1 file changed, 44 in

Re: [PATCH v2 6/7] staging: dgnc: Siplify the dgnc_start function

Sorry, I meant that "return directly" applied for all the new gotos. Don't do this: rc = -ENXIO; goto exit; ... exit: return rc; It just makes the code harder to read. Do this: return -ENXIO; without all the goto leap hop jumping around. regards, dan carpenter

Re: [PATCH 02/12] staging: unisys: remove U32 type

On Thu, Jul 31, 2014 at 12:00:50PM -0400, Benjamin Romer wrote: > @@ -121,7 +120,7 @@ typedef U64 GUEST_PHYSICAL_ADDRESS; > fil, lin); \ > } while (0) > > -#define CHANNEL_U32_MISMATCH(chType, chName, field, expected, actual, fil, \

[PATCH v2 6/7] staging: dgnc: Siplify the dgnc_start function

This commit slightly simplifies the sgnc_start() function by rearranging it. As a result the indentation level is reduced. This is not the functional change. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_driver.c | 93 +++--- 1 file changed, 46 in

Re: [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

On Wed, Aug 06, 2014 at 08:08:11AM -0500, Romer, Benjamin M wrote: > On Wed, 2014-08-06 at 11:18 +0300, Dan Carpenter wrote: > > On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > > > The CHANNEL_*_MISMATCH error message macros should not be inside of do > > > blocks. > > > > > >

Re: [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

On Wed, 2014-08-06 at 11:18 +0300, Dan Carpenter wrote: > On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > > The CHANNEL_*_MISMATCH error message macros should not be inside of do > > blocks. > > > > Why not? We do that so they can be called like a function. These seem > to no

verificar a sua conta

Caro usuário Seu e-mail ultrapassou 2 GB criadas pelo webmaster, você está atualmente rodando a 2.30GB, o que não é possível enviar ou receber nova mensagem no próximo 24 horas até que você verificar sua conta de e-mail. Por favor, informe seus dados abaixo para verificar a sua conta: (1)

Re: [PATCH 6/7] staging: dgnc: Siplify the dgnc_start function

On Wed, Aug 06, 2014 at 02:21:24PM +0200, Konrad Zapalowicz wrote: > diff --git a/drivers/staging/dgnc/dgnc_driver.c > b/drivers/staging/dgnc/dgnc_driver.c > index da7b226..66f2b2d 100644 > --- a/drivers/staging/dgnc/dgnc_driver.c > +++ b/drivers/staging/dgnc/dgnc_driver.c > @@ -278,65 +278,63 @@

[PATCH 6/7] staging: dgnc: Siplify the dgnc_start function

This commit slightly simplifies the sgnc_start() function by rearranging it. As a result the indentation level is reduced. This is not the functional change. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_driver.c | 93 +++--- 1 file changed, 46 in

[PATCH 7/7] staging: dgnc: Update the TODO file

It turned out that the TODO file contained the invalid information as some of the work has already been done. This commit updates it with the current status of what is left to be done. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/TODO | 5 - 1 file changed, 5 deletions(-) diff

[PATCH 4/7] staging: dgnc: Remove unnecessary functions from dgnc_driver.c

This commit slightly cleans up the dgnc_driver.c file. The changes include removing one-line proxy functions as they were not needed. Additionaly the pci 'remove' function is deleted because it was no need for it. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_driver.c | 30 ++---

[PATCH 5/7] staging: dgnc: Move utility functions out of dgnc_driver.c

This commit moves the utility functions out of dgnc_driver.c file and puts them in the new dgnc_utils.{c,h} files. The accompanying changes adjust the existing code to work with this design. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/Makefile | 3 +- drivers/staging/dgnc/dgn

[PATCH 3/7] staging: dgnc: Fix frame size is larger than 1024B

This comit fixes the following sparse warnign: drivers/staging/dgnc/dgnc_tty.c:572:1: warning: the frame size of 1060 bytes is larger than 1024 bytes [-Wframe-larger-than=] This was caused by having buffer as an automatic variable. This commit moves it from the stack to the heap. Signed-

[PATCH 0/7] staging: dgnc: cleanup of the dgnc_driver.c

This series of patches cleans up a bit the dgnc code. The focus is mostly put on the dgnc_driver.c file however the sparse warning from the other file has been fixed too. There is no functional changes, only the sparse warnings have been fixed, some of the checkpath issues have been fixed too (exc

[PATCH 2/7] staging: dgnc: Fix no spaces before tabs checkpath warning

This commit corrects the 'no space before tabs' checkpath warning. Signed-off-by: Konrad Zapalowicz --- drivers/staging/dgnc/dgnc_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index 1789

[PATCH 1/7] staging: dgnc: Fix externs should be avoided in the .c files

This commit fixes the following checkpatch warnings: WARNING: externs should be avoided in .c files #80: FILE: drivers/staging/dgnc/dgnc_driver.c:80: +intdgnc_init_module(void); #81: FILE: drivers/staging/dgnc/dgnc_driver.c:81: +void dgnc_cleanup_modul

Re: [PATCH v2] staging: comedi: add NI USB-6501 support

Il 06/08/2014 13:58, Dan Carpenter ha scritto: Some minor style nits. On Wed, Aug 06, 2014 at 01:35:32PM +0200, Luca Ellero wrote: +static int ni6501_send_command(struct comedi_device *dev, int command, + const u8 *port, u8 *bitmap) +{ + struct usb_device *usb

Re: [PATCH v2] staging: comedi: add NI USB-6501 support

Some minor style nits. On Wed, Aug 06, 2014 at 01:35:32PM +0200, Luca Ellero wrote: > +static int ni6501_send_command(struct comedi_device *dev, int command, > +const u8 *port, u8 *bitmap) > +{ > + struct usb_device *usb = comedi_to_usb_dev(dev); > + struct ni65

staging/rtl8192[eu]

Hello, Is anyone actually interested in the files: drivers/staging/rtl8192e/rtllib_softmac.c drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c Both contain the following code: if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || (param->u.wpa_ie.len && param->u.wpa_ie.data == NUL

Re: [PATCH] staging: comedi: add NI USB-6501 initial support

On 06/08/2014 11:29, Ian Abbott wrote: On 2014-08-06 09:49, Luca Ellero wrote: A question only: apart from renaming file from ni_6501.c to ni_usb6501.c, should I rename functions/variables as well? For example: ni6501_auto_attach -> niusb6501_auto_attach ni6501_private -> niusb6501_private It

RE: [PATCH v2 3/3] staging:r8190: coding style: Fixed checkpatch reported Error

Hello All, I have submitted few patches last week and also get reply from Greg that patches will show up in linux-next tree and in parallel I need to submit new patches and now Looks like I need to Sync my tree with linux-next tree before start working on New set of change and as soon as I am

Re: [PATCH] staging: comedi: add NI USB-6501 initial support

On 2014-08-06 09:49, Luca Ellero wrote: A question only: apart from renaming file from ni_6501.c to ni_usb6501.c, should I rename functions/variables as well? For example: ni6501_auto_attach -> niusb6501_auto_attach ni6501_private -> niusb6501_private It's okay to abbreviate the prefix, so ni6

[PATCH] staging: rtl8192u: fix sparse warnings in r8192U_core.c

Fix the following sparse warnings: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning: symbol 'txqueue2outpipe' was not declared. Should it be static? drivers/staging/rtl8192u/r819

Re: [PATCH] staging: comedi: add NI USB-6501 initial support

On 05/08/2014 17:58, Ian Abbott wrote: On 2014-08-05 15:22, Luca Ellero wrote: This is a preliminary version, some features are not implemented yet: GPIO: works counter: doesn't work Signed-off-by: Luca Ellero --- This is a preliminary version of the NI USB-6501 driver. Every comment/s

Re: [PATCH 14/14] staging: unisys: fix macros in iochannel.h

On Tue, Aug 05, 2014 at 02:57:58PM -0400, Benjamin Romer wrote: > Remove the do blocks around several macros and fix spacing and trailing > semicolons. > do blocks are prefered style actually. Otherwise people start leaving semi-colons out in the caller code. regards, dan carpenter ___

Re: [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks. > Why not? We do that so they can be called like a function. These seem to not be called at all. Just delete them (in a later patch). regards, dan

[PATCH] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/speakup/speakup_soft.c b/drivers/staging/speak