Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

2014-08-08 Thread Martin Berglund
On Thu, Aug 07, 2014 at 07:18:13PM -0700, Greg Kroah-Hartman wrote: > On Thu, Aug 07, 2014 at 11:08:34PM +0100, Martin Berglund wrote: > > Add missing __user macro casting in the function wpa_set_keys. > > This is okay since the function handles the possibility of > > param->u.wpa_key.key and param

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-08 Thread Dexuan Cui
> From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, August 8, 2014 11:32 AM > > Hi Richard and all, > > > > IMO the most feasible and need-the-least-change solution may be: > > the hyperv network VSC driver passes the event > > RNDIS_STATUS_NETWORK_CHANGE to the udev daemon? > > > >

Re: [PATCH 1/2] staging: iio: Fix vendor name typo in isl290[12]8.c

2014-08-08 Thread Jonathan Cameron
On 27/07/14 18:56, Masanari Iida wrote: > This patch fix vendor name typo in isl29018.c and isl29028.c > The company name Intersil should be isl, instead of isil. > > Signed-off-by: Masanari Iida Hi Masanari, This dropped by the wayside because it wasn't cc'd to linux-...@vger.kernel.org Also,

Re: [PATCH 2/2] Documentation: bindings: Add ISL29018 and ISL29028 in trivial-devices.txt

2014-08-08 Thread Jonathan Cameron
On 27/07/14 18:56, Masanari Iida wrote: > This patch add entries for ISL29018 and ISL29028 into trivial-devices.txt. > This patch fix following error. > > ./isl29018.c:643: WARNING: DT compatible string "isl,isl29018" > appears un-documented -- check Documentation/devicetree/bindings/ > > ./isl29

Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.

2014-08-08 Thread Dan Carpenter
On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote: > This patch clear some code that was not doing any help. > Pointed out by Larry.Finger > The patch is fine but the changelog doesn't inpsire confidence. It should say: This patch removes some unneeded code. 1) kzalloc() allocates

Re: [PATCH] Staging: rtl8188eu: Lines over 80 characters fixed.

2014-08-08 Thread Dan Carpenter
On Thu, Aug 07, 2014 at 11:45:32PM +0200, AdrianRemonda wrote: > I have resent the changes now. Is this ok? Or should I wait until the merge > window is close? Just send your patches. They will sit in Greg's inbox for a couple weeks, but that's ok. > Also N_BYTE_ALIGNMENT is being used by severa

Fix the Signature 答复: [PATCH] drivers: android: fix watermark when cma enabled

2014-08-08 Thread Zengtao (B)
From: Zeng Tao Date: Tue, 5 Aug 2014 17:58:10 +0800 Subject: [PATCH] drivers: android: fix watermark when cma enabled when cma is enabled, the watermark caculation will include the cma pages, while it can't use cma pages. this will cause oom while lowmemory killer don't work. Signed-off-by: Zen

[PATCH 9/14] imx-drm: imx-drm-core: delete unneeded test before of_node_put

2014-08-08 Thread Julia Lawall
From: Julia Lawall Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Juli

[PATCH] Staging:bcm:verndorspecificficextn.c: fixed five styling issues

2014-08-08 Thread Panos Vlachos
Fixed the following styling issues: vendorspecificextn.c:14: WARNING: line over 80 characters vendorspecificextn.c:64: WARNING: line over 80 characters vendorspecificextn.c:91: WARNING: line over 80 characters vendorspecificextn.c:115: WARNING: line over 80 characters vendorspecificextn.c:138: WARN

Re: [PATCH] Staging:bcm:verndorspecificficextn.c: fixed five styling issues

2014-08-08 Thread Dan Carpenter
On Fri, Aug 08, 2014 at 03:48:12PM +0300, Panos Vlachos wrote: > -INT vendorextnReadSection(PVOID pContext, PUCHAR pBuffer, enum > bcm_flash2x_section_val SectionVal, > +INT vendorextnReadSection(PVOID pContext, PUCHAR pBuffer, > + enum bcm_flash2x_section_val SectionVal, >

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-08 Thread Greg KH
On Fri, Aug 08, 2014 at 08:11:20AM +, Dexuan Cui wrote: > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Friday, August 8, 2014 11:32 AM > > > Hi Richard and all, > > > > > > IMO the most feasible and need-the-least-change solution may be: > > > the hyperv network VSC driver pass

Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

2014-08-08 Thread Greg Kroah-Hartman
On Fri, Aug 08, 2014 at 09:07:55AM +0200, Martin Berglund wrote: > On Thu, Aug 07, 2014 at 07:18:13PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Aug 07, 2014 at 11:08:34PM +0100, Martin Berglund wrote: > > > Add missing __user macro casting in the function wpa_set_keys. > > > This is okay since t

[PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

2014-08-08 Thread Benedict Boerger
drivers: staging: lustre: fix sparse warning: symbol XYZ was not declared. Should it be static? This was done by declaring them static. This could be done because the functions were used only in this file. Deleted the function lnet_print_text_bufs because it were unused. Compiled without an erro

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-08 Thread Stephen Hemminger
On Fri, 8 Aug 2014 06:45:49 -0700 Greg KH wrote: > On Fri, Aug 08, 2014 at 08:11:20AM +, Dexuan Cui wrote: > > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > Sent: Friday, August 8, 2014 11:32 AM > > > > Hi Richard and all, > > > > > > > > IMO the most feasible and need-the-least-c

[PATCH] staging: vt6655: iowpa.h: Fix sparse warnings

2014-08-08 Thread Martin Berglund
This resolves a sparse address space warning in wpactl.c Signed-off-by: Martin Berglund --- drivers/staging/vt6655/iowpa.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/iowpa.h b/drivers/staging/vt6655/iowpa.h index 772bc4c..fe4b22e 100644 ---

Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

2014-08-08 Thread Martin Berglund
On Fri, Aug 08, 2014 at 06:47:25AM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 08, 2014 at 09:07:55AM +0200, Martin Berglund wrote: > > On Thu, Aug 07, 2014 at 07:18:13PM -0700, Greg Kroah-Hartman wrote: > > > On Thu, Aug 07, 2014 at 11:08:34PM +0100, Martin Berglund wrote: > > > > Add missing _

[PATCH 2/7] staging: dgap: remove redundant declarations.

2014-08-08 Thread Daeseok Youn
These are already defined in dgap.h. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 55c06c9..b1253c0 100644 --- a/drivers/staging/dgap/dgap.c

[PATCH 1/7] staging: dgap: remove useless variable

2014-08-08 Thread Daeseok Youn
dgap_major_serial_registered and dgap_major_transparent_print_registered could be checked whether a board is initialized. But it doesn't need to check that variables becasue dgap module isn't calling the dgap_cleanup_tty() without initializing for a board completely. Signed-off-by: Daeseok Youn -

[PATCH 3/7] staging: dgap: cleanup duplicated warning message on dgap_tty_init()

2014-08-08 Thread Daeseok Youn
If true_count is not same with brd->nasync, warning messages are printed. But it has duplicated messages within if statement. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/dgap

[PATCH 4/7] staging: dgap: Simplify set a board type from configration file

2014-08-08 Thread Daeseok Youn
Board types need to separate normal command like IO, MEM and so on. And the board type will come after "board" string in config file normally. (If it is not, dgap_gettok returns an error with zero) After that, set a variable of a number which is matched with specific a board number to "board.type".

[PATCH 5/7] staging: dgap: Simplify to set a concentrator type

2014-08-08 Thread Daeseok Youn
It is same manner with setting a board type. For example of config file for concentrator, "conc ccon" or "conc epcon" After allocating a type of "CNODE" then set a type of concentrator. So remove cases in swith statement, just get a token from string and set to "conc.type". And also it doe

[PATCH 6/7] staging: dgap: Simplify to set a module type

2014-08-08 Thread Daeseok Youn
It is same manner with setting a board type. After allocating a type of "MNODE", get a token value set to "module.type". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 26 +++--- drivers/staging/dgap/dgap.h |1 - 2 files changed, 7 insertions(+), 20 delet

[PATCH 7/7] staging: dgap: cleanup print messages for dgap driver

2014-08-08 Thread Daeseok Youn
* use dev_{warn,err} instead of pr_{warn,err} * removes dgap_err() and just use pr_err(). pr_err() used in dgap_parsefile() not dev_err() because if dgap_parsefile() is failed, just one message is printed. * removes "out of memory" messages. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/d