Silences the following checkpatch warning:
WARNING: line over 80 characters
Signed-off-by: Janet Liu jianhua@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-md.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
Silences the following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Janet Liu jianhua@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-md.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff
After changing the comments format, the other error disappears.
So silences two checkpatch errors:
ERROR: do not use C99 // comments
ERROR: trailing statements should be on next line
Signed-off-by: Janet Liu jianhua@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-md.c |6 +++---
1
Silences the following error:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Janet Liu jianhua@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-md.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-md.c
On 29-08-2014 21:50:16, Andrew Plummer wrote:
Remove insignificant spaces before tabs in comments.
Signed-off-by: Andrew Plummer plummer...@gmail.com
---
drivers/staging/bcm/LeakyBucket.c | 81
---
1 file changed, 33 insertions(+), 48 deletions(-)
On 29/08/14 15:26, Laurentiu Palcu wrote:
isl29108 was used, instead of isl29018.
Signed-off-by: Laurentiu Palcu laurentiu.pa...@intel.com
Applied to the togreg branch of iio.git - initially pushed out as testing for
the
autobuilders to play.
Thanks,
Jonathan
---
On 29/08/14 15:26, Laurentiu Palcu wrote:
Intersil chips ISL29018, ISL29023 and ISL29035 are very similar. They're
all ambience light sensors. The ISL29018, however, is also a proximity
sensor. The registers are similar too:
-+--+--
AVAILABLE IN | ADDR REG | NAME
On 29/08/14 15:26, Laurentiu Palcu wrote:
Add support for enumerating the device through ACPI.
Signed-off-by: Laurentiu Palcu laurentiu.pa...@intel.com
Mostly fine, but I'm unclear on why we have a cast to a char * for name.
Maybe I just haven't had enough coffee this morning :)
Jonathan
---
On 30/08/14 02:40, Chase Southwood wrote:
Sparse has many warnings like:
drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to
restricted __le16
on lines on which devpriv-in_buf or devpriv-insn_buf are passed to
le16_to_cpu(). This suggests that both of these variables should
On 30/08/14 06:55, Chase Southwood wrote:
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
On Sat, Aug 30, 2014 at 02:52:55PM +0800, Janet Liu wrote:
@@ -121,7 +123,7 @@ lnet_md_build(lnet_libmd_t *lmd, lnet_md_t *umd, int
unlink)
lmd-md_length = total_length;
- if ((umd-options LNET_MD_MAX_SIZE) != 0 /* max size used
*/
+ if
This fixes the following sparse warning:
drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c:119:6: warning: symbol
'rtl88e_phy_mac_config' was not declared. Should it be static?
Signed-off-by: Max Vozeler m...@hinterhof.net
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 1 +
1 file
From: Julia Lawall julia.law...@lip6.fr
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
identifier lbl;
@@
if (...)
GOTO(lbl,...);
+else
GOTO(lbl,...);
@@
identifier lbl,rc;
constant c;
expression e,e1;
@@
if (
- e
+ !e
)
-
From: Julia Lawall julia.law...@lip6.fr
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
identifier lbl;
identifier rc;
constant c;
@@
- GOTO(lbl,\(rc\|c\));
+ goto lbl;
@@
identifier lbl;
expression rc;
@@
- GOTO(lbl,rc);
+ rc;
+ goto lbl;
//
Remove empty return at end of function.
Signed-off-by: Andrew Plummer plummer...@gmail.com
---
drivers/staging/nokia_h4p/nokia_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/nokia_h4p/nokia_fw.c
b/drivers/staging/nokia_h4p/nokia_fw.c
index 14ba219..18953ae 100644
---
Fix coding style issues, these changes include:
-Add space between if and brackets
-Add space after comma in an argument
-Add space between equal sign to separate the variable and the assignment
-Remove unnecessary curly braces around one-line if statements
-Remove unnecessary whitespace between
Remove spaces before semicolons to remove checkpatch warnings.
Signed-off-by: Andrew Plummer plummer...@gmail.com
---
drivers/staging/emxx_udc/emxx_udc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
On Sun, Aug 17, 2014 at 12:47:57PM -0400, Oleg Drokin wrote:
On Aug 17, 2014, at 12:37 PM, Greg Kroah-Hartman wrote:
On Fri, Aug 15, 2014 at 12:48:14PM -0400, Oleg Drokin wrote:
Just add the entry with some info.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
MAINTAINERS | 8
On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote:
This patch fixes the checkpatch.pl issue
Error: Required space after '+' ',' '=' '(' ' if'
Signed-off-by: Hema Prathaban hemakl...@gmail.com
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
On Sat, Aug 30, 2014 at 02:54:36PM -0400, wf...@worldbroken.com wrote:
From: Bill Pemberton wf...@worldbroken.com
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton wf...@worldbroken.com
---
drivers/tty/serial/jsm/jsm_driver.c | 38
On Fri, Aug 22, 2014 at 07:57:40PM -0400, Spencer Baugh wrote:
This patch fixes style errors and warnings reported by
scripts/checkpatch.pl
Which errors and warnings does it fix?
Please always be specific.
And only do one type of fix per patch, you do a few different ones
here, right?
Can
From: Bill Pemberton wf...@worldbroken.com
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton wf...@worldbroken.com
---
drivers/tty/serial/jsm/jsm_driver.c | 38 +
include/linux/pci_ids.h |
From: Bill Pemberton wf...@worldbroken.com
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports. In fact, it appears that jsm was
based on dgnc. The dgnc driver has PCI ids for more cards than jsm,
this patch moves support for all the Neo
On Sat, Aug 30, 2014 at 02:56:09PM +0800, Janet Liu wrote:
Silences the following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Janet Liu jianhua@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-md.c | 18
On Sat, Aug 30, 2014 at 02:57:33PM +0800, Janet Liu wrote:
After changing the comments format, the other error disappears.
So silences two checkpatch errors:
ERROR: do not use C99 // comments
ERROR: trailing statements should be on next line
Signed-off-by: Janet Liu
On Wed, Aug 27, 2014 at 01:11:19PM +0200, Matthias Beyer wrote:
-int FreeAdapterDsxBuffer(struct bcm_mini_adapter *Adapter)
+int FreeadDsxBuffer(struct bcm_mini_adapter *ad)
This change breaks the build:
ERROR: FreeAdapterDsxBuffer [drivers/staging/bcm/bcm_wimax.ko] undefined!
_PLEASE_
On 08/30/2014 02:59 PM, Greg KH wrote:
On Sat, Aug 30, 2014 at 02:54:36PM -0400, wf...@worldbroken.com wrote:
From: Bill Pemberton wf...@worldbroken.com
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton wf...@worldbroken.com
---
From: Julia Lawall julia.law...@lip6.fr
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
type T;
expression e;
@@
(
- T *
+ T *
)
e
// /smpl
This semantic patch just removes the cast and adds it back, but when it
does so, it follows the spacing
On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote:
Replace a long list of contiguous writel() calls with a for loop iterating
over the same values.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 27 +++
1 file changed,
From: Bill Pemberton wf...@worldbroken.com
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports. In fact, it appears that jsm was
based on dgnc. The dgnc driver has PCI ids for more cards than jsm,
this patch moves support for all the Neo
From: Bill Pemberton wf...@worldbroken.com
The Digi Neo cards are supported by the jsm driver. Remove support
for these cards from dgnc.
Signed-off-by: Bill Pemberton wf...@worldbroken.com
---
drivers/staging/dgnc/dgnc_driver.c | 13 -
1 file changed, 13 deletions(-)
diff --git
From: Bill Pemberton wf...@worldbroken.com
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton wf...@worldbroken.com
---
drivers/tty/serial/jsm/jsm.h| 10 ++
drivers/tty/serial/jsm/jsm_driver.c | 38
Your subject does not say what is going on in this patch, only the file
being modified :(
On Fri, Aug 22, 2014 at 11:32:38AM +0100, Miguel Oliveira wrote:
void rtw_proc_remove_one(struct net_device *dev)
{
}
void rtw_proc_init_one(struct net_device *dev)
/* TODO: Convert these to /sys */
On Fri, Aug 22, 2014 at 11:33:37AM +0100, Miguel Oliveira wrote:
Convert all rtw_proc_xxx references to rtw_sys_xxx in files
include/osdep_intf.h and os_dep/usb_intf.c
Same comments as the previous ones, please redo all of these patches.
greg k-h
___
On Fri, Aug 22, 2014 at 11:33:20AM +0100, Miguel Oliveira wrote:
Convert all rtw_proc_xxx references to rtw_sys_xxx
Again, your subject: is not understandable.
And what are you doing here?
Code with 62 WARNING: line over 80 characters, I'll write another patch
to clean the whole file.
What
On Fri, Aug 22, 2014 at 11:33:52AM +0100, Miguel Oliveira wrote:
Convert all rtw_proc_xxx references to rtw_sys_xxx in file
include/rtw_debug.h
That's interesting, but:
Signed-off-by: Miguel Oliveira cmro...@gmail.com
---
drivers/staging/rtl8188eu/include/rtw_debug.h | 227
On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
The rcu_dereference() call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
rcu_access_pointer() instead of rcu_dereference().
Therefore, this patch makes the
On Sat, Aug 23, 2014 at 07:48:24PM +0530, navin patidar wrote:
Rename CamelCase variables and function name.
Signed-off-by: navin patidar navin.pati...@gmail.com
This patch fails to apply:
checking file drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c
checking file
On Sun, Aug 17, 2014 at 10:19:28AM -0300, Raphael Silva wrote:
Type casting corrections in order to solve warnings of the sparce static
analyser.
Signed-off-by: Raphael Silva rapp...@gmail.com
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++--
On Sat, Aug 23, 2014 at 10:55:51AM +0800, Hoang Tran wrote:
This patch fixes the following sparse warnings in rtl8821ae/stats.c
drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
was not declared. Should it be static?
drivers/staging/rtl8821ae/stats.c:101:6:
On Mon, Aug 25, 2014 at 12:55:27PM +0530, Sanjeev Sharma wrote:
This is a patch to the r8190_rtl8256.c file that fixes
commenting style Error
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 59
+---
1
On Sat, Aug 30, 2014 at 02:10:52PM -0400, An Ha wrote:
Fix coding style issues, these changes include:
-Add space between if and brackets
-Add space after comma in an argument
-Add space between equal sign to separate the variable and the assignment
-Remove unnecessary curly braces around
On Sun, Aug 17, 2014 at 04:39:16PM +0300, Andreea-Cristina Bernat wrote:
The rcu_dereference() call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
rcu_access_pointer() instead of rcu_dereference().
Therefore, this patch makes the
On Wed, Aug 20, 2014 at 04:19:19PM +0100, Purnendu Kapadia wrote:
Signed-off-by: Purnendu Kapadia pro8li...@gmail.com
---
drivers/staging/android/sync.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index
On Mon, Aug 25, 2014 at 08:35:31PM +0100, Koray Gulcu wrote:
Add two new lines that are missing after declerations as detected by
checkpatch.pl
Signed-off-by: Koray Gulcu koray.gu...@ozu.edu.tr
---
drivers/staging/android/sw_sync.c |2 ++
1 file changed, 2 insertions(+)
2 other
From: John L. Hammond john.hamm...@intel.com
The functions exported by lustre/obdclass/lu_ucred.c are not used so
remove that file.
Signed-off-by: John L. Hammond john.hamm...@intel.com
---
drivers/staging/lustre/lustre/obdclass/Makefile | 3 +-
From: John L. Hammond john.hamm...@intel.com
The functions defined in lustre/include/lustre_idmap.h are not used so
remove them.
Signed-off-by: John L. Hammond john.hamm...@intel.com
Signed-off-by: Oleg Drokin oleg.dro...@intel.com
---
.../staging/lustre/lustre/include/lustre_idmap.h | 104
From: John L. Hammond john.hamm...@intel.com
The functions exported by lustre/obdclass/mea.c are not used so remove
them.
Signed-off-by: John L. Hammond john.hamm...@intel.com
---
drivers/staging/lustre/lustre/include/obd_class.h | 4 -
drivers/staging/lustre/lustre/obdclass/Makefile | 2
With removal of libcfs/heap.c, it's header can also go away now.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 1 -
.../lustre/include/linux/libcfs/libcfs_heap.h | 200 -
From: John L. Hammond john.hamm...@intel.com
The landing of clio #if 0-ed out some regions of echo_client.c. Just
remove these regions entirely.
Signed-off-by: John L. Hammond john.hamm...@intel.com
Reviewed-on: http://review.whamcloud.com/5580
Intel-bug-id:
This series of patches continues removal of unused code in
lustre client tree.
John L. Hammond (9):
staging/lustre/obdecho: remove #if 0-ed out regions
staging/lustre/obdclass: remove idmap.c
staging/lustre/obdclass: remove lu_ucred.c
staging/lustre/obdclass: remove mea.c
From: John L. Hammond john.hamm...@intel.com
Remove the server specific set_info handlers (KEY_REGISTER_TARGET,
KEY_SET_FS, KEY_CLEAR_FS) and supporting functions.
Signed-off-by: John L. Hammond john.hamm...@intel.com
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
From: Peng Tao tao.p...@emc.com
The metadata echo client requires server support and should not have
been included.
Signed-off-by: Liu Xuezhao xuezhao@emc.com
Signed-off-by: Peng Tao tao.p...@emc.com
Signed-off-by: John L. Hammond john.hamm...@intel.com
Reviewed-on:
From: John L. Hammond john.hamm...@intel.com
The declarations from lustre/include/md_object.h are not used so
remove them.
Signed-off-by: John L. Hammond john.hamm...@intel.com
Signed-off-by: Oleg Drokin oleg.dro...@intel.com
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 -
These structures are only used server-side to parse relevant
attributes.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
.../lustre/lustre/include/lustre/lustre_idl.h | 37 -
drivers/staging/lustre/lustre/ptlrpc/wiretest.c| 48 --
2 files changed,
From: John L. Hammond john.hamm...@intel.com
llog_osd_ops is not used so remove it and its supporting methods.
Signed-off-by: John L. Hammond john.hamm...@intel.com
---
drivers/staging/lustre/lustre/include/lustre_log.h |9 -
drivers/staging/lustre/lustre/obdclass/Makefile|2 +-
From: John L. Hammond john.hamm...@intel.com
The llog_test module requires server support (it needs a local MGS to
function) and should not have been included.
Signed-off-by: John L. Hammond john.hamm...@intel.com
---
drivers/staging/lustre/lustre/obdclass/Makefile|2 +-
From: John L. Hammond john.hamm...@intel.com
In mdc_iocontrol() remove the handlers for the obsolete llog ioctls
OBD_IOC_PARSE, OBD_IOC_LLOG_INFO, and OBD_IOC_LLOG_PRINT.
Signed-off-by: John L. Hammond john.hamm...@intel.com
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
Same comments as the previous ones, please redo all of these patches.
Should all the alterations be in one big single patch, insted of small ones?
___
devel mailing list
de...@linuxdriverproject.org
How does this change relate to what you said you were going to do above?
confused,
That was a fix for a sparse warning that went on this patch acidenttly.
Sorry about that.
___
devel mailing list
de...@linuxdriverproject.org
On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote:
2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux li...@arm.linux.org.uk:
On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
Hi Russell,
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote:
Same comments as the previous ones, please redo all of these patches.
Should all the alterations be in one big single patch, insted of small ones?
I don't know, I don't remember what this patch even contained given that
it was
On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
This patch fixes the following checkpatch.pl warnings:
WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+ if (!skb) {
+ pr_err(SKB allocation failed\n);
WARNING: Missing a
After changing the comments format, the other error disappears.
So silences two checkpatch errors:
ERROR: do not use C99 // comments
ERROR: trailing statements should be on next line
Signed-off-by: Janet Liu jianhua@gmail.com
---
drivers/staging/lustre/lnet/lnet/lib-md.c |6 +++---
1
Fixed a C99 comment issue in InterfaceMisc.h.
Signed-off-by: Anh Le anhlq2...@gmail.com
---
drivers/staging/bcm/InterfaceMisc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.h
b/drivers/staging/bcm/InterfaceMisc.h
index efb6860..0e5e38b
65 matches
Mail list logo
