Signed-off-by: Eli Billauer
---
MAINTAINERS | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f040e7f..95bcdee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8789,12 +8789,6 @@ M: Arnaud Patard
S: Odd Fixes
F: dri
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Sunday, August 31, 2014 2:28 AM
To: Sharma, Sanjeev
Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH] staging:r8190_rtl8256: coding style: Fixed commenting style
On Mon, Aug 25, 2014
This is a patch to the r8190_rtl8256.c file that fixes
commenting style Error
Signed-off-by: Sanjeev Sharma
---
Changes in v2:
- removed stuff which is not being used ad per greg comment
drivers/staging/rtl8192u/r8190_rtl8256.c | 52 +---
1 file changed, 21 inserti
From: Mikhail Pershin
OUT service is used to server both MDS-MDS updates and MDS-OST
therefore services on MDT and OST are set to use the same request
and reply portals to be fully unified and able to serve any type
of requests.
Signed-off-by: Mikhail Pershin
Reviewed-on: http://review.whamclou
This function is no longer used anywhere.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 29 -
1 file changed, 29 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd.h
b/drivers/staging/lustre/lustre/include/obd.h
index
Hugues has recently discovered a possibility
of buffer underflow in is_osp_on_mdt.
Instead of fixing it up, let's just get rid of this function altogether,
since it's no longer needed.
Mikhail Pershin (1):
staging/lustre: use osc_reply_portal for OUT services
Oleg Drokin (1):
staging/lustre:
Thanks!
Actually, I do't think this function is useful on the client.
>From the name of it, it would have been used in the server code, but even
>there it was recently removed as I now see.
I'll submit a removal patch.
On Sep 8, 2014, at 6:38 PM, Dan Carpenter wrote:
> On Tue, Sep 09, 2014 at
Rename this function so it has namespace associated with the driver.
Also, this function always succeeds. Change the return type to void
and remove the unnecessary error handling by the callers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
This function is called by the analog input (*insn_read) and (*do_cmd)
operations. The pci9118_set_chanlist() function is also called by those
operations. Setting the range and aref logically belongs with setting
the chanlist. To clarify the code, absorb pci9118_ai_set_range_aref()
into pci9118_set
The async command can operation in 4 modes in this driver.
Modes 1 and 4 use timers 1 and 2 as a cascaded timer to trigger each conversion.
Mode 1 begins the acquisitions immediately (scan_begin_src == TRIG_FOLLOW) and
Mode 4 begins after an external trigger (scan_begin_src == TRIG_EXT). Both mode
For aesthetics, change the type of this member to avoid the casts when
allocating
and freeing the DMA buffers. This does introduce a cast in move_block_from_dma()
but that cast is cleaner.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/driver
Currently the pci9118_ai_docmd_dma() or pci9118_ai_docmd_sampl() helper
is called by the (*do_cmd) to do the final setup for the command. Most
of this invloves setting various bits in 'ai_ctrl' and 'int_ctrl' to
setup the acquisition based on the 'ai_do' mode. Most of this is the
same for the DMA a
Define some macros to set the 'chan' and 'range' bits in the chanlist
register. Use them to tidy up this function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 48 ++--
1 file changed, 24 inser
This driver currently supports both the (*auto_attach) and legacy (*attach)
mechanisms. The (*auto_attach) always tries to use the interrupt and DMA to
support async commands with the analog input subdevice. The legacy (*attach)
only enables them depending on a user option that is passed to the (*a
Each of the error detections currently do a cfc_handle_events() and exits
the interrupt handler if the error is detected. The DMA and non-DMA handlers
also to a cfc_handle_events().
For aesthetics, use goto to exit the interrupt handler if an error is detected
and move the cfc_handle_events() call
For aesthetics convert the private data true/false flags to bit-fields. The
'usemux' member is used in the driver as a flag. Refactor the analog input
subdevice init so this member can also be a bit-field.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagi
In order for DMA to work we also need an interrupt. Refactor the code
so that the DMA allocation is only done if the interrupt is available.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 19 ++-
1 file
The 'rot' and 'usedma' parameters are not used in this function. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/sta
The 'source' passed to pci9118_exttrg_{add,del}() is always EXTTRG_AI.
Remove the parameter and unnecessary sanity checking. Also, since there
is only one vaild exttrg source, remove the unnecessary 'exttrg_users'
member from the private data.
The pci9118_exttrg_{add,del}() functions always succe
The (*do_cmdtest) validates the scan_begin_src as TRIG_FOLLOW, TRIG_TIMER,
or TRIG_EXT. Remove the invalid check for TRIG_INT in the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
1 file changed, 1 ins
For aesthetics, wrap the DMA buffer information in a struct.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 96 ++--
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/drivers/stagin
For aesthetics, merge these two helper functions and add a parameter,
'enable', to determine if the external trigger is being added (enabled)
or deleted (disabled).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 34
This function modifies the analog input acquistion programming after the first
DMA cycle to continue a "mode4" acqusition. Part of this programs timer 0 based
on the hardware address of the next buffer. When double buffering is not used
for DMA the "next" buffer is always the first, and only, buffe
The legacy (*attach) currently allows the user to pass a mask of error
conditions
to ignore when running async commands. Remove this support so that the async
command is always terminated if the hardware reports an error.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
-
For aesthetics, move the master/target abort detection from the DMA handler to
the
main interrupt handler. This allows removing the unused 'int_amcc' parameter
from
the DMA and non-DMA handlers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi
This member of the private data is only used in some #if 0'ed code. Remove
it along with the unused code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 17 -
1 file changed, 17 deletions(-)
diff --git
The async command can start immediately (TRIG_NOW), from an internal
trigger (TRIG_INT), or from an external trigger (TRIG_EXT). Currently
the start of the command is scattered in the DMA and non-DMA helper
functions.
Consolidate the start of the async command at the end of the (*do_cmd)
function.
For aesthetics, move this function closer to the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 324 +--
1 file changed, 162 insertions(+), 162 deletions(-)
diff --git a/drivers/stagi
This member of the private data is set but never used. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/d
The comment states that paramoid checks are broken. They also would only
work for 12-bit analog input samples.
Instead of fixing the paranoid checking just remove it to simplify the
driver a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi
Introduce a helper function to start the async command.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 43
1 file changed, 18 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/com
The 'tim2' parameter to this function is actually the cmd->convert_arg which
was validated in the (*do_cmdtest) as:
err |= cfc_check_trigger_arg_min(&cmd->convert_arg,
devprivriv->ai_ns_min);
The sanity checks in this function are just repeating th
The pci9118_ai_docmd_dma() function enables the DMA bit in the ai control
register for all acquisition modes. For aesthetics, move the enable of
this bit into the (*do_cmd).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c
Hardware errors will now always terminate an async command. For aesthetics,
absorb pci9118_decode_error_status() into the interrupt handler and use
the register map defines to remove the "magic" numbers. Refactor the code
to set the appropriate comedi event bits and handle the event.
Remove the un
The 'ai_cfg' was already set to PCI9118_AI_CFG_PDTRG | PCI9118_AI_CFG_PETRG.
Don't bother setting those bits in pci9118_ai_docmd_dma().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 12 +++-
1 file changed, 3 i
Start cleaning up the async command support in this comedi driver.
H Hartley Sweeten (29):
staging: comedi: adl_pci9118: DMA requires and interrupt
staging: comedi: adl_pci9118: always try to use interrupt and DMA
staging: comedi: adl_pci9118: don't ignore hardware errors
staging: comedi:
The DMA and non-DMA both check the analog input status value to detect
hardware errors. For aesthetics, move the this detection into the main
interrupt handler. This allows removing the unused 'int_adstat' parameter
from the DMA and non-DMA handlers. In addition, the 'int_daq' parameter
is also no
On Tue, Sep 09, 2014 at 12:12:01AM +0200, Hugues wrote:
> Fix potential buffer underflow
>
> When the string 'name' start with a '-' ptr == name and so --ptr will
> underflow, this patch corrected this by checking ptr before decrementing.
Good eye. Please fix up the changelog and send it inline
It's possible for dev_alloc_skb() to fail. Propagate the error to the caller,
so it can clean up and drop the packet. The sender should end up retransmitting
the packet, hopefully at a time we're prepared to allocate skb's again.
Reported-By: Nicholas Krause
Signed-Off-By: Valdis Kletnieks
---
Fix your email "From" header to say your full name instead of just
From: Hugues
All the subjects are the same so redo these patches. Also don't pick
the most vague subject you can think of. Mention "long lines", for
example.
On Tue, Sep 09, 2014 at 12:04:43AM +0200, Hugues wrote:
> Fix coding
On Tue, Sep 09, 2014 at 12:04:43AM +0200, Hugues wrote:
> Fix coding style issues:
> * limit the length of changed lines to 80 columns.
Why isn't this in the body of the changelog?
> >From a244d32aa34d0b13ac40dd014b88d0ff5ed10817 Mon Sep 17 00:00:00 2001
> From: Hugues Morisset
> Date: Mon, 8 Se
Fix potential buffer underflow
When the string 'name' start with a '-' ptr == name and so --ptr will
underflow, this patch corrected this by checking ptr before decrementing.
>From 5786040323bd1dc3149fb4afbea9f01e2bf4cfdf Mon Sep 17 00:00:00 2001
From: Hugues Morisset
Date: Mon, 8 Sep 2014 22:59:
On 09/09/2014 12:07 AM, Hugues wrote:
> Fix coding style issues:
> * Remove extra space in function's pointers
>
Sorry, I forgot the attachment.
>From d4ec8f9a9452102f0b044758bf407782665baa68 Mon Sep 17 00:00:00 2001
From: Hugues Morisset
Date: Mon, 8 Sep 2014 21:39:27 +0200
Subject: [PATCH 3/4]
Fix coding style issues:
* Remove extra space in function's pointers
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Fix coding style issues:
* Remove inappropriate typedefs
>From a2c6d82141849cd102b5805941351a6b20df0e8a Mon Sep 17 00:00:00 2001
From: Hugues Morisset
Date: Mon, 8 Sep 2014 21:36:10 +0200
Subject: [PATCH 2/4] staging: lustre: fix coding style issues
Signed-off-by: Hugues Morisset
---
drivers/st
Fix coding style issues:
* limit the length of changed lines to 80 columns.
>From a244d32aa34d0b13ac40dd014b88d0ff5ed10817 Mon Sep 17 00:00:00 2001
From: Hugues Morisset
Date: Mon, 8 Sep 2014 21:23:28 +0200
Subject: [PATCH 1/4] staging: lustre: fix coding style issues
Signed-off-by: Hugues Moriss
Silence checkpatch warning:
WARNING: type 'long long unsigned' should be specified in
[[un]signed] [short|int|long|long long] order
Signed-off-by: Eddie Kovsky
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Hi,
On Mon, Sep 08, 2014 at 12:33:47PM -0700, Greg KH wrote:
> On Mon, Sep 08, 2014 at 09:59:23PM +0300, Aaro Koskinen wrote:
> > On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote:
> > > This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning
> > > by removing retur
This is a patch to the octeon-hcd.c file that fixes
checkpatch.pl warning by removing return statement from
void functions.
Signed-off-by: Nitin Kuppelur
---
drivers/staging/octeon-usb/octeon-hcd.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.
On Thu, Sep 04, 2014 at 08:15:48PM +0300, Andreea-Cristina Bernat wrote:
> The "br_port" local variables obtained through the rcu_dereference() calls are
> not dereferenced in the rest of their function.
> Therefore, it is recommended to use rcu_access_pointer() instead of
> rcu_dereference().
> Th
Hi Aaro,
Thanks for review. I will correct the commit log length and resend the patch.
About the __cvmx_usb_perform_complete():
Here return statement has associated label. Due to which it will add
compilation warning. So I am not handling this.
Note:
Also checkpatch.pl does not complain about th
On Mon, Sep 01, 2014 at 08:47:12AM -0400, Dipak Zope wrote:
> Signed-off-by: Dipak Zope
> ---
> drivers/staging/android/uapi/binder.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi/binder.h
> b/drivers/staging/android/uapi/binder.h
> index
On 09/08/2014 04:17 PM, Greg KH wrote:
On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote:
From: Bill Pemberton
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports. In fact, it appears that jsm was
based on dgnc. The dgn
On Mon, Sep 08, 2014 at 01:44:49PM +0100, Luke Hart wrote:
> Copy the channel type into a temporary buffer so that code will work for
> architectures that don't support MMIO. This now works in same way as other
> tests in same function.
Can you please line-wrap your changelog lines?
> Re-sent s
On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote:
> From: Bill Pemberton
>
> The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
> cards that dgnc (staging) supports. In fact, it appears that jsm was
> based on dgnc. The dgnc driver has PCI ids for more ca
On Tue, Jul 29, 2014 at 11:57:06AM +0200, Philipp Zabel wrote:
> For the overlay plane scanning out a framebuffer with an alpha component,
> enable the DP local alpha feature on the partial plane.
>
> Signed-off-by: Philipp Zabel
> ---
> drivers/staging/imx-drm/ipuv3-plane.c | 12 ++--
>
On Sun, Sep 07, 2014 at 06:18:31PM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> identifier lbl;
> identifier rc;
> constant c;
> @@
>
> - GOTO(lbl,\(rc\|c\));
> + goto lbl;
>
> @@
> id
On Sat, Sep 06, 2014 at 01:38:27PM -0400, Spencer Baugh wrote:
> Fix errors reported by checkpatch of this kind:
> ERROR: open brace '{' following function declarations go on the next line
>
> Signed-off-by: Spencer Baugh
> ---
> drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++--
On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote:
> On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote:
>> Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi:
>> amplc_pci230: refactor iobase addresses") removed some parentheses
>> (presumably to keep the line
On Mon, Sep 08, 2014 at 09:59:23PM +0300, Aaro Koskinen wrote:
> On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote:
> > This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning
> > by removing return statement from void functions.
>
> Please format line length to <=
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Thursday, September 4, 2014 10:40 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; linux-s...@vger.kernel.org
> Subject:
On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote:
> Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 ("staging: comedi:
> amplc_pci230: refactor iobase addresses") removed some parentheses
> (presumably to keep the line withing 80 chars) in
> `pci230_ao_write_nofifo()` when writing to the
On Mon, Sep 08, 2014 at 12:08:59PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 01, 2014 at 06:07:12PM +0100, Russell King - ARM Linux wrote:
> > Greg,
> >
> > Here's two oops fixes for imx-drm, which I've had queued up for a number
> > of months now. Shawn posted different fixes for the same o
On Mon, Sep 01, 2014 at 06:07:12PM +0100, Russell King - ARM Linux wrote:
> Greg,
>
> Here's two oops fixes for imx-drm, which I've had queued up for a number
> of months now. Shawn posted different fixes for the same oops recently
> as well.
So do I take your patches, or Shawn's?
confused,
gr
Cleanup checkpatch.pl warnings.
Signed-off-by: Adrian Nicoara
---
Somehow I missed the comment Tobias made on the line indentation. I fixed the
patch, and added here as a reply - the previous patch should be ignored.
drivers/staging/ozwpan/ozhcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 d
On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote:
> This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by
> removing return statement from void functions.
Please format line length to <= 76 characters in the commit log.
Maybe you could fix __cvmx_usb_perform_
Cleanup checkpatch.pl warnings.
Signed-off-by: Adrian Nicoara
---
drivers/staging/ozwpan/ozhcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index ba2168f..4cfe56e 100644
--- a/drivers/staging/ozwpan/ozhcd.c
Cleanup checkpatch.pl warnings.
Signed-off-by: Adrian Nicoara
---
drivers/staging/ozwpan/ozproto.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c
index cae0e6f..3d3a3a8 100644
--- a/drivers/staging/ozwpan/ozproto.c
+++ b/dri
Cleanup checkpatch.pl warnings.
Signed-off-by: Adrian Nicoara
---
drivers/staging/ozwpan/ozhcd.c | 8 +++-
drivers/staging/ozwpan/ozpd.c | 10 --
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index b3
Cleanup checkpatch.pl warnings.
Signed-off-by: Adrian Nicoara
---
drivers/staging/ozwpan/ozcdev.c| 5 +
drivers/staging/ozwpan/ozeltbuf.c | 1 +
drivers/staging/ozwpan/ozpd.c | 6 ++
drivers/staging/ozwpan/ozproto.c | 4
drivers/staging/ozwpan/ozusbsvc.c | 2 ++
drivers
On Mon, 2014-09-08 at 10:24 -0700, Greg Kroah-Hartman wrote:
> If you test it, do a tested-by.
>
> If you sign off on it (i.e. it flows through you to me), then a
> signed-off is correct.
>
> Hope this helps,
>
> greg k-h
It does. :) We should add the Tested-by then, too.
Acked-by: Benjamin Ro
On Mon, 2014-09-08 at 13:32 +0300, Dan Carpenter wrote:
> On Sat, Sep 06, 2014 at 11:19:03AM -0700, Joe Perches wrote:
> > Indexing a string array with an enum is generally unsafe.
> > I think it better to use a switch/case like:
> The reverse side of that argument is that switch statements are slo
On Mon, Sep 08, 2014 at 12:10:55PM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> > Traditionally, you would respond with a:
> > Acked-by: Developer Name
> > so I can add it to the patch.
> >
> > Care to do that here?
> >
> > thanks,
> >
> >
This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by
removing return statement from void functions.
Signed-off-by: Nitin Kuppelur
---
drivers/staging/octeon-usb/octeon-hcd.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd
On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> Traditionally, you would respond with a:
> Acked-by: Developer Name
> so I can add it to the patch.
>
> Care to do that here?
>
> thanks,
>
> greg k-h
Of course. :)
Acked-by: Benjamin Romer
Should I do this instead of Test
On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote:
> On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> > fixed sparse warning : context imbalance in 'pause_device'
> > unexpected unlock
> > this patch will generate warning from checkpatch for
> > line
On Mon, Sep 08, 2014 at 11:48:44AM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 22:08 +0530, Sudip Mukherjee wrote:
> > Hi Ben,
> > sorry to disturb you again. i got confused , which one is perfect one
> > combined patch or
> > separate patches?
> >
> > thanks
> > sudip
>
> Two patch
On Mon, 2014-09-08 at 22:08 +0530, Sudip Mukherjee wrote:
> Hi Ben,
> sorry to disturb you again. i got confused , which one is perfect one
> combined patch or
> separate patches?
>
> thanks
> sudip
Two patches, as you preferred.
-- Ben
___
devel m
On Mon, Sep 08, 2014 at 11:30:48AM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 21:57 +0530, Sudip Mukherjee wrote:
> > Hi Ben,
> > thanks. the same file is having two more similar warnings. if you want i can
> > resend a patch fixing all the three warnings , or i can send two separate
>
On Mon, 2014-09-08 at 21:57 +0530, Sudip Mukherjee wrote:
> Hi Ben,
> thanks. the same file is having two more similar warnings. if you want i can
> resend a patch fixing all the three warnings , or i can send two separate
> patches.
> I personally will prefer two separate patches , as that will b
On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote:
> On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> > fixed sparse warning : context imbalance in 'pause_device'
> > unexpected unlock
> > this patch will generate warning from checkpatch for
> > line
On Mon, 2014-09-08 at 17:04 +0300, Dan Carpenter wrote:
> On Mon, Sep 08, 2014 at 01:44:49PM +0100, Luke Hart wrote:
> > Copy the channel type into a temporary buffer so that code will work for
> > architectures that don't support MMIO. This now works in same way as other
> > tests in same functi
On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> fixed sparse warning : context imbalance in 'pause_device'
> unexpected unlock
> this patch will generate warning from checkpatch for
> lines over 80 character , but since those are user-visible strings
> so it was
On Mon, Sep 08, 2014 at 01:44:49PM +0100, Luke Hart wrote:
> Copy the channel type into a temporary buffer so that code will work for
> architectures that don't support MMIO. This now works in same way as other
> tests in same function.
>
> Re-sent since I initially didn't copy de...@driverdev.o
Copy the channel type into a temporary buffer so that code will work for
architectures that don't support MMIO. This now works in same way as other
tests in same function.
Re-sent since I initially didn't copy de...@driverdev.osuosl.org and
sparmaintai...@unisys.com doesn't seem to be a mailing
On Sat, Sep 06, 2014 at 11:19:03AM -0700, Joe Perches wrote:
>
> Indexing a string array with an enum is generally unsafe.
>
> I think it better to use a switch/case like:
>
The reverse side of that argument is that switch statements are slower
and uglier.
My understanding is that according to
On 2014-09-05 17:25, H Hartley Sweeten wrote:
Cleans up all the non-async command support code.
This series applies after:
[PATCH 00/21] staging: comedi: adl_pci9118: cleanup the boardinfo and attach
[PATCH 00/19] staging: comedi: adl_pci9118: tidy up register map
H Hartley Sweeten (17):
sta
87 matches
Mail list logo
