From: Micky Ching micky_ch...@realsil.com.cn
This patch fix rts5227 and rts5249 suspend issue, when card reader
resumed from suspend state, the power state should reset before send
buffer command. The original not reset PM state first, so this will
lead resume failed, and can not do anything
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts5227 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead resume fail.
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
---
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead resume fail.
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
---
On Thu, Sep 11, 2014 at 03:17:52PM +0800, micky_ch...@realsil.com.cn wrote:
+ /* reset PM_CTRL3 before send buffer cmd */
+ err = rtsx_pci_write_register(pcr, PM_CTRL3, 0x10, 0x00);
+ if (err 0)
+ return err;
+
+ return err;
Just do:
return
Am Mittwoch, den 10.09.2014, 11:32 -0700 schrieb Greg Kroah-Hartman:
On Wed, Sep 10, 2014 at 11:35:29AM +0200, Philipp Zabel wrote:
Hi Greg,
I have asked Dave to pull Steve Longerbeam's preparation series for
capture support. It starts off with the following two commits that also
touch
Hi Philipp,
Thank you for the patch.
On Wednesday 10 September 2014 12:58:23 Philipp Zabel wrote:
Decrementing the reference count of the previous endpoint node allows to
use the of_graph_get_next_endpoint function in a for_each_... style macro.
Prior to this patch, all current users of this
Hi Philipp,
Thank you for the patch.
On Wednesday 10 September 2014 12:58:24 Philipp Zabel wrote:
Note that while of_graph_get_next_endpoint decrements the reference count
of the child node passed to it, of_node_put(child) still has to be called
manually when breaking out of the loop.
Hi Philipp,
Thank you for the patch.
On Wednesday 10 September 2014 12:58:25 Philipp Zabel wrote:
This patch adds a function to get a port device tree node by port id,
or reg property value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
Changes since v1:
- Fixed whitespace in
On 2014-09-10 19:39, Hartley Sweeten wrote:
On Wednesday, September 10, 2014 3:56 AM, Ian Abbott wrote:
On 2014-09-10 00:15, H Hartley Sweeten wrote:
The validation of the cmd-stop_arg when the cmd-stop_src == TRIG_EXT
is a bit over thought. The comments state that the stop_arg is validated
to
In preparation for the following patch, stop decrementing the endpoint node
refcount in the loop. This temporarily leaks a reference to the endpoint node,
which will be fixed by having of_graph_get_next_endpoint decrement the refcount
of its prev argument instead.
Signed-off-by: Philipp Zabel
This patch adds a function to get a port device tree node by port id,
or reg property value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
Changes since v2:
- Fixed and simplified of_graph_get_port_by_id function
---
drivers/of/base.c| 26 ++
Note that while of_graph_get_next_endpoint decrements the reference count
of the child node passed to it, of_node_put(child) still has to be called
manually when breaking out of the loop.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart
Using the for_each_... macro should make the code a bit shorter and
easier to read.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/gpu/drm/drm_of.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff
Using the for_each_... macro should make the code bit shorter and
easier to read. This patch also properly decrements the endpoint node
reference count before returning out of the loop.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/imx-drm-core.c | 9 +++--
Using the for_each_... macro should make the code bit shorter and
easier to read.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/imx-drm-core.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
In preparation for a following patch, stop decrementing the endpoint node
refcount in the loop. This temporarily leaks a reference to the endpoint node,
which will be fixed by having of_graph_get_next_endpoint decrement the refcount
of its prev argument instead.
Signed-off-by: Philipp Zabel
Decrementing the reference count of the previous endpoint node allows to
use the of_graph_get_next_endpoint function in a for_each_... style macro.
Prior to this patch, all current users of this function that actually pass
a non-NULL prev parameter should be changed to not decrement the passed
Hi,
this series converts all existing users of of_graph_get_next_endpoint that pass
a non-NULL prev argument to the function and decrement its refcount themselves
to stop doing that. The of_node_put is moved into of_graph_get_next_endpoint
instead.
This allows to add a for_each_endpoint_of_node
On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote:
The `comedi_board` inline function takes a single parameter of type
`struct comedi_device *` and merely returns the value of the `board_ptr`
member therein. This is somewhat superfluous as the member can be
accessed directly.
Replace
Hi Philipp,
Thank you for the patch.
On Thursday 11 September 2014 17:33:04 Philipp Zabel wrote:
This patch adds a function to get a port device tree node by port id,
or reg property value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart
On Thu, Sep 11, 2014 at 10:07:53AM +0200, Philipp Zabel wrote:
Am Mittwoch, den 10.09.2014, 11:32 -0700 schrieb Greg Kroah-Hartman:
On Wed, Sep 10, 2014 at 11:35:29AM +0200, Philipp Zabel wrote:
Hi Greg,
I have asked Dave to pull Steve Longerbeam's preparation series for
capture
On Thu, Sep 11, 2014 at 05:57:34PM +, Hartley Sweeten wrote:
On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote:
The `comedi_board` inline function takes a single parameter of type
`struct comedi_device *` and merely returns the value of the `board_ptr`
member therein. This is
On Mon, Sep 08, 2014 at 03:27:35PM +0100, Luke Hart wrote:
Copy the channel type into a temporary buffer so that code will work
for architectures that don't support MMIO. This now works in same way
as other tests in same function.
Signed-off-by: Luke Hart luke.h...@birchleys.eu
---
From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd,
multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd
are not returned or used for anything meaningful - remove the code
that collects them, and the struct members too.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
Remove some fairly useless comments regarding rx/tx _bytes and
_dropped, and use rcvd_pkts_dropped stat value to provide rx_dropped.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git
Memory allocation errors do not denote NETDEV_TX_BUSY, simply drop
the packet silently with kfree_skb() and return NETDEV_TX_OK.
Also remove this item from the TODO list.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/README | 1 -
drivers/staging/et131x/et131x.c |
'struct tcb' member 'flags' was only used to collect tx stats, now
we are no longer collecting those particular stats, we no longer
need tcb-flags or the code used to peek into the skb to set it's
value.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 18
Both these if statements have the same effect when true, so combine
them and save a few lines.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c
Tackle the last few major TODO items for this driver.
Mark Einon (8):
staging: et131x: Remove et131x_send_packets() function
staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just
drop the packet
staging: et131x: Tidy up rx/tx dropped bytes stats
staging: et131x: Remove
In nic_rx_pkts(), we check that a multicast packet received (when using
a multicast list) is one that was requested - despite setting the list
up with the hardware. We shouldn't expect to get a mc packet we didn't
ask for, so remove these extra checks.
This also means that the surrounding code
Remove et131x_send_packets() and replace the only use in et131x_tx
with the removed function's body.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 76 -
1 file changed, 29 insertions(+), 47 deletions(-)
diff --git
The number of spinlocks has been halved, from 8 to 4 since this
comment was made, let's see if this is enough.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/README | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/et131x/README
On Thursday, September 11, 2014 2:38 PM, Greg Kroah-Hartman wrote:
On Thu, Sep 11, 2014 at 05:57:34PM +, Hartley Sweeten wrote:
Just wanted to give you a heads up on this series and the ones I have
posted. The series are:
From Ian, [PATCH 00/48] staging: comedi: avoid using
On Wed, Sep 10, 2014 at 10:10:49PM +0100, Purnendu Kapadia wrote:
- add line after declaration
- allignment should match open parenthesis
- remove unnecessary new line
Signed-off-by: Purnendu Kapadia pro8li...@gmail.com
---
drivers/staging/android/sw_sync.c | 9 +
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The comedi async commands should stop if an error/overflow happens or when
the end-of-acquisition for the command is detected. Some of the drivers
do this correctly but many don't.
The cfc_handle_events() function automatically detects the events that would
terminate a command. If the events are
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Also, cfc_handle_events() does nothing if no events are set so the local
variable 'oldevents' can be removed.
Signed-off-by: H Hartley Sweeten
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
For aesthetics, add a local variable for the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
The pcl711_ai_set_mode() call when the end-of-acquisition is detected can
then be removed. The (*cancel) does the same thing.
Signed-off-by: H Hartley Sweeten
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
The s626_mc_disable() call when the end-of-acquisition is detected can then
be removed. The (*cancel) does the same thing.
For aesthetics, also remove the 'finished'
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Also, cfc_handle_events() does nothing if no events are set so the local
variable 'oldevents' can be removed.
Signed-off-by: H Hartley Sweeten
Clear the A/D FIFO as part of the analog input (*cancel) to help with
cleaning up the async command.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/rtd520.c | 1 +
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Also, cfc_handle_events() does nothing if no events are set so the check
can be removed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
The code to cancel the async command can then be removed from rtd_interrupt().
Since the (*cancel) will also clear the FIFO, the ai_read_dregs() function
can also be
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Also, cfc_handle_events() does nothing if no events are set so the local
variable 'do_event' can be removed.
Signed-off-by: H Hartley Sweeten
Currently cfc_handle_events() is done by both the DMA and non-DMA helper
functions that are called by the interrupt handler. For aesthetics, move
the cfc_handle_events() to the end of the interrupt handler do it in one
place.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Also, cfc_handle_events() does nothing if no events are set so the local
variable 'oldevents' can be removed.
Signed-off-by: H Hartley Sweeten
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
All the pci230_{ao,ai}_stop() calls to cancel the command can then be removed.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use cfc_handler_events() to automatically (*cancel) the async command for
an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts5227 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead resume fail.
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
---
From: Micky Ching micky_ch...@realsil.com.cn
v2:
using (err 0) to check if a function failed, not using
if (err) and if (err 0) in mixing way.
This patch fix rts5227 and rts5249 suspend issue, when card reader
resumed from suspend state, the power state should reset before send
buffer command.
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead resume fail.
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
---
62 matches
Mail list logo
