[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration - remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 27036

[PATCH] Staging: android: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration Signed-off-by: Sorin Facaoaru --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index e7b2e02..0d37495 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/stagi

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_system_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index 6b77c51..da2a63

[PATCH] Staging: android: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration Signed-off-by: Sorin Facaoaru --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index a76db3f..863d4b1 100644 --- a/drivers/staging/android/sw_sync.c +++

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_dummy_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c index 3a45e79..ce606bd

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_chunk_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c index 9c3e49a..3e6ec2e 1

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_carveout_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c index dcb6f21..

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration - remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 270

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 11:57:51PM +0300, Dan Carpenter wrote: > On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > > I don't think we can make this 100% foolproof without knowing which mbox > > > variant the writer used. B

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Mark Einon
On Sat, Sep 13, 2014 at 11:57:51PM +0300, Dan Carpenter wrote: > On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > > I don't think we can make this 100% foolproof without knowing which mbox > > > variant the writer used. B

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > I don't think we can make this 100% foolproof without knowing which mbox > > variant the writer used. But dropping the line is probably the worst > > possible thing, as it do

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Mark Einon
On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > I don't think we can make this 100% foolproof without knowing which mbox > variant the writer used. But dropping the line is probably the worst > possible thing, as it does not match _any_ variants. :) Hi, FYI it was 'git send-email' v2

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Jeff King
On Sat, Sep 13, 2014 at 08:45:56AM -0700, Greg KH wrote: > On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > > multicast_pkts_xmtd, broadcast_pkts_rcv

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 08:45:56AM -0700, Greg KH wrote: > On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > > multicast_pkts_xmtd, broadcast_pkts_rcvd

Re: [PATCH 2/8] staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet

2014-09-13 Thread Mark Einon
On Sat, Sep 13, 2014 at 12:23:04PM +0300, Dan Carpenter wrote: > On Thu, Sep 11, 2014 at 10:59:40PM +0100, Mark Einon wrote: > > + if (send_packet(skb, adapter)) > > + goto drop_err; > > + > > + return NETDEV_TX_OK; > > + > > +drop_err: > > + dev_kfree_skb_any(skb); > > + skb = NU

Re: [PATCH v2 3/3] staging: iio: light: isl29018: add ACPI support

2014-09-13 Thread Jonathan Cameron
On 01/09/14 10:20, Laurentiu Palcu wrote: > Add support for enumerating the device through ACPI. > > Signed-off-by: Laurentiu Palcu Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play. Thanks, Jonathan > --- > > Changes in v2: > * fix the unn

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Greg KH
On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd > > For some reason something adds a '>

Re: [PATCH 1/1] staging: emxx_udc: fix compile warnings: discarding const qualifier

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 01:39:20PM +0200, Vincenzo Scotti wrote: > Signed-off-by: Vincenzo Scotti > Reported-by: kbuild test robot Great. Thank you. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdri

Re: [PATCH] staging: wlan-ng: fix coding style issues

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 12:42:43PM +0200, Aede Symen wrote: > Limited a long line to 80 columns. > > Signed-off-by: Aede Symen Hoekstra Patch is corrupt. Read the first paragraph of Documentation/email-clients.txt. regards, dan carpenter ___ devel m

[PATCH 1/1] staging: emxx_udc: fix compile warnings: discarding const qualifier

2014-09-13 Thread Vincenzo Scotti
Signed-off-by: Vincenzo Scotti Reported-by: kbuild test robot --- drivers/staging/emxx_udc/emxx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index ef956df..cee12c07 100644 --- a/drivers/st

[PATCH] staging: wlan-ng: fix coding style issues

2014-09-13 Thread Aede Symen
Limited a long line to 80 columns. Signed-off-by: Aede Symen Hoekstra --- drivers/staging/wlan-ng/prism2fw.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index 6c38f79..8bd7c65 100644 --- a/dri

Re: [PATCH 1/1] staging: emxx_udc: fix compile warnings: discarding const qualifier

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 11:42:03AM +0200, Vincenzo Scotti wrote: > Signed-off-by: Vincenzo Scotti > Reported-by: kbuild test robot > --- > drivers/staging/emxx_udc/emxx_udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/

[PATCH 1/1] staging: emxx_udc: fix compile warnings: discarding const qualifier

2014-09-13 Thread Vincenzo Scotti
Signed-off-by: Vincenzo Scotti Reported-by: kbuild test robot --- drivers/staging/emxx_udc/emxx_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index ef956df..09d8fb3 100644 --- a/drivers/s

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd For some reason something adds a '>' to the start of lines which start with 'From'. I don't know what it is

Re: [PATCH 2/8] staging: et131x: In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet

2014-09-13 Thread Dan Carpenter
On Thu, Sep 11, 2014 at 10:59:40PM +0100, Mark Einon wrote: > + if (send_packet(skb, adapter)) > + goto drop_err; > + > + return NETDEV_TX_OK; > + > +drop_err: > + dev_kfree_skb_any(skb); > + skb = NULL; No need to set "skb = NULL;". It's on the stack after all. regar

Re: [PATCH] staging: rtl819x_TSProc.c: Initializer entry defined twice

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 10:10:26AM +0800, Cheng-Wei Lee wrote: > This patch fixs the sparse warning in rtl819x_TSProc.c: > drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:244:58: warning: > Initializer entry defined twice > drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c:244:61: also defi

Re: [PATCH 1/1] staging: emxx_udc: fix compile warnings: discarding const qualifier

2014-09-13 Thread Dan Carpenter
On Fri, Sep 12, 2014 at 08:21:18PM +0200, Vincenzo Scotti wrote: > Signed-off-by: Vincenzo Scotti > Reported-by: kbuild test robot > --- > drivers/staging/emxx_udc/emxx_udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/dr

Re: [PATCH v2] staging: lustre: Fix address space mismatch in ksocknal_recv_iov()

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 02:31:33AM +1000, Artemiy Volkov wrote: > This patch fixes the following sparse warnings: > > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:51: warning: > cast removes address space of expression > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:28