[PATCH linux-next] staging: rtl8192u: sparse warnings: declare ieee80211_TURBO_Info static

2014-09-14 Thread Merlin Chlosta
Declare ieee80211_TURBO_Info static to fix a sparse "symbol was not declared" warning. Signed-off-by: Merlin Chlosta --- diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c index 9539bca..a85bb23 100644 --- a/drivers/stag

[PATCH 01/12 v2] staging: et131x: Remove extra blank lines in et131x.h

2014-09-14 Thread Mark Einon
Remove some blank lines from et131.h, including double blank lines. Signed-off-by: Mark Einon --- Fixing minor typo in commit log. drivers/staging/et131x/et131x.h | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b/dri

Re: [PATCH] Staging: android: ion: fix coding style

2014-09-14 Thread Greg KH
First off, thanks for the patches. But, they need some tweaks before I can accept them. You sent a bunch of patches, all with the same exact subject, with no hint of which order they should be applied in, or what exactly they do. On Sat, Sep 13, 2014 at 04:46:10PM -0700, Sorin Facaoaru wrote: >

[PATCH] staging: wlan-ng: prism2fw.c: Cleaning up unnecessary use of memset in conjunction with strncpy

2014-09-14 Thread Rickard Strandqvist
Using memset before strncpy just to ensure a trailing null character is an unnecessary double writing of a string Signed-off-by: Rickard Strandqvist --- drivers/staging/wlan-ng/prism2fw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b

[PATCH] staging: lustre: lustre: libcfs: debug.c: Cleaning up unnecessary use of memset in conjunction with strncpy

2014-09-14 Thread Rickard Strandqvist
Using memset before strncpy just to ensure a trailing null character is an unnecessary double writing of a string Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/libcfs/debug.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lust

[PATCH 01/12] staging: et131x: Remove extra blank lines in et131x.h

2014-09-14 Thread Mark Einon
Remove some blank lines from et131.h, including dounble blank lines. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.h | 43 - 1 file changed, 43 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b/drivers/staging/et131x/et131x.h index

[PATCH 09/12] staging: et131x: logical continuations should be on the previous line

2014-09-14 Thread Mark Einon
Fix two occurrences of the checkpatch check: CHECK: Logical continuations should be on the previous line Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et

[PATCH 11/12] staging: et131x: Use braces on all arms of if/else statements

2014-09-14 Thread Mark Einon
In some places in et131x.c, one arm of am if/else statement has braces and the other not - put braces on both arms where this happens. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x

[PATCH 12/12] staging: et131x: Use variable names instead of types in sizeof

2014-09-14 Thread Mark Einon
A few calls to sizeof() in et131x.c give the type as a parameter - use the equivalent variable name instead. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/e

[PATCH 04/12] staging: et131x: Remove send_hw_lock spinlock

2014-09-14 Thread Mark Einon
We don't need to use this lock - the tx path is protected by the networking subsystem xmit_lock, so we don't also need it in nic_send_packet(). The other use of this spinlock in et1310_enable_phy_coma() to protect a low power flag makes no sense, so can just be removed. Signed-off-by: Mark Einon

[PATCH 02/12] staging: et131x: Remove blank lines form et131x.c

2014-09-14 Thread Mark Einon
Remove some unecessary blank lines from et131x.c Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8da4883..74d5f309 100644 --- a/drivers/staging/et

[PATCH 10/12] staging: et131x: Remove spaces after casts

2014-09-14 Thread Mark Einon
In three places in et131x.c, spaces exist after a cast. Remove them. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 17a3a36..c6b5193 10

[PATCH 08/12] staging: et131x: Fix 'else is not generally useful after a break or return'

2014-09-14 Thread Mark Einon
Fix this checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c inde

[PATCH 07/12] staging: et131x: Fix indenting using mixed tabs and spaces

2014-09-14 Thread Mark Einon
Fix two lines where mixed tabs and spaces were used for indenting. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 8b2f9a9..c158b01 100644

[PATCH 05/12] staging: et131x: Remove useless assignment to NULL

2014-09-14 Thread Mark Einon
The stack variable skb is no longer used after it's set to NULL. Don't set it to NULL. Reported-by: Dan Carpenter Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c in

[PATCH 03/12] staging: et131x: Simplify unlocking tcb_send_qlock in et131x_tx_timeout()

2014-09-14 Thread Mark Einon
The tcb_send_qlock spinlock is unlocked in all three paths at the end of et131x_tx_timeout(). We can call it once before entering any of the paths, saving ourselves a few lines of code. This change puts tcb->count++ outside of the lock, but et131x_tx_timeout() itself is protected by the tx_global_

[PATCH 06/12] staging: et131x: Add spinlock definition comments

2014-09-14 Thread Mark Einon
Checkpatch --strict advises that spinlocks should be described when defined, seems a good idea so this change does that. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/driv

[PATCH 2/2] staging: lustre: fix pointer whitespace style

2014-09-14 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_impo

[PATCH 1/2] staging: lustre: fix function definition style

2014-09-14 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/st

[PATCH] Staging: gs_fpgaboot: fix coding style

2014-09-14 Thread Sorin Facaoaru
- remove return statement at the end of void function Signed-off-by: Sorin Facaoaru --- drivers/staging/gs_fpgaboot/io.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot/io.c index 23c12f4..f5cd33b 100644 --- a/drivers/stagin

[PATCH] Staging: slicoss: fix coding style

2014-09-14 Thread Sorin Facaoaru
- remove return statement at the end of void function - add blank line after declaration Signed-off-by: Sorin Facaoaru --- drivers/staging/slicoss/slicoss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.

[PATCH] Staging: mt29f_spinand: fix coding style

2014-09-14 Thread Sorin Facaoaru
- add curly braces around else compound Signed-off-by: Sorin Facaoaru --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c inde