> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf
> Of Dexuan Cui
> Sent: Friday, September 26, 2014 12:52 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o...@aepfle.de; a...@ca
On Tue, 2014-10-07 at 16:48 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by
> checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
> b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -414,19 +414,19 @@ u8 r8712_efuse_pg_
From: Fabio Estevam
There is no need to forward declare 'struct imx_drm_crtc' because the
"imx-drm.h" header file already includes it.
Signed-off-by: Fabio Estevam
---
drivers/staging/imx-drm/imx-drm-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-c
This patch fixes two unnecessary else conditions that were found by
checkpatch.pl.
Signed-off-by: Serguey Parkhomovsky
---
drivers/staging/rtl8712/rtl8712_efuse.c | 41 +
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8
On Monday, October 06, 2014 10:28:46 PM Guenter Roeck wrote:
> No users of pm_power_off are left, so it is safe to remove the function.
>
> Cc: Rafael J. Wysocki
> Cc: Pavel Machek
> Cc: Len Brown
> Signed-off-by: Guenter Roeck
ACK
> ---
> include/linux/pm.h | 1 -
> kernel/po
On Monday, October 06, 2014 10:28:05 PM Guenter Roeck wrote:
> Poweroff handlers may now be installed with register_poweroff_handler.
> Use the new API function have_kernel_poweroff to determine if a poweroff
> handler has been installed.
>
> Cc: Rafael J. Wysocki
> Cc: Pavel Machek
> Cc: Len Br
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Thursday, September 25, 2014 6:47 AM
> To: KY Srinivasan
> Cc: h...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; linux-s...@vger.kerne
On 10/07/14 11:59, David Daney wrote:
> On 10/07/2014 09:31 AM, Guenter Roeck wrote:
>> On Tue, Oct 07, 2014 at 11:21:11AM -0500, Rob Landley wrote:
>>> On 10/07/14 00:28, Guenter Roeck wrote:
Devicetree bindings are supposed to be operating system independent
and should thus not describe
On 10/07/2014 09:31 AM, Guenter Roeck wrote:
On Tue, Oct 07, 2014 at 11:21:11AM -0500, Rob Landley wrote:
On 10/07/14 00:28, Guenter Roeck wrote:
Devicetree bindings are supposed to be operating system independent
and should thus not describe how a specific functionality is implemented
in Linux
On Tue, Oct 07, 2014 at 05:21:11PM +0100, Rob Landley wrote:
> On 10/07/14 00:28, Guenter Roeck wrote:
> > Devicetree bindings are supposed to be operating system independent
> > and should thus not describe how a specific functionality is implemented
> > in Linux.
>
> So your argument is that lin
On Tue, Oct 07, 2014 at 11:21:11AM -0500, Rob Landley wrote:
> On 10/07/14 00:28, Guenter Roeck wrote:
> > Devicetree bindings are supposed to be operating system independent
> > and should thus not describe how a specific functionality is implemented
> > in Linux.
>
> So your argument is that lin
On Tue, Oct 7, 2014 at 10:19 AM, Darshana Padmadas
wrote:
> This patch documents deprecated vendor name of device isl29028 for
> compatibility with older kernels.
Fix your line wrapping to 72 chars.
You can shorten the subject "Documentation: devicetree: bindings:" to
"dt-bindings:". We're horr
On Tue, Oct 7, 2014 at 10:19 AM, Darshana Padmadas
wrote:
> This patch adds the correct vendor-prefix listed in
> Documentation/devicetree/bindings/vendor-prefixes.txt
> with the device name to compatible property.
It would be nice if the subject and msg gave some clue as to which
binding and pl
On 10/07/14 00:28, Guenter Roeck wrote:
> Devicetree bindings are supposed to be operating system independent
> and should thus not describe how a specific functionality is implemented
> in Linux.
So your argument is that linux/Documentation/devicetree/bindings should
not be specific to Linux. Mer
On Mon, Oct 06, 2014 at 10:28:31PM -0700, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with default priority value of 128 since we don't know
> any better.
>
> Cc: Julian Andres Klode
> Cc: Marc Dietrich
> Cc: Greg Kroah-Hartma
On Tue, Oct 7, 2014 at 9:07 AM, PINTU KUMAR wrote:
> - Original Message -
>> From: Colin Cross
>> To: pint...@samsung.com
>> Cc: Laura Abbott ; Heesub Shin
>> ; "a...@linux-foundation.org"
>> ; "gre...@linuxfoundation.org"
>> ; "john.stu...@linaro.org"
>> ; "rebe...@android.com" ;
>>
On Mon, Oct 06, 2014 at 10:28:09PM -0700, Guenter Roeck wrote:
> Replace reference to pm_power_off (which is an implementation detail)
> and replace it with a more generic description of the driver's functionality.
Acked-by: Andrew Lunn
Thanks
Andrew
>
> Cc: Rob Herring
> Cc: Pawel Mo
On Mon, Oct 06, 2014 at 10:28:08PM -0700, Guenter Roeck wrote:
> pm_power_off is an implementation detail. Replace it with a more generic
> description of the driver's functionality.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Signed-off-by: Guenter Roeck
Acked-by: Andrew Lunn
- Original Message -
> From: Colin Cross
> To: pint...@samsung.com
> Cc: Laura Abbott ; Heesub Shin
> ; "a...@linux-foundation.org"
> ; "gre...@linuxfoundation.org"
> ; "john.stu...@linaro.org"
> ; "rebe...@android.com" ;
> "de...@driverdev.osuosl.org" ;
> "linux-ker...@vger.kernel.o
On Mon, Oct 06, 2014 at 10:28:22PM -0700, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of seting pm_power_off
> directly. Register as poweroff handler of last resort since the driver
> does not really power off the system but executes a restart.
I would not say last resort
On Mon, Oct 06, 2014 at 10:28:25PM -0700, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with default priority value of 128 to reflect that
> the original code generates an error if another poweroff handler has
> already been regist
On Mon, Oct 06, 2014 at 10:28:23PM -0700, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with a low priority value of 64 to reflect that
> the original code only sets pm_power_off if it was not already set.
>
> Other changes:
>
>
On Tue, Oct 07, 2014 at 12:02:19PM +0100, Mark Rutland wrote:
> On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote:
> > Replace reference to pm_power_off (which is an implementation detail)
> > and replace it with a more generic description of the driver's
> > functionality.
> >
> > Cc
Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
Signed-off-by: Dzmitry Sledneu
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgabo
From: Joe Perches
Use print_hex_dump_bytes instead of pr_info
Signed-off-by: Dzmitry Sledneu
Reviewed-by: Insop Song
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 25 ++---
1 file changed, 2 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpg
On Tue, 2014-10-07 at 17:23 +0200, Dzmitry Sledneu wrote:
> Fix "Possible unnecessary KERN_INFO" checkpatch.pl warning
[]
> diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
[]
> @@ -58,7 +58,7 @@ static void datadump(char *msg, void *m, int n)
>
Hi Darshana,
On Tue, Oct 07, 2014 at 04:19:26PM +0100, Darshana Padmadas wrote:
> This patch documents the device isl29028 with its vendor-prefix. Undocumented
> deprecated vendor-prefix
> found by checkpatch also documented for compatibility reasons.
>
> Signed-off-by: Darshana Padmadas
In fu
Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
Signed-off-by: Dzmitry Sledneu
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgabo
Fix "Possible unnecessary KERN_INFO" checkpatch.pl warning
Signed-off-by: Dzmitry Sledneu
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
inde
This patch documents the device isl29028 with its vendor-prefix. Undocumented
deprecated vendor-prefix
found by checkpatch also documented for compatibility reasons.
Signed-off-by: Darshana Padmadas
---
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
1 file changed, 2 insertio
This patch adds the correct vendor-prefix listed in
Documentation/devicetree/bindings/vendor-prefixes.txt
with the device name to compatible property.
Signed-off-by: Darshana Padmadas
---
arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/a
This patch adds the correct vendor-prefix for device isl29028 and
maintains deprecated vendor-prefix found by checkpatch warning
for older kernel releases.
Signed-off-by: Darshana Padmadas
---
drivers/staging/iio/light/isl29028.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --gi
Patchset documents correct and the deprecated vendor-prefix found by checkpatch
warning and also documents information of device isl29028 for compatibility.
Patchset also includes corrected vendor-prefix and device name in compatible
property for files with checkpatch warning of undocumented string
This patch documents deprecated vendor name of device isl29028 for
compatibility with older kernels.
Signed-off-by: Darshana Padmadas
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.t
Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
Signed-off-by: Dzmitry Sledneu
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgaboo
Fix "Possible unnecessary KERN_INFO" checkpatch.pl warning
Signed-off-by: Dzmitry Sledneu
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
inde
Am 07.10.2014 07:28, schrieb Guenter Roeck:
> arch/um/kernel/reboot.c| 2 --
Acked-by: Richard Weinberger
Thanks,
//richard
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driver
fixed several 'line over 80 characters' in places where it can be done
without changing/refactoring code
Signed-off-by: Aleh Suprunovich
---
drivers/staging/octeon-usb/octeon-hcd.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/octe
On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote:
> Replace reference to pm_power_off (which is an implementation detail)
> and replace it with a more generic description of the driver's functionality.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Signed-off-by: Guenter
On Tue, Oct 07, 2014 at 06:28:07AM +0100, Guenter Roeck wrote:
> Devicetree bindings are supposed to be operating system independent
> and should thus not describe how a specific functionality is implemented
> in Linux.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Signed-off-by: Gu
On Tue, Oct 07, 2014 at 06:28:08AM +0100, Guenter Roeck wrote:
> pm_power_off is an implementation detail. Replace it with a more generic
> description of the driver's functionality.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
Acked-by: Mark Rutland
> Signed-off-by: Guenter Roeck
checkpatch.pk tiny fix
get rid of 2 warnings and 2 errors for hal/fw.c
Signed-off-by: Igor Bogomazov
Cc: Greg Kroah-Hartman
Cc: navin patidar
Cc: Stephen Rothwell
---
linux-next 3.17.0
diff --git a/drivers/staging/rtl8188eu/hal/fw.c
b/drivers/staging/rtl8188eu/hal/fw.c
index 17b7f37..c42
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly.
>
> Cc: Geert Uytterhoeven
> Cc: Joshua Thompson
> Signed-off-by: Guenter Roeck
As someone already mentioned, having #defines instead of hardcoded
numbers fo
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> pm_power_off is defined for all architectures. Move it to common code.
>
> Have all architectures call do_kernel_poweroff instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_kernel_powero
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> Replace mach_power_off with pm_power_off to simplify the subsequent
> move of pm_power_off to generic code.
Thanks!
> Cc: Geert Uytterhoeven
> Cc: Greg Ungerer
> Cc: Joshua Thompson
> Signed-off-by: Guenter Roeck
Looks OK, so since you
y各种定价模＠式的砍价策3略.xls
Description: Binary data
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Mark functions static that are not used or declared outside of lo.c.
Signed-off-by: Thomas Gummerer
---
drivers/staging/lustre/lnet/lnet/lo.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lo.c
b/drivers/staging/lustre/lnet/lnet/lo.c
On 07/10/2014 07:28, Guenter Roeck :
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Always use register_poweroff_handler_simple as there is no
> indication that more than one poweroff handler is registered.
>
> If the poweroff handler only resets the system or
On Mon, 06 Oct 2014, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with a low priority value of 64 to reflect that
> the original code only sets pm_power_off if it was not already set.
>
> Cc: Linus Walleij
> Cc: Lee Jones
> Cc
On Mon, 06 Oct 2014, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with a low priority value of 64 to reflect that
> the original code only sets pm_power_off if it was not already set.
>
> Make twl4030_power_off static as it is o
Hello
This seems exactly what I would need on the mc13783 to handle cleanly
the poweroff,
but after reading this patchset I have the following question:
[...]
+/*
+ * Notifier list for kernel code which wants to be called
+ * to power off the system.
+ */
+static ATOMIC_NOTIFIER_HEAD
51 matches
Mail list logo
