Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Richard Cochran
On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote: > > In some situation, the user is not able to enable guest VM to sync with > external > time source, like NTP. But the host is still synced with a trusted time > source. But the guest *is* networked, right? (Otherwise syncing the

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Thomas Shao wrote: > > I still do not have a consistent argument from you WHY you need to abuse > > do_adjtimex() to do that host - guest synchronization in the first place. > > > > I need a function to gradually slew guest time. do_adjtimex() provides all > the > functiona

Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Richard Cochran
On Mon, Oct 20, 2014 at 11:02:13PM -0500, Jeff Epler wrote: > It's interesting to imagine that a virtualization host could present a > time service to the guest *userspace*, even when the guest is not > otherwise exposed to the internet at large. This could take the form of > an NTP server on a pr

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Thomas Shao wrote: > I didn't find a way to detect whether NTPd is running in the hyper-v module. And you better do not try at all. > In http://doc.ntp.org/4.1.0/ntpd.htm, it mentioned: Normally, the > time is slewed if the offset is less than the step threshold, which > i

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Gleixner
On Tue, 21 Oct 2014, Thomas Shao wrote: > I'm also thinking if NTPd could expose some interface to allow other > application to directly provide time source for it to consume. In my > opinion, emulating the ntp source should be very hard and error > prone. Well, if done right it would be pretty p

Re: [PATCH] staging: comedi: fix memory leak / bad pointer freeing for chanlist

2014-10-21 Thread Ian Abbott
On 20/10/14 22:38, Hartley Sweeten wrote: On Monday, October 20, 2014 7:11 AM, Ian Abbott wrote: As a follow-up to commit 6cab7a37f5c04 ("staging: comedi: (regression) channel list must be set for COMEDI_CMD ioctl"), Hartley Sweeten pointed out another couple of bugs stemming from commit 6cab7a3

[PATCH v3 RESEND] Tools: hv: vssdaemon: ignore the EBUSY on multiple freezing the same partition

2014-10-21 Thread Dexuan Cui
If a partition appears mounted more than once in /proc/mounts, vss_do_freeze() succeeds only for the first time and gets EBUSY (on freeze) or EINVAL (on thaw) for the second time. The patch ignores these to make the backup feature work. Also improved the error handling in case a freeze operation f

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Shao
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Thomas Gleixner > Sent: Tuesday, October 21, 2014 4:19 PM > To: Thomas Shao > Cc: gre...@linuxfoundation.org; LKML; de...@linuxdriverproject.org; > o...@aepfle.de; a.

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Shao
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Tuesday, October 21, 2014 4:14 PM > To: Thomas Shao > Cc: Thomas Gleixner; gre...@linuxfoundation.org; LKML; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-21 Thread Pavel Machek
On Fri 2014-10-17 01:14:57, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 04:18:02PM +0200, Michael Kerrisk (man-pages) wrote: > > On Thu, Oct 16, 2014 at 2:47 PM, Greg Kroah-Hartman > > wrote: > > > From: Greg Kroah-Hartman > > > > > > The Android binder code has been "stable" for many yea

RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

2014-10-21 Thread Thomas Shao
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Richard Cochran > Sent: Tuesday, October 21, 2014 4:21 PM > To: Jeff Epler > Cc: Thomas Shao; Thomas Gleixner; gre...@linuxfoundation.org; LKML; > de...@linuxdriverpr

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-21 Thread Pavel Machek
On Fri 2014-10-17 01:12:21, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote: > > On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman > > wrote: > > > From: Greg Kroah-Hartman > > Are the Android guys comfortable with the ABI stability rules they'll > > now

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-21 Thread Christoph Hellwig
On Mon, Oct 20, 2014 at 06:04:50AM +0800, Greg Kroah-Hartman wrote: > There is now work to resolve the interface, it requires someone who has > the rights to push to Android userspace. But that is going to be a > "total rewrite", and until then, this code needs to be used, no matter > how much we

[PATCH 2/3] tools: hv: fcopy_daemon: Unused variable removed

2014-10-21 Thread Matej Mužila
From: Matej Mužila Remove unused variable Signed-off-by: Matej Mužila Acked-by: K. Y. Srinivasan --- diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c index 6f27e2f..1fc2dc2 100644 --- a/tools/hv/hv_fcopy_daemon.c +++ b/tools/hv/hv_fcopy_daemon.c @@ -132,7 +132,7 @@ static

[PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits

2014-10-21 Thread Matej Mužila
From: Matej Mužila Check if cpmsg->size is in limits of DATA_FRAGMENT Signed-off-by: Matej Mužila Acked-by: K. Y. Srinivasan --- If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can read from memory outside of the buffer (defined at line 138). Added check. --- @@ -104,6 +104,10 @@

[PATCH 3/3] tools: hv: fcopy_daemon: Don't use uninitialized variable

2014-10-21 Thread Matej Mužila
From: Matej Mužila Don't use uninitialized variable Signed-off-by: Matej Mužila Acked-by: K. Y. Srinivasan --- diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c index 1fc2dc2..0f8f918 100644 --- a/tools/hv/hv_fcopy_daemon.c +++ b/tools/hv/hv_fcopy_daemon.c @@ -191,7 +191,7

Re: [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits

2014-10-21 Thread One Thousand Gnomes
On Tue, 21 Oct 2014 13:49:00 +0200 Matej Mužila wrote: > From: Matej Mužila > > Check if cpmsg->size is in limits of DATA_FRAGMENT > > Signed-off-by: Matej Mužila > Acked-by: K. Y. Srinivasan > --- > If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can > read from memory outside

Re: linux-3.18-rc1 bug report

2014-10-21 Thread Mark Hounschell
On 10/21/2014 07:33 AM, David Binderman wrote: Hello there, 1. [linux-3.18-rc1/drivers/staging/dgap/dgap.c:6692]: (warning) Logical disjunction always evaluates to true: conc_type != 65 || conc_type != 66. Source code is if (conc_type == 0 || conc_type != CX ||

Re: [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits

2014-10-21 Thread Matej Mužila
> sizeof(__u8) is by definition 1 so it's perhaps surplus ? Now the size is now determined from the structure definition in include/uapi/linux/hyperv.h > - C style comments for coding style Fixed > Also your patch block is devoid of a few thins like the file name... I'm sorry, the (missing) filen

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-21 Thread Arnd Bergmann
On Tuesday 21 October 2014 12:36:22 Pavel Machek wrote: > On Fri 2014-10-17 01:12:21, Greg Kroah-Hartman wrote: > > On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote: > > > On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman > > > wrote: > > > > From: Greg Kroah-Hartman > > > > Are the

Re: [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits

2014-10-21 Thread Dan Carpenter
On Tue, Oct 21, 2014 at 02:59:58PM +0200, Matej Mužila wrote: > > sizeof(__u8) is by definition 1 so it's perhaps surplus ? > Now the size is now determined from the structure definition in > include/uapi/linux/hyperv.h > > > - C style comments for coding style > Fixed > > > Also your patch block

[PATCH v2] staging: skein: Loadable Module Support

2014-10-21 Thread Eric Rost
Adds loadable module support for Skein256, Skein512, and Skein1024 Hash Algorithms. Signed-off-by: Eric Rost --- drivers/staging/skein/Kconfig | 12 + drivers/staging/skein/Makefile| 6 +++ drivers/staging/skein/skein.c | 11 +++- drivers/staging/skein/sk

[PATCH v2 1/3] tools: hv: fcopy_daemon: Check buffer limits

2014-10-21 Thread Matej Mužila
From: Matej Mužila Check if cpmsg->size is in limits of DATA_FRAGMENT Signed-off-by: Matej Mužila --- If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can read from memory outside of the buffer (defined at line 138). Added check. Changes made since v1: * max value of cmesg

[PATCH] staging: rtl8712: Remove redundant cast

2014-10-21 Thread Rasmus Villemoes
struct firmware::data has type const u8*, as does *ppmappedfw, so the cast to u8* is unnecessary and slightly confusing. Signed-off-by: Rasmus Villemoes --- drivers/staging/rtl8712/hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/hal_init.c

[PATCH] staging: vt6655: Remove redundant cast

2014-10-21 Thread Rasmus Villemoes
Both sides have type const struct iw_handler_def*, so the cast is unnecessary and confusing. Signed-off-by: Rasmus Villemoes --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655

Re: [PATCH] staging: rtl8712: Remove redundant cast

2014-10-21 Thread Dan Carpenter
On Tue, Oct 21, 2014 at 04:58:26PM +0200, Rasmus Villemoes wrote: > struct firmware::data has type const u8*, as does *ppmappedfw, so the > cast to u8* is unnecessary and slightly confusing. > > Signed-off-by: Rasmus Villemoes > --- > drivers/staging/rtl8712/hal_init.c | 2 +- > 1 file changed,

Re: [PATCH] staging: comedi: addi_apci_035: remove driver

2014-10-21 Thread Ian Abbott
On 20/10/14 18:37, H Hartley Sweeten wrote: According to ADDI-DATA, this board was discontinued last year and they feel that no further development is needed for this driver. Remove the driver from comedi to help with the addi-data cleanup. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: G

Re: [PATCH] staging: comedi: ni_65xx: remove deadcode in ni_65xx_intr_cmdtest()

2014-10-21 Thread Ian Abbott
On 20/10/14 23:02, H Hartley Sweeten wrote: Reported by: coverity (CID 142963) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_65xx.c

Re: [PATCH] staging: comedi: ni_65xx: remove deadcode in ni_65xx_intr_cmdtest()

2014-10-21 Thread Ian Abbott
On 21/10/14 16:14, Ian Abbott wrote: On 20/10/14 23:02, H Hartley Sweeten wrote: Reported by: coverity (CID 142963) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_65xx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/driv

Re: [PATCH] staging: comedi: ni_6527: remove deadcode in ni6527_intr_cmdtest()

2014-10-21 Thread Ian Abbott
On 20/10/14 23:03, H Hartley Sweeten wrote: Reported by: coverity (CID 142962) There should be a dash in "Reported by". Not sure if it matters. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_6527.c | 3 --- 1 file changed, 3

Re: [PATCH] staging: comedi: ni_mio_common: remove deadcode in ni_cdio_cmdtest()

2014-10-21 Thread Ian Abbott
On 20/10/14 23:04, H Hartley Sweeten wrote: Reported by: coverity (CID 142967) Should be a dash in "Reported by". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git

*****SPAM***** 2ND NOTICE AGAIN ,

2014-10-21 Thread Admin Staff
it. Opening spam messages might allow the spammer to verify your email address. If you believe that this message has been incorrectly marked as spam, please forward this email to postmaster. Date: 20141021 pts rule name description

Re: [PATCH 0/9] staging: comedi: addi_apci_1564: additional clean up

2014-10-21 Thread Ian Abbott
On 20/10/14 18:57, H Hartley Sweeten wrote: This driver currently passes the timer "channel" in a manner that violates the comedi API. Fix the timer subdevice so that the timers "channels" are correctly used from the insn->chanspec. Fix the I/O access for the boards registers. Currently the ioba

RE: [PATCH 0/9] staging: comedi: addi_apci_1564: additional clean up

2014-10-21 Thread Hartley Sweeten
On Tuesday, October 21, 2014 9:29 AM, Ian Abbott wrote: > On 20/10/14 18:57, H Hartley Sweeten wrote: >> This driver currently passes the timer "channel" in a manner that violates >> the comedi API. Fix the timer subdevice so that the timers "channels" are >> correctly used from the insn->chanspec.

Re: [PATCH net 1/1] hyperv: Fix a bug in netvsc_send()

2014-10-21 Thread Long Li
Thanks Sitsofe. This should have been fixed by this patch: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=f88e67149f97d73c704d6fe6f492edde97463025 Can you give it a try? From: Sitsofe Wheeler Sent: Saturday, October 11, 2014 3:3

Re: [PATCH 0/9] staging: comedi: addi_apci_1564: additional clean up

2014-10-21 Thread Hartley Sweeten
On Tuesday, October 21, 2014 9:29 AM, Ian Abbott wrote: > On 20/10/14 18:57, H Hartley Sweeten wrote: >> This driver currently passes the timer "channel" in a manner that violates >> the comedi API. Fix the timer subdevice so that the timers "channels" are >> correctly used from the insn->chanspec.

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-21 Thread Mark Hounschell
On 10/14/2014 08:01 AM, Mark Hounschell wrote: On 10/13/2014 10:04 PM, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH : On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-21 Thread KY Srinivasan
> -Original Message- > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > Sent: Monday, October 20, 2014 9:46 PM > To: KY Srinivasan > Cc: Jeff Leung; James Bottomley; Christoph Hellwig; Haiyang Zhang; Christoph > Hellwig; Hannes Reinecke; linux-s...@vger.kernel.org; linux- > ker...@vger.

RE: [PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

2014-10-21 Thread KY Srinivasan
> -Original Message- > From: Jeff Leung [mailto:jle...@v10networks.ca] > Sent: Monday, October 20, 2014 10:39 PM > To: linux-s...@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org > Cc: KY Srinivasan; james.bottom...@hansenpartnership.com; Jeff Leung > Subject:

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-21 Thread Pavel Machek
On Tue 2014-10-21 16:12:24, Arnd Bergmann wrote: > On Tuesday 21 October 2014 12:36:22 Pavel Machek wrote: > > On Fri 2014-10-17 01:12:21, Greg Kroah-Hartman wrote: > > > On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote: > > > > On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman > > > >

Re: [PATCH net 1/1] hyperv: Fix a bug in netvsc_send()

2014-10-21 Thread Sitsofe Wheeler
On 21 October 2014 18:13, Long Li wrote: > Thanks Sitsofe. This should have been fixed by this patch: > http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=f88e67149f97d73c704d6fe6f492edde97463025 > > Can you give it a try? Ah this one went mainline a few days ago so I've a

RE: [PATCH] staging: comedi: addi_apci_035: remove driver

2014-10-21 Thread Hartley Sweeten
On Tuesday, October 21, 2014 8:14 AM, Ian Abbott wrote: > On 20/10/14 18:37, H Hartley Sweeten wrote: >> According to ADDI-DATA, this board was discontinued last year and they >> feel that no further development is needed for this driver. Remove the >> driver from comedi to help with the addi-data

RE: [PATCH net 1/1] hyperv: Fix a bug in netvsc_send()

2014-10-21 Thread Haiyang Zhang
> -Original Message- > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > Sent: Tuesday, October 21, 2014 5:16 PM > To: Long Li > Cc: David Miller; o...@aepfle.de; net...@vger.kernel.org; > jasow...@redhat.com; linux-ker...@vger.kernel.org; a...@canonical.com; > de...@linuxdriverproject.o

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-21 Thread Rom Lemarchand
On the topic of maintainers for binder: both Arve Hjønnevåg (a...@android.com) and Riley Andrews (riandr...@android.com) have volunteered to be co-maintainers with Greg. We would also like to make kernel-t...@android.com the maintainer of the whole android directory. __