[PATCH 0/3] remove final uses of the GOTO macro

2014-11-09 Thread Julia Lawall
Remove final uses of the GOTO macro, and remove the associated macro and underlying function. drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 12 drivers/staging/lustre/lustre/libcfs/debug.c |8 drivers/staging/lustre/lustre/osc/osc_cache.c | 168

[PATCH 3/3] staging: lustre: libcfs: remove final uses of the GOTO macro

2014-11-09 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Remove the goto logging function, as it is no longer used. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/staging/lustre/lustre/libcfs/debug.c |8 1 file changed, 8 deletions(-) diff --git

[PATCH 2/3] staging: lustre: libcfs_debug.h: remove final uses of the GOTO macro

2014-11-09 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Remove the GOTO macro, as it is no longer used. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 12 1 file changed, 12 deletions(-) diff --git

[PATCH 1/3] staging: lustre: osc: remove final uses of the GOTO macro

2014-11-09 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; //

Re: [PATCH] rtl8188eu: Remove unnecessary braces for simple return in xmit_linux.c

2014-11-09 Thread Krzysztof Konopko
On 08/11/14 21:23, Joe Perches wrote: On Sat, 2014-11-08 at 22:14 +0100, Krzysztof Konopko wrote: scripts/checkpatch.pl reports a coding style problem in xmit_linux.c [] diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c [] @@ -67,9

Re: [PATCH] rtl8188eu: Fix several stylistic problems in rtw_led.*

2014-11-09 Thread Krzysztof Konopko
On 06/11/14 23:03, Greg Kroah-Hartman wrote: On Thu, Nov 06, 2014 at 11:56:05PM +0100, k...@konagma.com wrote: From: Krzysztof Konopko k...@konagma.com Several stylistics problems are reported by scripts/checkpatch.pl run on rtw_led.*: * FSF_MAILING_ADDRESS Free Software

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-09 Thread Philipp Zabel
Hi Guennadi, On Fri, Nov 07, 2014 at 11:06:21PM +0100, Guennadi Liakhovetski wrote: Hi Philipp, Thanks for the patch and sorry for a late reply. I did look at your patches earlier too, but maybe not attentively enough, or maybe I'm misunderstanding something now. In the scan_of_host()

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-09 Thread Guennadi Liakhovetski
On Sun, 9 Nov 2014, Philipp Zabel wrote: Hi Guennadi, On Fri, Nov 07, 2014 at 11:06:21PM +0100, Guennadi Liakhovetski wrote: Hi Philipp, Thanks for the patch and sorry for a late reply. I did look at your patches earlier too, but maybe not attentively enough, or maybe I'm

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Niklas Svensson
On 11/08/2014 08:56 PM, Jason Cooper wrote: On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol

Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

2014-11-09 Thread Marc Dietrich
Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck: Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode j...@jak-linux.org Cc: Marc Dietrich marvi...@gmx.de Cc:

Re: [PATCH] staging: skein: fixed sparse warnings related to static declarations

2014-11-09 Thread Jason Cooper
On Sun, Nov 09, 2014 at 07:51:36PM +0100, Niklas Svensson wrote: On 11/08/2014 08:56 PM, Jason Cooper wrote: On Sat, Nov 08, 2014 at 04:49:18PM +0100, Niklas Svensson wrote: drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be

Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

2014-11-09 Thread Andreas Färber
Am 09.11.2014 um 22:41 schrieb Marc Dietrich: Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck: Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode

Re: [PATCH v5 33/48] staging: nvec: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
On 11/09/2014 01:41 PM, Marc Dietrich wrote: Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck: Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '' and '=='

2014-11-09 Thread Chen Weixiang
On Mon, Nov 03, 2014 at 04:05:43PM -0800, Greg Kroah-Hartman wrote: On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c and ft1000/ft1000-pcmcia/ft1000_hw.c: ERROR: spaces required around that '=' (ctx:VxV)

Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '' and '=='

2014-11-09 Thread Chen Weixiang
On Mon, Nov 10, 2014 at 08:16:16AM +0800, Chen Weixiang wrote: On Mon, Nov 03, 2014 at 04:05:43PM -0800, Greg Kroah-Hartman wrote: This patch doesn't apply against my staging.git tree on git.kernel.org Please refresh the series against the staging-testing and resend. thanks, greg

[PATCH v6 33/48] staging: nvec: Register with kernel power-off handler

2014-11-09 Thread Guenter Roeck
Register with kernel power-off handler instead of setting pm_power_off directly. Register with default priority since we don't know any better. Cc: Julian Andres Klode j...@jak-linux.org Cc: Marc Dietrich marvi...@gmx.de Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Acked-by: Greg