Dexuan Cui de...@microsoft.com writes:
Under high memory pressure and very high KVP R/W test pressure, the netlink
recvfrom() may transiently return ENOBUFS to the daemon -- we found this
during a 2-week stress test.
We'd better not terminate the daemon on the failure, because a typical KVP
Hi Dan,
2014-11-20 17:48 GMT+08:00 Dan Carpenter dan.carpen...@oracle.com:
Chill. Wait for two weeks minimum before asking these questions, and
longer than two weeks if Greg is traveling or there is a merge window
open.
Got it! Thanks very much for your advice! I will keep waiting for
On Saturday 08 November 2014, Darshana Padmadas wrote:
Patchset documents correct and the deprecated vendor-prefix found by
checkpatch
warning and also documents information of device isl29028 for compatibility.
Patchset also includes corrected vendor-prefix and device name in compatible
From: Markus Elfring elfr...@users.sourceforge.net
Date: Thu, 20 Nov 2014 15:15:21 +0100
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Changed return type of function get_my_bssid from __inline to inline
Signed-off-by: Abel Moyo abelmoyo...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
-Original Message-
From: Dexuan Cui
Sent: Wednesday, November 19, 2014 11:48 PM
To: KY Srinivasan; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org;
o...@aepfle.de; a...@canonical.com; jasow...@redhat.com
Cc: Haiyang Zhang
Subject:
The following checkpatch warning was fixed:
WARNING: Missing a blank line after declarations
Signed-off-by: Lekshmi andnlnb...@gmail.com
---
drivers/staging/octeon/ethernet-rx.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon/ethernet-rx.c
This patch fixes the checkpatch.pl warning:
WARNING:Missing a blank line after declaration
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
drivers/staging/dgap/dgap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
-Original Message-
From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net]
Sent: Thursday, November 20, 2014 9:25 AM
To: Haiyang Zhang; KY Srinivasan; de...@linuxdriverproject.org;
net...@vger.kernel.org
Cc: LKML; kernel-janit...@vger.kernel.org; Julia Lawall
Subject:
The comedi core expects the (*insn_write) functions to write 'insn-n'
values to the hardware and return the number of values written. Currently
this function only writes the first value. For this subdevice it only makes
sense to write the final data value.
Fix the function to work like the core
For consistency with the other calib subdevices, refactor this (*insn_write)
function so that it only writes the final data value to the hardware.,
For aesthetics, rename the function so it has namespace associated with the
driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Most of the comedi drivers that use the comedi_subdevice 'readback' use
the core provided (*insn_read) function, comedi_readback_insn_read().
Modify comedi_alloc_subdev_readback() to automatically default the
subdevice (*insn_read) to this function after allocating the 'readback'
memory. A couple
The 'address' passed to this function is actually the comedi channel. This
value will always be less than the subdevice n_chan (which is 8). Remove
the unnecessary sanity check in caldac_8800_write().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only caldac subdevice. Remove the then
unused
'caldac' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only calibration subdevice. Remove the
then unused 'caldac_state' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only dac08 calib subdevice. Remove the
then unused 'dac08_value' member from the private data.
The dac08 calib subdevice only has one channel. For consistency in the driver,
modify
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only caldac subdevice. Remove the then
unused 'caldac_value' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Introduce a helper function to write a value to a given DAC channel.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 32 +++-
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only calibration subdevice. Remove the
then unused 'ad8402_state' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only caldac subdevice. Remove the then
unused
'caldac' member from the private data.
Tidy up atao_calib_insn_write().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Move the check/save of the calib subdevice value to the (*insn_write) function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 19
The comedi core expects the (*insn_write) functions to write 'insn-n'
values to the hardware and return the number of values written. Currently
this function only writes the first value. For this subdevice it only makes
sense to write the final data value.
Fix the function to work like the core
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the analog output subdevice. Remove the then unused
'ao_value' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
The comedi core expects the (*insn_write) functions to write 'insn-n'
values to the hardware and return the number of values written. Currently
this function only writes the first value. For this subdevice it only makes
sense to write the final data value.
Fix the function to work like the core
The comedi core expects the (*insn_write) functions to write 'insn-n'
values to the hardware and return the number of values written. Currently
this function only writes the first value. For this subdevice it only makes
sense to write the final data value.
Fix the function to work like the core
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the eeprom subdevice. Remove the then unused
'eeprom_data' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only trimpot calib subdevice. Remove the
then unused 'trimpot_value' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Someone reported a bug in the function graph tracer for MIPS. As I'm
still waiting on my USB serial for my Imagination MIPS board, I decided
to bring my Lemote Yeeloong laptop back up to the latest kernel. This
is where I noticed that the screen no longer displays anything.
I ran a bisect, which
Use the comedi_timeout() helper to wait for the eeprom to be ready to accept
writes and remove the timeout loop in labpc_eeprom_write().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Most of the comedi drivers that provide readback for write only subdevices now
use the comedi core comedi_alloc_subdev_readback() helper to allocate the
subdevice
'reaback' member instead of using some member in their private data. These
drivers
also hook up the (*insn_read) callback to the
Use the comedi_timeout() helper to wait for the DAC to be idle before
writing to it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 33
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only analog output subdevice. Remove the
then unused 'ao_value' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This define is already in pci_ids.h. Remove the duplicate in this driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 2 --
1 file changed, 2
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only offset calib subdevice. Remove the
then unused 'offset_value' member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
For aesthetics, remove the enum and define the bits for this register.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 10 --
1 file
This enum is not used in the driver. Remove it.
For aesthetics, rename the register define and move the comment that
any value will trigger the sync output.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
The analog output, offset calib, and gain calib subdevices all use similar
(*insn_write) functions. The onyl difference is the 'mode' that is passed
to the set_dac() helper.
Introduce a new (*insn_write) function that can be used by all the subdevices.
Use the s-private member to pass the 'mode'
Remove the unnecessary noise at the end of the (*auto_attach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 2 --
1 file changed, 2 deletions(-)
For aesthetics, add some whitespace to the pci_driver declaration.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 9 -
1 file changed, 4
For aesthetics, add some whitespace to the comedi_driver declaration.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 8
1 file changed, 4
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 94 +---
1 file
Define the bits for the DAC control register and remove the enum along
with the helper functions.
Simplify adv_pci1724_insn_write() a bit. The 'ctrl' bits are based on
the 'chan' and 'mode' and do not need to be recalculated for each 'val'.
Signed-off-by: H Hartley Sweeten
For aesthetics, absorb this function into the (*auto_attach).
Add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Define the bits for the synchronous output control/status register and
remove the enum.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1724.c | 15
Following is the big cleanup for the adv_pci1724 driver.
H Hartley Sweeten (19):
staging: comedi: adv_pci1724: use subdevice readback for 'ao_value'
staging: comedi: adv_pci1724: use subdevice readback for 'offset_value'
staging: comedi: adv_pci1724: use subdevice readback for 'gain_value'
On Thu, Nov 20, 2014 at 05:09:25PM -0500, Steven Rostedt wrote:
Someone reported a bug in the function graph tracer for MIPS. As I'm
still waiting on my USB serial for my Imagination MIPS board, I decided
to bring my Lemote Yeeloong laptop back up to the latest kernel. This
is where I
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
arch/arm/boot/dts/include/dt-bindings | 1 -
arch/metag/boot/dts/include/dt-bindings | 1 -
arch/mips/boot/dts/include/dt-bindings | 1 -
On Thu, 2014-11-20 at 17:09 -0500, Steven Rostedt wrote:
Someone reported a bug in the function graph tracer for MIPS. As I'm
still waiting on my USB serial for my Imagination MIPS board, I decided
to bring my Lemote Yeeloong laptop back up to the latest kernel. This
is where I noticed that
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
drivers/staging/skein/skein_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/skein/skein_generic.c
On Thu, 2014-11-20 at 15:43 -0800, hpdd-discuss-ow...@lists.01.org
wrote:
You must be a subscriber to post to this list. Please make sure you
are sending from a subscribed email address.
The linux-kernel MAINTAINERS file has this as a moderated list.
If it's not moderated, this entry should be
-Original Message-
From: KY Srinivasan
Sent: Friday, November 21, 2014 1:58 AM
To: Dexuan Cui; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
driverdev-devel@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com; jasow...@redhat.com
Cc: Haiyang Zhang
Subject: RE:
51 matches
Mail list logo