Replaced printk with pr_debug in dprintk
Signed-off-by: Abel Moyo
---
drivers/staging/media/lirc/lirc_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_serial.c
b/drivers/staging/media/lirc/lirc_serial.c
index 181b92b..86c5274 100644
--
On 20/11/14 22:07, H Hartley Sweeten wrote:
Most of the comedi drivers that provide readback for write only subdevices now
use the comedi core comedi_alloc_subdev_readback() helper to allocate the
subdevice
'reaback' member instead of using some member in their private data. These
drivers
also
On 20/11/14 22:07, H Hartley Sweeten wrote:
Most of the comedi drivers that use the comedi_subdevice 'readback' use
the core provided (*insn_read) function, comedi_readback_insn_read().
Modify comedi_alloc_subdev_readback() to automatically default the
subdevice (*insn_read) to this function afte
On 20/11/14 22:10, H Hartley Sweeten wrote:
Following is the big cleanup for the adv_pci1724 driver.
H Hartley Sweeten (19):
staging: comedi: adv_pci1724: use subdevice readback for 'ao_value'
staging: comedi: adv_pci1724: use subdevice readback for 'offset_value'
staging: comedi: adv_p
On Fri, Nov 21, 2014 at 10:31:57AM +0100, Abel Moyo wrote:
> Replaced printk with pr_debug in dprintk
>
> Signed-off-by: Abel Moyo
> ---
> drivers/staging/media/lirc/lirc_serial.c | 2 +-
Please use scripts/get_maintainer.pl to determine the correct person to
send this patch to, it's not me, sor
Replaced printk with pr_debug in dprintk
Signed-off-by: Abel Moyo
---
drivers/staging/media/lirc/lirc_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_serial.c
b/drivers/staging/media/lirc/lirc_serial.c
index 181b92b..86c5274 100644
--
Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends().
http://lkml.iu.edu/hypermail/linux/kernel/1410.3/04561.html
The following series tries to do this.
There are still some hard-coded locations which I was not sure how to replace
with.
Recently lockless_dereference() was added which can be used in place of
hard-coding smp_read_barrier_depends(). The following PATCH makes the change.
Signed-off-by: Pranith Kumar
---
include/linux/hyperv.h | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/linux
On Friday, November 21, 2014 3:59 AM, Ian Abbott wrote:
> On 20/11/14 22:07, H Hartley Sweeten wrote:
>> Most of the comedi drivers that provide readback for write only subdevices
>> now
>> use the comedi core comedi_alloc_subdev_readback() helper to allocate the
>> subdevice
>> 'reaback' member
Most of the comedi drivers that provide readback for write only subdevices now
use the comedi core comedi_alloc_subdev_readback() helper to allocate the
subdevice
'reaback' member instead of using some member in their private data. These
drivers
also hook up the (*insn_read) callback to the comed
On 21/11/2014 17:19, H Hartley Sweeten wrote:
Most of the comedi drivers that provide readback for write only subdevices now
use the comedi core comedi_alloc_subdev_readback() helper to allocate the
subdevice
'reaback' member instead of using some member in their private data. These
drivers
als
> -Original Message-
> From: Dexuan Cui
> Sent: Thursday, November 20, 2014 6:41 PM
> To: KY Srinivasan; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com
> Cc: Haiyang Zhang; Vita
From: SF Markus Elfring
Date: Thu, 20 Nov 2014 15:25:27 +0100
> From: Markus Elfring
> Date: Thu, 20 Nov 2014 15:15:21 +0100
>
> The vfree() function performs also input parameter validation. Thus the test
> around the call is not needed.
>
> This issue was detected by using the Coccinelle sof
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
to handle the readback of the write-only analog output subdevice. Remove the
then unused 'ao_data' member from the private data.
The private data is now unnecessary. Remove it and the allocation.
For aesthetics, rename
For aesthetics, rename the defines used for the register map offsets and
remove the unnecessary comments. Add the bit defines for the registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 117 +++
This member of the private data is initialized to 0 by pci1723_reset()
and is not used any where else in the driver. Remove it.
Use the register map defines to set the range for each output channel.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
Tidy up the code that determines the initial io_bits (direction) of the
digital I/O subdevice and remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 23 +++
1 file changed, 7 in
The comedi_device 'write_subdev' should only be initialized if the subdevice
supports async commands.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comed
This function is only called by the (*auto_attach) to reset all the analog
output channels. For aesthetics, absorb the function.
Fix the range programming for each channel. According to the users manual
the "range strobe" register needs to be written after setting the "DAC range
control" register
The pci1723_reset() function simply resets all the analog output channels
to 0V and a +/-10V range. This really isn't necessary when detaching the
driver.
Remove the board reset and just use comedi_pci_detach() directly for the
(*detach).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
Update the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Following is the big cleanup for the adv_pci1723 driver.
H Hartley Sweeten (11):
staging: comedi: adv_pci1723: tidy up register map
staging: comedi: adv_pci1723: remove private data 'da_range'
staging: comedi: adv_pci1723: remove board reset during (*detach)
staging: comedi: adv_pci1723: a
The subdevice 'len_chanlist' is only used by subdevices that support async
commands. Remove the unnecessary initializations in this driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 4 +---
1 file changed, 1 insert
Tidy up the multi-line comments to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 79 +---
1 file changed, 38 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/
For aesthetics, tidy this function up and use the register defines
to remove the magic numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1723.c | 21 ++---
1 file changed, 6 insertions(+), 15 deletions(-)
> This does not apply to the net-next tree, please respin.
Thanks for your reply.
How do you think about to try out the scripts which I published
in March to get more constructive feedback?
Will they run faster for another analysis on current
Linux source files with your test systems (than my com
From: SF Markus Elfring
Date: Fri, 21 Nov 2014 23:15:42 +0100
>> This does not apply to the net-next tree, please respin.
>
> Thanks for your reply.
>
> How do you think about to try out the scripts which I published
> in March to get more constructive feedback?
This has nothing to do with me
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran
---
drivers/staging/skein/skein_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/skein/skein_generic.c
b/drivers/staging/skein/skein_generic.c
index 7096d5a..86
This patch fixes the five checkpatch.pl warnings:
WARNING:Missing a blank line after declaration
Signed-off-by: Anjana Sasindran
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drive
This patch fixes the five checkpatch.pl warnings:
WARNING:Missing a blank line after declaration
Signed-off-by: Anjana Sasindran
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drive
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
> This patch fixes the checkpatch.pl error:
this patch is not applying to next-20141121.
>
> ERROR: trailing whitespace
but your patch is adding a blank line in the code ?
thanks
sudip
>
> Signed-off-by: A
On Thu, Nov 20, 2014 at 03:23:29PM -0800, Greg Kroah-Hartman wrote:
> On Thu, Nov 20, 2014 at 05:09:25PM -0500, Steven Rostedt wrote:
> >
> > Someone reported a bug in the function graph tracer for MIPS. As I'm
> > still waiting on my USB serial for my Imagination MIPS board, I decided
> > to brin
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c
b/drivers/staging/skein/skein_generic.c
index 7096d5
33 matches
Mail list logo
