Re: [PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue

2014-12-17 Thread Greg KH
On Thu, Dec 18, 2014 at 12:17:54AM -0200, Eduardo Barretto wrote: > Fixed a coding style issue. What coding style issue? Be specific, you have lots of room here. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.or

[PATCH v2] Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue

2014-12-17 Thread Eduardo Barretto
Fixed a coding style issue. Signed-off-by: Eduardo Barretto --- drivers/staging/wlan-ng/hfa384x_usb.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 55d2f56..de33a07 100644 --- a

RE: [PATCH 1/1] Drivers: hv: vmbus: Add device and vendor ID to vmbus devices

2014-12-17 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, December 17, 2014 4:17 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH 1/1]

Re: [PATCH 1/1] Drivers: hv: vmbus: Add device and vendor ID to vmbus devices

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 02:52:24PM -0800, K. Y. Srinivasan wrote: > Add vendor and device ID attributes to vmbus devices. This would allow us to > support vmbus based devices that can support guest RDMA. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/vmbus_drv.c | 20 ++

Re: [PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Removed an unnecessary NULL check

2014-12-17 Thread Greg Kroah-Hartman
On Wed, Dec 17, 2014 at 11:05:00PM +0100, Rickard Strandqvist wrote: > Removed an unnecessary NULL check. And clarified a switch statement. That's two different things, please only do one thing in a patch, so this would be 2 different patches. please fix up and resend as a series of patches. tha

[PATCH] staging: lustre: lustre: mdc: mdc_lib.c: Removed an unnecessary NULL check

2014-12-17 Thread Rickard Strandqvist
Removed an unnecessary NULL check. I have checked the only place this function is called from. Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/mdc/mdc_lib.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/mdc/mdc_li

[PATCH] staging: lustre: lustre: obdclass: lprocfs_status.c: Removed an unnecessary NULL check

2014-12-17 Thread Rickard Strandqvist
Removed an unnecessary NULL check. And clarified a switch statement. Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread Pavel Machek
On Wed 2014-12-17 09:32:16, Greg KH wrote: > On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > Enable FPGA manager for Altera socfpga. > > > > Signed-off-by: Alan Tull > > --- > > v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_SOCFPGA/ > > --

[PATCH 1/1] Drivers: hv: vmbus: Add device and vendor ID to vmbus devices

2014-12-17 Thread K. Y. Srinivasan
Add vendor and device ID attributes to vmbus devices. This would allow us to support vmbus based devices that can support guest RDMA. Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c | 20 include/linux/hyperv.h |2 ++ 2 files changed, 22 insertions(+), 0 del

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Remove some unused functions

2014-12-17 Thread Jes Sorensen
Rickard Strandqvist writes: > Removes some functions that are not used anywhere: > rtw_hw_resume23a() rtw_hw_suspend23a() > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8723au/include/osde

HELLO

2014-12-17 Thread Colin Cook
Good day, I am Barrister Colin Cook, a legal practitioner with JasonShaw law firm in Leeds, United kingdom, I saw your contact and profile and decided that you could cooperate with me in this proposition.I have a client who was deceased in November 2004, in Kuala Lumpur, Malaysia. I am co

[PATCH] staging: rtl8723au: os_dep: usb_intf.c: Remove some unused functions

2014-12-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtw_hw_resume23a() rtw_hw_suspend23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/include/osdep_intf.h |3 - drivers/staging/rtl8723au/

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-17 Thread Rickard Strandqvist
Hi Ok, do a patch to remove it now. Kind regards Rickard Strandqvist 2014-12-16 1:04 GMT+01:00 Larry Finger : > On 12/15/2014 05:01 PM, Rickard Strandqvist wrote: >> >> Hi >> >> No the rtw_hw_resume23a() is not used anywhere. >> I also do a check of all functions that are not used, but not in t

Re: [PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include instead of #include

2014-12-17 Thread Joe Perches
On Thu, 2014-12-18 at 00:55 +0530, Hariharan wrote: > From 2a84ceb9e5043a5700d35108ec72737be5102356 Mon Sep 17 00:00:00 2001 > From: Hariharan Rangasamy > Date: Wed, 17 Dec 2014 23:57:47 +0530 > Subject: [PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include > instead of #include Hi again.

Re: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() and seq_putc() instead of seq_printf()

2014-12-17 Thread Dan Carpenter
On Thu, Dec 18, 2014 at 12:57:59AM +0530, Hariharan wrote: > >From 55d1ae4a440126e5befa9de4698a7aac57319885 Mon Sep 17 00:00:00 2001 > From: Hariharan Rangasamy > Date: Thu, 18 Dec 2014 00:04:24 +0530 > Subject: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() and > seq_putc() instead of

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread atull
On Wed, 17 Dec 2014, Michal Simek wrote: > On 12/17/2014 06:32 PM, Greg KH wrote: > > On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: > >> From: Alan Tull > >> > >> Enable FPGA manager for Altera socfpga. > >> > >> Signed-off-by: Alan Tull > >> --- > >> v5: s/CONFIG_

[PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() and seq_putc() instead of seq_printf()

2014-12-17 Thread Hariharan
>From 55d1ae4a440126e5befa9de4698a7aac57319885 Mon Sep 17 00:00:00 2001 From: Hariharan Rangasamy Date: Thu, 18 Dec 2014 00:04:24 +0530 Subject: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() and seq_putc() instead of seq_printf() used seq_puts() and seq_putc() instead of seq_printf()

[PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include instead of #include

2014-12-17 Thread Hariharan
>From 2a84ceb9e5043a5700d35108ec72737be5102356 Mon Sep 17 00:00:00 2001 From: Hariharan Rangasamy Date: Wed, 17 Dec 2014 23:57:47 +0530 Subject: [PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include instead of #include Used #include instead of #include Signed-off-by: Hariharan Rangasamy

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread Michal Simek
On 12/17/2014 06:32 PM, Greg KH wrote: > On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: >> From: Alan Tull >> >> Enable FPGA manager for Altera socfpga. >> >> Signed-off-by: Alan Tull >> --- >> v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_SOCFPGA/ >> --- >> arch/arm

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread Jason Cooper
On Wed, Dec 17, 2014 at 09:32:16AM -0800, Greg KH wrote: > On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: > > From: Alan Tull > > > > Enable FPGA manager for Altera socfpga. > > > > Signed-off-by: Alan Tull > > --- > > v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_S

Re: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf()

2014-12-17 Thread Joe Perches
On Wed, 2014-12-17 at 23:29 +0530, Hariharan Rangasamy wrote: > Replaced seq_printf() with seq_puts() [] > diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c > b/drivers/staging/lustre/lustre/osc/lproc_osc.c [] > @@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m,

[PATCH v2] staging:board: remove unnecessary function

2014-12-17 Thread Tsung-Han Lin
Remove the unnecessary 'of_can_translate_address', which is already removed in commit d9c6866be8a145e32da616d8dcbae806032d75b5 ("of: kill off of_can_translate_address"). Signed-off-by: Tsung-Han Lin --- drivers/staging/board/board.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

[PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf()

2014-12-17 Thread Hariharan Rangasamy
Replaced seq_printf() with seq_puts() Signed-off-by: Hariharan Rangasamy --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c in

[PATCH 1/2] Staging: lustre: lproc_osc.c : Added #include instead of #include

2014-12-17 Thread Hariharan Rangasamy
Used #include instead of #include Signed-off-by: Hariharan Rangasamy --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c index 9f719b

Re: [PATCH] Staging : lustre : replaced seq_printf() with seq_puts and changed include statement

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 11:04:41PM +0530, Hariharan Rangasamy wrote: > Used seq_puts instead of seq_printf() > Used #include instead of #include That's two different things, which means two different patches are needed. Please only do one-thing-per-patch. thanks, greg k-h

[PATCH] Staging : lustre : replaced seq_printf() with seq_puts and changed include statement

2014-12-17 Thread Hariharan Rangasamy
Used seq_puts instead of seq_printf() Used #include instead of #include Signed-off-by: Hariharan Rangasamy --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/s

Re: [PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 10:54:49AM -0600, at...@opensource.altera.com wrote: > From: Alan Tull > > Enable FPGA manager for Altera socfpga. > > Signed-off-by: Alan Tull > --- > v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_SOCFPGA/ > --- > arch/arm/configs/socfpga_defconfig |4 > 1 file

[PATCH v5 5/6] arm: dts: socfpga: add altera fpga manager

2014-12-17 Thread atull
From: Alan Tull Add Altera FGPA manager to device tree. Signed-off-by: Alan Tull --- v5 : remove simple-bus and associated stuff --- arch/arm/boot/dts/socfpga.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi inde

[PATCH v5 3/6] staging: fpga manager: framework core

2014-12-17 Thread atull
From: Alan Tull Supports standard ops for low level FPGA drivers. Various manufacturors' FPGAs can be supported by adding low level drivers. Each driver needs to register its ops using fpga_mgr_register(). Exports methods of doing operations to program FPGAs. These should be sufficient for ind

[PATCH v5 2/6] fpga manager: add sysfs interface document

2014-12-17 Thread atull
From: Alan Tull Add documentation under drivers/staging for new fpga manager's sysfs interface. Signed-off-by: Alan Tull --- v5 : (actually second version, but keeping version numbers aligned with rest of patch series) Move document to drivers/staging/fpga/Documentation/ABI --- ..

[PATCH v5 1/6] doc: add bindings document for altera fpga manager

2014-12-17 Thread atull
From: Alan Tull New bindings document for Altera fpga manager. Signed-off-by: Alan Tull --- v5 : Move bindings to drivers/staging/fpga/Documentation/bindings --- .../Documentation/bindings/altera-fpga-mgr.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644 d

[PATCH v5 6/6] ARM: socfpga: defconfig: enable fpga manager

2014-12-17 Thread atull
From: Alan Tull Enable FPGA manager for Altera socfpga. Signed-off-by: Alan Tull --- v5: s/CONFIG_FPGA_MGR_ALTERA/CONFIG_FPGA_MGR_SOCFPGA/ --- arch/arm/configs/socfpga_defconfig |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/so

[PATCH v5 4/6] staging: fpga manager: add driver for socfpga fpga manager

2014-12-17 Thread atull
From: Alan Tull Add driver to fpga manager framework to allow configuration of FPGA in Altera SoCFPGA parts. Signed-off-by: Alan Tull --- v2: fpga_manager struct now contains struct device fpga_manager_register parameters now take device v3: skip a version to align versions v4: move to dr

[PATCH v5 0/6] FPGA Manager Framework

2014-12-17 Thread atull
From: Alan Tull Intended for after 3.19-rc1 v5 includes changes from feedback from Michal, Steffen, Alan, Greg, and the kbuild test robot. The driver is under drivers/staging/fpga/ The header is now in include/linux/fpga/ The sysfs doc is in staging/fpga/Documentation/ABI/ The DT binding is in

Re: [PATCH] staging: speakup: replace simple_strtoul with kstrtoul

2014-12-17 Thread Dan Carpenter
On Wed, Dec 17, 2014 at 04:43:54PM +0300, samuel kihahu wrote: > On Wed, Dec 17, 2014 at 03:11:19PM +0300, Dan Carpenter wrote: > > On Wed, Dec 17, 2014 at 02:56:02PM +0300, samuel kihahu wrote: > > > Replacing obsolete simple_strtoul with kstrtoul. > > > > > > > Nope. That's wrong. Learn how t

Re: [PATCH] staging: speakup: replace simple_strtoul with kstrtoul

2014-12-17 Thread samuel kihahu
On Wed, Dec 17, 2014 at 03:11:19PM +0300, Dan Carpenter wrote: > On Wed, Dec 17, 2014 at 02:56:02PM +0300, samuel kihahu wrote: > > Replacing obsolete simple_strtoul with kstrtoul. > > > > Nope. That's wrong. Learn how the functions are different beyond just > the name. Noted, have made correct

Re: [PATCH] staging: speakup: replace simple_strtoul with kstrtoul

2014-12-17 Thread Dan Carpenter
On Wed, Dec 17, 2014 at 02:56:02PM +0300, samuel kihahu wrote: > Replacing obsolete simple_strtoul with kstrtoul. > Nope. That's wrong. Learn how the functions are different beyond just the name. regards, dan carpenter ___ devel mailing list de...@l

[PATCH] staging: speakup: replace simple_strtoul with kstrtoul

2014-12-17 Thread samuel kihahu
Replacing obsolete simple_strtoul with kstrtoul. Signed-off-by: samuel kihahu --- drivers/staging/speakup/varhandlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c index d758284..b526c8e 100644

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-17 Thread Christoph Hellwig
On Mon, Dec 15, 2014 at 10:56:38AM -0800, Greg KH wrote: > Ok, that was a bit snotty on my part, I apologize. > > But really, this is self-contained, doesn't touch any core > infrastructure, and is really just like any other driver for hardware > that people don't use. It shouldn't affect anythin