Re: [PATCH v1] staging: comedi: dmm32at: fix style issues

David, On Wed, Dec 24, 2014 at 05:55:38PM -0800, David Decotigny wrote: Before: 1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line After: (none) Signed-off-by: David Decotigny ddeco...@gmail.com ---

[PATCH v2] staging: comedi: dmm32at: fix style issues

Before: 1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line After: (none) Signed-off-by: David Decotigny ddeco...@gmail.com --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 0/6] staging: lustre: use built in min/max functions

The lustre modules define their own custom MIN, MAX and min_t functions. However Linux provides these functions (include/linux/kernel.h) and their design is more robust. They check types and produce compiler warnings if differing types are used. This patch set updates the lustre modules to use

[PATCH 2/6] staging: lustre: replace MIN with min_t

Switch from MIN to the built in min_t with the int type. Signed-off-by: Jeremiah Mahler jmmah...@gmail.com --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c

[PATCH 6/6] staging: lustre: remove custom MIN/MAX and min_t operations

Remove all custom MIN/MAX and min_t operations since they are no longer needed. Signed-off-by: Jeremiah Mahler jmmah...@gmail.com --- drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 8 drivers/staging/lustre/lustre/osc/osc_internal.h | 5 - 2 files

[PATCH 4/6] staging: lustre: replace MIN with min, cast (__kernel_size_t)

Switch from MIN to min and fix the new type warning. The warning is produced because a comparison between iov_len, which is a __kernel_size_t, is made to kiov_len, which is an unsigned int (include/linux/lnet/types.h). Fix the warning by casting kiov_len to __kernel_size_t. Signed-off-by:

[PATCH 3/6] staging: lustre: replace MIN/MAX with min_t/max_t

Switch from MIN/MAX to min_t/max_t with a size_t type. The size_t type was chosen because one operand is a size_t and all the others are immediate integer values. Signed-off-by: Jeremiah Mahler jmmah...@gmail.com --- drivers/staging/lustre/lnet/lnet/router_proc.c | 2 +- 1 file changed, 1

[PATCH 1/6] staging: lustre: use min/max instead of MIN/MAX, simple cases

Custom MIN/MAX operations are being used which are not as robust as the built in min/max operations which will warn about potentially problematic type comparisons. For the simple cases, where no type warning is produced, simply replace MIN/MAX with min/max. Signed-off-by: Jeremiah Mahler

[PATCH 5/6] staging: lustre: replace MIN with min_t, remove cast

Switch from MIN to min_t and remove the previous cast of the second argument to int. Signed-off-by: Jeremiah Mahler jmmah...@gmail.com --- drivers/staging/lustre/lnet/lnet/lib-move.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c

[PATCH] staging: dgap: use gotos for handling error in dgap_remap()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index bdb5317..518ab56 100644 ---

[PATCH 1/2] drivers:staging:rtl8192u: Change all C99 comments to standard style C comments in rtl819x_QOS.h

This changes all C99 comments found in rtl819x_QOS.h to standard C style comments as found by running checkpatch on this file. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 352 +++ 1 file changed, 176

[PATCH 1/2] staging: lustre: libcfs/nidstrings: Declare internal symbols static

This fixes sparse warnings: staging/lustre/lustre/libcfs/nidstrings.c:200:11: warning: symbol 'libcfs_nnetstrfns' was not declared. Should it be static? drivers/staging/lustre/lustre/libcfs/nidstrings.c:203:1: warning: symbol 'libcfs_lo_str2addr' was not declared. Should it be static?

[PATCH 2/2] staging: lustre: libcfs/nidstrings: Avoid forward declarations

Avoid forward declaratoins by moving functions to a location before they are referenced. Signed-off-by: Sören Brinkmann soeren.brinkm...@gmail.com --- drivers/staging/lustre/lustre/libcfs/nidstrings.c | 77 +++ 1 file changed, 37 insertions(+), 40 deletions(-) diff --git