On Tue, Dec 30, 2014 at 07:04:35PM -0800, Serguey Parkhomovsky wrote:
> On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
> >
> > If you look at the source code just below these functions you will find:
> >
> > EXPORT_SYMBOL(libcfs_arch_init);
> > EXPORT_SYMBOL(libcfs_arch_cleanup)
On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
>
> If you look at the source code just below these functions you will find:
>
> EXPORT_SYMBOL(libcfs_arch_init);
> EXPORT_SYMBOL(libcfs_arch_cleanup);
>
> So making these static is incorrect because they are being used outside
> o
On 28/12/14 18:56, Andreas Siegling wrote:
This patch will fix all occurrences of the checkpatch warning:
WARNING: Missing a blank line after declarations
in drivers/staging/comedi/.
Signed-off-by: Andreas Siegling
Signed-off-by: Zhutao Lu
---
drivers/staging/comedi/drivers/comedi_b
On 28/12/14 18:56, Andreas Siegling wrote:
This patch will fix the following checkpatch errors/warnings in
drivers/staging/comedi/ which are brought by wrong spacing:
ERROR: trailing whitespace
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: please, no space bef
On 28/12/14 18:56, Andreas Siegling wrote:
This patch fixes all occurrences of 8 whitespaces instead of a tab.
It will remove the 8 whitespaces and replace them with a tab, thereby
the checkpatch-error:
ERROR: code indent should use tabs where possible
is removed from all files in
Serguey,
On Mon, Dec 29, 2014 at 03:10:32AM -0800, Serguey Parkhomovsky wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning:
> symbol 'libcfs_arch_init' was not declared. Should it be static?
> drivers/staging/lustre/lustre/lib
On 29/12/14 09:27, jitendra kumar khasdev wrote:
This is a patch to the s626.c file that fixes up a maximum 80 character limit
warning found by the checkpatch.pl tool
Signed-off-by: Jitendra Kumar Khasdev
---
drivers/staging/comedi/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 d
On 29/12/14 09:12, jitendra kumar khasdev wrote:
This is a patch to the s626.c file that fixes up a space error
found by the checkpatch.pl tool
Signed-off-by: Jitendra Kumar Khasdev
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
On 25/12/14 20:28, David Decotigny wrote:
Before:
1 ERROR: code indent should use tabs where possible
1 WARNING: please, no spaces at the start of a line
After:
(none)
Signed-off-by: David Decotigny
---
drivers/staging/comedi/drivers/dmm32at.c | 2 +-
1 file changed, 1 inse
Fixes the following sparse warnings:
drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol
'libcfs_arch_init' was not declared. Should it be static?
drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: symbol
'libcfs_arch_cleanup' was not declared. Sho
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Tuesday, December 16, 2014 1:22 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Tuesday, December 16, 2014 1:22 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Tuesday, December 16, 2014 1:22 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Tuesday, December 16, 2014 1:22 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom
> -Original Message-
> From: h...@infradead.org [mailto:h...@infradead.org]
> Sent: Tuesday, December 30, 2014 1:32 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; linux-s.
Mathieu,
On Mon, Dec 22, 2014 at 08:20:37AM -0700, mathieu.poir...@linaro.org wrote:
> From: Mathieu Poirier
>
> This patchset is fixing miscellaneous coding style problems as reported
> by checkpatch. More interesting is the removal of 'do {} while (0) loop'
> statements for single line macros
Andreas,
On Tue, Dec 30, 2014 at 12:33:34AM +0100, Andreas Siegling wrote:
> This small patch will fix the trailing whitespace in
> drivers/staging/skein/skein_generic.c.
>
> After applying the patch, there will only remain the checkpatch warning:
> WARNING: Single statement macros should n
This patch fixes the following checkpatch.pl warnings:
ERROR: do not use C99 // comments
+//
ERROR: do not use C99 // comments
+// For memory mapped IO
ERROR: do not use C99 // comments
+//
ERROR: do not use C99 // comments
+#endif // __UPC_H__
ERROR: do not use C99 // comments
+ // set
On Mon, Dec 29, 2014 at 09:07:59PM +, KY Srinivasan wrote:
> Should I be resending these patches.
I don't need a resend, I need a review for the patches. Note that for
driver patches I'm also fine with a review from a co worker, as long as
it's a real review not just a rubber stamp.
Talking
19 matches
Mail list logo
