[patch] staging: lustre: potential underflow in mdc_iocontrol()

2015-01-06 Thread Dan Carpenter
Smatch complains that data-ioc_plen2 is a user controlled value and, since we cast to signed int, the limit check can underflow. It's not very serious because probably the copy_to_user() would return -EFAULT on every arch that matters instead of creating an info leak. Also I haven't followed it

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Dan Carpenter
On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: Do you mean I should resend it or wait for reply from maintainer first? Resend, please. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Ian Abbott
On 06/01/15 06:02, Sudip Mukherjee wrote: On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote: On 01/04, Piotr Kubus wrote: This is a patch to the dmm32at.c file that fixes up a code indent error found by the

[PATCH v2] Staging: comedi: dmm32at: Fix a code indent issue

2015-01-06 Thread Piotr Kubus
Fixed a code indent error found by checkpatch.pl in dmm32at.c. Signed-off-by: Piotr Kubus p.t.ku...@gmail.com --- v2: make the commit message clearer and shorter drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] Staging: comedi: dmm32at: Fix a code indent issue

2015-01-06 Thread Ian Abbott
On 06/01/15 10:16, Piotr Kubus wrote: Fixed a code indent error found by checkpatch.pl in dmm32at.c. Signed-off-by: Piotr Kubus p.t.ku...@gmail.com --- v2: make the commit message clearer and shorter drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Sudip Mukherjee
On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote: On 06/01/15 06:02, Sudip Mukherjee wrote: On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote: On 01/04, Piotr Kubus wrote: This is a patch to the dmm32at.c

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Konrad Zapalowicz
On 01/06, Sudip Mukherjee wrote: On Tue, Jan 06, 2015 at 10:08:37AM +, Ian Abbott wrote: On 06/01/15 06:02, Sudip Mukherjee wrote: On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote: On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote: On 01/04, Piotr Kubus

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-06 Thread Sudip Mukherjee
On Tue, Jan 06, 2015 at 02:33:27PM +0100, Konrad Zapalowicz wrote: On 01/06, Sudip Mukherjee wrote: yes, i read the SubmittingPatches again. summary is the subject line. But then as Piotr Kubus has written that he could not find this rule in the documentaion, I also tried to find that in

Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2015-01-06 Thread Russell King - ARM Linux
On Thu, Dec 11, 2014 at 12:24:15PM +0100, Heiko Stübner wrote: Past practices suggest that having the dw in the name is a sane solution too, like in dw_mmc-foo (mmc/host), dwmac-foo (net/ethernet/stmicro/stmmac). And personally I'd keep to this already established naming scheme ... i.e.

Re: [PATCH v18 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver

2015-01-06 Thread Russell King - ARM Linux
On Fri, Dec 05, 2014 at 02:25:50PM +0800, Andy Yan wrote: hdmi phy configuration is platform specific, which can be adusted Minor typo: adjusted -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. ___

Re: [PATCH v18.1 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2015-01-06 Thread Russell King - ARM Linux
On Tue, Jan 06, 2015 at 12:52:24PM +0100, Heiko Stübner wrote: +static void imx_hdmi_bridge_nope(struct drm_bridge *bridge) _nope ? As in No? Or should this be _nop for no-operation ? -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.

Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2015-01-06 Thread Philipp Zabel
Hi Heiko, Am Dienstag, den 06.01.2015, 12:49 +0100 schrieb Heiko Stübner: Hi Philipp, Am Samstag, 6. Dezember 2014, 00:31:46 schrieb Andy Yan: I am happy with the series so far. Pending Acks from the device tree maintainers for the new binding documents, I'd like to apply either the

[PATCH v8 0/4] FPGA Manager Framework

2015-01-06 Thread atull
From: Alan Tull at...@opensource.altera.com v8 changes the compatible string for SOCFPGA FPGA managers to be more chip specific. altr,fpga-mgr becomes altr,socfpga-fpga-mgr Thanks, Alan Alan Tull (4): doc: add bindings document for altera fpga manager fpga manager: add sysfs interface

[PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-06 Thread atull
From: Alan Tull at...@opensource.altera.com Add documentation under drivers/staging for new fpga manager's sysfs interface. Signed-off-by: Alan Tull at...@opensource.altera.com --- v5 : (actually second version, but keeping version numbers aligned with rest of patch series) Move

[PATCH v8 3/4] staging: fpga manager: framework core

2015-01-06 Thread atull
From: Alan Tull at...@opensource.altera.com Supports standard ops for low level FPGA drivers. Various manufacturors' FPGAs can be supported by adding low level drivers. Each driver needs to register its ops using fpga_mgr_register(). Exports methods of doing operations to program FPGAs. These

[PATCH v8 1/4] doc: add bindings document for altera fpga manager

2015-01-06 Thread atull
From: Alan Tull at...@opensource.altera.com New bindings document for Altera fpga manager. Signed-off-by: Alan Tull at...@opensource.altera.com --- v5 : Move bindings to drivers/staging/fpga/Documentation/bindings v6 : No change in this patch for v6 of the patch set v7 : No change in this

[PATCH v8 4/4] staging: fpga manager: add driver for socfpga fpga manager

2015-01-06 Thread atull
From: Alan Tull at...@opensource.altera.com Add driver to fpga manager framework to allow configuration of FPGA in Altera SoCFPGA parts. Signed-off-by: Alan Tull at...@opensource.altera.com Acked-by: Michal Simek michal.si...@xilinx.com --- v2: fpga_manager struct now contains struct device

Re: [PATCH v8 1/4] doc: add bindings document for altera fpga manager

2015-01-06 Thread atull
On Tue, 6 Jan 2015, Rob Herring wrote: On Tue, Jan 6, 2015 at 2:13 PM, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com New bindings document for Altera fpga manager. Signed-off-by: Alan Tull at...@opensource.altera.com Acked-by: Rob Herring

Re: [PATCH v8 1/4] doc: add bindings document for altera fpga manager

2015-01-06 Thread Rob Herring
On Tue, Jan 6, 2015 at 2:13 PM, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com New bindings document for Altera fpga manager. Signed-off-by: Alan Tull at...@opensource.altera.com Acked-by: Rob Herring r...@kernel.org Like I said, this binding doesn't look

lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)-iov_base, which is __user

2015-01-06 Thread Andrey Utkin
Dear maintainers of LustreFS and other experienced kernel developers! I am working on fixing some sparse warnings as a task of Eudyptula Challenge. There's a thing that look suspiciously to me (or I just don't understand it). This looks same both in upstream kernel code in drivers/staging/ and in

Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2015-01-06 Thread Liu Ying
On 12/05/2014 02:22 PM, Andy Yan wrote: We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly differences, such as phy pll configuration, register width(imx hdmi register is one byte, but

Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2015-01-06 Thread Andy Yan
Hi Liu Ying , Philipp: On 2015年01月07日 10:39, Liu Ying wrote: On 12/05/2014 02:22 PM, Andy Yan wrote: We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly differences, such as phy pll

[PATCH] staging: ft1000: Fix code style issue

2015-01-06 Thread Arjun AK
Remove unnecessary braces from single statement blocks. Signed-off-by: Arjun AK arjunak...@gmail.com --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 101 --- 1 file changed, 35 insertions(+), 66 deletions(-) diff --git

Re: [PATCH v7 1/4] doc: add bindings document for altera fpga manager

2015-01-06 Thread atull
On Mon, 22 Dec 2014, Rob Herring wrote: On Fri, Dec 19, 2014 at 10:45 AM, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com New bindings document for Altera fpga manager. Signed-off-by: Alan Tull at...@opensource.altera.com --- v5 : Move bindings to

Christmas Gift From TNB

2015-01-06 Thread TNB, Kuala Lumpur
Tenaga Nasional Berhad (TNB HQ) 129 Jalan Bangsar, 59200 Kuala Lumpur, Kuala Lumpur, Malaysia Ini adalah satu pemberitahuan rasmi daripada ibu pejabat daripada Tenaga Nasional Berhad sempena Persatuan Air Malaysia (PAM) untuk memaklumkan anda mengenai Hadiah Khas Eksklusif Tenaga Nasional