Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Stefan Hajnoczi
On Sun, Jan 11, 2015 at 10:34 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 9 Jan 2015 23:35:46 -0600, Chris Rorvick wrote: The line6usb driver references the device's idProduct and, in some cases, the interface number in a number of places to determine device- specific configuration values

Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err

2015-01-11 Thread Joe Perches
On Sat, 2015-01-10 at 21:24 -0800, Greg Kroah-Hartman wrote: On Sat, Jan 10, 2015 at 08:55:21PM -0800, Joe Perches wrote: On Sat, 2015-01-10 at 20:13 -0800, Greg Kroah-Hartman wrote: On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote: Use the normal logging facility instead of a

Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Takashi Iwai
At Fri, 9 Jan 2015 23:35:46 -0600, Chris Rorvick wrote: The line6usb driver references the device's idProduct and, in some cases, the interface number in a number of places to determine device- specific configuration values and to call device-specific functionality. Rework code to leverage

[PATCH v3] Staging: vt6655: fixed a coding style warning

2015-01-11 Thread Sakshi Bansal
Fixed 80 line warning in the code comments. Signed-off-by: Sakshi Bansal sakshi.apr...@gmail.com --- Changes in v3: - Make the commit message more clearer. drivers/staging/vt6655/baseband.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/baseband.c

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad Hi Konrad,

[PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-11 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:588: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss em...@paradise.net.nz --- drivers/staging/vt6656/rxtx.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread atull
On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration and you need to fix. thanks, konrad Hi Konrad, Can you be more specific? What

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-11 Thread atull
On Sat, 10 Jan 2015, Pavel Machek wrote: On Sat 2015-01-10 10:10:51, Pantelis Antoniou wrote: Hi Pavel, On Jan 9, 2015, at 22:56 , Pavel Machek pa...@denx.de wrote: On Fri 2015-01-09 13:14:24, atull wrote: On Wed, 7 Jan 2015, Pavel Machek wrote: On Tue 2015-01-06

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-11 Thread Joe Perches
On Mon, 2015-01-12 at 03:19 +1100, Emrys Bayliss wrote: This patch fixes the following checkpatch.pl error: rxtx.c:588: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss em...@paradise.net.nz --- drivers/staging/vt6656/rxtx.c | 6 +- 1 file

Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err

2015-01-11 Thread Joe Perches
On Sun, 2015-01-11 at 08:57 -0800, Greg Kroah-Hartman wrote: It will need to be done to get the code merged out of staging, so it better happen... Maybe the unisys folk will do something in the order you want. Good luck. ___ devel mailing list

Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err

2015-01-11 Thread Greg Kroah-Hartman
On Sat, Jan 10, 2015 at 09:32:33PM -0800, Joe Perches wrote: On Sat, 2015-01-10 at 21:24 -0800, Greg Kroah-Hartman wrote: On Sat, Jan 10, 2015 at 08:55:21PM -0800, Joe Perches wrote: On Sat, 2015-01-10 at 20:13 -0800, Greg Kroah-Hartman wrote: On Sat, Jan 10, 2015 at 07:09:02PM -0800,

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Pavel Machek
On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote: On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something wrong with your email client configuration

[PATCH] staging: virtpci: Remove no-op suspend/resume functions

2015-01-11 Thread Lars-Peter Clausen
The virtpci bus driver still uses the legacy suspend/resume callbacks. In their current implementation these callbacks only contain a macro that always expands to 'do { } while(0)'. So instead of converting them to dev PM ops just remove them. Signed-off-by: Lars-Peter Clausen l...@metafoo.de ---

[PATCH] staging: lustre: Fix spacing error in libcfs_string.c

2015-01-11 Thread Nickolaus Woodruff
This patch fixes the following checkpatch.pl error in libcfs_string.c: ERROR: spaces required around that '=' Signed-off-by: Nickolaus Woodruff nickolauswoodr...@gmail.com --- drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] Staging: comedi: kcomedilib: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in kcomedilib_main.c file. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/comedi/kcomedilib/kcomedilib_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Konrad Zapalowicz
On 01/11, Pavel Machek wrote: On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote: On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull at...@opensource.altera.com Alan, there is something

Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Chris Rorvick
At Fri, 9 Jan 2015 23:35:46 -0600, Chris Rorvick wrote: I have a TonePort UX2 that I've used for testing, meaning that some of this is really only compile-tested. If anyone is responsible for testing with real hardware, I'll happily review. To be clear, the TonePort UX2 is real hardware.

[PATCH 3/3] Staging: nvec: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in nvec.c file Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 093535c..2637059 100644 ---

[PATCH 4/4] Staging: octeon-usb: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in octeon-hcd.c file Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index

Re: [PATCH 3/3] Staging: nvec: Fixed a typo

2015-01-11 Thread Greg KH
On Sun, Jan 11, 2015 at 03:12:15PM -0600, Gustavo A. R. Silva wrote: Fixed a typo in nvec.c file Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Where are patches 1/3 and 2/3?

Re: [PATCH 4/4] Staging: octeon-usb: Fixed a typo

2015-01-11 Thread Greg KH
On Sun, Jan 11, 2015 at 03:23:06PM -0600, Gustavo A. R. Silva wrote: Fixed a typo in octeon-hcd.c file Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Where are patches 1/4, 2/4,

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-11 Thread Malcolm Priestley
On 11/01/15 16:42, Joe Perches wrote: On Mon, 2015-01-12 at 03:19 +1100, Emrys Bayliss wrote: This patch fixes the following checkpatch.pl error: rxtx.c:588: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss em...@paradise.net.nz ---

Re: [PATCH v8 0/4] FPGA Manager Framework

2015-01-11 Thread Pavel Machek
On Sun 2015-01-11 21:58:00, Konrad Zapalowicz wrote: On 01/11, Pavel Machek wrote: On Sun 2015-01-11 17:24:26, Konrad Zapalowicz wrote: On 01/11, atull wrote: On Sat, 10 Jan 2015, Konrad Zapalowicz wrote: On 01/06, at...@opensource.altera.com wrote: From: Alan Tull

[PATCH] Staging: vt6656: Fixed typo in a variable name

2015-01-11 Thread Gustavo A. R. Silva
Fixed typo in a variable name in dpc.h file. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/vt6656/dpc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/dpc.h b/drivers/staging/vt6656/dpc.h index fab195f..95e0e83 100644

[PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-11 Thread Shirish Gajera
This patch fixes the checkpatch.pl warning: WARNING: Single statement macros should not use a do {} while (0) loop I remove do while from the single statement macro. Signed-off-by: Shirish Gajera gajerashir...@gmail.com --- drivers/staging/skein/skein_block.c | 31

[PATCH] Staging: octeon-usb: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in octeon-hcd.c file Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index

[PATCH] Staging: nvec: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in nvec.c file Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/nvec/nvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 093535c..2637059 100644 ---

[PATCH] Staging: vt6656: Fixed typo in a macro name

2015-01-11 Thread Gustavo A. R. Silva
Fixed typo in a macro name in card.c and device.h files. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/vt6656/card.c | 2 +- drivers/staging/vt6656/device.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/card.c

[PATCH] Staging: comedi: kcomedilib: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in kcomedilib_main.c file. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/comedi/kcomedilib/kcomedilib_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-11 Thread Emrys Bayliss
This is a bungle please disregard it. I will send it again with a 'ret' variable if that's okay (one that has been properly proofed and compiles). My apologies. Sorry for completely wasting your time by not checking properly. On 01/12/2015 08:30 AM, Malcolm Priestley wrote: On 11/01/15

Re: [PATCH 3/3] Staging: nvec: Fixed a typo

2015-01-11 Thread Greg KH
On Sun, Jan 11, 2015 at 03:33:01PM -0600, Gustavo A. R. Silva wrote: 2015-01-11 15:27 GMT-06:00 Greg KH gre...@linuxfoundation.org: On Sun, Jan 11, 2015 at 03:12:15PM -0600, Gustavo A. R. Silva wrote: Fixed a typo in nvec.c file Signed-off-by: Gustavo A. R. Silva

[PATCH] Staging: octeon: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in ethernet.c file. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/octeon/ethernet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index ee32149..460e854

[PATCH] Staging: olpc_dcon: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in olpc_dcon_xo_1.c file. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon_xo_1.c

[PATCH] Staging: vt6655: Fixed a typo

2015-01-11 Thread Gustavo A. R. Silva
Fixed a typo in mac.c file. Signed-off-by: Gustavo A. R. Silva garsi...@embeddedor.com --- drivers/staging/vt6655/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index 8f0d652..1975c91 100644 ---

[PATCH v4 1/2] staging: lustre: Use mult if units not specified

2015-01-11 Thread Chris Rorvick
Units can be passed to lprocfs_write_frac_u64_helper() via a suffix (e.g., ...K, ...M, etc.) tacked onto the value. A comment states that specified units override the multiplier, though the multiplier is overridden regardless. Update the conditional logic so that it only applies when units are

[PATCH v4 0/2] lprocfs_write_frac_u64_helper cleanup

2015-01-11 Thread Chris Rorvick
Removed drivers from the subject. I saw examples of this in the commit log but have since realized this is not preferred. v3: Added Andreas as reviewer (thanks!) v2: Added a second patch to address Dan Carpenter's concern with the complexity of passing the sign through `mult'. Compile tested

[PATCH v4 2/2] staging: lustre: Track sign separately

2015-01-11 Thread Chris Rorvick
The `mult' parameter is negated if the user data begins with a '-' so that the final value has the appropriate sign. But `mult' is only used if the user data does not include a units suffix. In this case, `mult' is overridden with the numeric scale conveyed by the units suffix, but retains the

[no subject]

2015-01-11 Thread Alexander Paul.
Do you need an Investment Loan Or Company Loan ?If yes,reply us with, Loan Amount: Loan Duration: Country: Mobile No: for more Details ___ devel mailing list de...@linuxdriverproject.org